Project

General

Profile

Actions

Feature #1248

closed

New Permission: Edit own issues

Added by Ronie Henrich about 16 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Permissions and roles
Target version:
Start date:
2008-05-16
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

  • Today (as in version 0.7.1):
    • We may only grant/revoke a role the permission to edit any issues ("Edit issues" permission).
  • Suggestion / Request:
    • It would be nice to be able to grant/revoke a role the permission to "Edit own issues".

Files


Related issues

Related to Redmine - Patch #7444: Patch for improved issue edit permissionsClosedBrian Lindahl2011-01-25

Actions
Related to Redmine - Feature #5195: edit_own_issues and delete_own_issues permissionsNew2010-03-26

Actions
Related to Redmine - Feature #29935: Edit authored issues and Edit assigned issues in issue tracking permissionNew

Actions
Related to Redmine - Defect #39493: Role with only :edit_own_issues no longer considered for workflowConfirmed

Actions
Has duplicate Redmine - Feature #8805: Please consider to make a new permission for "edit _own_ issues"Closed2011-07-13

Actions
Has duplicate Redmine - Feature #6194: Edit own issuesClosed2010-08-23

Actions
Has duplicate Redmine - Feature #4767: Add permission group to allow 'edit your own tickets (header)'.Closed2010-02-08

Actions
Actions #1

Updated by Jean-Philippe Lang over 15 years ago

  • Target version deleted (0.8)
Actions #2

Updated by Daniel Jones about 15 years ago

+1

Actions #3

Updated by Royce Williams about 14 years ago

+1. Empowering users to modify their own request can reduce the load on the people processing requests.

Actions #4

Updated by Алексей Лошкарёв almost 14 years ago

+1 This may reduce count of misspelled or invalid bug. Because user may do mistake on filling bug.

Actions #5

Updated by Leo Hourvitz over 13 years ago

I have a patch for this against recent trunk, attached. We are having this problem in a big way at an installation of mostly native Japanese speakers; with Asian languages, you're always hitting return to do Kanji conversion of your input and one extra carriage return means a half-baked issue in the tracker!

New Permissions

I addressed this by creating two new permissions that can be assigned to roles:
  • edit_own_issues allows users with that permission to edit issues they created (i.e., whose author field is equal to the current user). This addresses the problem, but is potentially a big workflow change, so not all sites might want it.
  • edit_own_new_issues is a more limited permission that allows a user to edit their own issues if there are no journals yet, or if all existing journals were created by the author. I think this is really the pinpoint solution to the problem; as far as I know, all edits will create a journal, so this lets you edit your issue until the moment someone else pays attention to it.
    • Because it seems like such a contained right, in the patch I added it to the default permissions for the Reporter role.

Implementation

To implement the above, I created a new editable? predicate on the issue model parallel to the visible? predicate that was already there (this also seems like a pretty good pattern to follow in general). Then, I changed the code that was doing
User.current.allowed_to?(:edit_issues, @project)
to just call
issue.editable?
instead.

I updated the English and Japanese locales as well.

The patch file was formatted with git format-patch; is that the preferred patch format? Specifically, the patch was generated against svn+ssh://rubyforge.org/var/svn/redmine/trunk@4175 e93f8b46-1217.

I'm fairly new to Redmine and Ruby, so it would definitely be good to get other eyes on this patch. I'll be able to get in some more testing next week. My configuration is:

bash-3.2$ RAILS_ENV=production ruby script/about
About your application's environment
Ruby version              1.8.7 (universal-darwin10.0)
RubyGems version          1.3.5
Rack version              1.0
Rails version             2.3.5
Active Record version     2.3.5
Active Resource version   2.3.5
Action Mailer version     2.3.5
Active Support version    2.3.5
Application root          /Users/leo/OpenSrcSources/redmine
Environment               production
Database adapter          mysql
Database schema version   20100819172912
Actions #6

Updated by Leo Hourvitz over 13 years ago

I also applied this patch on our production redmine at work (Redmine 1.0.1 release on CentOS 5.2).

Actions #7

Updated by Nathan Eggen over 13 years ago

+1 - this should go in the trunk.

Actions #8

Updated by Bernhard Furtmueller over 13 years ago

+1

Actions #9

Updated by Brian Lindahl over 13 years ago

Created patch issue to follow the progression of my patch to add this feature and other issue edit permission improvements. Please add relation to #7444.

Actions #10

Updated by Leo Hourvitz over 13 years ago

Is there any approved way to urge this get moved to trunk? I need to apply this on every Redmine instance we use, I think any installation with real scale of users is unmanageable without something like this.

Brian: I don't seem to have permissions to add the relation.

Actions #11

Updated by Brian Lindahl over 13 years ago

Leo: Issue relations in Redmine are controlled by a different permission: 'Manage issue relations'. I can see a situation where project managers/software leads would not want issue reporters to have the ability to set up relations. Perhaps another permission should be added: 'Manage own issue relations'?

Actions #12

Updated by Brian Lindahl over 13 years ago

Leo: Hah! Just realized that you were saying that you don't have the permissions to relate this issue to my patch issue #7444.

Actions #13

Updated by Etienne Massip almost 13 years ago

  • Target version set to Candidate for next major release
Actions #14

Updated by Gokay Gok over 12 years ago

+1

Actions #15

Updated by Aleksej Lebedev over 12 years ago

+1

Actions #16

Updated by Yannick Recht about 12 years ago

+1 also.

It should be interesting to add this parameter.

Actions #17

Updated by Gabriel Mazetto almost 12 years ago

It's also wise to have a "time limit" to help people not trying to modify something made a year ago, for example. As we will never find a good for everyone value, it's good to have it configurable, some values as suggestion:

  • Limit own issue editing and own issue comments:
    • Custom (please specify)
    • 30 days
    • 15 days
    • 7 days
    • 3 days
    • 24 hours
    • 12 hours
    • 6 hours
    • 3 hours
    • less then one hour
    • Never
Actions #18

Updated by Rolf Bagge over 11 years ago

+1

Actions #19

Updated by Bruno Passos over 11 years ago

+1

Actions #20

Updated by Thierry Brochu over 11 years ago

This would be an excellent feature to allow our client to edit the mistakes on its own created issues without having us to deal with it through a note left on this same issue by him. +1

Actions #21

Updated by Terence Mill over 11 years ago

+1 - very useful for redmine.org itself

Actions #22

Updated by Anonymous over 10 years ago

+1 crucial

Actions #23

Updated by Florian Kaiser over 10 years ago

+1

Actions #24

Updated by Alain V. about 10 years ago

+1 please for 3.0.0

Actions #25

Updated by Alain V. almost 10 years ago

A feature that we should have, please!

Actions #26

Updated by Etienne Massip almost 10 years ago

Actions #27

Updated by Toshi MARUYAMA over 9 years ago

  • Related to Feature #5195: edit_own_issues and delete_own_issues permissions added
Actions #28

Updated by Alain V. over 9 years ago

+1 please

Actions #29

Updated by Oleg Aksenov about 9 years ago

+1

Actions #30

Updated by Omer Arslan about 9 years ago

+1 - will be very useful

Actions #31

Updated by Guillaume Laneel about 9 years ago

+1 will be usefull

Actions #32

Updated by Sandro De Melis about 9 years ago

+1 this would be an excellent feature

Actions #33

Updated by 4wk_ _ about 9 years ago

+1, really need this. "Editing issue" grant ppl to be like an admin ! (and we don't want that, we want "Edit own issue")

Actions #34

Updated by Chet Wang about 9 years ago

+100

I really need this feature. We're planning to use Redmine but the lack of this feature blocks a lot.

Actions #35

Updated by Do Lam almost 9 years ago

+100. We need this permission.
Thank so much!

Actions #36

Updated by Alexander Lyzhenkov almost 9 years ago

+100 v 3.1

Actions #37

Updated by Trurl McByte almost 9 years ago

+100500 It's bad idea to give access to edit all issues for Reporter only for possibility to change Status from Resolved to Closed

Actions #38

Updated by Adnan Topçu over 8 years ago

Leo Hourvitz's edit_own_new_issues is good idea.
edit_own_issues is topic of this issue.
edit assigned issues is most important for me

In my opinion, "own" is not clear for this mean. Reported or created is more understable ?

Actions #39

Updated by budo kaiman over 8 years ago

+1 to separate "Edit Reported Issues" and "Edit Assigned Issues".

Actions #40

Updated by Ronie Henrich over 8 years ago

Adnan Topçu wrote:

Leo Hourvitz's edit_own_new_issues is good idea.
edit_own_issues is topic of this issue.
edit assigned issues is most important for me

In my opinion, "own" is not clear for this mean. Reported or created is more understable ?

Owner == Author all accross Redmine, modifying this Redmine convention is out of this issue's scope.

Actions #41

Updated by Ronie Henrich over 8 years ago

budo kaiman wrote:

+1 to separate "Edit Reported Issues" and "Edit Assigned Issues".

  • In regards to "Edit Reported Issues", please read my comment 40 (#1248#note-40) above;
  • If a user belongs to a role with "Issues can be assigned to this role" enabled, having something like "Edit Assigned Issues" is not gonna stop him/her to edit an issue, it is just a matter of assigning the issue to himself/herself and voila, now he/she may edit the issue.
Actions #42

Updated by budo kaiman over 8 years ago

Ronie Henrich wrote:

  • If a user belongs to a role with "Issues can be assigned to this role" enabled, having something like "Edit Assigned Issues" is not gonna stop him/her to edit an issue, it is just a matter of assigning the issue to himself/herself and voila, now he/she may edit the issue.

That only works if they already have "Edit Issues" permission, if they don't have that permission then they cannot assign an issue to themself, someone else with that permission must assign the issue to them.

Ronie Henrich wrote:

Owner == Author all accross Redmine, modifying this Redmine convention is out of this issue's scope.

I don't think that there is any scope change, just a wording change as "Author" or "Reporter" is more clear in it's intention.

Actions #43

Updated by Yuuki NARA over 7 years ago

+1

Actions #44

Updated by Pasi Karkkainen over 7 years ago

Yes please, this is an important feature to have!

Actions #45

Updated by José Campos over 7 years ago

+1

Actions #46

Updated by Eugene Belford over 6 years ago

must have feature indeed

Actions #47

Updated by Go MAEDA over 5 years ago

  • Related to Feature #29935: Edit authored issues and Edit assigned issues in issue tracking permission added
Actions #48

Updated by Go MAEDA over 5 years ago

  • Has duplicate Feature #4767: Add permission group to allow 'edit your own tickets (header)'. added
Actions #49

Updated by Yuichi HARADA about 5 years ago

Added "Edit own issues" permission. This permission can edit issues created by you regardless of the presence or absence of a journal.
I attached a patch.

Actions #50

Updated by Go MAEDA about 5 years ago

  • Target version changed from Candidate for next major release to 4.1.0

LGTM. Setting the target version to 4.1.0.

Actions #51

Updated by Go MAEDA about 5 years ago

  • Subject changed from Permissions - Edit own issues to New Permission: Edit own issues
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed
Actions #52

Updated by Mischa The Evil 7 months ago

  • Related to Defect #39493: Role with only :edit_own_issues no longer considered for workflow added
Actions

Also available in: Atom PDF