Redmine

We need it the other way round and have to be able to log time for weeks ago...
It would need to be configurable.

+1 Good idea restricting log time. But I would restrict only for closed issues: #13596

someone has been successful in this?

Pavel Potcheptsov wrote:

Last line in diff gives ability to restrict log time for specified number of days and exclude specific users from this restriction.

I have noted at #3322#note-11 because this issue is closed as duplicate.

Why is this considered a duplicate ? This is a totally legitimate and self-standing use case: for some projects, I want to have a strict discipline in regards with spent time logging. So I want to be sure that the users on this project are allowed to log time ONLY for today AND X working days before (where X most probably equals to 1)

Does anyone know of a plugin that would allow for such functionality? Or might it be included in Redmine itself ?

any chances this will be merged into redmine [soon] ?

hello, anyone ? does Redmine have a community ?

pavel ochman, may be you can change "resolution" for this issue ?

No I can't.

is there anyone alive here ? why are patches ignored ? Man spent his time and effort into it, he deserves at least a reaction !!!

well, I've seen the patch finally ))

this is NOT something that's possible to merge into upstream. just a couple of hard-coded validation checks.

• is time logging restricted for this project at all
• how many days in the past are allowed to log time on (0 is minimum, which means you can only log time on today)

if this sounds bad, please leave your comments

If anyone is interested a coworker made this plugin: https://github.com/cerxal/estatisticas
It does a lot of things, but it includes a field called Numero máximo de dias sin incurrir horas = Maximum number of days to log spent time so users can only log time X days ago, if you try to log X+1 days ago it will raise an error.
We are using it in 3.4.4 (also in 3.3.1). Don't know if it will work in other versions.
Maybe you can use part of the source code to do your own dedicate plugin.

Thanks you for information.
Do you know if there an option to exclude certain users from that restriction?

Pavel Potcheptsov wrote:

Do you know if there an option to exclude certain users from that restriction?

No, it applies to all users on all projects.

We would like to have this functionality as well. IO agree with Kirill and Pavel. Important feature.

We have the same problem In our use case. Users should log their time max 1-3 days back butthey do it just to fiil the time. I'd like to restrict it. If they do not log the time properly, they should have a problem which can solve only someone with higher privilegy.

+1 see my comments from #31984

Ashwin Date wrote:

Corrected spelling for "time logs"

Hi Aswin, please tell me how to use this patch in Redmine.

Ashwin Date wrote:

I have created a patch based on the master git branch for this feature.

Hi there.
Your path works great however I didn't make any changes in app/controllers/issues_controller.rb. Can you describe what is the purpose of that changes?

Do you know how to implement changes so that to add setting to choose users who is excluded from past time log restriction?

For now I have to use this line with hardcoded users IDs:

errors.add :spent_on, :invalid if \
(days_diff.to_i  > Setting.timelog_max_days_before.to_i) && \
([10,20,30,110].exclude? User.current.id)

i use

 errors.add :spent_on,  "is too early" if (spent_on < Date.today - 5.day)
   end

successfully, but like to restrict time logs to the current month, u should not be able to log time in any other month except the current month. so u can only log the time in march, as soon as its 1st of march. im no ruby or redmine coder, can someone help me with this?

Pavel Potcheptsov wrote in #note-38:

Ashwin Date wrote:

I have created a patch based on the master git branch for this feature.

Hi there.
Your path works great however I didn't make any changes in app/controllers/issues_controller.rb. Can you describe what is the purpose of that changes?

Greetings!
I warn you right away, I'm still not well versed in Ruby and Redmine, but I needed to fix the patch that was in this branch.

Do you know how to implement changes so that to add setting to choose users who is excluded from past time log restriction?
For now I have to use this line with hardcoded users IDs:

The corrections were made so that one of the groups could be granted the rights to change. The group can be replenished separately with redmine funds without having to get into the code.
app/models/time_entry.rb

      days_diff = (Date.today - spent_on)
      time_group_name = Setting.timelog_groups_exclude
      time_group = Group.find_by_lastname(time_group_name)
      time_group_id = time_group.id if time_group
      time_users_list = time_group.users if time_group
      time_user_array = []                                                                                  
      time_users_list.each do |user|
        user_id = user.id
        time_user_array.push(user.id)
      end
      errors.add :spent_on, :invalid if \                                                                   
      (days_diff.to_i  > Setting.timelog_max_days_before.to_i) && \
      (time_user_array.exclude? User.current.id)                                                                
      time_user_array.clear

app/views/settings/_timelog.html.erb

<p><%= setting_select :timelog_groups_exсlude, Group.where(["type IN (?)",['User','Group']]).order("users.lastname ASC").each {|u| [u.name.to_s, u.id]}, :blank => :label_none, :label => :setting_timelog_groups_exclude %></p>

config/locales/en-GB.yml

setting_timelog_groups_exclude: Users group for exclude

config/settings.yml

timelog_groups_exclude:
default: ''

<If you think that something needs to be fixed, write.

app/models/time_entry.rb

     days_diff = (Date.today - spent_on).to_i
      time_group = Group.find_by_lastname(Setting.timelog_groups_exclude)
      users_in_group = time_group.users.map(&:id) if time_group
      if days_diff > Setting.timelog_max_days_before.to_i && !users_in_group.include?(User.current.id) && !(User.current.admin?)
        errors.add :spent_on, :invalid
      end

Hi,

i would like to block adding or changing time entries at all if, for example, then spent_on is on last month, and number of day in current month is like >= 5. Only allow admins to do so, no seetings needed.

Im not really sure where exactly to put it on the time_entry.rb file, could someone explain? Is it the "validate_time_entry" method?

Eser Esen wrote in #note-42:

Hi,

i would like to block adding or changing time entries at all if, for example, then spent_on is on last month, and number of day in current month is like >= 5. Only allow admins to do so, no seetings needed.

Well you can follow my original patch and do something like that, i.e. throw error if current day is more then 05 in current month and spent time is in the past month and hardcode users's id to exclude from this condition:

errors.add :spent_on,  "is too early" if (spent_on <= Date.today.prev_month.end_of_month && Date.today.day >= 5) && ([admin_id1,admin_id2].exclude? User.current.id)

Wow!
Although I'm not an active user of Remine anymore still glad the project has such a valuable contributors.

Jens Krämer wrote in #note-47:

Upon user request, we have developed a very simple solution at Planio, which allows to disable time logging on closed issues on a per-project basis (in the project settings / issue tracking tab):

[..]

• Accept time logs with 0 hours
• Accept time logs on future dates

I fully agree that having the option to override some settings at the project level is very useful. Until that feature is available, I prefer to add this setting next to the existing ones. I've posted a new patch based on your work in #13596. Let's continue the discussion there.

Marius BĂLTEANU wrote in #note-50:

Go MAEDA, I've reworked a little bit your patch in order to be in the same direction with the similar settings that we already have. What do you think?

Thank you for taking care of this.

I think that with Planio's new "Time tracking on closed issues" setting, the additional setting to restrict time entries for past dates that I proposed may not be necessary. This new setting seems sufficient to cover many use cases, and adding a restriction for past dates on top of this might increase complexity. Adding too many settings could make it cumbersome for users to manage configurations effectively.

Marius BĂLTEANU wrote in #note-49:

I fully agree that having the option to override some settings at the project level is very useful. Until that feature is available, I prefer to add this setting next to the existing ones. I've posted a new patch based on your work in #13596. Let's continue the discussion there.

Thank you Marius, that makes sense. I guess #4015 is what you mean regarding project level setting overrides?

Jens Krämer wrote in #note-52:

Marius BĂLTEANU wrote in #note-49:

I fully agree that having the option to override some settings at the project level is very useful. Until that feature is available, I prefer to add this setting next to the existing ones. I've posted a new patch based on your work in #13596. Let's continue the discussion there.

Thank you Marius, that makes sense. I guess #4015 is what you mean regarding project level setting overrides?

Yes, that is the ticket.