Project

General

Profile

Activity

From 2018-12-02 to 2018-12-04

2018-12-04

13:59 Feature #29482: Query system for Projects page
This is a super useful feature. Thanks for making this patch. I did not quite get if it makes possible filtering by custom fields. Hope this feature is available. Ivan Gretsky
11:06 Defect #26785 (Closed): Wrong columns after CSV export
Merged to 3.4-stable branch. Go MAEDA
10:28 Defect #26785 (Resolved): Wrong columns after CSV export
Committed the patch with a slight change in the test.
Thank you for reporting and fixing the issue.
Go MAEDA
06:29 Defect #28636: Cannot find an issue from a closed subproject when search scope is Project and its subprojects
I agree with Marius' opinion. Jean-Philippe wrote in #6049#note-9 as follows. It is obvious that closed subprojects should be searchable.
> I'm closing this request since 2.1.0 adds the ability to close projects. Closed projects are s...
Go MAEDA
00:53 Defect #28636 (Confirmed): Cannot find an issue from a closed subproject when search scope is Project and its subprojects
Confirmed the problem.
Scope 'subprojects' is the only scope that searches only in the active projects. Scopes 'all' and 'my projects' include also closed projects. I think we should be consistent with the behaviour between the search...
Marius BĂLTEANU
04:00 Feature #5242: Display source project for cross-project associated revisions for issues
I rebuilt the patch to work with the latest Redmine.
In the cross-project it looks like the following.
!{width:80%;border:1px solid gray}cross-project-associated-revisions.png!
Yuichi HARADA
02:21 Feature #30086 (Closed): Use HTTP status code 403 instead of 401 when REST API is disabled
Currently, Redmine returns HTTP status code 401 (Unauthorized) if the REST API feature is disabled. Go MAEDA
01:06 Defect #29918: Related issues section ignores the date format setting
Jean-Philippe Lang wrote:
>
> ...
Indeed, could be an improvement, but I think that it'll be better to make the attributes configurable because the use cases and the relevant information depends from instance to instance. For example, ...
Marius BĂLTEANU

2018-12-03

22:16 Feature #16717: Add _blank support for "Link values to URL"
+1 Heiko Böhme
22:14 Patch #29951: Quick design fix/proposals for projects index page
Bernhard Rohloff wrote:
> First of all I really like the idea of different views to navigate through projects in Redmine. I think that it can be very beneficial if you offer the user different viewing angles to fit their specific needs....
Marius BĂLTEANU
21:59 Patch #29951: Quick design fix/proposals for projects index page
Kim Henriksen wrote:
> Tried to apply the patch, but doesn't seems to make sub-sub projects not break:
Did you restart your webserver or hard reset your cache?
Marius BĂLTEANU
20:00 Patch #29951: Quick design fix/proposals for projects index page
Tried to apply the patch, but doesn't seems to make sub-sub projects not break:
!projects-overview.png!
Kim Henriksen
18:10 Patch #30071: Show parent projects when filtering in the project jump box
The original patch uses on font-weight to grey out the non-matched parent nodes. This relies on the used font to provide the font-style which often it does not. Just realised this as I tested on Windows.
Supplied patch uses "color" in...
Anders Thomsen
09:27 Patch #30071 (Needs feedback): Show parent projects when filtering in the project jump box
It is an interesting improvement.
I tried out the patch. But parent projects were displayed in not grey but black. And the checkmark for the current project was not displayed even after applying the patch 0002-Mark-current-project-whe...
Go MAEDA
15:02 Feature #10267: Show custom date fields in calendar
Any chance to get this feature for redmine >=3.4 ?
Thanks
Davide Galletti
10:34 Defect #26785: Wrong columns after CSV export
LGTM. Setting the target version to 3.4.7. Go MAEDA
10:06 Defect #26785: Wrong columns after CSV export
I cleaned up the code a little. Mizuki ISHIKAWA
09:49 Defect #26785: Wrong columns after CSV export
Go MAEDA wrote:
> The problem can be addressed by restoring the session value after sending CSV to the client.
The patch attached to #26785#note-5 worked fine for me, but I think it would be better to use the argument use_session of ...
Mizuki ISHIKAWA
06:14 Defect #26785: Wrong columns after CSV export
You can fix this issue with the attached patch.
My customer experiences @ActionDispatch::Cookies::CookieOverflow@ exception due to this defect. The Redmine has 200+ custom fields. A list of all custom fields is set to @session[:issue_...
Go MAEDA
01:59 Feature #27672: Show selected columns in gantt chart
Iwan Yudhistira wrote:
> how to run the patch in windows, thank you before
You should be able to apply the patch in the following way.
# Change into your Redmine directory (the one with app, test, and config folders)
# Download t...
Mizuki ISHIKAWA

2018-12-02

23:32 Patch #29406 (Closed): Use sorted instead of sort
Committed. Thank you for improving Redmine. Go MAEDA
02:20 Patch #29406: Use sorted instead of sort
Passed all tests. Setting the target version to 4.1.0.
The attached patch is a combination of Pavel Rosický's three patches.
Go MAEDA
17:35 Defect #29855: add_working_days may return wrong date when the start date is a non-working day
Jean-Philippe Lang wrote:
>
> ...
Thanks, but are still not clear for me the expected results so I'll leave Go Maeda or Mizuki ISHIKAWA to fix this issue.
Marius BĂLTEANU
17:23 Defect #29855: add_working_days may return wrong date when the start date is a non-working day
Marius BALTEANU wrote:
> The number of the expected working days according to the test is 4. But in my opinion, it should be 5 days (Tuesday, Wednesday, Thursday, Friday and Monday). 4 could be only if we exclude the end date from the...
Jean-Philippe Lang
12:39 Defect #29855: add_working_days may return wrong date when the start date is a non-working day
I took a look and there are some strange (or wrong) test cases the we should review before changing anything else.
Taking the following test scenario:
Marius BĂLTEANU
08:53 Defect #29855: add_working_days may return wrong date when the start date is a non-working day
Mizuki ISHIKAWA wrote:
> Any feedback is welcome.
@DateCalculation#working_days@ should be fixed in a similar way to be consistent with the proposed fix. These new assertions should pass:
Jean-Philippe Lang
16:35 Defect #9708 (Closed): Adding relation to the issue sometimes does not work
Go MAEDA
16:34 Feature #26620 (Closed): Change the text of the submit button on search page from button_submit to label_search
Marius BALTEANU wrote:
> For me, this change generates "translation missing: en.button_search". Please see the below screenshot.
> ...
Fixed in r17684. Thanks.
I changed button_search to label_search before committing as I wrote in ...
Go MAEDA
16:27 Feature #26620 (Reopened): Change the text of the submit button on search page from button_submit to label_search
For me, this change generates "translation missing: en.button_search". Please see the below screenshot.
!{width:70%; border: 1px solid black;}button_search.png!
In the existing locales, we have only "label_search". We can use this ...
Marius BĂLTEANU
15:15 Feature #26620 (Closed): Change the text of the submit button on search page from button_submit to label_search
Committed. Thank you for improving Redmine. Go MAEDA
16:19 Feature #4491 (Closed): Direct Image Upload in Forum
Implemented by #26071. Go MAEDA
15:05 Feature #1777 (Closed): Allow %2650 in Wiki to display and linke the Title of the Ticket (next to #2650
The new syntax "##123" which renders tracker name, issue id, and title will be available in Redmine 4.0.0. Go MAEDA
12:52 Patch #29951: Quick design fix/proposals for projects index page
We can achieve a better projects page only with some CSS changes. The most important change is to not allow to break inside a column.
The proposed solution has a down side effect on Safari (which is a known issue and I didn't find any...
Marius BĂLTEANU
12:26 Feature #29993 (Closed): Option to unarchive the project when admins visit an archived project
When trying to access an archived project, a link to unarchive it will now be displayed to admin users. Jean-Philippe Lang
11:07 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
Hopefully soon™... Anonymous
07:25 Patch #28662 (Closed): Replace "Cancel" buttons from the modals with "Cancel" link
Committed the patch. Thank you for your contribution. Go MAEDA
01:33 Patch #30075 (Closed): Czech translation update
Committed. Thank you for your contribution. Go MAEDA
 

Also available in: Atom