Project

General

Profile

Activity

From 2019-09-28 to 2019-09-30

2019-09-30

20:14 Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed
@$ LC_ALL=en_US.UTF-8 firefox@
!POC.png!
Toshi MARUYAMA
20:01 Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed
Simplified. Toshi MARUYAMA
19:51 Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed
This is POC.
There is no test.
You need apply #28492 patch first.
Toshi MARUYAMA
18:18 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
By the way...
... *display:block;* and *padding:0;* on the avatar link aligns it vertically with the rest. ;-)
Bernhard Rohloff
18:13 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Go MAEDA wrote:
> Thank you for writing the patch. I have some requests:
> ...
I'm also in favor of moving user related links inside the user menu. This makes thinks very easy for new users.
Github's user menu is also a nice case stud...
Bernhard Rohloff
13:24 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Go MAEDA wrote:
> Perhaps we can study from Planio, a Redmine based online service. Planio already has account drop-down.
I like the idea, of moving more links inside user menu :D
Anonymous
04:05 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Perhaps we can study from Planio, a Redmine based online service. Planio already has account drop-down.
!{width: 429px; border: 1px solid #ccc;}.planio@2x.png!
They offer a freemium plan (Bronze plan, 1 project, 2 users, 1GB), so...
Go MAEDA
03:49 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Thank you for writing the patch. I have some requests:
* Change the link text name to "Profile" (@label_profile@). The name of page /users/999 is "Profile". I think the correct name should be shown in the menu.
* Add "My page" to the...
Go MAEDA
17:27 Feature #32029: Replace gantt and calendar tooltips with jquery tooltips
Marius BALTEANU wrote:
> Nice job! I will help you with this. Also, we should preserve the white background for these tooltips.
I included your suggestion in an updated patch and introduced a new custom class called "white-tip" for tho...
Anonymous
16:24 Feature #16098: On relation change/add notification setting
Setting the target version to 4.2.0. Go MAEDA
15:31 Feature #32169 (Closed): Add links to the detailed Wiki formatting help in Quick Reference
Committed the patch. Go MAEDA
00:26 Feature #32169: Add links to the detailed Wiki formatting help in Quick Reference
Setting the target version to 4.1.0. Go MAEDA
15:16 Feature #31879 (Closed): "starts with" and "ends with" filter operators for string values
Yuichi HARADA wrote:
> I added "starts with" and "ends with" filter operators to File filter, but didn't create an implementation.
Committed the fix in r18570. Thank you.
Go MAEDA
10:26 Feature #31879 (Reopened): "starts with" and "ends with" filter operators for string values
Go MAEDA
10:21 Feature #31879: "starts with" and "ends with" filter operators for string values
I added "starts with" and "ends with" filter operators to File filter, but didn't create an implementation.
I created a patch.
Yuichi HARADA
14:32 Defect #32176 (Closed): Emails are not getting triggered
When we create a new ticket and update existing one emails are not getting triggered. Kindly help as we have to manually inform to business every time. Prashant Chavan
13:40 Defect #32153: Repository browser does not render previews for audio/video files
Go MAEDA wrote:
> Attaching a quick-and-dirty workaround.
Thanks :-)
I'll share more feedback after I test it if I'll find more bugs
Anonymous
11:51 Feature #7360: Issue custom query: default query per instance, project and user
+1
Is this patch workable on 4.0.4 ? Because "redmine_default_custom_query" is conflict with DMSF. So I am seeking another solution with same function.
Ryoji Takeuchi
09:42 Defect #32172: Warning "constant Loofah::HTML5::WhiteList is deprecated"
The fix has already merged to master before I filed an issue.
https://github.com/rails/rails-html-sanitizer/pull/100
Go MAEDA
05:18 Defect #32172: Warning "constant Loofah::HTML5::WhiteList is deprecated"
Reported the issue to the rails-html-sanitizer team.
https://github.com/rails/rails-html-sanitizer/issues/101
Go MAEDA
01:45 Defect #32172: Warning "constant Loofah::HTML5::WhiteList is deprecated"
I observed this after loofah was updated from 2.2.3 to 2.3.0. Go MAEDA
01:38 Defect #32172 (Closed): Warning "constant Loofah::HTML5::WhiteList is deprecated"
Go MAEDA
02:29 Defect #32170 (Resolved): Text enclosed in pre tag in Wiki formatting reference is not displayed in monospaced font in Chrome
Committed the patch. Go MAEDA
00:26 Defect #32170: Text enclosed in pre tag in Wiki formatting reference is not displayed in monospaced font in Chrome
Setting the target version to 4.1.0. Go MAEDA

2019-09-29

16:05 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Marius BALTEANU wrote:
> Bernhard, Antonio, I've reworked the entire patch, you can use the new one for testing. It's more complete, but it still need some work to improve the code and of course, fixes. I've tested only one Chrome.
> ....
Anonymous
14:54 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Bernhard, Antonio, I've reworked the entire patch, you can use the new one for testing. It's more complete, but it still need some work to improve the code and of course, fixes. I've tested only one Chrome.
All 3 proposals were been i...
Marius BĂLTEANU
09:01 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Version 2 FTW! This search bar in the header annoys me as hell.
I've tried your patch and looked nice already. One thing I would like to change is the drop-down trigger. I'm used to trigger the drop-down menu on click rather then on hov...
Bernhard Rohloff
04:35 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Marius BALTEANU wrote:
> I made some progress and I would like to share two screenshots
I am all for the second implementation, so we could close #32115 but couple of cents from me:
- It feels like links on the left side are too small...
Anonymous
04:35 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Edit: _deleted, because dupe_ Anonymous
15:07 Defect #32170 (Closed): Text enclosed in pre tag in Wiki formatting reference is not displayed in monospaced font in Chrome
This is related to #20372, should have been fixed together with it.
*Before:*
!{width: 250px; border: 1px solid #ccc;}.before@2x.png!
*After:*
!{width: 250px; border: 1px solid #ccc;}.after@2x.png!
Go MAEDA
12:43 Feature #32169 (Closed): Add links to the detailed Wiki formatting help in Quick Reference
The attached patch adds links to the detailed Wiki formatting help in Quick Reference.
Currently, there is only one link to the detailed help in Quick Reference. The link is placed at the bottom of the page, so it is not prominent. So...
Go MAEDA
03:27 Defect #32168 (New): Allow issue id with "#" prefix for the value of issue ids filter
I found an inconsistent behavior regarding issues filter.
"Parent task" and "Subtasks" filter accept issue ids with "#" prefix (e.g. !#123), however, "Issues" filter does not. I think "Issues" filter should also behave the same.
|_...
Go MAEDA
02:04 Feature #25540 (Closed): Unify fields of subtasks and related issues on issue page
Committed the patch. Thank you all for your contribution. Go MAEDA
01:50 Patch #31147 (Closed): Add custom styles for all fields
Marius BALTEANU wrote:
> We should make the disabled fields more obvious using the below patch:
Committed the fix in r18548. Thank you.
Go MAEDA

2019-09-28

23:08 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
I made some progress and I would like to share two screenshots:
1. Move only user related links under a user dropdown:
!user_dropdown.png!
2. Move search and project jump box to top menu:
!search_and_jump_box_in_top_menu.png!
Marius BĂLTEANU
19:16 Patch #31147 (Reopened): Add custom styles for all fields
We should make the disabled fields more obvious using the below patch: Marius BĂLTEANU
19:08 Patch #31971 (Closed): Change the color of the input field frame when in focus
Marius BĂLTEANU
19:08 Patch #31971 (Reopened): Change the color of the input field frame when in focus
Go Maeda, Mizuki, is there any reason for why you chose to target each type of @input@ instead of using @input@? Marius BĂLTEANU
18:46 Feature #29482: Query system for Projects page
Dmitry Makurin wrote:
> According to the "current trunk":http://www.redmine.org/projects/redmine/repository/entry/trunk/app/helpers/projects_helper.rb#L62 you should probably change 'my project' icon
> ...
Thanks for pointing this out...
Marius BĂLTEANU
18:17 Defect #32167 (Closed): Inconsistent border coloring of UI elements?
- Table lists (list.table), Boxes (.box) and fieldsets (fieldset) border color is #e4e4e4
- Gantt (table.gantt-table) border color is #c0c0c0
- Calendar (table.cal) border color is #d7d7d7
- Separrator after tabs (#content .tabs ul), ...
Anonymous
16:22 Patch #32014: Rounded corners on table.list elements
Go MAEDA wrote:
> I will revert this change because the change caused other changes such as #32165 and #32166 and I cannot predict how much the impact will spread further.
#32165 and #32166 would be the last patches for the tables anyw...
Anonymous
15:48 Patch #32014 (Reopened): Rounded corners on table.list elements
I will revert this change because the change caused other changes such as #32165 and #32166 and I cannot predict how much the impact will spread further. Go MAEDA
02:07 Patch #32014 (Closed): Rounded corners on table.list elements
Committed the patch. Thank you for improving Redmine. Go MAEDA
14:52 Patch #26030: Like issues and news comments, want to specify the display order of the forum's reply.
Opps, Thank you for checking my patch. I've removed the duplicated @MessageTest@.
Popoki Tom (@cat_in_136)
14:42 Patch #32166 (New): Rounded corners on table.gantt-table
This patch is a follow up to #32014 to add 3px border-radius to gantt table. Anonymous
14:40 Patch #32165 (Closed): Rounded corners on table.cal
This patch is a follow up to #32014 to add 3px border-radius to calendar table. Anonymous
14:07 Feature #25540: Unify fields of subtasks and related issues on issue page
Looks good to me and it's a useful improvement until we make these columns configurable in the admin. Marius BĂLTEANU
13:52 Feature #29752 (Needs feedback): Render Textile and Markdown attachments on the preview page
The patch looks good to me with one small observation, do you see any problem if we add @'text/textile' => 'textile'@ to @MIME_TYPES@? In this way, we can replace in the patch @self.filename =~ /\.(textile)$/i@ with @Redmine::MimeType.o... Marius BĂLTEANU
13:41 Patch #32162: Improved progress bars for issues and versions
I think I like rounded one better :D Maybe 25% border radius would also look quite cool.
We should probably add #32016 as related, so we could remember to close it later as well, in case rounded version of the bar in this patch will be ...
Anonymous
10:51 Patch #32162: Improved progress bars for issues and versions
Antonio McDeal wrote:
> +1 :D
> ...
A 50% border radius looks not too bad either. :-)
!{border: 1px solid grey;}round-progress-bars.png!
Bernhard Rohloff
13:13 Feature #31505: Mark edited journal notes as "Edited"
Updated to apply cleanly on the current trunk. Marius BĂLTEANU
12:19 Feature #1237: Add support for two-factor authentication
Go MAEDA wrote:
> Two-factor authentication is becoming a must-have feature nowadays. Thanks to Planio, now there is a complete and ready-to-commit patch with test code.
> ...
Totally agree with you regarding the need for this feature....
Marius BĂLTEANU
10:33 Feature #1237 (New): Add support for two-factor authentication
Two-factor authentication is becoming a must-have feature nowadays. Thanks to Planio, now there is a complete and ready-to-commit patch with test code.
I think it is the time to commit the patch. Setting the target version to 4.1.0.
Go MAEDA
08:46 Feature #1237: Add support for two-factor authentication
I have slightly fixed two of the four patches to apply to the latest trunk, r18547. You can add two-factor authentication by applying the following patches.
* attachment:0001-adds-two-factor-authentication-support-r18547.patch (update...
Go MAEDA
04:53 Patch #32145 (Resolved): Update locales for Vietnamese
Closed Enziin System
04:53 Patch #32163 (Closed): Update locales for Vietnamese
Update locales for Vietnamese Enziin System
 

Also available in: Atom