Redmine

2020-01-30

16:38 Feature #8241: Advanced notification: per user, per project configurable schedule, event filter and notification format

+1 Gustavo Rodriguez

16:06 Patch #32927: CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific

No, we should not ;) But I think this specific test is too precise. It will break as soon as the table is modified, e... Vincent Robert

15:20 Patch #32927: CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific

Plugins often break core tests. Should we relax tests every time a plugin the test suite? Go MAEDA

14:27 Patch #32927 (Closed): CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific

Hi
Just a tiny patch which makes a test less specific. This way, a plugin can add columns to the table without break... Vincent Robert

15:47 Patch #32918 (Closed): Czech translations

Committed the patch. Thank you. Go MAEDA

15:43 Patch #32928 (Closed): Czech translation for 4.1-stable

Committed the patch. Thank you for your contribution. Go MAEDA

15:37 Patch #32928 (Closed): Czech translation for 4.1-stable

Originally posted by Pavel Rosický as #32918. Go MAEDA

15:26 Patch #32917 (Closed): Bulgarian translation

Committed the patch. Thank you for your contribution. Go MAEDA

12:28 Patch #32922 (Resolved): Reload detached attachments

sry, thanks for catching this, I was confused about the comment. Closing Pavel Rosický

08:13 Patch #32922: Reload detached attachments

Thanks Pavel for posting the patches for Rails 6 update.
I've applied this patch on the current trunk and a test f... Marius BĂLTEANU

00:57 Patch #32922 (Closed): Reload detached attachments

use #reload instead, after upgrading to Rails 5 Pavel Rosický

11:55 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note

+1 for this Robert Röttger

09:34 Defect #32477 (Resolved): Right-aligned TOC tag is displayed in exported PDF if the text formatting setting is Markdown

Committed the patch. Go MAEDA

09:19 Feature #16006: Include attachments in forum post notifications

Yuichi HARADA wrote:
> Perhaps I think that Message's callback method @after_create_commit@ ( "Message#send_notifica... Go MAEDA

08:47 Defect #5354: Updating custom fields does not trigger update to "updated_on" field in the customized object

Setting the target version to 4.2.0. Go MAEDA

08:16 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator

Go MAEDA wrote:
> Marius BALTEANU wrote:
> > Sorry, I've attached a broken patch, please revert it and will post la... Marius BĂLTEANU

06:27 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator

Marius BALTEANU wrote:
> Sorry, I've attached a broken patch, please revert it and will post later the correct one.
... Go MAEDA

04:45 Patch #32924 (Closed): tmp/pdf directory is no longer necessary

We can remove the following code because @tmp/pdf@ directory that is used when generating pdf files is no longer used... Go MAEDA

03:34 Defect #32916: Bar length is wrong when exporting gantt chart to PDF

Improved bar length calculation accuracy for exporting to PDF (and png).
(modified patch code)... Anonymous

02:53 Feature #32240: Add download buttons in Files columns of the issues list

LGTM. Setting the target version to 4.2.0. Go MAEDA

02:46 Feature #3088: Estimated hours field able to hide role based

Go MAEDA wrote:
> Now the patch cannot be applied cleanly.
Fixed the patch to work on the current trunk(r19478). Yuichi HARADA

01:00 Defect #32923 (Closed): Rails 6: detach attachments when a conflict occurs

fixes... Pavel Rosický

2020-01-29

23:06 Defect #32921 (Closed): Rails 6: add header=present to csv tests

fixes... Pavel Rosický

22:38 Patch #32909: Replace pluck().first with pick()

Looks good to me. Marius BĂLTEANU

11:33 Patch #32918 (Closed): Czech translations

Pavel Rosický

08:07 Patch #32917 (Closed): Bulgarian translation

* field_toolbar_language_options
* label_user_mail_notify_about_high_priority_issues_html Ivan Cenov

06:15 Defect #32916 (Closed): Bar length is wrong when exporting gantt chart to PDF

When exporting a gantt chart to PDF, short (1 or 2 days) tasks are sometimes correct and sometimes incorrect, dependi... Anonymous

05:58 Defect #32737: Duplicate sort keys for issue query cause SQL error with SQL Server

Go MAEDA wrote:
> Maybe also this patch will work.
Execute tests on SQL Server, 12 test failures (500: Internal S... Yuichi HARADA

05:44 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects

Simon Hori wrote:
> Now it works perfectly fine with my MS Outlook!!
> No deletion occurred after a drag-drop. Than... Go MAEDA

05:37 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects

Sorry, you are right. I changed a wrong line in `dragOutHandler` but it must be added to `dragOverHandler` as you wro... Simon Hori

04:07 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects

Simon Hori wrote:
> Thanks for the patch! I believe I added the two lines properly to the js but unfortunately it is... Yuichi HARADA

03:41 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects

Thanks for the patch! I believe I added the two lines properly to the js but unfortunately it is still deleting the i... Simon Hori

05:11 Defect #32915 (New): Internal Server Error occurted when exporting gantt chart to png on Windows

Redmine 4.0.4 using RMagick was fine.
However, Redmine 4.1.0 using MiniMagick does not work.
prodution.log of Red... Anonymous

02:07 Defect #32914 (Closed): Rails 6: remove #filename_for_content_disposition for MS browsers

relates to #32913
this prevents double escaping, fixes... Pavel Rosický

01:33 Defect #32913 (Closed): Rails 6: add filename header

fixes... Pavel Rosický

00:50 Defect #32912: Rails 6: update no longer bypass optimistic locking

I'm not sure about test_copy_should_not_copy_subtasks_twice_when_saving_twice which was introduced in https://github.... Pavel Rosický

00:42 Defect #32912 (Closed): Rails 6: update no longer bypass optimistic locking

fixes test failures... Pavel Rosický

2020-01-28

23:39 Patch #32911 (Closed): Rails 6: Fix deprecation warning "Class level methods will no longer inherit scoping"

fixes... Pavel Rosický

23:17 Defect #32910 (Closed): Rails 6: add lookup_context to hook_test.rb

fixes... Pavel Rosický

23:03 Patch #32909 (Closed): Replace pluck().first with pick()

https://github.com/rails/rails/pull/31941 Pavel Rosický

22:56 Defect #32908 (Closed): Rails 6: Sending mail with DeliveryJob is deprecated

this change isn't compatible with Rails < 6
#29914 Pavel Rosický

22:51 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Go MAEDA wrote:
>
> I agree. Redmine 5.0.0 is the appropriate version to switch to Rails 6 and this should be decid... Marius BĂLTEANU

14:57 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

+1 however I guess lot's of plugin developers will need to be notified and start their upgrades as well... Aleksandar Pavic

06:34 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Marius BALTEANU wrote:
> I'm willing to help with this, but I think we should have first a decision (from Jean-Phili... Go MAEDA

22:36 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator

Here is the correct patch, please revert r19478 and commit this one. Marius BĂLTEANU

10:55 Defect #32897 (Reopened): Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator

Sorry, I've attached a broken patch, please revert it and will post later the correct one. Marius BĂLTEANU

10:49 Defect #32897 (Closed): Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator

Committed the patch. Thank you for your contribution. Go MAEDA

10:19 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator

Tests results "here":https://gitlab.com/redmine-org/redmine/pipelines/112841765. Marius BĂLTEANU

22:24 Patch #32907 (Closed): Update capybara (~> 3.31.0)

the patch reduces warnings for Ruby 2.7 support #31500
https://github.com/teamcapybara/capybara/blob/master/Histor... Pavel Rosický

21:59 Patch #32906 (Closed): Update i18n (~> 1.8.2)

the patch reduces warnings for Ruby 2.7 support #31500
https://github.com/ruby-i18n/i18n/releases Pavel Rosický

17:42 Feature #1712: add custom fields that are calculations of other fields

+1 Matteo Turra

10:32 Patch #18770: Make issue history collapsable

Can you update for Redmine 4
also, can you create normal patch, not hg one, because I'm getting:... Aleksandar Pavic

04:01 Patch #32890 (Closed): Fix violations reported by Stylelint

Committed the patches. Thank you. Go MAEDA

02:20 Defect #32896 (Closed): Totals not working in projects list view

Go MAEDA

02:18 Defect #32896: Totals not working in projects list view

Committed the patch. Thank you for posting the patch so quickly. Go MAEDA

01:34 Defect #32899 (Closed): Javascript error caused by tooltip

Improved tooltip in Redmine 4.1.0 ( #31441) causes a Javascript error on some (self-made) plugin pages using the "tit... Anonymous

01:32 Feature #32898 (Closed): PDF thumbnails support on Windows

Redmine 4.1.0 don't support PDF thumbnails on Windows. ( #22481 )
For Windows, "gswin64c(32c).exe"(command line vers... Anonymous