Project

General

Profile

Activity

From 2020-04-24 to 2020-04-26

2020-04-26

23:12 Feature #12222: SLA Integration (Service Level Agreement)
+1 for this feature Sebastián Labonia
23:11 Feature #15152: SLA Feature
+1 for this feature Sebastián Labonia
23:11 Feature #15021: Service Level Agreement (SLA), more user-friendly email configuration, add any other notifications
+1 for this feature Sebastián Labonia
18:52 Defect #33341: Time entry user is shown twice in the User drop-down when editing spent time
The fix looks good to me. The attached patch contains the fix and an assertion.
Tests pass: https://gitlab.com/redmine-org/redmine/pipelines/139995890
Marius BĂLTEANU
18:14 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
Let's use for now this safer fix: Marius BĂLTEANU
17:12 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
I attached another example screen with incorrect label lenght. Alexander Meindl
17:06 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
The labels of the settings are cut. There should be more space for it and moved to the right. On the picture the forth settings from top and the second last entry are not complete. Can you see it? Alexander Meindl
16:36 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
Alexander Meindl wrote:
> The related css code is used by plugins. If css code changes in Redmine, all plugin developers have to take care of this change. But if you think this is the best solution, this should not be a problem.
I ch...
Go MAEDA
16:10 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
Are there any non third-party Plugins?
At the moment in template plugin.html.erb is set
Alexander Meindl
16:01 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
Alexander Meindl wrote:
> The problem only exist, if tabs are used in settings, e.g. with most of redmineup plugins.
If the problem is specific to particular third-party plugins, it should be cared by the third-party vendor. Maybe th...
Go MAEDA
15:35 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
The problem only exist, if tabs are used in settings, e.g. with most of redmineup plugins. Alexander Meindl
15:33 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
Alexander Meindl wrote:
> sure, e.g. redmineup CRM settings. See my attachment.
To my eyes, it appears to be normal. And I could not find any problem with the sample plugin (/extra/sample_plugin). Could you describe more detail?
!...
Go MAEDA
15:28 Defect #33339 (Reopened): Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
Go MAEDA
15:22 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
Hi,
sure, e.g. redmineup CRM settings. See my attachment.
!redminecrm_settings.png!
Alexander Meindl
15:04 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
Alexander Meindl wrote:
> Hi,
> ...
Do you have any example such a plugin, so we can look for a proper fix for the padding issues. The whole CSS styles for the padding inside these boxes look a bit chaotic to me.
Bernhard Rohloff
13:14 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
Hi,
r19720 breaks alignment with lots of plugin settings, because this padding left is used in "plugin.html.erb":/projects/redmine/repository/entry/trunk/app/views/settings/plugin.html.erb
If a plugin uses tabs for settings, this l...
Alexander Meindl
17:22 Feature #33352: Enable inline issue autocomplete in issue id query filter fields
+1
I think we should implement #32168 that allows entering issue ids with "#" prefix to the filters to move this issue forward. This is because issue ids inserted by the auto-complete feature have "#" prefix.
Go MAEDA
17:14 Defect #17809 (Closed): wrong syntax highlighting "---" header and "--" footer of git diff
3.4
!3.4.png!
4.1
!4.1.png!
Toshi MARUYAMA
17:03 Defect #17809: wrong syntax highlighting "---" header and "--" footer of git diff
Go MAEDA wrote:
> It can be fixed with the following code:
No.
I have created new #33357.
Toshi MARUYAMA
17:02 Defect #33357 (Closed): rendering extra "--" footer of git patch attachment
From #17809.
For example #4511 0002-Use-Principal-to-get-users-and-groups-for-watchers-i.patch.
!git-diff.png!
#17809#note-5 has solution.
Toshi MARUYAMA
11:27 Feature #28471: Query links for subtasks on issue page
IMHO, it looks like a nice improvement. :-) Bernhard Rohloff
09:54 Defect #33355 (Closed): TypeError when attempting to update a user with a blank email address
Go MAEDA

2020-04-25

19:44 Feature #22425: Allow "style" tag in Redcarpet Markdown formatter
+1
I also want to set the text color on markdown.
There was a related discussion at the URL below.
https://www.redmine.org/boards/2/topics/56096?r=57052
You can fix it with the following modification,
but I am worried about t...
Yuuki NARA
11:23 Feature #28471: Query links for subtasks on issue page
I reworked a little bit the patch proposed by Bernhard:
!subtasks.png!
What do you think?
Marius BĂLTEANU
10:27 Feature #32085: Allow newline as a separator in "Allowed extensions", "Disallowed extensions", "Exclude attachments by name" field in Administration
I have removed some refactorings because they are not directly related to this issue and should be a separate patch.
Setting the target version to 4.2.0.
Go MAEDA
10:12 Feature #33352 (New): Enable inline issue autocomplete in issue id query filter fields
The query filters on issues and related issues accept issue ids. I see several use-cases/benefits of enabling the inline issue subject autocomplete functionality added by #31989 for these fields. Mischa The Evil
10:05 Feature #4511: Allow adding user groups as watchers for issues
Regarding first problem (N+1), we don’t do anything? Marius BĂLTEANU
10:03 Feature #4511 (Closed): Allow adding user groups as watchers for issues
Committed the patches attached in #4511#note-73. Thank you. Go MAEDA
09:31 Feature #4511: Allow adding user groups as watchers for issues
Go MAEDA wrote:
> Marius, thank you for improving the code but I noticed that attachment:0001-Get-the-list-of-new-issue-watchers-using-single-quer.patch change the behavior.
> ...
You're right, thanks for pointing this out, I've update...
Marius BĂLTEANU
05:15 Feature #4511: Allow adding user groups as watchers for issues
Marius, thank you for improving the code but I noticed that attachment:0001-Get-the-list-of-new-issue-watchers-using-single-quer.patch change the behavior.
Redmine 2.5 or later does not show watchers checkboxes on the new issue page w...
Go MAEDA
10:01 Revision 19726 (svn): Use scope assignable_watchers (#4511).
Patch by Marius BALTEANU. Go MAEDA
10:00 Revision 19725 (svn): Use principals in acts_as_watchable (#4511).
Patch by Marius BALTEANU. Go MAEDA
09:59 Revision 19724 (svn): Use Principal to get users and groups for watchers in watchers controller (#4511).
Patch by Marius BALTEANU. Go MAEDA
09:57 Revision 19723 (svn): Get the list of new issue watchers using single query and limit the results to 20 (#4511).
Patch by Marius BALTEANU. Go MAEDA
09:54 Patch #16133: Available watchers on new issue form include users who cannot even view issues
Here are some ideas in order to avoid the overhead:
1. If we really want to show some watchers in the new issue form:
* Get first 20 users from the database and check the visibility only for them
* Get more users from the database a...
Marius BĂLTEANU
09:45 Patch #33329: Improve watchers functionality to mark the users that are watching a non visible object and to not return watchers that cannot see the object
Go MAEDA wrote:
> Looks good to me.
> ...
I'm adding this to 4.2.0 in order to discuss and find some solutions to fix the current annoying behaviour. We can limit the number of calls made by @watchable_object.visible?@ by limiting the ...
Marius BĂLTEANU
09:01 Patch #33329: Improve watchers functionality to mark the users that are watching a non visible object and to not return watchers that cannot see the object
Looks good to me.
A similar patch #16133 was rejected 5 years ago due to performance concerns when a project has a lot of members, but I think 0002-Do-not-propose-watchers-that-are-not-allowed-to-see-.patch does not introduce the perf...
Go MAEDA
09:30 Patch #33315: IssuesSystemTest#test_bulk_watch_issues_via_context_menu randomly fails due to Capybara clicks out out of context menu
Setting the target version to 4.2.0. Go MAEDA
08:47 Feature #33174 (Closed): Show groups in members box on project overview page
Go MAEDA wrote:
> I think it is how it should behave.
Thanks!
Marius BĂLTEANU
03:17 Feature #33174: Show groups in members box on project overview page
Marius BALTEANU wrote:
> Is it ok to show the builtin groups ("Anonymous users", "Non members users") and group members ("User misc" is member of A Team)?
I think it is how it should behave.
* The list is used to see the members o...
Go MAEDA
02:48 Defect #33350 (New): Rows in Forums tab of project setting are not striped according to odd/even rule
Tables in other tabs are striped. The table in the Forum tab should be striped as well.
!{width: 714px; border: 1px solid grey;}.rows-are-not-striped.png!
Go MAEDA
00:12 Feature #30207: Hide menu item in the cross-project menu if the module is not enabled in any project
It is still displayed for roles that don't have permission to use any of those...
Once they click on projects tab.
My Redmine version is: 4.1.0.stable.19444
Aleksandar Pavic

2020-04-24

23:09 Feature #33174 (Reopened): Show groups in members box on project overview page
Is it ok to show the builtin groups ("Anonymous users", "Non members users") and group members ("User misc" is member of A Team)?
!{width:50%; border: 1px solid grey;}.members.png!
Marius BĂLTEANU
15:57 Defect #33303 (Closed): CustomField float 2.000,55 instead of 2,000.55
Please don't make me say the same thing. It should be discussed on the existing issue. What you should do is pointing the existing issue you found. Go MAEDA
13:37 Defect #33303 (Reopened): CustomField float 2.000,55 instead of 2,000.55
Go MAEDA wrote:
> Konstantinos Pagonakis wrote:
> ...
Yeha i know but the solution of the old topic is not wokring. I use Redmine 4.1
Konstantinos Pagonakis
13:20 Defect #33334: bump i18n for advisory: CVE-2014-10077
Popa Marius wrote:
> Thanks we did it that way , also in 4.0.x branch i18n should be bumped to 0.8.0
Is not only the bump, it requires also to backport some code changes from r17888 and r18286. At that time, Toshi tried to update the...
Marius BĂLTEANU
11:39 Defect #33334: bump i18n for advisory: CVE-2014-10077
Thanks we did it that way , also in 4.0.x branch i18n should be bumped to 0.8.0 Popa Marius
09:13 Defect #33281: Totals of custom fields may not be sorted as configured
Custom fields that are normally stored in "@Query#available_columns@" are in position order, but the cross-project's projects, issues, and spent time tabs do not store them in "@Query#available_columns@" in position order.
I fixed the p...
Yuichi HARADA
08:55 Feature #4687: Add copy project permission
I've attached a patch, similar to the one above, where the user is allowed to copy projects if he has add_project permission. If one is allowed to create projects he should also be able to copy projects. The current user is also added as... Markus Gerhold
04:13 Patch #33342 (Closed): Remove unused i18n key "label_overall_activity" and "label_overall_spent_time"
Committed the patch. Go MAEDA
01:35 Patch #33342: Remove unused i18n key "label_overall_activity" and "label_overall_spent_time"
Setting the target version to 4.2.0. Go MAEDA
04:12 Revision 19722 (svn): Remove unused i18n key "label_overall_activity" and "label_overall_spent_time" (#33342).
Patch by Go MAEDA. Go MAEDA
 

Also available in: Atom