Activity
From 2020-04-27 to 2020-04-29
2020-04-29
-
18:10 Patch #33361: Polish translation update
- Jerzy Wydra wrote:
> Which version of Redmine does it apply to?
It is based on trunk r19726. -
13:36 Patch #33361: Polish translation update
- Which version of Redmine does it apply to?
-
16:31 Defect #33374: hook call "view_layouts_base_body_bottom" Inserts content below the viewport
- Forgot to mention the file for the possible fix:
@app/views/layouts/base.html.erb@ -
15:52 Defect #33374 (Confirmed): hook call "view_layouts_base_body_bottom" Inserts content below the viewport
- The content added via the "view_layouts_base_body_bottom" Hook is generated outside of any wrapper object.
With r18427 the size of the wrapper object is set to 100% of the viewport height.
As "view_layouts_base_body_bottom" places cont... -
11:05 Patch #33367 (Closed): Use more efficient "exists?" instead of "first" in tests when checking the existence of rows
- When you check if any row exists, using @exists?@ that does not return ActiveRecord objects is more efficient than using @first@.
The attached patch replaces @first@ with @exists?@. -
10:00 Feature #33296 (Closed): Load default custom queries when running redmine:load_default_data rake task
- Go MAEDA wrote:
> r19731 caused test failures.
Fixed in r19733. -
09:04 Feature #33296 (Reopened): Load default custom queries when running redmine:load_default_data rake task
- r19731 caused test failures.
-
09:43 Revision 19733 (svn): Fix test failures due to r19731 (#33296).
-
09:03 Feature #3369: Allowed/Disallowed email domains settings to restrict users' email addresses
- I have updated the patch again.
* Changed the error message when the domain is not allowed from *"Email contains a domain not allowed (example.com)"* to simpler *"Email is invalid"* because the former detailed error message may give a... -
08:05 Feature #32783: Redirect to index page instead of edit page after creating a new custom field
- It is good, sorry for confusion.
Thanks. -
07:18 Feature #33347: Include updated_on and passwd_changed_on columns when exporting users to CSV
- I have slightly updated the patch as follows.
* Move the "Updated" column to after the "Created" column. This order is consistent with several REST API
* Change the translation for passwd_changed_on from "Last password change on" to ... -
06:17 Patch #32888 (Closed): Use stylelint to avoid errors and enforce conventions in CSS files
- Committed the patch. Thank you for improving the dev environment.
-
06:17 Revision 19732 (svn): Adds Stylelint to lint CSS files (#32888).
- Patch by Marius BALTEANU.
2020-04-28
-
17:23 Feature #3369: Allowed/Disallowed email domains settings to restrict users' email addresses
- Let's deliver this feature in Redmine 4.2.0.
-
05:30 Feature #3369: Allowed/Disallowed email domains settings to restrict users' email addresses
- Thank you for creating the patch.
Recent versions of Redmine allow users to register multiple email addresses.
This is a useful feature.
However, on the other hand, there is a possibility that information will be leaked to the em... -
17:20 Feature #33352: Enable inline issue autocomplete in issue id query filter fields
- Since "Issues" filter that has been implemented in #4806 does not support an issue id with "#" prefix (@#123@), we should implement #32168 to support the auto-complete in the filter.
-
16:53 Feature #33296 (Closed): Load default custom queries when running redmine:load_default_data rake task
-
09:11 Feature #33296: Load default custom queries when running redmine:load_default_data rake task
- Committed the patch.
-
16:51 Feature #32783: Redirect to index page instead of edit page after creating a new custom field
- Aleksandar Pavic wrote:
> If you create custom filed for issue, and save it, you are redirected to that field not
> ...
Do you mean that the behavior after applying attachment:32783.patch is broken? I could not reproduce such wrong re... -
16:30 Feature #32783: Redirect to index page instead of edit page after creating a new custom field
- Same problem is with other custom fields also, not just users.
If you create custom filed for issue, and save it, you are redirected to that field not
to issue's custom fields.
Same goes for documents etc... -
08:39 Feature #32783: Redirect to index page instead of edit page after creating a new custom field
- Setting the target version to 4.2.0.
-
16:50 Feature #3966: Tickets Subcategories
- +1!
-
11:51 Defect #33355: TypeError when attempting to update a user with a blank email address
- I'm not sure which is more appropriate, changing the API of AvatarsHelper as suggested in #note-1, or changing app/views/users/edit.html.erb as follows.
-
06:39 Defect #33355: TypeError when attempting to update a user with a blank email address
- I've attached a patch to fix the problem.
-
09:54 Feature #33347: Include updated_on and passwd_changed_on columns when exporting users to CSV
- Fixed because the test sometimes failed due to time zone.
-
07:23 Feature #33347: Include updated_on and passwd_changed_on columns when exporting users to CSV
- It was fixed because the test was incorrect.
-
07:00 Feature #33347: Include updated_on and passwd_changed_on columns when exporting users to CSV
- I have attached a patch to add columns.
-
09:10 Revision 19731 (svn): Load default custom queries when running redmine:load_default_data rake task (#33296).
- Patch by Go MAEDA.
-
08:38 Feature #28198: Support issue relations when importing issues
- Go MAEDA wrote:
> Setting the target version to 4.2.0.
Sorry, I have changed the target version mistakenly. -
08:36 Feature #28198: Support issue relations when importing issues
- Setting the target version to 4.2.0.
-
08:36 Patch #33117: Redirect to users_path instead of edit_user_path in order to avoid confusion
- Setting the target version to 4.2.0.
-
03:49 Defect #33281: Totals of custom fields may not be sorted as configured
- Yuichi HARADA wrote:
> Custom fields that are normally stored in "@Query#available_columns@" are in position order, but the cross-project's projects, issues, and spent time tabs do not store them in "@Query#available_columns@" in positi... -
03:28 Defect #33339 (Closed): Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
- Committed the fix #33339#note-18.
Thank you all for your advice. -
03:26 Revision 19730 (svn): Merged r19729 from trunk to 4.1-stable (#33339).
-
03:23 Revision 19729 (svn): Fix UI issues in the setting page of some plugins that have arisen after r19720.
- Patch by Marius BALTEANU.
2020-04-27
-
14:47 Defect #33334: bump i18n for advisory: CVE-2014-10077
- The version of @Hash#slice@ in the i18n gem (which was vulnerable to CVE-2014-10077) is only used if there is not already another version of this method present:
* From Ruby 2.5.0 on, Ruby itself "ships this method":https://ruby-doc.o... -
13:39 Patch #33361 (Closed): Polish translation update
-
12:19 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
- Go MAEDA wrote:
> [...]
> ...
As far as I can see any plugin that has one or more text_area type setting and/or long settings labels will be affected like the RedmineUP example given by Alexander Meindl.
I think that the fix propose... -
11:38 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
- Bernhard Rohloff wrote:
> Since the current fix really seems to affect existing plugins I tend to go with Marius on this topic.
Do you know if there are any affected plugins other than RedmineUP's ones? If so, I will readily follow M... -
11:17 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
- Bernhard Rohloff wrote:
> Marius BALTEANU wrote:
> ...
Totally agree with your remarks. -
11:14 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
- Marius BALTEANU wrote:
> Go Maeda, why we don't revert the change committed and apply to safer fix which targets only the @p@ element from settings wiki-preview?
Since the current fix really seems to affect existing plugins I tend to... -
08:21 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
- Go Maeda, why we don't revert the change committed and apply to safer fix which targets only the @p@ element from settings wiki-preview?
-
07:41 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
- Alexander Meindl wrote:
> I added a patch for this possible change. It would be very helpful, also for other situations for a Redmine plugin developer.
Thank you for sharing the patch. It would be nice if the patch will be a part of ... -
06:38 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
- Hi Go MAEDA,
I would suggest, that we stick to your solution. But it should be a possibility for plugin developers to change css for an individual namespace to the plugin settings (without using deface or Javascript).
If a css clas... -
03:26 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left
- I am not sure if it is the right way to change the code of Redmine in order to fix RedmineUP plugins.
I will leave the judgment to Jean-Philippe Lang. -
08:36 Defect #33341 (Closed): Time entry user is shown twice in the User drop-down when editing spent time
- Committed the fix. Thank you.
-
08:33 Revision 19728 (svn): Merged r19727 from trunk to 4.1-stable (#33341).
-
08:19 Revision 19727 (svn): Fix time entry user is shown twice in the User drop-down (#33341).
- Patch by Thomas Löber and Marius BALTEANU.
-
04:07 Feature #3369: Allowed/Disallowed email domains settings to restrict users' email addresses
- I have updated the patch:
* Changed the domain name matching to support subdomains. Now *"example.com"* matches "example.com", "foo.example.com", and "bar.example.com". Putting a dot at the beginning of the domain name like *".examp... -
03:43 Defect #17809: wrong syntax highlighting "---" header and "--" footer of git diff
- Toshi MARUYAMA wrote:
> Go MAEDA wrote:
> ...
I have written reason at #33357#note-2. -
03:41 Defect #33357: rendering extra "--" footer of git patch attachment
- #17809#note-5 is not solution in this case.
-
03:12 Defect #33357: rendering extra "--" footer of git patch attachment
- Fixed title.