Redmine

2021-04-01

21:52 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note

Directories @a/@ and @b/@ won't actually exist on your filesystem, so I think you need to use @patch -p1@ instead of ... Ismael Barros²

18:16 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note

Ismael Barros² wrote:
> Which command did you use to apply the patch? @patch -p0@? @patch -p1@? @git apply@?
Hey ... Leo L.

21:46 Feature #32938: Rails 6: Zeitwerk support

Pavel, do you have any working patch for this? Marius BĂLTEANU

21:42 Defect #34999 (Closed): The result of Attachment.latest_attach is unstable if attachments have the same timestamp

refs #27780
test_latest_attach_should_support_unicode_case_folding... Pavel Rosický

20:13 Defect #32885: Rails 6: DEPRECATION WARNING: Single arity template handlers are deprecated

why not use the source directly? see the patch file Pavel Rosický

19:16 Defect #32885 (Closed): Rails 6: DEPRECATION WARNING: Single arity template handlers are deprecated

Done in r20886 as a part of #29914. Go MAEDA

19:05 Feature #31128 (Closed): Drop Ruby < 2.5 support

Done. Go MAEDA

18:12 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Committed 19 patches attached to #29914#note-38 and #29914#note-39 (r20879 .. r20901). Go MAEDA

10:29 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Go MAEDA wrote:
> The following error was reported while running the test suite.
>
> [...]
I will fix @Reposit... Go MAEDA

09:58 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

The following error was reported while running the test suite.... Go MAEDA

17:45 Defect #32935 (Closed): Rails 6: fix set role_ids

Committed the patch as a part of #29914.
Go MAEDA

17:37 Defect #34984 (Closed): Rails 6.1 Rendering actions with '.' in the name is deprecated

Committed the patch as a part of #29914.
Go MAEDA

17:27 Defect #34985 (Closed): Rails 6.1 replace ActiveModel::Errors #<< with #add

Committed the patch as a part of #29914.
Go MAEDA

17:25 Defect #32923 (Closed): Rails 6: detach attachments when a conflict occurs

Committed the patch as a part of #29914.
Go MAEDA

17:22 Defect #32936 (Closed): Rails 6: disable AJ test adapter for integration tests

Committed the patch as a part of #29914.
Go MAEDA

17:19 Defect #32914 (Closed): Rails 6: remove #filename_for_content_disposition for MS browsers

Committed the patch as a part of #29914.
Go MAEDA

17:16 Defect #32913 (Closed): Rails 6: add filename header

Committed the patch as a part of #29914.
Go MAEDA

17:03 Defect #32939 (Closed): Rails 6: fix plugin migrations

Committed the patch as a part of #29914.
Go MAEDA

16:59 Defect #32921 (Closed): Rails 6: add header=present to csv tests

Committed the patch as a part of #29914.
Go MAEDA

16:49 Defect #32912 (Closed): Rails 6: update no longer bypass optimistic locking

Committed as a part of #29914.
Go MAEDA

16:41 Defect #32908 (Closed): Rails 6: Sending mail with DeliveryJob is deprecated

Committed as a part of #29914.
Go MAEDA

16:37 Defect #34980 (Closed): Fix "undefined method `represent_boolean_as_integer=' for nil:NilClass" in Rails 6.1

Committed as a part of #29914. Go MAEDA

16:35 Defect #32897 (Closed): Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator

Committed as a part of #29914. Go MAEDA

08:47 Feature #32898: PDF thumbnails support on Windows

Go MAEDA wrote:
> Steve Zhou wrote:
> > MAEDA-san, I tested the patch, it can successfully show PDF thumbnails on W... Steve Zhou

06:14 Feature #32898: PDF thumbnails support on Windows

Steve Zhou wrote:
> MAEDA-san, I tested the patch, it can successfully show PDF thumbnails on Windows with setting i... Go MAEDA

05:57 Feature #32898: PDF thumbnails support on Windows

Go MAEDA wrote:
> Steve Zhou, thank you for your feedback.
>
> Could you try the attached patch *without* setting... Steve Zhou

07:53 Defect #33127 (Closed): Assignee icon is misaligned when print stylesheet is applied

The current version of Firefox (87.0) does not have this issue. Closing. Go MAEDA

07:21 Defect #34998: Cannot open journal dropdown menu after editing note

Mizuki, one question, why not binding directly on document? Marius BĂLTEANU

03:31 Defect #34998: Cannot open journal dropdown menu after editing note

The following changes will resolve the issue.... Mizuki ISHIKAWA

02:09 Defect #34998 (Closed): Cannot open journal dropdown menu after editing note

After rewriting the journal note, clicking the journal dropdown does not open the menu. Reloading will fix the menu t... Mizuki ISHIKAWA

01:33 Feature #29285: Add "Assign to me" shortcut to issue edit form

Please open a new issue for feature requests or bug reports.
This issue has already closed and the feature has bee... Go MAEDA

2021-03-31

22:33 Feature #29285: Add "Assign to me" shortcut to issue edit form

Michael Michalewicz wrote:
> Hi all.
>
> Fantastic stuff with the 'Assign to me' button.
> I do have one suggest... Jenda Benda

15:41 Feature #32898 (New): PDF thumbnails support on Windows

Steve Zhou, thank you for your feedback.
Could you try the attached patch *without* setting imagemagick_convert_co... Go MAEDA

11:56 Feature #32898: PDF thumbnails support on Windows

Go MAEDA wrote:
> Redmine 4.1.2 will support a new setting @gs_command@ in config/configuration.yml (#33283). You ca... Steve Zhou

15:18 Defect #34995 (New): Running redmine in docker getting ssl error, any ideas what might be the issue?

Im having an issue with SSL. Im getting pretty crazy currently. Got the feeling that I miss something really simple :... rafaelteb rafaelteb

11:31 Feature #34981: Allow to change a project identifier

+1
I think this feature is needed.
The identifier change itself can simply be done in SQL.
I've done it dozen... Yuuki NARA

11:00 Patch #34969 (Closed): Remove dependency on MimeMagic

Backported to 4.1-stable in r20877 and r20878. Go MAEDA

10:39 Defect #34982 (Closed): Cannot change the default version and default assignee under settings

Go MAEDA

10:28 Defect #34982 (Resolved): Cannot change the default version and default assignee under settings

Committed the fix. Thank you. Go MAEDA

06:26 Defect #34982: Cannot change the default version and default assignee under settings

I've checked/tested the patch, too. I can confirm that it fixes the issue. Bernhard Rohloff

02:57 Defect #34982: Cannot change the default version and default assignee under settings

The patch verified and the defect was FIXED, thanks for your guys quick & selfless contributions! Sunding Wei

10:13 Feature #11543: Sort attachments by name

I implemented sorting in the attachments list of Issue and Wiki (I referred to #1718). Name, Description, Author, Cre... Yuichi HARADA

08:44 Feature #32424: CommonMark Markdown Text Formatting

Marius BALTEANU wrote:
> What do you think about the following plan for this issue?
> ...
I really like this app... Bernhard Rohloff

08:39 Feature #32424: CommonMark Markdown Text Formatting

What do you think about the following plan for this issue?
* We introduce this as third text formatting option in ve... Marius BĂLTEANU

08:40 Feature #34992 (Closed): Ruby 3.0 support

Ruby 3.0.0 has been released on 25 Dec 2020.
https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
Go MAEDA

04:59 Defect #33941: Do not use timezone unaware methods

Here is the result of the following command:... Go MAEDA

04:31 Feature #34974: Change the default value for "Preferred part of multipart (HTML) emails" from "Text" to "HTML"

Thank you for your feedback.
In our environment, some of the emails we received did not have a proper text part, a... Go MAEDA

02:29 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Thank you all for working on this.
Marius BALTEANU wrote:
> My proposal is to have these patches committed as soo... Go MAEDA

2021-03-30

18:42 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Batch 2. Marius BĂLTEANU

18:42 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

I'm attaching a patch series (19) that updates Rails to 6.1.3.1 and fixes all the tests on "MySQL":https://gitlab.com... Marius BĂLTEANU

17:53 Defect #34982: Cannot change the default version and default assignee under settings

I've attached a fix with tests included. Marius BĂLTEANU

16:21 Defect #34982: Cannot change the default version and default assignee under settings

The issue is caused by r20766 which was done for #34032. The form parameter (project_issue_tracking) was changed with... Bernhard Rohloff

13:30 Defect #34982 (Confirmed): Cannot change the default version and default assignee under settings

Yes, you are right. I've tested it again.
The issue is not that the versions are not shown but that it flips back to... Bernhard Rohloff

12:25 Defect #34982: Cannot change the default version and default assignee under settings

Hi Bernhard,
Thanks for your quick response, I checked out the latest 4.2-stable branch from github, the problem p... Sunding Wei

10:37 Defect #34982 (Needs feedback): Cannot change the default version and default assignee under settings

I cannot reproduce the issue on my production system. Please make sure that the not shown versions are neither locked... Bernhard Rohloff

08:44 Defect #34982 (Closed): Cannot change the default version and default assignee under settings

Cannot change the default version under settings... Sunding Wei

16:18 Feature #34988: Add new notification settings for priority based notification to the user guide

Commented wrong issue... Bernhard Rohloff

14:04 Feature #34988 (New): Add new notification settings for priority based notification to the user guide

Bernhard Rohloff

14:13 Feature #34981: Allow to change a project identifier

> The problem with changing the project identifier is that the identifier is used as part of URLs, so links from outs... Pavel Rosický

14:01 Feature #34981: Allow to change a project identifier

The concept of separate project name and identifier is a useless construct which irritates the user more than it help... Bernhard Rohloff

13:46 Feature #34981: Allow to change a project identifier

Many repository integrations (including the bundled @Redmine.pm@ and @reposman.rb@) assume that the repository on the... Holger Just

04:42 Feature #34981 (New): Allow to change a project identifier

Currently, it is not possible to change the identifier of a project. However, you may want to change the project iden... Go MAEDA

13:54 Feature #32628: Notify users about high issues (only)

If you have a default priority defined, we assume high priority issues to have any priority higher than the defined d... Holger Just

11:58 Feature #32628: Notify users about high issues (only)

Bernhard Rohloff wrote:
> As I understand it the state "higher than ..." is determined by the position of the status... Mikhail Oleynik

10:54 Feature #32628: Notify users about high issues (only)

As I understand it the state "higher than ..." is determined by the position of the status in the enumeration list. I... Bernhard Rohloff

07:47 Feature #32628: Notify users about high issues (only)

Hi!
Could you please help me with using this really cool feature?
We use custom grained issue priorities list i... Mikhail Oleynik

13:23 Defect #32935: Rails 6: fix set role_ids

Pavel Rosický wrote:
> you're welcome, the last failure is related to https://www.redmine.org/issues/32936
>
> th... Marius BĂLTEANU

13:02 Defect #32935: Rails 6: fix set role_ids

you're welcome, the last failure is related to #32936
the class attribute isn't inherited to subclasses, that's wh... Pavel Rosický

12:19 Defect #32935: Rails 6: fix set role_ids

Pavel Rosický wrote:
> @marius - I see you've finally started working on this. Just to let you know, there's a mista... Marius BĂLTEANU

12:10 Defect #32935: Rails 6: fix set role_ids

@marius - I see you've finally started working on this. Just to let you know, there's a mistake in this patch. The re... Pavel Rosický

13:06 Feature #34987 (New): Rails 6.1 destroy async

Rails 6.1 has a new feature that allows associations to be destroyed asynchronously.
https://bigbinary.com/blog/ra... Pavel Rosický

12:30 Defect #34983 (Confirmed): Roadmap tab is missing if there are only inherited from parent project versions

It's caused by #7956.
Marius BĂLTEANU

11:33 Defect #34983 (Closed): Roadmap tab is missing if there are only inherited from parent project versions

It was fine before 4.2.0 so I suppose there were some changes in 4.2.0.
There is a project 'Project Big', it has v... Mikhail Oleynik

12:22 Defect #34986 (Closed): Ruby 3.0 fix super calls

https://github.com/rails/rails/blob/f855139f3d2bb9b032613279d0adfbd6a77a2d07/activerecord/lib/active_record/persisten... Pavel Rosický

12:14 Defect #34985: Rails 6.1 replace ActiveModel::Errors #<< with #add

refs #29914 Pavel Rosický

12:13 Defect #34985 (Closed): Rails 6.1 replace ActiveModel::Errors #<< with #add

fixes
DEPRECATION WARNING: Calling `<<` to an ActiveModel::Errors message array in order to add an error is deprecat... Pavel Rosický

12:12 Defect #34984 (Closed): Rails 6.1 Rendering actions with '.' in the name is deprecated

refs #29914 Pavel Rosický

11:17 Feature #34974: Change the default value for "Preferred part of multipart (HTML) emails" from "Text" to "HTML"

When receiving a mail, we extract the text part in order to add a journal node or issue description as a Textile or M... Holger Just

10:12 Feature #34715: Filter issues by file description

Go MAEDA wrote:
> I think it would be even useful if it is possible to filter issues by attachment file description.... Yuichi HARADA

01:42 Patch #34969 (Reopened): Remove dependency on MimeMagic

I think it is better to merge the change to older versions for the following reason. Keep using MimeMagic may cause i... Go MAEDA