Redmine

2018-12-02

23:32 Patch #29406 (Closed): Use sorted instead of sort

Committed. Thank you for improving Redmine. Go MAEDA

02:20 Patch #29406: Use sorted instead of sort

Passed all tests. Setting the target version to 4.1.0.
The attached patch is a combination of Pavel Rosický's thre... Go MAEDA

17:35 Defect #29855: add_working_days returns wrong date

Jean-Philippe Lang wrote:
>
> @#working_days@ and @#add_working_days@ are used to reschedule an issue when the star... Marius BĂLTEANU

17:23 Defect #29855: add_working_days returns wrong date

Marius BALTEANU wrote:
> The number of the expected working days according to the test is 4. But in my opinion, it... Jean-Philippe Lang

12:39 Defect #29855: add_working_days returns wrong date

I took a look and there are some strange (or wrong) test cases the we should review before changing anything else.
... Marius BĂLTEANU

08:53 Defect #29855: add_working_days returns wrong date

Mizuki ISHIKAWA wrote:
> Any feedback is welcome.
@DateCalculation#working_days@ should be fixed in a similar w... Jean-Philippe Lang

16:35 Defect #9708 (Closed): Adding relation to the issue sometimes does not work

Go MAEDA

16:34 Feature #26620 (Closed): Change the text of the submit button on search page from button_submit to label_search

Marius BALTEANU wrote:
> For me, this change generates "translation missing: en.button_search". Please see the below... Go MAEDA

16:27 Feature #26620 (Reopened): Change the text of the submit button on search page from button_submit to label_search

For me, this change generates "translation missing: en.button_search". Please see the below screenshot.
!{width:70... Marius BĂLTEANU

15:15 Feature #26620 (Closed): Change the text of the submit button on search page from button_submit to label_search

Committed. Thank you for improving Redmine. Go MAEDA

16:19 Feature #4491 (Closed): Direct Image Upload in Forum

Implemented by #26071. Go MAEDA

15:05 Feature #1777 (Closed): Allow %2650 in Wiki to display and linke the Title of the Ticket (next to #2650

The new syntax "##123" which renders tracker name, issue id, and title will be available in Redmine 4.0.0. Go MAEDA

12:52 Patch #29951: Quick design fix/proposals for projects index page

We can achieve a better projects page only with some CSS changes. The most important change is to not allow to break ... Marius BĂLTEANU

12:26 Feature #29993 (Closed): Option to unarchive the project when admins visit an archived project

When trying to access an archived project, a link to unarchive it will now be displayed to admin users. Jean-Philippe Lang

11:07 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring

Hopefully soon™... Anonymous

07:25 Patch #28662 (Closed): Replace "Cancel" buttons from the modals with "Cancel" link

Committed the patch. Thank you for your contribution. Go MAEDA

01:33 Patch #30075 (Closed): Czech translation update

Committed. Thank you for your contribution. Go MAEDA

2018-12-01

20:38 Patch #30075 (Closed): Czech translation update

1/ new translations
2/ "deleted." line in error_can_not_delete_auth_source: key was removed (bad merge) Pavel Rosický

20:06 Defect #30074: Puma shouldn't be included in the Gemfile

IMO, your CI should add Puma to Gemfile.local in a before_script or use Capybara.server = :webrick if Puma isn't avai... Pavel Rosický

19:52 Defect #30074 (Closed): Puma shouldn't be included in the Gemfile

right now it isn't possible to use a different Puma version or define it for a production environment because there's... Pavel Rosický

19:41 Defect #30073 (Closed): Ajax Request Returns 200 but an error event is fired instead of success

here's an explanation of the issue
https://stackoverflow.com/questions/6186770/ajax-request-returns-200-ok-but-an-er... Pavel Rosický

19:19 Defect #26066 (Closed): Selenium::WebDriver doesn't work with current version of Firefox

Thanks Pavel for updating the ticket.
I’m setting version version:"4.0.0" because it is an useful fix for Redmine... Marius BĂLTEANU

19:14 Defect #26066 (Resolved): Selenium::WebDriver doesn't work with current version of Firefox

the version restiction was removed in https://github.com/redmine/redmine/commit/530eef96033bf1474157bbc9c7739ff8dc7e2... Pavel Rosický

19:08 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring

+1
Yes, it's very time consuming to contribute and also for maintainers to verify existing patches.
If you don'... Pavel Rosický

19:02 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring

+1
However technically tough that could sound (since I'm not even a web dev XD), less time consuming = faster, and a... Anonymous

14:03 Feature #30069 (Closed): Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring

On my local development box, I've a lot of branches with my entire work for Redmine. These branches contain features ... Marius BĂLTEANU

18:54 Feature #29041: Update session token only once per minute

if you have time, could you review? https://www.redmine.org/attachments/20901/user.rb.patch
GET requests shouldn't... Pavel Rosický

18:28 Patch #29406: Use sorted instead of sort

> issue priorities on the issue's report page were originaly sorted by id
forget about this statement. I was wrong, ... Pavel Rosický

10:21 Patch #29406: Use sorted instead of sort

Pavel Rosický wrote:
> issue priorities on the issue's report page were originaly sorted by id (desc), but I think t... Go MAEDA

17:22 Patch #30071 (New): Show parent projects when filtering in the project jump box

Attached patch returns parents projects to matched projects when filtering in the project jump box (improves #23310)
... Anders Thomsen

15:43 Defect #22046 (Needs feedback): Markdown XML code blocks not properly supported

I could not reproduce the issue on Redmine 3.4.6. Do you still experience the issue in the latest version? Go MAEDA

15:12 Feature #27313: More custom queries on My page

Jean-Philippe, what do you think about increasing the maximum number of "issuequery" block?... Go MAEDA

14:36 Defect #30070 (Closed): Unable to update assignee with rdm-mailhandler.rb

h1. Issue Summary
I try to update ticket status by sending email.
But assignee cannot be updated.
So, I commente... okifumi mita

11:04 Patch #28895 (Closed): view_projects_copy_only_items hook

Committed the patch. Thank you for your contribution. Go MAEDA

10:29 Defect #29291 (Closed): NoMethodError: undefined method `migrate' for Redmine::Plugin::Migrator:Class

This should have been fixed in #28934. Go MAEDA

09:55 Feature #29725: Show recent documents first when sorting documents by date

LGTM. Setting the target version to 4.1.0. Go MAEDA

09:50 Defect #29855: add_working_days returns wrong date

Jean-Philippe, do you think we can accept this performance deterioration?
I think it is OK because 'add_working_da... Go MAEDA

09:38 Patch #30000 (Closed): Japanese translation update (r17623)

Committed. Go MAEDA

09:30 Feature #29752: Render Textile and Markdown attachments on the preview page

LGTM. Setting the target version to 4.1.0. Go MAEDA

08:13 Feature #30068 (Closed): Remove :async_smtp and :async_sendmail delivery methods

The purpose of this issue is not to implement any feature but to add a notice regarding the removal of a feature done... Go MAEDA

07:57 Defect #30067 (Closed): About installation

You can not get home page after installation done with these steps. Madhusudan Miniyar

2018-11-30

16:42 Patch #30037 (Closed): Allow single Chinese character as a search keyword

Committed. Go MAEDA

04:53 Patch #30037: Allow single Chinese character as a search keyword

Updated the patch. The new patch accepts single character tokens only if they are a Chinese character (汉字/漢字).
The... Go MAEDA

15:49 Defect #13854 (Closed): Unable to raise new issue

Most probably, is the same issue from the related issue which was fixed in the upcoming Redmine version:"4.0.0".
P... Marius BĂLTEANU

15:46 Defect #5703 (Closed): On SMTP failure, an internal error occurs and all changes to an issue are lost

In Redmine 4.0, the emails are delivered asynchronously by default using ActiveJob. This should fix this issue. Marius BĂLTEANU

15:13 Defect #26023: Category filter only shows categories of current project

Hi,
I agree with the fact to keep too filters for Categories, one by Id and the other by Name, to keep the coheren... Jérôme BATAILLE

14:58 Feature #27523 (Closed): More options for project manager

Marius BĂLTEANU

14:19 Defect #20915 (Closed): email notification isn't send to

Marius BĂLTEANU

14:14 Defect #8137 (Closed): HTML email doesn't obey directionality of locale

I'm closing this in favour of #5990 (is the same feature request IMHO). Marius BĂLTEANU

14:05 Defect #11981 (Closed): Redmine send mail fail when project has too much members

It should be fixed by #26791 by sending individual emails. Marius BĂLTEANU

14:00 Defect #16784 (Closed): Notifications not sent when receiving emails with rake task and async deliveries

In Redmine 4.0, the async_smtp setting is obsolete and emails are delivered asynchronously by default. Go MAEDA

12:27 Defect #8157 (Closed): Redmine do not send notification emails if a recipients email address is not valid

Fixed by #26791.
Setting the target version to 4.1.0 in order to add this issue to the changelog. Go MAEDA

12:10 Feature #6409 (Closed): Define default langage to a project (for email)

Thanks to #26791, now the language in email notifications obey the user's language setting. In other words, users rec... Go MAEDA

11:22 Feature #12239 (Closed): Translateable Notifications

Closing as a duplicate of #5990. Go MAEDA

11:17 Feature #28338 (Closed): Make Redmine Email Delivery compatible with ActiveJob

Email delivery using ActiveJob was implemented by #26791. Go MAEDA

11:10 Feature #25686: Make the issues sidebar menu use accordion with JQuery

For an accordion in pure ecmascript see https://codepen.io/sureshrkm/pen/ZbzBpr Fabrice ROBIN

04:50 Feature #20081: Filter issues and time entries by project status

Hi,
I came from #29449 and just applied these patches to my redmine 3.4 instance:
* 0001-Filter-issues-after-proj... Rang Tang