Activity
From 2014-09-12 to 2014-09-14
2014-09-14
-
19:32 Defect #17581 (Closed): Drag & Drop does not work with Safari 5.1
- Committed in trunk, 2.5-stable and 2.4-stable, thanks.
-
15:15 Defect #17630 (Needs feedback): Non-Administrator account can't show Issues list on multi role.
- Thanks for this detailed report but I'm not able to reproduce this probelm with the permissions set as in your example.
-
13:33 Patch #16685 (Closed): Introduce the request_store gem to hold User.current and prevent data leakage in error messages
-
13:33 Patch #17492 (Closed): Lowering configuration.example.yml confusion
- If the examples are uncommented below as proposed in the patch, all the settings in previous production "section" will be overwritten. So it doesn't look like a better option. Instead, I think that the production key should be removed in...
-
13:12 Feature #17599: Allow users to edit issues without adding notes.
- The "Add notes" permission lets users add notes without editing the issue. But whenever a user is allowed to edit an issue, he is allowed to add notes by design.
-
13:04 Defect #6579 (Closed): Tree hierachy being currupted on multiple submissions of an issue
-
12:52 Defect #17517 (Needs feedback): Attempting to Add a Related Issue Multiple Times Sequentially Causes 500
- The proposed fix has a side effect with Firefox (tested with 24 ESR):
# go to an issue, add a relation
# hit F5
# click on the 'Add' link to add another relation => the 'Add' button is disabled
Problem doesn't occur if step 2 is om... -
12:47 Defect #17322 (Closed): Long strings such as URL break out of box
- Committed in r13401, thanks.
-
12:43 Defect #14281 (Closed): Parent issue autocomplete does not follow to the "Allow cross-project subtasks" setting
- Parent issue selection does not depend on @Setting.cross_project_issue_relations@ but @Setting.cross_project_subtasks@ introduced in r10587. The fix is committed in r13400, thanks for pointing this out.
-
11:49 Defect #12580 (Closed): long hyperlinks inserted in task description breaks right frame boundary
- Patch committed in r13399, thanks.
-
11:42 Defect #9660 (Closed): Issues counters in roadmap only link to issues in the same project
- Patch committed in r13398 with slight changes: helper method renamed and moved to VersionHelper, thanks.
-
11:20 Defect #17163 (Closed): Files assigned to a version can not be deleted if Issue Tracking module is disabled
- Merged.
-
11:19 Defect #17202 (Closed): Copying Project Fails to Copy Queries with visibility == VISIBILITY_ROLES
- Thanks for your feedback, please open a new issue for your additional fixes and try to include tests in your patch.
-
11:16 Defect #17023 (Closed): The error flash message on session expiration is not in the language of the user but of the user of the previous request
-
10:36 Patch #17717: Password/Email address change should invalidate security tokens
- Thanks!
-
10:24 Patch #17717 (Closed): Password/Email address change should invalidate security tokens
- Committed it in r13396.
2014-09-13
-
15:16 Feature #17857 (New): Custom fields for repositories
- Attaching custom fields to repositories would allow, along with a repository REST API (see #11977), to write smart custom repository managers
For example, this could allow to write a repository manager which would manage repository ho... -
15:10 Feature #11977: REST API for repositories
- I would like to see this feature implemented too. It would allow to write a proper implementation of a remote repository manager.
-
14:43 Patch #17717: Password/Email address change should invalidate security tokens
- Etienne Massip wrote:
> Why are both issues in Security? Do you have any objection if we move them to public?
It was just a precautionary measure. In theory, the issues can be exploited (together with some other vector such as social... -
14:28 Patch #17717: Password/Email address change should invalidate security tokens
- Why are both issues in Security? Do you have any objection if we move them to public?
More generally, now that issues can be set as private, do we still need Security project? -
11:54 Patch #17717: Password/Email address change should invalidate security tokens
- Jan from Planio www.plan.io wrote:
> Personally, I don't think it would be a problem since it's not a fix for a security issue per se. Both this and #17796 can only be exploited in conjunction with social engineering or other security... -
13:23 Feature #10914 (Closed): Include is_private setting in xml/json output
- Feature added in r13395, thanks.
-
13:13 Patch #16905 (Closed): Count users with a single query on group list
-
13:12 Feature #16930 (Closed): Need Additional parameter for hook to enable Multi Factor Authentication Patch
- Actually, adding :params to the context of controller hooks is not needed. The request is automatically added to the context of these hooks (see: source:/tags/2.5.0/lib/redmine/hook.rb#L149).
You can use @context[:request].params@ in ... -
12:53 Feature #17380 (Closed): Move project sidebar content to a partial
- Committed in r13393.
-
12:49 Feature #17077 (Closed): fetch_changesets should use POST method too
- Fix committed in r13392.
-
12:39 Patch #16133: Available watchers on new issue form include users who cannot even view issues
- I see the point but this change adds to much overhead for projects with lots of users.
-
12:36 Defect #17023 (Resolved): The error flash message on session expiration is not in the language of the user but of the user of the previous request
- Fixed in r13391.
-
12:17 Defect #17163 (Resolved): Files assigned to a version can not be deleted if Issue Tracking module is disabled
- Patch committed in r13390, thanks.
-
12:08 Defect #17486 (Closed): Error when removing user from group
- Merged.
-
11:55 Patch #17796: Expire all other sessions on password change
- We can commit this patch now, but I'd like to change the new column to @passwd_changed_on@ instead of @password_changed_at@.
-
05:31 Defect #13375 (Closed): Inline Image formatting does not allow a file name with spaces
- Michael Esemplare wrote:
> Duplicate of #10189
Thank you for your pointing.
2014-09-12
-
22:44 Defect #17828: Could not find gem 'mocha (~> 1.0.0) ruby'
- You should probably remove @Gemfile.lock@ before running commands if it's present.
Here's the Gemfile.lock I get when running a bundle install. I noticed that for me, should-matchers doesn't depend on bourne, which is causing your pro... -
09:37 Defect #17828: Could not find gem 'mocha (~> 1.0.0) ruby'
- I checked config twice. Firstly, with existing config which excludes groups as well and secondly by removing the config.
The bundle config output: -
20:09 Defect #17698 (Needs feedback): Date format is incorrect
- I cannot reproduce.
Redmine uses 'yy-mm-dd' format.
* source:tags/2.5.2/app/views/versions/_form.html.erb#L9
* source:tags/2.5.2/app/helpers/application_helper.rb#L1159
I think plugin or browser causes problem. -
19:53 Feature #12704: Allow selecting subprojects on new issue form
- I too have tried this approach. It's definitely nice and would be the optimal way to go for those who organize everything with a boat-load of projects. I haven't noticed the issue that @Quan has mentioned. When the project is changed ...
-
16:15 Defect #17686 (New): MarkDownFormatting: Sections support.
-
16:02 Patch #17705: MailHandler should ignore bogus issue strings [some-string#1234] in subject
- Here we go!
-
09:55 Patch #17705: MailHandler should ignore bogus issue strings [some-string#1234] in subject
- Jean-Baptiste Barth wrote:
> No problem merging that as long as it has some more tests for failing strings we introduce... and for good ones too, as I can't find tests in @test/unit/mail_handler_test.rb@.
Sure, can you assign it back... -
07:10 Patch #17705: MailHandler should ignore bogus issue strings [some-string#1234] in subject
- No problem merging that as long as it has some more tests for failing strings we introduce... and for good ones too, as I can't find tests in @test/unit/mail_handler_test.rb@. Maybe it's time to refactor the logic in @MailHandler#dispatc...
-
15:20 Patch #17853 (Closed): Portuguese translation file
- Committed in trunk r13383, thanks.
-
11:57 Patch #17853 (Closed): Portuguese translation file
- PT-pt translation files reviewed.
-
10:15 Feature #17380: Move project sidebar content to a partial
- Mischa, you're right, but the content of the partial is totally different.
-
06:46 Feature #17380: Move project sidebar content to a partial
- Jérôme BATAILLE wrote:
> Here is the patch
Nice. Thanks for sharing.
Daniel Felix wrote:
> ...
Daniel, am I missing something? AFAICT the sidebar code for issues (both @#index@ and @#show@) is already located in a dedicated parti... -
08:35 Defect #17852 (Closed): Issue journals should be ordered by created_on, not id
- After migration to Redmine form another system, I noticed issue journals were not in the right order.
Our migration added file attachment journals last, so the ID was higher than the rest of the journals.
While this was incidental to... -
08:01 Feature #17844: A help intercept or better options
- You can render hidden partial by base layout hook, and then show it by hover on help link
-
08:01 Feature #7017: Add watchers from To and Cc fields in issue replies
- Looking at the mail_handler today, MailHandler.receive_issue calls add_watchers(issue) _before_ saving the issue off so email's entered in the To: and CC: fields will be added as watchers and can reply to the email.
This patch puts ad... -
07:51 Feature #7017: Add watchers from To and Cc fields in issue replies
- I haven't tested the patch (because I hope it will be merged into redmine core), but the current behaviour is: Users are added as watcher from to/cc if you create an issue by email. But if you reply to an email from redmine (to add a com...
-
07:19 Feature #7017: Add watchers from To and Cc fields in issue replies
- Can anybody explain me this patch like I'm 5 ? What's the current behaviour, and what's the new proposed one ?
It would add "to/cc" persons in an *incoming* email as watchers of the issue automatically ?? -
07:59 Patch #13413: Let users choose how many days in advance they want to receive issue due date reminders via email
- Jean-Baptiste Barth wrote:
> I think that's not a good default value, as it may break existing behaviour for current users of this feature, and they will have a hard time figuring out what happens.
I agree. I still like this patch as... -
07:16 Patch #13413: Let users choose how many days in advance they want to receive issue due date reminders via email
- I think that's not a good default value, as it may break existing behaviour for current users of this feature, and they will have a hard time figuring out what happens. Now the number of days is fixed by the admin as a parameter when he ...
-
07:37 Feature #17763: Ability to render multiple partials with view hook
- It's easier, in case of multiple partials within one plugin, but if you have multiple plugins using the same hook - it's a problem.
-
07:21 Feature #17763: Ability to render multiple partials with view hook
- Isn't it easier to add a "parent" partial that groups the other ones you'd want to render ? Maybe you can explain why this is needed.
Plus we need to have some tests if we ever want to merge this in. -
07:05 Feature #7842: Creation new users by non-admin user
- Jean-Baptiste Barth wrote:
> I confirm this is still not possible in current redmine versions. It may not be really difficult to implement on the logic side, but I don't really know how to deal with that in the UI. For now "users manage... -
06:44 Feature #2722: New user notification
- I wouldn't mind creating a patch that would:
* Create an option in either Settings->Authentication or Settings->Email notifications to "Notify Administrators of new account activation"
* Email administrators when a new account is act... -
06:39 Feature #17354: User detail : show user login to admins
- Small, simple and effective...
-
05:10 Defect #17679 (Closed): Attached inline image not working
- Michael Esemplare wrote:
> Duplicate of #10189.
Thank you for your pointing.
-
04:27 Defect #17843 (Needs feedback): Possible to delete issue even it is disabled in permissions
- I did a quick test on current trunk but wasn't able to reproduce. Are you testing this with a user account that is marked as an administrator? If so, that would be the expected behavior since Redmine administrator permissions are not res...
-
01:23 Defect #5880: Only consider open subtasks when computing the priority of a parent issue
- The above patch does not work on db's with proper boolean types such as PostgreSQL; it also has a bug in the else clause in that it returns an IssuePriority object rather than a number. Here's an updated version that should work on all ...