Project

General

Profile

Activity

From 2019-02-05 to 2019-02-07

2019-02-07

21:10 Feature #30773 (New): Enhance issue workflow - viewing, adding or deleting files
It would be nice to have ability to disable viewing, adding or deleting attached files for some issue statuses during the issue lifetime.
Sometimes it it required to 'freeze' uploaded files at some issue statuses, to protect them from l...
VD DV
19:40 Patch #30757: LDAP Contextless login in Active Directory
Well it broke automatic user creation and getting add user from LDAP server for, in both cases, auth_source_ldap.rb tries to bind again with anonymous binds, instead of the current user's dn and password...
Have to review the code wit...
Guilherme Chehab
14:29 Feature #18556: Raise the limit of attachments at once from 10 to 50 and make it configurable in configuration.yml
I am also looking for this feature. Chris D
13:55 Defect #30771 (Closed): Author of issue is listed at assignee drop box
The issue author that has role with disabled "Issues can be assigned to this role" is still listed at Assignee dropbox (while editing the issue).
VD DV
11:53 Feature #30492: Replace RMagick with MiniMagick
Definitely +1 if it takes less memory :)
But I also wanted to take a look into doing all the image processing and saving stuff on the front end instead. Now that you can create canvas objects with *2d* and *webgl* contexts as variable...
Anonymous
05:42 Feature #30492: Replace RMagick with MiniMagick
Go MAEDA wrote:
> Redmine uses ImageMagick via rmagick to generate thumbnails and gantt png export.
Redmine does not use rmagick to generate thumbnails, but it directly executes the ImageMagick convert command.
rmagick is using on...
Yuichi HARADA
11:10 Defect #30510: Bad Project's page Form
I experience a similar problem, but only with Firefox (v65.0) on MacOS (the cache has been cleared).
When resizing the page, the layout is broken.
This bug does not appear with Chrome or Safari.
!resizing.gif!
Vincent Robert
08:44 Feature #3956: Login by Email
Thanks Bernhard for clarification.
It should be enough to allow users to login by username or email address, right? without any other impact in application. I'm asking because first time when I read this, I understood that we should...
Marius BĂLTEANU
06:44 Feature #3956: Login by Email
Marius BALTEANU wrote:
> You can already achieve this by using the same email address as login username (attached a screenshot). IMO, current implementation is flexible enough to cover multiple use cases.
If your email address change...
Bernhard Rohloff
08:20 Defect #30758: Preview URL in Wiki Toolbar should be escaped
Here it is:
!screenshot.png!
Vincent Robert
07:53 Defect #30760 (Closed): there is no button to add the schedule
can't form a plan schedule,there are buttons to add ,the procurement plan is placed Адиля Санатуллина
07:22 Patch #28510: Show issue assignee gravatar in roadmap and version page
I think it is better to add an icon to the left side of the tracker name because gantt already shows gravatar icons like that.
Here is a screenshot of gantt. tiket.png is displayed when gravatar is disabled or no one is assigned to t...
Go MAEDA
07:04 Patch #7975: Hook for adding content to the side bar of Wiki page
Since there is no '.*_sideber_.*bottom' hook, I suggest adding only @:view_wiki_show_sidebar_bottom@. Go MAEDA
05:26 Patch #16087 (Closed): Markdown renderer doesn’t clean HTML properly
Current versions of Redmine don't render @[bad link](javascript:alert(1\))@. And code blocks don't accept unknown language name (r16501 and r16502). Go MAEDA

2019-02-06

23:02 Defect #30758: Preview URL in Wiki Toolbar should be escaped
Vincent Robert wrote:
> Here is an example. The last link will lead to a form where the wikitoolbar is missing.
> ...
Thank you. But it does not break the toolbar in my environment. Could you paste a screenshot that shows the problem? ...
Go MAEDA
22:51 Defect #30758: Preview URL in Wiki Toolbar should be escaped
Here is an example. The last link will lead to a form where the wikitoolbar is missing. Vincent Robert
22:44 Defect #30758 (Needs feedback): Preview URL in Wiki Toolbar should be escaped
Thank you for the patch. Could you paste some example URLs that reproduce the problem? Go MAEDA
19:15 Defect #30758 (Closed): Preview URL in Wiki Toolbar should be escaped
Since Redmine 4.0.0 and the addition of the preview tab, the wiki toolbar is not displayed if the preview url contains single quotes. The url is not escaped and we can see an error in our browser console.
We should escape the preview url:
Vincent Robert
21:49 Feature #26561: Enable frozen string literals
ok, rebased and pushed to the github
https://github.com/redmine/redmine/pull/113
there're many changes but most of them is just adding a magic comment
Pavel Rosický
07:23 Feature #26561: Enable frozen string literals
Pavel Rosický wrote:
> Hi Marius,
> ...
Yes, if you can do it, it will be very useful and I think we should have in mind that the support for Ruby 2.2 will be dropped in 4.1.
I'm in favour of this change, but this doesn't mean neces...
Marius BĂLTEANU
00:31 Feature #26561: Enable frozen string literals
Hi Marius,
the patch is more than a year old, so there'll be some conflicts and missing files.
Do you see any value in adding the # frozen_string_literal: true to db migration files?
There was a discussion about making it default fo...
Pavel Rosický
16:07 Patch #30757 (New): LDAP Contextless login in Active Directory
I created a very quick and dirty 4-line patch to allow contextless login authentication in Active Directory on LDAP module. I.e. without the need to have a search specific user nor allowing anonymous search in the directory server.
It...
Guilherme Chehab
14:51 Feature #10264: Add a check/uncheck all button to search
I changed the target version to 4.0.1, but this change may break themes for 4.0 because it changes the structure of HTML (wraps @p#search-types@ with @fieldset.box@).
I think 4.1.0 is better.
Go MAEDA
01:07 Feature #10264: Add a check/uncheck all button to search
Marius BALTEANU wrote:
> it is a small change and very useful, I propose to add it in a next minor release.
I agree. Setting the target version to 4.0.2.
Go MAEDA
12:10 Feature #23301: Allow "Custom queries" to be shared across projects
+1
I think that allow sharing like Versions is best way,
As a method of simplifying implementation,
I think that queries defined in the top project may be displayed unconditionally.
In this way, you do not have to modify the Data...
Yuuki NARA
09:55 Defect #30745 (Closed): Rich text formatting is broken on Text and Long text custom fields
VD DV wrote:
> That's it. I was missing toolbar covered in #29712. Thank you.
> ...
Hopefully in version:"4.1.0".
Marius BĂLTEANU
09:52 Defect #30745: Rich text formatting is broken on Text and Long text custom fields
That's it. I was missing toolbar covered in #29712. Thank you.
Do you know when this feature will be available?
VD DV
08:25 Defect #30753 (Closed): Plugins auto_load and eager_load paths
This is actually a follow-up patch to #30725 (as I was digging deeper into this topic).
If a plugin uses e.g. _ActiveJob_, _ActionCable_ etc. or puts the mailer classes into app/mailers (Rails default) instead of _app/models_ the curr...
Florian Schwab
06:16 Defect #30752 (Closed): New project button doesn't appear
Please use forums for questions. Reading "How to request help":http://www.redmine.org/boards/2/topics/667 may be helpful for you. Go MAEDA
02:45 Patch #13688 (Closed): Chosen thumbnail has to be bigger than requested one and not smaller
Marius BALTEANU wrote:
> To fix the tests:
> ...
Committed. Thanks.
Go MAEDA
00:29 Patch #13688 (Reopened): Chosen thumbnail has to be bigger than requested one and not smaller
To fix the tests: Marius BĂLTEANU
00:40 Revision 17851 (svn): Fix a test failure (#13688).
Patch by Marius BALTEANU. Go MAEDA

2019-02-05

23:48 Defect #30752 (Closed): New project button doesn't appear
Hi everybody
I've created new account, and after opening Projects I don't have New Project button. The same situation on Chrome in Windows 10 or Safari in OSX.
Thanks for help
Anonymous
23:39 Feature #26561: Enable frozen string literals
I've added your patch to my "GitLab repository":https://gitlab.com/marius-balteanu/redmine/commits/feature/frozen_string_literals in order to run the tests and to see what is missing.
Do you see any value in adding the @# frozen_strin...
Marius BĂLTEANU
20:20 Feature #29712: Preview and wiki toolbar for full width custom fields
Mizuki ISHIKAWA wrote:
> #29712#note-9 code looks better than changing the FieldFormat module.
> ...
Agree, we should show to toolbar for all custom fields that support full text formatting, but I prefer to do it in another ticket beca...
Marius BĂLTEANU
20:17 Feature #29712: Preview and wiki toolbar for full width custom fields
Applying my previous patch, will allow us to refactor a small piece of code that adds the 'wiki' class to the issues custom fields with text formatting enabled (including my fix for #30027). I'm attaching the patch. Marius BĂLTEANU
19:51 Defect #30745: Rich text formatting is broken on Text and Long text custom fields
One more thing, if you expect to see the toolbar for text formatting (Edit/Preview tabs and buttons), this feature is under development, please see #29712. Marius BĂLTEANU
19:49 Defect #30745 (Needs feedback): Rich text formatting is broken on Text and Long text custom fields
Can you provide the steps to reproduce the problem?
The feature is covered by the test and I double checked now on my instance and everything looks good. Please see the attached screenshots.
Marius BĂLTEANU
15:56 Defect #30745 (Closed): Rich text formatting is broken on Text and Long text custom fields
It seems that rich text formatting is broken.
On custom fields (type Text and Long text) enabling and disabling "Text formatting" checkbox does not make any difference on custom field beahviour.
VD DV
16:40 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
+1 Muhammad Yusuf
14:50 Patch #13688 (Closed): Chosen thumbnail has to be bigger than requested one and not smaller
Committed the patch. Thank you for your contribution. Go MAEDA
14:50 Revision 17850 (svn): Makes sure the generated thumbnail is always of at least the requested size (#13688).
Patch by Jens Krämer and Marius BALTEANU. Go MAEDA
12:01 Feature #5458: Extend Start/Due date to include time
+1 for this.
I propose ability to configure in settings if someone wants to display time or just date...
Preferably, per project. Sometimes time is important, sometimes not...
Aleksandar Pavic
09:34 Defect #30073 (Closed): Ajax Request Returns 200 but an error event is fired instead of success
Committed. Thank you for reporting and fixing this issue. Go MAEDA
09:33 Revision 17849 (svn): Ajax Request Returns 200 but an error event is fired instead of success (#30073).
Patch by Pavel Rosický. Go MAEDA
09:26 Feature #3547: Wiki include macro: add ability to include single section
+1, I thought it would be very useful.
So, I made a patch, with reference to "redmine_include_macro_extension":http://www.redmine.org/plugins/redmine_include_macro_extension plugin maded by @Taiki I.
We will be able to include a sectio...
Takenori TAKAKI
07:14 Feature #10264: Add a check/uncheck all button to search
it is a small change and very useful, I propose to add it in a next minor release.
Marius BĂLTEANU
01:04 Feature #10264: Add a check/uncheck all button to search
!{width: 70%; border: 1px solid #ccc}search.png!
By changing like this, a green check icon will be added.
{{collapse(diff)
Mizuki ISHIKAWA
 

Also available in: Atom