Project

General

Profile

Activity

From 2019-03-07 to 2019-03-09

2019-03-09

23:32 Feature #30838: Option to parse HTML part of multipart (HTML) emails first
Go MAEDA wrote:
> We may change the default value to 'html' in the future version of Redmine but I think it is safer to stay in 'plain' in Redmine 4.1 because this unreleased feature is not widely tested and used yet in the production e...
Marius BĂLTEANU
16:38 Patch #30994 (Closed): Refactor custom field css classes
Committed. Thank you. Go MAEDA
16:38 Revision 17937 (svn): Move custom field classes to a method (#30994).
Patch by Marius BALTEANU. Go MAEDA
16:22 Feature #30985 (Closed): Add CSS class to user custom fields
Go MAEDA
16:08 Feature #30985 (Resolved): Add CSS class to user custom fields
Committed. Go MAEDA
16:22 Revision 17936 (svn): Merged r17935 from trunk to 4.0-stable (#30985).
Go MAEDA
16:07 Revision 17935 (svn): Add CSS class to user custom fields (#30985).
Patch by Go MAEDA. Go MAEDA
09:43 Defect #31002 (New): Can't change priority of tickets which are not "in Progress" (In Bearbeitung)
All of my tickets which do not have the status "New" do not show the "priority field" in the edit mode.
Why is this so?
When I created the issue the priority was urgent. After working a bit on this task the priority of this very ta...
Thomas Fengler
06:08 Feature #4347: Contributing to an issue should automatically add the user to the watchers list
Great! Mitsuyoshi Kawabata
02:43 Defect #30099 (Reopened): Multiple blank lines in pre tags are not preserved in Textile
This patch causes a problem reported as #30987.
I think r17891 should be reverted.
Go MAEDA

2019-03-08

19:18 Patch #30739: Project Custom Fields configuration : split by tracker
Performance fix applied. Jérôme BATAILLE
17:50 Patch #30999 (Needs feedback): Datepicker javascript files locale in uppercase not found
* In public / javascripts / i18n
Files like datepicker-en-GB.js are not found because file is searched with locale that is lowercase.
These files should be in lower case.
Jérôme BATAILLE
15:45 Feature #30998 (Closed): Add an rake task to prune registered users after a certain number of days
Hello,
Unfortunately I'm not enough skilled in ruby to propose a patch.
Like many other people, I'm affected by spammers that half-register themselves but do not complete inscriptions due their fake emails. So I constantly have a p...
David Demelier
15:14 Feature #30986: New toolbar button to insert wiki macros
Sounds great, some kind of "Redmine" button can be very convenient for sure although I think it would make more sense to have a separate menu for only macros.
+1
Bernhard Rohloff
14:09 Feature #30997 (New): Add selected key number of a key/value list as a CSS class
This feature enables styling of the fields based on their current value.
I've created something similar with CSS and JavaScript but a pure CSS version would be much more desirable.
!cf_traffic_light.png!
Bernhard Rohloff
07:29 Defect #30987 (Confirmed): Unnecessary empty lines are displayed when syntax highlighting
Confirmed the behavior. Probably I should revert r17891. Go MAEDA
05:45 Defect #30753: Plugins auto_load and eager_load paths
Much better way to do this, please use this patch instead of the one above :) Jens Krämer
05:34 Defect #30753 (Reopened): Plugins auto_load and eager_load paths
Go MAEDA
05:32 Defect #30753: Plugins auto_load and eager_load paths
Turns out the patch using Rails' engine config does only solve the issue for directories under <plugin>/app. <plugin>/lib still has to be added manually. I attached a patch based on 4.0-stable for that.
Jens Krämer
05:23 Defect #30731: "View differences" buttons are shown in the repository page even without "Browse repository" permission
It seems to be able to solve this problem by adding the following condition for disp the button. Takenori TAKAKI
02:42 Feature #30838 (Reopened): Option to parse HTML part of multipart (HTML) emails first
The caption of the options for the setting is hardcoded in source:trunk/app/views/settings/_mail_handler.html.erb@17913#L21 and cannot be localized. Go MAEDA
02:35 Patch #30995 (Closed): Japanese translation update (r18073)
Translated the following strings:
* setting_mail_handler_preferred_body_part
* setting_show_status_changes_in_mail_subject
* label_inherited_from_parent_project
* label_inherited_from_group
* label_trackers_description
* label_op...
Go MAEDA
01:12 Feature #26561: Enable frozen string literals
great, thanks :) Pavel Rosický
00:58 Feature #26561: Enable frozen string literals
Pavel Rosický wrote:
> What is the prefered way how to deal with these issues? I would rather fix those methods to avoid side-effects, what do you think?
You don't have to work on splitting the patch. I will do that :)
Go MAEDA
00:11 Patch #30994: Refactor custom field css classes
Setting the target version to 4.1.0. Go MAEDA

2019-03-07

22:50 Feature #30893: Show "Updated issues" on the profile page
I'm not sure that retrieving the "Updated issues" using a custom query is the best option. I would investigate how to get those issues using @IssueQuery@ (in the same way how the issues are retrieved in My page) if we really want to add ... Marius BĂLTEANU
09:34 Feature #30893: Show "Updated issues" on the profile page
I attached a patch.
The "Updated issues" row shows number of open, closed and total. And each value is linked to issues list filtered by "Updated by" filter.
Yuichi HARADA
22:09 Patch #30994 (Closed): Refactor custom field css classes
We should move the logic to generate the css classes for a custom field to a method in order to make the code cleaner and easy to maintain.
The attach patch must be applied on top of #30985.
Marius BĂLTEANU
22:02 Feature #30986: New toolbar button to insert wiki macros
I like this idea. In the future, we can extend the button to include Redmine links to different objects (issues, source, etc). Marius BĂLTEANU
08:15 Feature #30986 (New): New toolbar button to insert wiki macros
Redmine has useful wiki macros such as "child_pages", "collapse", "include" and "thumbnail".
Despite the usefulness of those macros, not so many people know the feature because they are too hidden. Only people who read the detailed sy...
Go MAEDA
21:37 Feature #26561: Enable frozen string literals
Go MAEDA wrote:
> Thank you for updating the patch. I would like to enable frozen_string_literal in files under the ./test directory first
I can do that, but there're some problematic methods
User#find_by_login
https://github.com/r...
Pavel Rosický
04:04 Feature #26561: Enable frozen string literals
Pavel Rosický wrote:
> https://github.com/redmine/redmine/pull/115
> ...
Thank you for updating the patch. I would like to enable frozen_string_literal in files under the ./test directory first for the following reasons:
* Changes ...
Go MAEDA
15:29 Feature #30985: Add CSS class to user custom fields
Attaching a patch. Go MAEDA
05:23 Feature #30985 (Closed): Add CSS class to user custom fields
User custom fields displayed in the profile page don't have a CSS class that expresses the internal id of the custom field.
Those fields should have a class as already done in issue and project custom fields.
*[The current HTML]*
Go MAEDA
10:08 Feature #4347: Contributing to an issue should automatically add the user to the watchers list
nice! Kamil .
01:45 Feature #4347: Contributing to an issue should automatically add the user to the watchers list
I propose the following features for auto watch.
* User is added as a watcher automatically, When adding a comment to an issue.
* Enable to select "Auto watch" ON / OFF on Account Settings (Default is ON).
* When adding a feature, the...
Takenori TAKAKI
09:42 Defect #30988 (Closed): Preformatted text overflows the preview area
Like the image below, the pre tag overflows from the preview tab.
!{width: 70%; border: 1px solid #ccc}note.png!
Mizuki ISHIKAWA
09:24 Defect #30987 (Closed): Unnecessary empty lines are displayed when syntax highlighting
Unnecessary empty lines are displayed like the image.
!{width: 70%; border: 1px solid #ccc}test.png!
I found this problem with trunk.
r17891 may be involved in this problem.
Mizuki ISHIKAWA
09:08 Patch #30983 (Closed): Traditional Chinese translation (to r17932)
Committed the translation. Thank you. Go MAEDA
04:11 Patch #30983 (Closed): Traditional Chinese translation (to r17932)
* New tags added
** setting_mail_handler_preferred_body_part, setting_show_status_changes_in_mail_subject
ChunChang (Nagaharu) Lo
09:07 Revision 17934 (svn): Traditional Chinese translation (#30983).
Patch by ChunChang Lo. Go MAEDA
09:05 Defect #30367 (Resolved): "Last updated by" filter causes an SQL error with MariaDB
Committed the patch. Thank you for reporting and fixing the issue. Go MAEDA
08:20 Defect #30367: "Last updated by" filter causes an SQL error with MariaDB
Pavel Rosický wrote:
> the fix is fairly simple, Marius please take a look
Thank you for sharing the patch.
I confirmed that the failed test succeeded by applying your patch.
I also confirmed that the last_updated_by filter works f...
Mizuki ISHIKAWA
09:05 Revision 17933 (svn): "Last updated by" filter causes an SQL error with MariaDB (#30367).
Patch by Pavel Rosický. Go MAEDA
05:41 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
The attached patch adds a feature to mention to the user.
* Use user link such as "user:jsmith" "@jsmith" "user#2".
* Notify when the user mentioned by the user link has the authority to view the element and has not rejected the notifi...
Mizuki ISHIKAWA
03:40 Defect #30850: Unified diff link broken on specific file/revision diff view
By changing to the following, the diff format is allowed. Mizuki ISHIKAWA
00:29 Feature #30977 (Closed): Add CSS class to project custom fields
Go MAEDA
00:23 Revision 17932 (svn): Merged r17931 from trunk to 4.0-stable (#30977).
Go MAEDA
 

Also available in: Atom