Project

General

Profile

Activity

From 2019-05-18 to 2019-05-20

2019-05-20

22:51 Feature #31395: Make the footer of the 'Powered by Redmine' line user changeable.
Thank you for your response.
Yuuki NARA
22:38 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
I made two changes:
1. Moved the repository from my namespace to a new one created 'redmine-org'.
2. Changed the visibility to public.
If you consider it shouldn't be public, please let me know. I'm still using it to keep my work an...
Marius BĂLTEANU
22:34 Feature #23980: Replace icon images with Tabler SVG icons
Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Sorry, I didn't know that the project is private. I made it public now, you should have access.
Marius BĂLTEANU
16:51 Feature #23980: Replace icon images with Tabler SVG icons
Marius BALTEANU wrote:
> "Here":https://gitlab.com/redmine-org/redmine/merge_requests/3 is an updated version of my patch.
Since the page requires authentication, I could not get the patch.
Go MAEDA
08:49 Feature #23980: Replace icon images with Tabler SVG icons
"Here":https://gitlab.com/redmine-org/redmine/merge_requests/3 is an updated version of my patch. Because the size of the patch is too big, you need to download it from my gitlab instance (screenshot attached for those who are not famili... Marius BĂLTEANU
19:52 Defect #31407 (New): relative_url_root does not correctly set the menu_items href
If I set the relative_url_root in config/environment.rb using
Redmine::Utils::relative_url_root = "/redmine"
or
ActionController::Base.relative_url_root = "/redmine"
or with an ENV of RAILS_RELATIVE_URL_ROOT=/redmine
the script a...
Philip Dalrymple
17:26 Feature #31225: Show the number of days left until the due date in reminders
Yuichi HARADA wrote:
> Sorry, I fixed to the UTC Date at 0:00 using @travel_to Date.today.to_time(:utc)@ .
> ...
Unfortunately, tests still fail.
Go MAEDA
07:23 Feature #31225: Show the number of days left until the due date in reminders
Go MAEDA wrote:
> The tests fail depending on the timezone.
> ...
Sorry, I fixed to the UTC Date at 0:00 using @travel_to Date.today.to_time(:utc)@ .
This fix eliminates the dependency on time zones.
Yuichi HARADA
01:36 Feature #31225 (Reopened): Show the number of days left until the due date in reminders
The tests fail depending on the timezone.
I think the error occurs when the date of the current timezone is different from the date in UTC. For example, I observed the following error on *20 May* 2019 08:15:00 +0900 (*19 May* 2019 23:...
Go MAEDA
17:11 Patch #28510: Show issue assignee gravatar in roadmap and version page
Marius BALTEANU wrote:
> Here is the updated patch that can be applied after #31391 is committed.
The patch works fine but I prefer the layout of attachment:assignee_first.png is better the layout of the latest patch because the star...
Go MAEDA
15:39 Feature #31196: Updates jQuery to 2.2.4 and adds jQuery Migrate library
I've some work in progress on this topic. Marius BĂLTEANU
14:46 Feature #31196: Updates jQuery to 2.2.4 and adds jQuery Migrate library
Federico Vera wrote:
> The current version of jQuery used in Redmine (1.11.1) is a couple of years old, and plagued with known "security vulnerabilities":https://www.cvedetails.com/vulnerability-list.php?vendor_id=6538&product_id=0&vers...
Philippe Bourjac
14:59 Defect #31387: Don't rescue Exception class
exceptions have a hierarchy Pavel Rosický
14:26 Defect #31387: Don't rescue Exception class
Pavel Rosický wrote:
> it should be
Go MAEDA
14:09 Defect #31387: Don't rescue Exception class
thanks, there's a typo in config/routes.rb
it should be
Pavel Rosický
13:46 Defect #31387: Don't rescue Exception class
Here are patches to fix not to raise/rescue Exception. I hope someone to review these patches. Go MAEDA
11:39 Feature #31404 (Resolved): Time visualization plugin
This feature could help the project management to review the estimations.
This plugin makes the plannings faster and the presentations more understandable.
http://www.redmine.org/plugins/redtime
Botond Tóth
11:28 Feature #6666: Soft delete of issues
+1 Piotr Błądek
10:51 Patch #5899 (Closed): Display user's gravatar when editing profile
Committed the patch. Go MAEDA
10:51 Revision 18180 (svn): Display user's gravatar when editing profile (#5899).
Patch by Go MAEDA. Go MAEDA
10:44 Patch #31402 (Closed): Add support for customization by block to IssueCustomField.generate!
Committed the patch. Thank you for your contribution. Go MAEDA
09:09 Patch #31402: Add support for customization by block to IssueCustomField.generate!
Setting the target version to 4.1.0. Go MAEDA
08:29 Patch #31402 (Closed): Add support for customization by block to IssueCustomField.generate!
@generate!@ methods in @test/object_helpers.rb@ supports customizing by block. But @IssueCustomField.generate!@ doesn't support it.
The attached patch adds it.
FYI: I created this diff by Git. Because I have the same problem as #24...
Kouhei Sutou
10:43 Revision 18179 (svn): Add support for customization by block to IssueCustomField.generate! (#31402).
Patch by Kouhei Sutou. Go MAEDA
10:37 Patch #31398 (Closed): Traditional Chinese translation (to r18175)
Committed. Thank you for your contribution. Go MAEDA
05:27 Patch #31398 (Closed): Traditional Chinese translation (to r18175)
* New tags added
** label_import_time_entries, label_import_notifications, text_gs_available
ChunChang (Nagaharu) Lo
10:36 Revision 18178 (svn): Traditional Chinese translation update (#31398).
Patch by ChunChang Lo. Go MAEDA
10:34 Patch #31147 (Closed): Add custom styles for all fields
Committed the patch in #31147#note-22. Thanks. Go MAEDA
09:39 Patch #31147: Add custom styles for all fields
Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Not really, I think it is enough to revert only the CSS change and committed it again as part of this ticket.
Marius BĂLTEANU
09:35 Patch #31147: Add custom styles for all fields
Marius BALTEANU wrote:
> Go Maeda, just to know, you have committed the change proposed above by Bernhard as part of the #31391.
Sorry, I didn't know the mistake. Do you think if I should revert r18175 and commit #31391 again?
Go MAEDA
09:30 Patch #31147: Add custom styles for all fields
Go Maeda, just to know, you have committed the change proposed above by Bernhard as part of the #31391.
Please see http://www.redmine.org/projects/redmine/repository/revisions/18175/diff/trunk/public/stylesheets/application.css
Marius BĂLTEANU
10:34 Revision 18177 (svn): Set background color in order to provide a consistent style on GTK dark themes (#31147).
Patch by Bernhard Rohloff. Go MAEDA
10:25 Revision 18176 (svn): Reverts undesired changes in r18175 (#31391).
Go MAEDA
09:26 Feature #31355: Bookmarks and recently used projects for the project jump box
I am sure that no one will dislike or oppose this feature. Let's deliver this feature in 4.1.0. Go MAEDA
09:15 Feature #31355: Bookmarks and recently used projects for the project jump box
The patch looks very good to me. I'm in favour of delivering this feature in version:"4.1.0". Marius BĂLTEANU
07:40 Feature #31355: Bookmarks and recently used projects for the project jump box
Bernhard Rohloff wrote:
> Oh, one thing I forgot is, the patch doesn't contain the two new icons referenced by the stylesheet changes.
> ...
The icons are included in the patch. You can get them by using @git apply@ instead of @patch@ ...
Go MAEDA
06:25 Feature #31355: Bookmarks and recently used projects for the project jump box
Oh, one thing I forgot is, the patch doesn't contain the two new icons referenced by the stylesheet changes. Bernhard Rohloff
06:03 Feature #31355: Bookmarks and recently used projects for the project jump box
I've tried the patch and it makes project switching very fast and easy. A really great improvement for Redmine!
+1
Bernhard Rohloff
09:13 Patch #31384: Remove custom lazy loading of i18n files
Jean-Philippe, please take a look at the patch proposed by Pavel as a fix to a problem that was introduced by me when we updated the i8n gem to 1.6.0 (#29946).
For me, the change looks good, especially because we drop quite a lot of c...
Marius BĂLTEANU
08:35 Feature #25746: Spent time - CUSTOM fields - permissions
+1 Alexandr Chernyaev
05:34 Patch #31399 (Closed): make /my/account endpoint accessible through API
This would allow a user to update their account info through an external app. Currently admin privileges are required to change i.e. a user's name through the /users API. Jens Krämer
00:27 Patch #31391 (Closed): Small refactorization of avatar methods
Committed the patch. Thanks. Go MAEDA
00:27 Revision 18175 (svn): Small refactorization of avatar methods (#31391).
* move existing methods from ApplicationHelper to a new helper file (AvatarsHelper)
* change default avatar size from 50 to 24 because most of the avatars are using the size 24
* class 'gravatar' is always added and all custom classes a...
Go MAEDA

2019-05-19

17:54 Feature #31395: Make the footer of the 'Powered by Redmine' line user changeable.
Excuse me, but please change it because the subject was incorrect
From
Yuuki NARA
17:02 Feature #31395 (New): Make the footer of the 'Powered by Redmine' line user changeable.
In the case of in-house operation, it may be instructed to display the management department / responsible person name display in the footer.
It can be dealt with by modifying the source code, but I think that it is desirable to be ab...
Yuuki NARA
16:53 Feature #31381: Find change status of issues at custom query
+1 Ryoh HAMADA
13:07 Feature #31381: Find change status of issues at custom query
+1
Yuuki NARA
15:30 Feature #29946 (Reopened): Update i18n gem (~> 1.6.0)
#31384 has been reported for this change. Go MAEDA
14:03 Patch #5899: Display user's gravatar when editing profile
Go MAEDA wrote:
> Marius, could you attach the patch?
Sorry, I referred to the patch from #31391. Your patch from note-1 is good enough, we should remove only the size from it.
Marius BĂLTEANU
13:19 Patch #5899: Display user's gravatar when editing profile
Marius, could you attach the patch? Go MAEDA
13:55 Defect #31388: ApiTest fails if config.time_zone is set
Should we update the test code or always fix the time zone for API responses to UTC? Go MAEDA
12:08 Feature #29824: Add user initials when Gravatar is disabled
Go MAEDA wrote:
> I prefer option 2 for privacy reason. An admin should be able to decide whether to send characters extracted from user names to ui-avatars.com.
> ...
We won't use ui-avatars.com or any other external service, it will ...
Marius BĂLTEANU
11:58 Feature #29824: Add user initials when Gravatar is disabled
I prefer option 2 for privacy reason. An admin should be able to decide whether to send characters extracted from user names to ui-avatars.com.
As I wrote in #29824#note-5, the names of people in East Asian countries such as Japan, Ch...
Go MAEDA
10:58 Feature #23778 (Closed): default sort email reminders by due date (and list due date in email)
The upcoming Redmine 4.1.0 shows the number of days left until the due date ("due in X days" / "X days late"). Please see #31225 for details. Go MAEDA
10:57 Patch #6357 (Closed): Show and sort by due_date in reminders
The upcoming Redmine 4.1.0 shows the number of days left until the due date ("due in X days" / "X days late"). Please see #31225 for details. Go MAEDA
10:53 Feature #31225 (Closed): Show the number of days left until the due date in reminders
Committed the patch. Thanks. Go MAEDA
10:52 Revision 18174 (svn): Show the number of days left until the due date in reminders (#31225).
Patch by Yuichi HARADA. Go MAEDA
08:21 Patch #31391: Small refactorization of avatar methods
LGTM. Setting the target version to 4.1.0. Go MAEDA

2019-05-18

17:05 Feature #29824: Add user initials when Gravatar is disabled
I really like to add this to the core, but I'm not sure how it should work because there are some options to implement it:
1. The initial proposal to show the user initials when the Gravatar service returns 404, but this mean that the...
Marius BĂLTEANU
15:41 Patch #28510: Show issue assignee gravatar in roadmap and version page
Here is the updated patch that can be applied after #31391 is committed. Marius BĂLTEANU
15:06 Patch #31385: Formating toolbar : new color tools
!{border: 1px solid}text_color.png!
!{border: 1px solid}text_color_and_background.png!
Jérôme BATAILLE
14:50 Patch #31385: Formating toolbar : new color tools
Here is the patch, and the 2 new images to put in *public/images/jstoolbar/*
This patch does not manage the case when we want background an text color at the same time.
Jérôme BATAILLE
13:38 Patch #5899: Display user's gravatar when editing profile
Go MAEDA wrote:
>
> ...
I've posted the patch.
Marius BĂLTEANU
13:34 Patch #31391 (Closed): Small refactorization of avatar methods
Small refactorization of avatar methods:
* move existing methods from ApplicationHelper to a new helper file (AvatarsHelper)
* change default avatar size from 50 to 24 because most of the avatars are using the size 24
* class 'gra...
Marius BĂLTEANU
06:55 Defect #31387: Don't rescue Exception class
Thank you for pointing it out.
Maybe we should also check the following lines, shouldn't we?
Go MAEDA
01:42 Defect #31388 (Closed): ApiTest fails if config.time_zone is set
ApiTest fails if config.time_zone is set. The tests suppose that time in API response is always in UTC, but it varies depending on the value of config.time_zone is set.
Set @config.time_zone@ in @config/additional_environment.rb@.
Go MAEDA
00:29 Feature #31225: Show the number of days left until the due date in reminders
I applied this patch to my production environment and found that the information "Due in X days" / "X days late" is useful. It made me realize that there were too many overdue issues!
I am setting the target version to 4.1.0.
Go MAEDA
 

Also available in: Atom