Activity
From 2019-06-17 to 2019-06-19
2019-06-19
-
22:01 Feature #31581: Issue burnup chart in the version detail
- It is an interesting feature, but I'm not sure how to read the chart. Go Maeda, Takenori TAKAKI, can you explain a little bit what we should understand from the chart?
-
18:02 Feature #31581: Issue burnup chart in the version detail
- !{border: 1px solid #ccc;}.screenshot-whole-page.png!
-
17:45 Defect #31519 (Closed): Redmine 4.0.3 does not send all notification emails ?
- Thank you for the feedback.
-
11:45 Defect #31519 (Resolved): Redmine 4.0.3 does not send all notification emails ?
- It was the mail server... My external it service company seems to be unexperienced with exchange configuration
-
17:43 Feature #31553 (Closed): Preview .webm as video instead of audio
- Committed the patch. Thank you all for working on this issue.
-
09:21 Feature #31553: Preview .webm as video instead of audio
- I've attached the patch to my dev environment and it works flawlessly with my test video made by a screen recorder. Very nice improvement!
-
09:02 Feature #31553: Preview .webm as video instead of audio
- Setting the target version to 4.1.0.
-
17:41 Revision 18261 (svn): Preview .webm as video instead of audio (#31553).
- Patch by Seiei Miyagi.
-
11:46 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
- In the meantime, I've added Rubocop checks to the "pipeline":https://gitlab.com/redmine-org/redmine/pipelines/66911287. Test results "here":https://gitlab.com/redmine-org/redmine/-/jobs/234560433.
Go Maeda, I'm planning to add Posteg... -
11:39 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
- Pavel Rosický wrote:
> are you about to open it for constributors? in such case all stable branches should be marked as protected.
> ...
I'm open only to accept new branches to be pushed in order to have the tests run in GitLab CI. Any... -
11:29 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- Mizuki, why we don't check the value of @indice@ inside the @render_journal_actions@ method?
Something like that (tested briefly): -
11:16 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- I attached a patch that added a test to #31427#note-11 's change.
-
10:33 Patch #31441 (Closed): Show elements titles using jQuery UI tooltips
- Thank you to everyone who involved in this patch.
-
10:22 Patch #31441: Show elements titles using jQuery UI tooltips
- Thank you! It looks good to me.
Since the title attribute is too general and XSS may occur, I think it would be nice to disable HTML support.
IMO If you need HTML support, it may be better to add explicit attributes. (e.g. like html-... -
10:01 Patch #31441: Show elements titles using jQuery UI tooltips
- I think for now it's enough to disable the HTML support (attached patch).
What do you think, Seiei Miyagi? -
10:30 Revision 18260 (svn): Show elements titles using jQuery UI tooltips (#31441).
- Patch by Marius BALTEANU.
-
09:43 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
- Marius BALTEANU wrote:
> Did you start work on this? or someone from your team? If not, I can do it considering that I was the one who implemented the restriction.
No one in my team has started work yet. I am appreciative that you wi... -
09:34 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
- Did you start work on this? or someone from your team? If not, I can do it considering that I was the one who implemented the restriction.
-
05:23 Feature #31589 (Closed): Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
- You cannot close an issue if it has open subtasks (#10989).
This rule is not obvious and difficult to know for users. In my company, "why I cannot close this issue?" is an FAQ. When they come across the behavior, they spend a long tim... -
07:57 Feature #31322 (Closed): Provide a way to automatically close all open subtasks too when a parent issue is being closed
- Closing as a duplicate of #28492.
-
02:49 Patch #31509 (Closed): Add Rubocop to enforce some styles
- Committed. Thank you for your contribution.
-
00:44 Patch #31509: Add Rubocop to enforce some styles
- Go MAEDA wrote:
> I have updated the patch:
> ...
Looks very good to me, thank you for improving my patch!
-
02:49 Revision 18259 (svn): Add RuboCop to enforce some styles (#31509).
- Patch by Marius BALTEANU and Go MAEDA.
-
02:19 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique
- Seiei Miyagi wrote:
> > 'issues.id DESC'
> ...
Thank you for pointing it out.
I changed the way of writing table names.
2019-06-18
-
20:23 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
- In a company there should be no problem as mentioning a user would have the same effect as sending an email to the user. So I believe the main concern would be in public websites like this one.
It could be controlled by a new permissi... -
18:10 Defect #31587 (Closed): Time Entries REST API user_id parameter doesn't work
- I'm trying to use Time Entries REST API and it works as expected except user_id parameter.
When I tried to get time entries https://myredmine/time_entries.json?key=mykey&from=2019-06-01&to=2019-06-30&limit=5&user_id=5 I'm getting time... -
17:51 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique
- > 'issues.id DESC'
Is it OK to write table name of the Issue model directly?
In app/models/issue_query.rb, It seems code like following is more preferable. -
14:06 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique
- Thank you for your response! Your v2 patch looks good to me.
-
07:25 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique
- vzvu 3k6k wrote:
> > -
17:15 Patch #31509: Add Rubocop to enforce some styles
- I have updated the patch:
* Added rules that Marius pointed out in #31509#note-6. I have added rules to @.rubocop.yml@ instead of updating @.rubocop_todo.yml@ because @.rubocop_todo.yml@ is an auto-generated file and it will be overwr... -
11:25 Feature #11313: Automatic closing of resolved issues
- +1
redmine 3.4 here -
09:52 Patch #31441: Show elements titles using jQuery UI tooltips
- Seiei Miyagi wrote:
> I found the XSS in attached patch.
> ...
You're right, thanks for pointing this out, I'll fix it. -
09:34 Patch #31441: Show elements titles using jQuery UI tooltips
- I found the XSS in attached patch.
If I fill the project description like below, then open http://localhost:3000/admin/projects and hover the title of the project, the alert is showing. -
04:00 Patch #31441: Show elements titles using jQuery UI tooltips
- +1
-
09:16 Defect #31582 (Confirmed): Issue subject may be truncated if the subject field in the receiving email is split into multiple lines in singlebytes and multibytes mixed
- When you create issues via email, the subject of the created issue may be truncated if the subject field in the original email is split into multiple lines in singlebytes and multibytes mixed format like the following.
-
07:17 Feature #31581: Issue burnup chart in the version detail
- +1 A really useful feature
-
05:48 Feature #31581 (New): Issue burnup chart in the version detail
- I propose a feature to visualize the changes of registration / completion of issues in the version detail using 'Burnup chart'.
By visualizing with Burnup chart, we can intuitively grasp the change of issue registration / completion in ... -
03:58 Feature #31444: Add "<< me >>" option to user format issue custom fields
- akitani ryo wrote:
> confirmed.
> ...
Thank you for confirming!
2019-06-17
-
15:28 Feature #30485: Make activity type project dependant instead of redmine global
- Bump
-
14:38 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
- Anders Thomsen wrote:
> Won't adding mentioned users as watchers cause them to get even more e-mails? Consider a scenario where developers (watching the issue) frequently adds notes to an issue. Once in a while they need to notify some ... -
07:30 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique
- >
-
02:44 Patch #31509: Add Rubocop to enforce some styles
- +1