Activity
From 2019-06-20 to 2019-06-22
2019-06-22
-
02:31 Patch #31594 (Closed): Japanese translation update (r18281)
-
02:30 Revision 18312 (svn): Change the Japanese translation for label_issue_history_properties (#31594).
- Patch by Go MAEDA.
-
02:22 Feature #3058 (Closed): Show issue history using tabs
- Marius BALTEANU wrote:
> A small problem was reported by Mizuki in #31599. I've attached there the fix.
Committed the patch in r18311. Thanks. -
02:21 Defect #31599 (Closed): 'selected' class disappears from the tab of the input field when switching the issue history tab
- Committed the fix. Thank you all for reporting and fixing the issue.
-
02:20 Revision 18311 (svn): "selected" class is wrongly removed from journal edit tabs when switching the issue history tabs (#3058, #31599).
- Patch by Marius BALTEANU.
-
01:04 Patch #25154: Allow non-administrator users to copy certain projects
- Updated patch for Redmine 4.0.3
2019-06-21
-
14:58 Feature #21585: "Associated revisions" to be minimized / opened by click
- !{width:80%; border: 1px solid grey;}tabs.png!
-
14:57 Feature #21585 (Closed): "Associated revisions" to be minimized / opened by click
- "Associated revisions" are now under a tab and loaded only on click. The feature was implemented in #3058 for the upcoming Redmine version:"4.1.0".
-
14:55 Feature #16052 (Closed): Consider a better associated revisions block in the issue tracker
- Implemented in #3058 for the upcoming Redmine version:"4.1.0".
-
14:52 Feature #8536 (Closed): Separate notes/comments from issue updates
- Implemented in #3058 for the upcoming Redmine version:"4.1.0".
-
14:43 Feature #3058 (Reopened): Show issue history using tabs
- A small problem was reported by Mizuki in #31599. I've attached there the fix.
-
14:32 Defect #31599: 'selected' class disappears from the tab of the input field when switching the issue history tab
- The attached patch should fix this problem.
-
14:15 Defect #31599 (Confirmed): 'selected' class disappears from the tab of the input field when switching the issue history tab
-
09:57 Defect #31599 (Closed): 'selected' class disappears from the tab of the input field when switching the issue history tab
- The 'selected' class disappears from the tab of the input field when switching the issue history tab.
!{width: 70%; border: 1px solid #ccc}tabs.gif!
Affected version: trunk(r18310) -
11:36 Feature #29663: Select a JavaScript library to handle tags
- Choices.js looks very good to me because it's more versatile and provides also options for improvements of other fields in the future.
-
09:51 Feature #29663: Select a JavaScript library to handle tags
- I looked for some other libraries that can be used to handle the tags:
* "Tagify":https://github.com/yairEO/tagify: JavaScript vanilla tag component, no custom dropdown. The size is ~7kb gzipped.
* "Choises":https://github.com/jshjohns... -
09:24 Feature #31427 (Closed): Insert a link to the source to the attribution line when quoting a note or a message
- Committed the fix attached in #31427#note-19. Thanks.
-
09:07 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- Marius BALTEANU wrote:
> Here is the patch.
> ...
I confirmed that the patch solves the problem. -
09:23 Revision 18310 (svn): Fix missing journal indice when updating a journal (#31427).
- Patch by Marius BALTEANU.
-
07:06 Defect #31053 (Closed): Some issue fixtures are set inconsistent tracker id which is not available in the project
- Committed the fix. Thanks.
-
05:17 Defect #31053 (Confirmed): Some issue fixtures are set inconsistent tracker id which is not available in the project
-
07:01 Revision 18309 (svn): Some issue fixtures are set inconsistent tracker id which is not available in the project (#31053).
- Patch by Mizuki ISHIKAWA.
-
05:25 Feature #25540: Unify fields of subtasks and related issues on issue page
- This patch is small, so I think we can include in 4.1.0.
-
04:59 Patch #21493: Tweak colors of default theme
- +1
-
01:59 Defect #31141 (Closed): SCM: error when *.yml and *.txt show
- Fixed in r18206.
-
00:05 Feature #31573: Show each journal entry from issue history in a box
- Updated the patch series. Screenshots attached.
2019-06-20
-
23:35 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- Here is the patch.
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/67280161
* Rubocop: https://gitlab.com/redmine-org/redmine/-/jobs/236746558
* Tests: https://gitlab.com/redmine-org/redmine/-/jobs/236746561
-
13:25 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- Marius BALTEANU wrote:
> Should these commits (r18216, r18217 and r18218) be reverted now that the target version was changed to version:"4.2.0"?
I don't think so. The issue reported in #31427#note-11 is small and an edge case. In a... -
12:16 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- Should these commits (r18216, r18217 and r18218) be reverted now that the target version was changed to version:"4.2.0"? Or, considering that the fix remained is not so big, I can attach tonight a new patch with my changes and the test...
-
01:49 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- Marius BALTEANU wrote:
> Mizuki, why we don't check the value of @indice@ inside the @render_journal_actions@ method?
> ...
The fix looks cleaner and looks better.
I think that it is good with this correction method. -
22:50 Patch #31598 (Closed): Move the links (All time entries, Import) from Spent time section of the spent time list sidebar under a dropdown
- !{width:50%;border: 1px solid grey!}move_links_from_sidebar.png!
Same as #30294, but for time spent. -
22:41 Patch #30294: Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown
- Bernhard Rohloff wrote:
> I've tested the latest trunk version (r18308) right now and the dropdown menu is missing. Presumably there went something wrong with the "settings" patch.
Indeed, the patch didn't apply as expected, I've att... -
20:02 Patch #30294 (Reopened): Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown
- I've tested the latest trunk version (r18308) right now and the dropdown menu is missing. Presumably there went something wrong with the "settings" patch.
-
18:38 Patch #30294 (Closed): Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown
- Committed, thanks.
-
19:19 Revision 18308 (svn): Test errors with SQLite3 (#10378).
-
18:59 Feature #27988: Option to configure which trackers can be set as subtasks for each tracker
- Jean-Philippe Lang wrote:
> Kamil . wrote:
> ...
I can try to add this checkbox, but I’m a little bit worried about the complexity because in order to not confuse the admin users, we need also to modify in the Workflow -> Fields permis... -
10:04 Feature #27988: Option to configure which trackers can be set as subtasks for each tracker
- Kamil . wrote:
> Adding my two cents (as my feature request was considered as duplicate of this one)
> ...
I think it really makes sense to support this behaviour along with this feature. -
18:58 Patch #30162 (Closed): Wiki page collapse block image is not displayed in exported PDF
- Committed, thanks!
-
18:58 Revision 18307 (svn): Wiki page collapse block image is not displayed in exported PDF (#30162).
- Patch by Jun NAITOH.
-
18:46 Patch #26604 (Closed): Set a random name attribute on all forms to prevent overwritten values after soft reload with Firefox
- Committed, thanks.
-
18:46 Revision 18306 (svn): Add a randomized name attribute to all form fields (#26604).
- This is a workaround for a Bug in Firefox described at
https://bugzilla.mozilla.org/show_bug.cgi?id=1279253
Patch by Holger Just. -
18:44 Patch #30203 (Closed): Add links to administration pages in project settings
- Committed, thanks.
-
18:44 Revision 18305 (svn): Add links to administration pages in project settings (#30203).
- Patch by Go MAEDA.
-
18:38 Revision 18304 (svn): Remove "View all issues" link from actions dropdown (#30294).
- Patch by Marius BALTEANU.
-
18:37 Revision 18303 (svn): Move the links from the sidebar under actions dropdown (#30294).
- Patch by Marius BALTEANU.
-
18:36 Feature #31444 (Closed): Add "<< me >>" option to user format issue custom fields
- Committed, thanks.
-
16:34 Feature #31444 (Reopened): Add "<< me >>" option to user format issue custom fields
- The test fails randomly.
-
11:05 Feature #31444 (Closed): Add "<< me >>" option to user format issue custom fields
- Committed, thanks.
-
18:35 Revision 18302 (svn): Test failure (#31444).
-
18:24 Patch #29151 (Closed): Add honorific suffixes ("san") in Japanese translation
- Committed, thanks.
-
18:23 Revision 18301 (svn): Add honorific suffixes ("san") in Japanese translation (#29151).
- Patch by Go MAEDA.
-
18:22 Patch #29263: Move issue attributes to their own section in issue page
- I don't see the benefit of adding this section for now. It just eats up a bit more vertical space.
-
17:44 Feature #31581: Issue burnup chart in the version detail
- Thanks for the comment, Marius.
I think that we can understand from the chart when & how many tickets were created and closed in the version. And when we have these information, we can make an outlook whether it is possible to complete ... -
16:50 Feature #25540: Unify fields of subtasks and related issues on issue page
- !{width:700px}25540.png!
I made a patch to display the same field on Subtasks and Related issue. -
16:35 Feature #26709: Use correct http status codes
- only http://www.redmine.org/attachments/19034/builders.rb.patch is relevant.
this is the redmine way how to access an api, the format is determined as an extension -
15:45 Feature #26709: Use correct http status codes
- Fixing status codes and changing the behaviour of the API regarding Accept header are different topics. I think these patches need some deeper review.
-
16:21 Revision 18300 (svn): Code cleanup: RuboCop: Layout/TrailingWhitespace
-
16:19 Revision 18299 (svn): Code cleanup: RuboCop: Style/UnneededInterpolation
-
16:17 Patch #27659 (Closed): redmine_plugin_model_generator improvements(fixes and timestamps)
- Committed, thanks.
-
16:16 Revision 18298 (svn): redmine_plugin_model_generator improvements (#27659).
- Patch by Javier Menéndez Rizo.
-
16:10 Patch #31399 (Closed): make /my/account endpoint accessible through API
- Documentation to be added here [[Rest_MyAccount]].
-
16:05 Feature #30820: Drop setting "Blind carbon copy recipients (bcc)"
- Removing a setting may cause some plugins to error.
Setting it to a major release. -
16:04 Patch #30448: Remove wrapper2 and wrapper3 wrapping containers
- We remove tags from the layout and some themes may rely on them.
Better set it to a major release. -
16:01 Feature #29489 (Closed): Issue macro for flexible linking to issues
- Committed, thanks!
-
16:01 Revision 18297 (svn): Issue macro for flexible linking to issues (#29489).
- Patch by Jens Krämer.
-
15:59 Patch #27625 (Closed): Increase maximum size for role name
- Committed, thanks.
-
15:59 Revision 18296 (svn): Increase maximum size for role name (#27625).
- Patch by Aleksandar Pavic.
-
15:56 Patch #26714: pluck instead of map in issue_query
- Need some work to avoid duplicate code with @IssueQuery#versions@.
-
15:48 Patch #29441 (Closed): Remove code related to JRuby and unsupported Ruby versions
- Committed, thanks.
-
15:48 Revision 18295 (svn): Remove code related to JRuby and unsupported Ruby versions (#29441).
- Patch by Go MAEDA.
-
15:47 Revision 18294 (svn): Remove code related to JRuby and unsupported Ruby versions (#29441).
- Patch by Marius BALTEANU.
-
15:35 Patch #29589 (Closed): Set the first status as a default status in "New tracker" form
- Committed, thanks.
-
07:46 Patch #29589: Set the first status as a default status in "New tracker" form
- I often forget to select the default status and see a validation error. It always irritates me.
Setting the target version to 4.1.0.
!{width: 505px; border: 1px solid #ccc;}.new-tracker-form@2x.png! -
15:34 Revision 18293 (svn): Set the first status as a default status in "New tracker" form (#29589).
- Patch by Yuichi HARADA.
-
15:20 Revision 18292 (svn): RuboCop: Disable Metrics
-
14:43 Patch #31384: Remove custom lazy loading of i18n files
- thanks for the feedback. You're right, i18n gem provides lazy loading for translations, but it loads all available translations at once.
the original redmine backend loaded only the current locale and this optimization was removed.
... -
10:42 Patch #31384 (Closed): Remove custom lazy loading of i18n files
- Patch committed.
-
10:40 Patch #31384: Remove custom lazy loading of i18n files
- Marius BALTEANU wrote:
> For me, the change looks good, especially because we drop quite a lot of custom code.
Sure but it also removes the feature that this custom code provides :-)
-
14:23 Revision 18291 (svn): Code cleanup: RuboCop: Rails/Presence
-
14:15 Revision 18290 (svn): Code cleanup: RuboCop: Style/DefWithParentheses
-
13:57 Revision 18289 (svn): Code cleanup: RuboCop: Style/UnneededInterpolation
-
13:18 Defect #31466 (Closed): Error assigning a task to a user whose role does not allow it
- The author of an issue can always be set as an assignee. This is an intended behavior implemented in r4240.
Closing as a duplicate of #30771. -
13:04 Defect #31595 (Closed): Error allowing assigning a task to a user when his role does not allow it
- Hi,
We have found an error in the roles of the users.
I thought it only happened in version 3.3.1, but it also happens in actual version 4.0.4.
we have a user called for example "*user1*" with a "*reporter*" role but in this rol... -
11:49 Defect #31549: LF line terminators cause misparse of a multi-part email when rdm-mailhandler.rb is invoked from /etc/aliases
- Using the same regular expression as "Mail::Utilities.binary_unsafe_to_crlf":https://www.rubydoc.info/gems/mail/Mail%2FUtilities.binary_unsafe_to_crlf is faster.
-
08:43 Defect #31549: LF line terminators cause misparse of a multi-part email when rdm-mailhandler.rb is invoked from /etc/aliases
- Yuichi HARADA wrote:
> I rewrote the patch of rdm-mailhandler.rb. Please delete the previous patch. ( attachment:fixed-31549.patch )
I didn't need encoding, so I rewrote the patch. -
11:13 Feature #31573: Show each journal entry from issue history in a box
- I need to update these patches now that #3058 was committed .
-
11:05 Revision 18288 (svn): Add "<< me >>" option to user format issue custom fields (#31444).
- Patch by Mizuki ISHIKAWA.
-
10:59 Feature #30986: New toolbar button to insert wiki macros
- Nice feature but:
* we should find something else than the Redmine logo for this button
* as Bernhard said, it should comme along with additional information about the macro and the arguments that it expects. The macro name on its own ... -
10:58 Revision 18287 (svn): Update locales (#28213).
-
10:57 Feature #30207 (Closed): Hide menu item in the cross-project menu if the module is not enabled in any project
- I also had a concern about these queries but as long as they are fast it should not be a problem.
-
10:51 Feature #29482: Query system for Projects page
- Marius BALTEANU wrote:
> I'm working on updating the patch series to apply cleanly on the current trunk.
Here are the updated patches, all tests pass.
-
09:41 Feature #29482: Query system for Projects page
- I'm working on updating the patch series to apply cleanly on the current trunk.
-
10:42 Feature #29946 (Closed): Update i18n gem (~> 1.6.0)
-
10:41 Revision 18286 (svn): Removes lazy loading of i18n files for 18n 1.6.0 compat (#31384).
-
10:26 Feature #29034: Option to collapse/expand issue sections
- I think we actually save space when we can collapse some sections +by default+. Having to collpase sections manually to save space each time we display an issue doesn't sound so much usefull to me.
Can we have more feedback on this prop... -
10:17 Feature #28213 (Closed): Support external ID when importing issues
- Patch committed, thanks!
-
10:17 Revision 18285 (svn): Support external ID when importing issues (#28213).
- Patch by Gregor Schmidt and Marius BALTEANU.
-
10:14 Revision 18284 (svn): Test failure with mysql (#30288).
-
10:13 Feature #11530: Support hooks in mailer
- Kouhei Sutou wrote:
> It's already provided.
> ...
Sure, but how does the hook that is called know about this? -
09:50 Feature #11530: Support hooks in mailer
- It's already provided.
If we're rendering a HTML email, @XXX.html.erb@ is used.
If we're rendering a plain text email, @XXX.text.erb@ is used. -
09:44 Feature #11530: Support hooks in mailer
- We need to provide a way for the hook to know if we're rendering a html or plain text email.
-
10:02 Feature #26653 (Closed): REST API - Add full CRUD support for News
-
10:01 Feature #26033 (Closed): Respect "Objects per page" option when displaying forum replies
-
09:57 Feature #22090 (Closed): Make project settings more accessible
- Committed, thanks.
-
09:56 Revision 18283 (svn): Make project settings more accessible (#22090).
- Patch by Jan Schulz-Hofen and Go MAEDA.
-
09:56 Revision 18282 (svn): Japanese translation update (#31594).
- Patch by Go MAEDA.
-
09:49 Patch #31594 (Closed): Japanese translation update (r18281)
- Translated the following strings which are added by #3058:
* field_history_default_tab
* label_issue_history_properties
* label_issue_history_notes
* label_last_tab_visited -
09:40 Revision 18281 (svn): Update locales (#3058).
-
09:36 Feature #10378 (Closed): Don't show empty fields in email notifications
- Patch committed, thanks.
-
09:36 Revision 18280 (svn): Don't show empty fields in email notifications (#10378).
- Patch by Yuichi HARADA.
-
09:26 Feature #3058 (Closed): Show issue history using tabs
- Thanks Marius for updating the patches. They are now committed, thanks for your hard work on this!
-
08:20 Feature #3058: Show issue history using tabs
- Ko Nagase wrote:
> Hi,
> ...
No, you can't, it is Jean-Philippe decision on this feature.
In the meantime, I've updated the patch series to apply cleanly and I've added a new patch (attachment:0008-Remove-history-label-and-no-data.p... -
09:25 Revision 18279 (svn): Set border on tab content instead of #history.
-
09:14 Revision 18278 (svn): Remove history label and no data (#3058).
- Patch by Marius BALTEANU.
-
09:13 Revision 18277 (svn): User preference for issue history default tab (#3058).
- Patch by Marius BALTEANU.
-
09:13 Revision 18276 (svn): Load remote tab only once (#3058).
- Patch by Marius BALTEANU.
-
09:12 Revision 18275 (svn): Load changesets and time entries tabs async (#3058).
- Patch by Marius BALTEANU.
-
09:11 Revision 18274 (svn): Add time entries tab to issue history tabs (#3058).
- Patch by Marius BALTEANU.
-
09:10 Defect #31593 (Closed): Email Receiving creates broken issues when incoming message is S/MIME signed
- Email Receiving creates broken issues when incoming message is S/MIME signed.
See attached screenshots, they show several parts of the ticket.
-
09:08 Revision 18273 (svn): Move changesets to its own tab (#3058).
- Patch by Marius BALTEANU.
-
09:07 Revision 18272 (svn): Show issue history in tabs (#3058).
- Patch by Marius BALTEANU.
-
09:06 Revision 18271 (svn): Allow tabs to have a custom action (#3058).
- Patch by Marius BALTEANU.
-
09:06 Revision 18270 (svn): Merged r18269 from trunk to 4.0-stable in order to revert r18246 (#31582, #31365).
-
08:57 Revision 18269 (svn): Reverts r18245 (#31582, #31365).
- Issue subjets are truncated in some cases when they are created via email.
-
08:50 Feature #306: Full Text Search of files
- This is a nice feature but it should go along with a more appropriate search engine. It also add
Scanning megs or gigs of text files (eg log files attached to tickets) with a simple sql LIKE would quickly kill the search. -
08:46 Defect #31582 (Confirmed): Issue subject may be truncated if the subject field in the receiving email is split into multiple lines in singlebytes and multibytes mixed
-
08:42 Defect #31582: Issue subject may be truncated if the subject field in the receiving email is split into multiple lines in singlebytes and multibytes mixed
- This is caused by patch #31365.
I think this is a severe problem and r18245 must be reverted. -
08:38 Defect #31232 (Closed): Text may unexpectedly be enclosed in pre tags when an issue is created via HTML email
- Committed, thanks.
-
08:38 Revision 18268 (svn): Text may unexpectedly be enclosed in pre tags when an issue is created via HTML email (#31232).
- Patch by Go MAEDA.
-
08:33 Feature #13803 (Closed): Implement grouping issues by date (start, due, creation, update, closing dates)
- Go MAEDA wrote:
> An issue regarding this feature has been reported as #30288.
It was fixed in r17745. -
08:33 Defect #31093 (Closed): Duplicate method definition: ProjectsControllerTest#test_jump_should_not_redirect_to_unknown_tab
- Fixed in r18267, thanks.
-
08:33 Revision 18267 (svn): Duplicate method definition in tests (#31093).
-
08:30 Defect #30288: Groups are incorrect when grouping by date without user timezone set
- Removing the target version. This fix is a part of #13803 which will be delivered in upcoming 4.1.0, so it is not necessary to publish in the changelog.
-
08:24 Defect #30288 (Closed): Groups are incorrect when grouping by date without user timezone set
- Patch committed, thanks!
-
08:29 Defect #30949 (Closed): Roadmap shows 100%, but one of its tasks is still set to 90%
- Patch and test committed, thanks to both of you.
-
08:29 Revision 18266 (svn): Test for #30949.
- Patch by Marius BALTEANU.
-
08:29 Revision 18265 (svn): Roadmap shows 100%, but one of its tasks is still set to 90% (#30949).
- Patch by Bernhard Rohloff.
-
08:23 Revision 18264 (svn): Groups are incorrect when grouping by date without user timezone set.
-
08:13 Defect #29581 (Closed): Issues in paginated views may be lost because sorting criteria are not unique
- Patch committed, thanks.
-
08:13 Revision 18263 (svn): Issues in paginated views may be lost because sorting criteria are not unique (#29581).
- Patch by Mizuki ISHIKAWA.
-
08:12 Revision 18262 (svn): ffi gem is missing for running tests on windows.
-
08:08 Feature #28392: Improve wiki headings style
- Jean-Philippe Lang has removed border-bottom property for headings in r10102. I think it is better not to add a bottom border on ".wiki h1".
-
07:24 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
- Marius BALTEANU wrote:
> My main concern regarding the proposed solution is that there is no way for the user to control the notification emails, he'll be notified every time when someone will mention him.
I think it is the ideal be...