Project

General

Profile

Activity

From 2019-09-03 to 2019-09-05

2019-09-05

20:35 Patch #30448: Remove wrapper2 and wrapper3 wrapping containers
Actively maintained themes have to be anyway patched on per minor release basis, and not actively maintained themes shouldn't be our responsibility really. I bet those wrappers aren't even the most important things that may affect things... Anonymous
16:58 Feature #31921: Changes to properly support 4 byte characters (emoji) when database is MySQL
I updated Marius's patch:
* Removed "with ruby1.9". The version of Ruby is unnecessary because Redmine no longer supports Ruby 1.8 that require 'mysql' adapter instead of 'mysql2' adapter. Please see the example file in Redmine 2.6 fo...
Go MAEDA
13:54 Feature #31989: Inline issue auto complete (#) in fields with text-formatting enabled
I think it is better to add @requireLeadingSpace: true@ in order to prevent the auto-complete menu from being displayed while typing the second "#" in "#123#note-4" or "@" in "foo@example.com". Go MAEDA
13:21 Patch #32019 (Closed): Remove unnecessary scroll indicator from Gantt page
Committed the fix as a part of #27672. Thank you for reporting and fixing this issue. Go MAEDA
06:02 Patch #32019: Remove unnecessary scroll indicator from Gantt page
LGTM. This superfluous scrollbar was introduced by r18171 as part of #27672. Mischa The Evil
02:18 Patch #32019: Remove unnecessary scroll indicator from Gantt page
The vertical scrollbar in the gantt is useless even when there are many issues. I think it is no problem to remove it.
Setting the target version to 4.1.0.
Go MAEDA
13:20 Revision 18439 (svn): Remove unnecessary vertical scroll bar from gantt (#32019, #27672).
Patch by Antonio McDeal. Go MAEDA
12:31 Patch #32023 (Closed): Add missing fixtures to IssueStatusesControllerTest
Committed the patch. Thank you for fixing the issue. Go MAEDA
09:52 Patch #32023 (Closed): Add missing fixtures to IssueStatusesControllerTest
@IssueStatusesControllerTest#test_index_should_show_warning_when_no_workflow_is_defined@ has failed. Yuichi HARADA
12:30 Revision 18438 (svn): Add missing fixture to IssueStatusesControllerTest (#32023).
Patch by Yuichi HARADA. Go MAEDA
12:26 Feature #32002: Add inherit_members to projects API response
Thank you. Alex Sinav
06:11 Feature #32002 (Closed): Add inherit_members to projects API response
Committed the patch. Thank you for your contribution.
Alex Sinav wrote:
> So is there plans to update REST API with this feature?
It will be available in upcoming Redmine 4.1.0, stay tuned. Thank you for reporting this.
Go MAEDA
03:24 Feature #32002: Add inherit_members to projects API response
LGTM. Setting the target version to 4.1.0. Go MAEDA
02:08 Feature #32002: Add inherit_members to projects API response
I fixed to return @inherit_members@ for @GET /projects/:id.(xml|json)@ and @GET /projects.(xml|json)@.
I attached a patch.
Yuichi HARADA
11:54 Defect #32024 (Closed): Broken gzip icon in the repository view
Committed the patch. Thank you for catching and fixing the issue. Go MAEDA
11:46 Defect #32024: Broken gzip icon in the repository view
In my environment, @Redmine::MimeType.css_class_of('foo.gz')@ returns "application-x-gzip" in 2.6-stable but "application-gzip" in 3.0-stable.
Probably it has been broken since Redmine 3.0.
Go MAEDA
09:52 Defect #32024 (Closed): Broken gzip icon in the repository view
Seiei Miyagi
11:54 Revision 18437 (svn): Merged r18435 from trunk to 3.4-stable (#32024).
Go MAEDA
11:53 Revision 18436 (svn): Merged r18435 from trunk to 4.0-stable (#32024).
Go MAEDA
11:49 Revision 18435 (svn): Broken gzip icon in the repository view (#32024).
Patch by Seiei Miyagi. Go MAEDA
10:05 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
Beauty knows no pain! :D It really reduces the amount white (specifically large non-text elements) against oppositely contrasted background in the header though. To be fair we will never know unless a new way on something is shown to use... Anonymous
04:31 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
I prefer not to hide the search box and the project selector. I am afraid that it makes difficult for newcomers to find the features. Go MAEDA
10:02 Feature #2716: User option to automatically add assignee to watchers
kai b wrote:
> Hi, i have forked this plugin on Github and fixed Redmine 4 compatibility:
> ...
It doesn't work with version 4.0.4.stable
If you try make new issue, and assign user - it will crash.
In logs:
Anton Koptsev
09:23 Feature #31154 (Closed): Reject setting RFC non-compliant emission email addresses
Yuichi HARADA wrote:
> Go MAEDA wrote:
> ...
Committed the fix in r18434. Thanks.
Go MAEDA
07:43 Feature #31154: Reject setting RFC non-compliant emission email addresses
Go MAEDA wrote:
> The test sometimes fails:
> ...
I think @::I18n.locale@ was set to @'fr'@ in other tests. I think it will be solved with this patch.
Yuichi HARADA
09:22 Revision 18434 (svn): Fix that test_mail_from_format_should_be_validated randomly fails (#31154).
Patch by Yuichi HARADA. Go MAEDA
09:01 Defect #32022 (Closed): IssueSubtaskingTest fails with high probability
Merged to 3.4-stable. Go MAEDA
08:45 Defect #32022 (Reopened): IssueSubtaskingTest fails with high probability
3.4-stable branch has the same problem. It also can be fixed by backporting r17761. Go MAEDA
07:58 Defect #32022 (Closed): IssueSubtaskingTest fails with high probability
Merged r17761 to 4.0-stable. Go MAEDA
07:17 Defect #32022: IssueSubtaskingTest fails with high probability
I backported r17761 to 4.0-stable and performed the same seed test.
I have confirmed that no fail occurred in IssueSubtaskingTest.
Yuichi HARADA
05:32 Defect #32022: IssueSubtaskingTest fails with high probability
The test assumes that @User.current@ is @AnonymousUser@, who cannot see other user's private issue. The error occurs when @User.current@ is a user whose role has permission to see see other user's private issue.
We can fix the error b...
Go MAEDA
04:43 Defect #32022: IssueSubtaskingTest fails with high probability
I am having been observed this issue since r18359. I think it can be fixed if r17761 is merged to 4.0-stable branch. Go MAEDA
04:38 Defect #32022 (Closed): IssueSubtaskingTest fails with high probability
Go MAEDA
09:00 Revision 18433 (svn): Merged r17761 from trunk to 3.4-stable (#32022).
Go MAEDA
07:58 Revision 18432 (svn): Merged r17761 from trunk to 4.0-stable (#32022).
Go MAEDA
07:01 Feature #28471: Query links for subtasks on issue page
here's how it looks now...
!{border: 1px solid #ccc;}subtask_query_links.png!
Bernhard Rohloff
06:41 Feature #28471: Query links for subtasks on issue page
This patch implements Ewan's proposal. It's quite convenient to filter subtasks this way. Good idea!
Bernhard Rohloff
06:08 Revision 18431 (svn): Add inherit_members to projects API response (#32002).
Patch by Yuichi HARADA. Go MAEDA
02:19 Patch #30435 (Reopened): Replace float rules with flexbox for content and sidebar block
Go MAEDA
02:03 Defect #32012 (Closed): Broken JavaScript icon in the repository view
Go MAEDA
01:59 Defect #32012 (Resolved): Broken JavaScript icon in the repository view
Committed the patch. Thank you for your contribution. Go MAEDA
01:45 Defect #32012: Broken JavaScript icon in the repository view
Confirmed that the icon is not displayed due to r10195 and the attached patch fixes the issue.
!{width: 300px; border: 1px solid #ccc;}.before@2x.png!
!{width: 300px; border: 1px solid #ccc;}.after@2x.png!
Go MAEDA
02:03 Revision 18430 (svn): Merged r18428 from trunk to 3.4-stable (#32012).
Go MAEDA
02:01 Revision 18429 (svn): Merged r18428 from trunk to 4.0-stable (#32012).
Go MAEDA
01:57 Revision 18428 (svn): Broken JavaScript icon in the repository view (#32012).
Patch by Antonio McDeal. Go MAEDA

2019-09-04

21:04 Patch #32021 (New): Give project description, homepage and custom fields an own box too
This patch wraps project information like description, homepage, custom fields in the box if they exist.
Couple of very minor problems with this patch, but aren't catastrophic to not consider proceeding:
1. If a custom field exists a...
Anonymous
19:44 Feature #8095: Allow overriding the default text formatting in each project
Currently, we use the following plugin:
https://www.redmine.org/plugins/per-project-formatting
but it would be nice to have this upstream. Or even per page formatting!
Peter Volkov
19:39 Patch #32016: Rounded corners on roadmap's progress bar
!roadmapbar.png! Anonymous
19:01 Patch #32016 (New): Rounded corners on roadmap's progress bar
Same motivation as for #32013 Anonymous
19:36 Patch #32015: Rounded corners of "my page" blocks
!roundedmypage.png! Anonymous
18:58 Patch #32015 (Closed): Rounded corners of "my page" blocks
Same motivation as in #32013 Anonymous
19:33 Patch #32013: Rounded corners of the main menu
!roundedmenu.png! Anonymous
18:53 Patch #32013 (Closed): Rounded corners of the main menu
Most UI elements of Redmine are now rounded, it feels like main menu should too. Anonymous
19:31 Patch #32014: Rounded corners on table.list elements
!{border: 1px solid; border-color: #ccc; width: 99%;}roundedlisttables.png!
!{border: 1px solid; border-color: #ccc; width: 99%;}roundedlisttables2.png!
Anonymous
18:56 Patch #32014 (Closed): Rounded corners on table.list elements
Same motivation as in #32013
The patch doesn't make calendar and gantt tables rounded though, due to more complex structure that they have, hence requiring different approach.
Anonymous
19:23 Patch #30435: Replace float rules with flexbox for content and sidebar block
To conclude the major point behind this issue, which never got resolved back then, here is a patch to try out as a reference to #30435#note-19 Anonymous
19:18 Patch #32019 (Closed): Remove unnecessary scroll indicator from Gantt page
!Capture.PNG! Anonymous
19:16 Patch #32018: Visually consolidate project selector and the popup box with the projects
This looks the best when #32017 is applied, else there will be border between bar and the box. Anonymous
19:14 Patch #32018 (New): Visually consolidate project selector and the popup box with the projects
!preview.png! Anonymous
19:11 Patch #32017 (Closed): A much happier blue palette for the header (#header + #top-menu)
This patch also makes search bar + project selector "camouflage" a bit until clicked.
!newheader.png!
!focusedsearchbar.png!
!focusedselector.png!
Anonymous
18:50 Defect #32012 (Closed): Broken JavaScript icon in the repository view
Related to #11621 Anonymous
12:21 Feature #32009 (New): Allow to directly edit Issues
Hi,
thanks for this amazing application, we introduced redmine in our company and it works great sofar. But people are complaining about the following:
Before editing or writing a comment they must press edit. So I am thinking abo...
Jannis Hübl
11:59 Feature #32002: Add inherit_members to projects API response
So is there plans to update REST API with this feature? Alex Sinav
02:34 Feature #32002: Add inherit_members to projects API response
Unfortunately, @GET /projects/:id.(xml|json)@ and @GET /projects.(xml|json)@ don't return @inherit_members@. I think the APIs should have been updated when the feature was added in Redmine 2.3.0 (#5605). Go MAEDA
10:01 Feature #32005 (New): Better Category Handling
One of my central projects had become hard to manage so I split out about 25% of the functionality into a new project. As I set about moving 100's (and soon 1000's) of tasks to the new project I realised a major drawback of my approach -... Ewan Makepeace
09:39 Defect #30467 (Closed): Footer is not placed at the bottom on pages with little content
Committed the patch. Thank you for your contribution. Go MAEDA
07:15 Defect #30467: Footer is not placed at the bottom on pages with little content
I had a chat with Go and it's OK for him, so LGTM! :-) Bernhard Rohloff
09:38 Revision 18427 (svn): Footer is not placed at the bottom on pages with little content (#30467).
Patch by Bernhard Rohloff. Go MAEDA
09:29 Revision 18426 (svn): add newline at end of config/settings.yml
Toshi MARUYAMA
08:16 Feature #31321 (Closed): Option not to block closing a parent issue when its subtask is open
Duplicate of #28492. Toshi MARUYAMA
08:12 Feature #31322 (New): Provide a way to automatically close all open subtasks too when a parent issue is being closed
I don't think this issue is duplicate of #28492. Toshi MARUYAMA
07:35 Revision 18425 (svn): code cleanup: rubocop: fix Layout/SpaceBeforeFirstArg in test/unit/lib/redmine/scm/adapters/git_adapter_test.rb
Toshi MARUYAMA
04:00 Defect #32003 (Confirmed): Project copy always send email notifications ignoring "Send email notifications during the project copy" option
When copying a project in the projects list(Administration > Projects), you can disable sending an email by unchecking the "Send email notifications during the project copy" checkbox.
However, even if this checkbox is unchecking, email ...
Yuichi HARADA
03:35 Defect #31900: Problem with tickets issued by rdm-mailhandler on redmine 4.0.4
My coworker looked into this but we could not reproduce the problem. The email you sent to me was correctly parsed after replacing rdm-mailhandler.rb with the latest one. Go MAEDA
02:40 Patch #31556: Update Rouge to 3.12.0
Updated Rouge to 3.10.0 in r18424. Go MAEDA
02:40 Revision 18424 (svn): Update Rouge to 3.10.0 (#31556).
Go MAEDA
02:19 Feature #31921: Changes to properly support 4 byte characters (emoji) when database is MySQL
I think the change against test/unit/issue_test.rb should not be merged because it may break tests on the official CI server if the encoding of the MySQL database on the CI server is not utf8mb4.
http://www.redmine.org/builds/
No one...
Go MAEDA

2019-09-03

23:31 Feature #32002 (Closed): Add inherit_members to projects API response
I didn't found a way to get inherit_members field value of project via REST API.
According to docs - https://www.redmine.org/projects/redmine/wiki/Rest_Projects#Showing-a-project - this field doesn't returned by "GET /projects/[id].xml"...
Alex Sinav
11:15 Feature #32000 (New): abstraction layer for notifications
Redmine provides an email notification feature. These days email is only one channel for notifications. Many organisations switch to different messaging based architectures to notify users (chat, message hubs, ...) and phase out email.
...
Heiko Robert
11:07 Feature #31978 (Needs feedback): Multiple trackers id and multiple status id in get issue rest api redmine
The API already supports multiple IDs. Please use '|'. Does this work for you? Go MAEDA
10:03 Feature #31921: Changes to properly support 4 byte characters (emoji) when database is MySQL
Marius BALTEANU wrote:
> Go Maeda, it is ok from you point of view to set only the encoding to @encoding: utf8mb4@?
Yes, I think it is OK.
But I am not sure whether the comment "# Remove encoding for existing installation on MySQ...
Go MAEDA
09:17 Feature #31921: Changes to properly support 4 byte characters (emoji) when database is MySQL
Go Maeda, it is ok from you point of view to set only the encoding to @encoding: utf8mb4@? Marius BĂLTEANU
09:42 Revision 18423 (svn): Code cleanup: RuboCop: Fix Performance/InefficientHashSearch
Go MAEDA
09:14 Feature #31735 (Closed): Select the language on login
Thanks for your feedback. Marius BĂLTEANU
09:12 Feature #31735 (Resolved): Select the language on login
I have made a mistake,
I have a redmine server installed in my office, in the login configuration, i didn't see that we could choose the language
The checkbox "force to the default language" was checked
So the feature is already av...
Olivier Reyre
09:02 Feature #26521: Identify over-allocated resource
I meant, we cannot see when the ressources are overloaded when we plan developments
we can affect two tasks to the same ressource for the same day, if we could be warned, that would be very helpfull
Olivier Reyre
08:56 Defect #30467: Footer is not placed at the bottom on pages with little content
Bernhard, I've tested your patch in several browsers (including IE 11 and Edge) and it works very well, nice job.
I would love to see this fixed in version:"4.1.0" along with #30435. It's very annoying to see the footer and the sideb...
Marius BĂLTEANU
08:34 Feature #31989: Inline issue auto complete (#) in fields with text-formatting enabled
Go MAEDA wrote:
> * How about getting the project identifier from the body["class"] element (@<body class="theme-Default project-ecookbook has-main-menu ...@)? We don't have to avoid updating multiple views?
I wish to be so easy, but i...
Marius BĂLTEANU
02:58 Feature #31989: Inline issue auto complete (#) in fields with text-formatting enabled
* How about getting the project identifier from the body["class"] element (@<body class="theme-Default project-ecookbook has-main-menu ...@)? We don't have to avoid updating multiple views?
* I think @user auto-complete should be implem...
Go MAEDA
08:28 Patch #31999: Add missing fixtures to TimelogCustomFieldsVisibilityTest
Removing the target version.
Since test_edit_should_not_show_custom_fields_not_visible_for_user was added by #31859, the reported error does not affect to 4.0-stable. r18422 should be considered as a part of #31859.
Go MAEDA
08:17 Patch #31999 (Closed): Add missing fixtures to TimelogCustomFieldsVisibilityTest
Committed the fix. Thank you. Go MAEDA
07:25 Patch #31999 (Closed): Add missing fixtures to TimelogCustomFieldsVisibilityTest
TimelogCustomFieldsVisibilityTest has failed. Yuichi HARADA
08:16 Revision 18422 (svn): Add missing fixtures to TimelogCustomFieldsVisibilityTest (#31999).
Patch by Yuichi HARADA. Go MAEDA
05:46 Patch #31997 (Closed): Traditional Chinese translation (to r18420)
Committed the patch.
Thank you for your contribution.
Go MAEDA
05:38 Patch #31997 (Closed): Traditional Chinese translation (to r18420)
* New tags added
** text_no_subject, setting_password_required_char_classes, label_password_char_class_uppercase, label_password_char_class_lowercase, label_password_char_class_digits, label_password_char_class_special_chars, text_chara...
ChunChang (Nagaharu) Lo
05:46 Revision 18421 (svn): iTraditional Chinese translation (#31997).
Patch by ChunChang Lo. Go MAEDA
 

Also available in: Atom