Activity
From 2020-01-28 to 2020-01-30
2020-01-30
-
16:38 Feature #8241: Advanced notification: per user, per project configurable schedule, event filter and notification format
- +1
-
16:06 Patch #32927: CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific
- No, we should not ;) But I think this specific test is too precise. It will break as soon as the table is modified, even if the tested function has not changed.
But feel free to close my issue if you prefer to not update the current t... -
15:20 Patch #32927: CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific
- Plugins often break core tests. Should we relax tests every time a plugin the test suite?
-
14:27 Patch #32927 (Closed): CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific
- Hi
Just a tiny patch which makes a test less specific. This way, a plugin can add columns to the table without breaking core tests.
Thank you -
15:47 Patch #32918 (Closed): Czech translations
- Committed the patch. Thank you.
-
15:46 Revision 19484 (svn): Czech translation update (#32918).
- Patch by Pavel Rosický.
-
15:43 Patch #32928 (Closed): Czech translation for 4.1-stable
- Committed the patch. Thank you for your contribution.
-
15:37 Patch #32928 (Closed): Czech translation for 4.1-stable
- Originally posted by Pavel Rosický as #32918.
-
15:42 Revision 19483 (svn): Merged r19482 from trunk to 4.1-stable (#32928).
-
15:40 Revision 19482 (svn): Czech translation update for 4.1-stable (#32928).
- Patch by Pavel Rosický.
-
15:26 Patch #32917 (Closed): Bulgarian translation
- Committed the patch. Thank you for your contribution.
-
15:26 Revision 19481 (svn): Bulgarian translation update (#32917).
- Patch by Ivan Cenov.
-
12:28 Patch #32922 (Resolved): Reload detached attachments
- sry, thanks for catching this, I was confused about the comment. Closing
-
08:13 Patch #32922: Reload detached attachments
- Thanks Pavel for posting the patches for Rails 6 update.
I've applied this patch on the current trunk and a test fails: -
00:57 Patch #32922 (Closed): Reload detached attachments
- use #reload instead, after upgrading to Rails 5
-
11:55 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note
- +1 for this
-
09:34 Defect #32477 (Resolved): Right-aligned TOC tag is displayed in exported PDF if the text formatting setting is Markdown
- Committed the patch.
-
09:34 Revision 19480 (svn): Right-aligned TOC tag is displayed in exported PDF if the text formatting setting is Markdown (#32477).
- Patch by Yuichi HARADA.
-
09:19 Feature #16006: Include attachments in forum post notifications
- Yuichi HARADA wrote:
> Perhaps I think that Message's callback method @after_create_commit@ ( "Message#send_notification":https://www.redmine.org/projects/redmine/repository/entry/trunk/app/models/message.rb#L126 ) fired before saving t... -
08:47 Defect #5354: Updating custom fields does not trigger update to "updated_on" field in the customized object
- Setting the target version to 4.2.0.
-
08:16 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Thanks, patch from #note-5 is the correct one, you can commit it. -
06:27 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Marius BALTEANU wrote:
> Sorry, I've attached a broken patch, please revert it and will post later the correct one.
Done. -
06:27 Revision 19479 (svn): Reverts r19478 (#32897).
-
04:45 Patch #32924 (Closed): tmp/pdf directory is no longer necessary
- We can remove the following code because @tmp/pdf@ directory that is used when generating pdf files is no longer used after r13358.
Curentry, the PDF library rbpdf uses tmp instead of tmp/pdf as a temporary directory. -
03:34
Defect #32916: Bar length is wrong when exporting gantt chart to PDF
- Improved bar length calculation accuracy for exporting to PDF (and png).
(modified patch code) -
02:53 Feature #32240: Add download buttons in Files columns of the issues list
- LGTM. Setting the target version to 4.2.0.
-
02:46 Feature #3088: Estimated hours field able to hide role based
- Go MAEDA wrote:
> Now the patch cannot be applied cleanly.
Fixed the patch to work on the current trunk(r19478). -
01:00 Defect #32923 (Closed): Rails 6: detach attachments when a conflict occurs
- fixes
2020-01-29
-
23:06 Defect #32921 (Closed): Rails 6: add header=present to csv tests
- fixes
-
22:38 Patch #32909: Replace pluck().first with pick()
- Looks good to me.
-
11:33 Patch #32918 (Closed): Czech translations
-
08:07 Patch #32917 (Closed): Bulgarian translation
- * field_toolbar_language_options
* label_user_mail_notify_about_high_priority_issues_html -
06:15
Defect #32916 (Closed): Bar length is wrong when exporting gantt chart to PDF
- When exporting a gantt chart to PDF, short (1 or 2 days) tasks are sometimes correct and sometimes incorrect, depending on the time period.
(The attached image is modified.)
!{width:500px}gc2pdf.png!
Calculation error of start and e... -
05:58 Defect #32737: Duplicate sort keys for issue query cause SQL error with SQL Server
- Go MAEDA wrote:
> Maybe also this patch will work.
Execute tests on SQL Server, 12 test failures (500: Internal Server Error. I think duplicate ORDER BY clauses are involved) and 16 execution errors (duplicate ORDER BY clause) occurr... -
05:44 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects
- Simon Hori wrote:
> Now it works perfectly fine with my MS Outlook!!
> ...
Thank you for the test result. Setting the target version to 4.0.7. -
05:37 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects
- Sorry, you are right. I changed a wrong line in `dragOutHandler` but it must be added to `dragOverHandler` as you wrote.
Now it works perfectly fine with my MS Outlook!!
No deletion occurred after a drag-drop. Thank you.
I hope th... -
04:07 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects
- Simon Hori wrote:
> Thanks for the patch! I believe I added the two lines properly to the js but unfortunately it is still deleting the item from my Outlook and this error is logged when mouse over to the drop area.
> ...
attachments.j... -
03:41 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects
- Thanks for the patch! I believe I added the two lines properly to the js but unfortunately it is still deleting the item from my Outlook and this error is logged when mouse over to the drop area.
-
05:11
Defect #32915 (New): Internal Server Error occurted when exporting gantt chart to png on Windows
- Redmine 4.0.4 using RMagick was fine.
However, Redmine 4.1.0 using MiniMagick does not work.
prodution.log of Redmine 4.1.0 is this: -
02:07 Defect #32914 (Closed): Rails 6: remove #filename_for_content_disposition for MS browsers
- relates to #32913
this prevents double escaping, fixes -
01:33 Defect #32913 (Closed): Rails 6: add filename header
- fixes
-
00:50 Defect #32912: Rails 6: update no longer bypass optimistic locking
- I'm not sure about test_copy_should_not_copy_subtasks_twice_when_saving_twice which was introduced in https://github.com/redmine/redmine/commit/5003927f13f54850ca9eeac48e353df5e4e325a1
it should be probably refactored in order to refl... -
00:42 Defect #32912 (Closed): Rails 6: update no longer bypass optimistic locking
- fixes test failures
2020-01-28
-
23:39 Patch #32911 (Closed): Rails 6: Fix deprecation warning "Class level methods will no longer inherit scoping"
- fixes
-
23:17 Defect #32910 (Closed): Rails 6: add lookup_context to hook_test.rb
- fixes
-
23:03 Patch #32909 (Closed): Replace pluck().first with pick()
- https://github.com/rails/rails/pull/31941
-
22:56 Defect #32908 (Closed): Rails 6: Sending mail with DeliveryJob is deprecated
- this change isn't compatible with Rails < 6
#29914 -
22:51 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
- Go MAEDA wrote:
>
> ...
Let's do it then. I've prepared "this":https://gitlab.com/redmine-org/redmine/pipelines/113081049 branch on my Gitlab CI instance, it should be easier to track the test fails.
As next steps, I propose to open ... -
14:57 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
- +1 however I guess lot's of plugin developers will need to be notified and start their upgrades as well...
-
06:34 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
- Marius BALTEANU wrote:
> I'm willing to help with this, but I think we should have first a decision (from Jean-Philippe, I guess) regarding next Redmine major version. If we're going to update to Rails 6, we should merge version 4.2.0 t... -
22:36 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Here is the correct patch, please revert r19478 and commit this one.
-
10:55 Defect #32897 (Reopened): Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Sorry, I've attached a broken patch, please revert it and will post later the correct one.
-
10:49 Defect #32897 (Closed): Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Committed the patch. Thank you for your contribution.
-
10:19 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Tests results "here":https://gitlab.com/redmine-org/redmine/pipelines/112841765.
-
22:24 Patch #32907 (Closed): Update capybara (~> 3.31.0)
- the patch reduces warnings for Ruby 2.7 support #31500
https://github.com/teamcapybara/capybara/blob/master/History.md -
21:59 Patch #32906 (Closed): Update i18n (~> 1.8.2)
- the patch reduces warnings for Ruby 2.7 support #31500
https://github.com/ruby-i18n/i18n/releases -
17:42 Feature #1712: add custom fields that are calculations of other fields
- +1
-
10:49 Revision 19478 (svn): Fix 'DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1.' (#32897).
- Patch by Marius BALTEANU.
-
10:32 Patch #18770: Make issue history collapsable
- Can you update for Redmine 4
also, can you create normal patch, not hg one, because I'm getting: -
04:01 Patch #32890 (Closed): Fix violations reported by Stylelint
- Committed the patches. Thank you.
-
04:00 Revision 19477 (svn): Fix duplicate "margin-right" property (#32890).
- Patch by Marius BALTEANU.
-
03:58 Revision 19476 (svn): Remove empty block (#32890).
- Patch by Marius BALTEANU.
-
03:57 Revision 19475 (svn): Fix duplicate selector (#32890).
- Patch by Marius BALTEANU.
-
03:56 Revision 19474 (svn): Fix missing generic font family (#32890).
- Patch by Marius BALTEANU.
-
03:55 Revision 19473 (svn): Fix duplicate "color" attribute (#32890).
- Patch by Marius BALTEANU.
-
03:52 Revision 19472 (svn): Fix duplicate selectors (#32890).
- Patch by Marius BALTEANU.
-
03:48 Revision 19471 (svn): Remove duplicate white-space property (#32890).
- Patch by Marius BALTEANU.
-
02:20 Defect #32896 (Closed): Totals not working in projects list view
-
02:18 Defect #32896: Totals not working in projects list view
- Committed the patch. Thank you for posting the patch so quickly.
-
02:17 Revision 19470 (svn): Merged r19469 from trunk to 4.1-stable (#32896).
-
02:15 Revision 19469 (svn): Fix totals not displayed in projects list view (#32896).
- Patch by Marius BALTEANU.
-
01:34
Defect #32899 (Closed): Javascript error caused by tooltip
- Improved tooltip in Redmine 4.1.0 ( #31441) causes a Javascript error on some (self-made) plugin pages using the "title" attribute.
This is caused by the absence of the tooltip() function in the "title" attribute. By inserting a judgmen... -
01:32
Feature #32898 (Closed): PDF thumbnails support on Windows
- Redmine 4.1.0 don't support PDF thumbnails on Windows. ( #22481 )
For Windows, "gswin64c(32c).exe"(command line version) can be used instead of "gswin64(32).exe".
By applying this diff, we can detect the presence of Ghostscript on Wind...