Redmine

2021-08-11

23:52 Revision 21166 (svn): Fixed Replace class var @@allowlist with a class instance var (#32424).

Marius BĂLTEANU

23:52 Revision 21165 (svn): Render markdown attachments using markdown or common_mark based on the text formatting setting (#32424).

Patch by Marius BĂLTEANU and Martin Cizek. Marius BĂLTEANU

23:51 Revision 21164 (svn): Fixed failing test on CommonMark by striping the trailing whitespace returned by the footnote (#32424).

Marius BĂLTEANU

23:50 Revision 21163 (svn): Fixed Layout/HeredocIndentation: Use 2 spaces for indentation in a heredoc by using <<~ instead of <<- (#32424).

Marius BĂLTEANU

23:50 Revision 21162 (svn): Replace deprecated Sanitize keywords (#32424).

Patch by Martin Cizek. Marius BĂLTEANU

23:49 Revision 21161 (svn): Relax allowed protocols in links by denying specific protocols for CommonMark text formatting (#32424).

Patch by Martin Cizek. Marius BĂLTEANU

23:48 Revision 21160 (svn): Mark CommonMark Markdown (GitHub Flavored) as experimental (#32424).

Marius BĂLTEANU

23:47 Revision 21159 (svn): Pin sanitize to 5.2 (#32424).

Marius BĂLTEANU

23:46 Revision 21158 (svn): Pin html-pipeline to 2.13.2 (#32424).

Marius BĂLTEANU

23:45 Revision 21157 (svn): Pin commonmarker to 0.22 if Ruby version is greater than 2.5 (#32424).

Marius BĂLTEANU

23:40 Revision 21156 (svn): Adds CommonMark Markdown (GitHub Flavored) as third text formatting option (#32424).

Patch by Jens Krämer. Marius BĂLTEANU

22:40 Defect #35655 (Closed): Create duplicated follows relations fails with 500 internal error

Marius BĂLTEANU

22:37 Revision 21155 (svn): Merged r21152 to 4.1-stable (#35634).

Marius BĂLTEANU

22:36 Revision 21154 (svn): Merged r21152 to 4.2-stable (#35634).

Marius BĂLTEANU

22:35 Revision 21153 (svn): Merged r21150 to 4.2-stable (#35655).

Marius BĂLTEANU

21:53 Defect #35731: Password and Confirmation fields are marked as required when editing a user

Looks good to me. Thanks! Holger Just

10:20 Defect #35731: Password and Confirmation fields are marked as required when editing a user

Added test code. Go MAEDA

07:46 Defect #35731: Password and Confirmation fields are marked as required when editing a user

The following patch fixes the issue.... Go MAEDA

07:40 Defect #35731 (Closed): Password and Confirmation fields are marked as required when editing a user

Password and Confirmation are marked as required in UsersController#edit page. However, in actuality, those fields ar... Go MAEDA

21:50 Feature #35658 (Closed): Administration -> Role -> Users Visibility

Holger Just

21:48 Defect #35715: File upload fails when run with uWSGI

uwsgi is certainly an unusual application server... However, as restoring basic support for it should be rather simpl... Holger Just

19:16 Feature #32424: CommonMark Markdown Text Formatting

Thanks Holger for you reply, let's move the discussion about Ruby 2.5 support to #31128 (I've reopen it and I added o... Marius BĂLTEANU

17:26 Feature #32424: CommonMark Markdown Text Formatting

I would be fine with requiring Ruby 2.6 for Redmine 5.0.
Some notes here:
* Debian 11 Bullseye is going to shi... Holger Just

19:15 Feature #31128 (Reopened): Drop Ruby < 2.5 support

I'm reopening this to discuss the option to drop support for Ruby 2.5 as well.
I wrote in #32424#note-62:
> Rails... Marius BĂLTEANU

13:25 Defect #35734 (New): Comments are not shown correctly in Outlookmails when using nummeration where PRE-Blocks are included

If your comment has the following structure
Intro:
# First number
# Second number... Pan Tau

08:38 Defect #35732 (New): Clean up and reorder Redmine Wiki

The structure is getting more and more confused, especially in the area of the instructions in the individual languag... C S

08:23 Defect #35726: Time Formatting does not apply to CSV exports

Good point. Fair enough. FYI, I'm also ok with no back-ports like you propose. My comment was more about the Redmine ... Mischa The Evil

01:17 Feature #15855: Add information about whether an issue is open or closed to Issues API response

I made a patch to implement this improvement and posted it. Takenori TAKAKI

2021-08-10

23:01 Feature #32424: CommonMark Markdown Text Formatting

Rails 6.1 and Redmine version:"5.0.0" supports minimum Ruby 2.5, but the "CommonMarker":https://github.com/gjtorikian... Marius BĂLTEANU

22:26 Revision 21152 (svn): Fixed "Layout/IndentationWidth: Use 2 (not 4) spaces for indentation." introduced by r21141 (#35634).

Marius BĂLTEANU

22:18 Defect #32977 (Needs feedback): Remove references to deleted user from "user"-Format CustomFields

Jens, I've reviewed the patch and it looks good to me, except the test that fails:... Marius BĂLTEANU

22:02 Patch #30448 (Closed): Remove wrapper2 and wrapper3 wrapping containers

Patch committed. Marius BĂLTEANU

21:59 Revision 21151 (svn): Remove wrapper2 and wrapper3 wrapping containers (#30448).

Marius BĂLTEANU

21:56 Patch #35729 (Closed): Update jQuery to 3.6.0

https://blog.jquery.com/2021/03/02/jquery-3-6-0-released/ Marius BĂLTEANU

21:36 Defect #35655 (Resolved): Create duplicated follows relations fails with 500 internal error

Fixed in r21150. Marius BĂLTEANU

21:35 Revision 21150 (svn): Fixed create duplicate follow relation fails with 500 internal error (#35655).

Marius BĂLTEANU

14:55 Defect #19925 (Closed): Arabic settings page - Icons are not aligned correctly

No problem found in Redmine 4.2.2.
!{width: 464px; border: 1px solid grey;}.arabic-admin.png! Go MAEDA

14:38 Defect #35642 (Closed): Long text custom field values are not aligned with their labels

Go MAEDA

14:38 Revision 21149 (svn): Merged r21137 from trunk to 4.1-stable (#35642).

Go MAEDA

14:37 Revision 21148 (svn): Merged r21137 from trunk to 4.2-stable (#35642).

Go MAEDA

14:30 Patch #35727 (Closed): Add missing fixtures to Redmine::ProjectJumpBoxTest

Committed the patch. Thank you. Go MAEDA

03:42 Patch #35727: Add missing fixtures to Redmine::ProjectJumpBoxTest

It was solved with the following patch.... Yuichi HARADA

03:36 Patch #35727 (Closed): Add missing fixtures to Redmine::ProjectJumpBoxTest

Redmine::ProjectJumpBoxTest has failed.... Yuichi HARADA

14:30 Revision 21147 (svn): Add missing fixtures to Redmine::ProjectJumpBoxTest (#35727).

Patch by Yuichi HARADA. Go MAEDA

12:17 Defect #35726: Time Formatting does not apply to CSV exports

I don't think we should backport this to older versions.
The CSV export emits a technical format which is usually ... Holger Just

07:54 Feature #15707: Possibility to limit user access to certain IPs and access method (Web or API)

Hey Mischa, thanks a lot for your comment - we'll look into this! Marco Descher

2021-08-09

22:16 Feature #15707: Possibility to limit user access to certain IPs and access method (Web or API)

Marco Descher wrote:
> The fork in https://github.com/ngiger/redmine_access_filters works against redmine 4.1
I h... Mischa The Evil

07:55 Feature #15707: Possibility to limit user access to certain IPs and access method (Web or API)

We sponsored the creation of an additional plugin for this a few years ago. See https://github.com/MEDEVIT/redmine_ac... Marco Descher

21:52 Defect #35430: Internal error when viewing revisions diff

salman mp wrote:
> Go MAEDA wrote:
> > Does the error occur without plugins?
>
> No, even when using plugins wit... Mischa The Evil

18:31 Defect #35430: Internal error when viewing revisions diff

Go MAEDA wrote:
> Does the error occur without plugins?
No, even when using plugins without any deface on 'layout... salman mp

21:45 Defect #35726 (Confirmed): Time Formatting does not apply to CSV exports

Nice catch! However, this does not only apply to the CSV export of the timelog report. It also applies to CSV exports... Mischa The Evil

18:25 Defect #35726 (Confirmed): Time Formatting does not apply to CSV exports

When you export time report to CSV, formatting does not apply on hours field.
Attached patch can fixed it. salman mp

16:59 Patch #35721: Unlink files after they're closed

The tests were specifically written to simulate the race condition. On Filesystems following the usual POSIX semantic... Holger Just

13:48 Feature #19563 (Closed): Filter Issues based on selected issues only.

Implemented in Redmine 3.3.0. See #4806#note-9 for details. Go MAEDA

13:18 Defect #19179 (Closed): Very slow performance on editing issues when projects have inherit members checked

A fix to improve the performance was delivered in Redmine 3.4.0 (#22850). Closing. Go MAEDA

12:15 Feature #13143: Populate dropdown custom field list based on previous another selection

+1 Nina Lušin

09:22 Feature #12005: Mightful workflow field enhancement: hide

Yeah, the logic is quite simple for custom fields, unfortunately non-custom ("core") fields are treated very differen... David Robinson

07:54 Feature #19169 (Closed): Project link shown as "Project name" for user with no access to it

Any information about the project should not be made available to users who cannot see the project. Go MAEDA

06:29 Feature #5303 (Closed): Add spent_hours to /issues/index API

It has been implemented by #34857 and will be available in Redmine version:5.0.0. Go MAEDA

06:26 Defect #18943 (Closed): REST API does not return spent_hours when listing issues

It has been implemented by #34857 and will be available in Redmine version:5.0.0. Go MAEDA

06:02 Feature #18827 (Closed): "Spent time" custom field - option to choose which projects have it

Closing as a duplicate of #1767. Go MAEDA