Project

General

Profile

Activity

From 2018-09-30 to 2018-10-02

2018-10-02

21:34 Feature #26791: Send individual notification mails per mail recipient
Thank you all for working on the patch and considering its inclusion!
I'll try to get to this tomorrow to fix any remaining test failures. Unfortunately, it's been a crazy week so far and I hadn't had much time so far...
Holger Just
17:31 Feature #26791: Send individual notification mails per mail recipient
Marius BALTEANU wrote:
> [...]
> ...
I think that was an external problem because now the test passes on redmine.org and on my environment as well.
Marius BĂLTEANU
00:34 Feature #26791: Send individual notification mails per mail recipient
I looked again in the code and a fix that makes sense for me is the following one: Marius BĂLTEANU
17:06 Patch #6778 (Closed): Wiki compatibility link broken w/o project_id
A long time has passed since the routing changed and no people complain about this recently. Probably few people want this change.
I think we can close this issue.
Go MAEDA
16:48 Defect #27071 (Closed): Error testing LDAPS Connection: "Unable to connect (hostname X.X.X.X does not match the server certificate)"
You will be able to disable a certificate check in upcoming Redmine 4.0.0. See #29606 for details.
Go MAEDA
14:54 Feature #29482: Query system for Projects page
I just discovered this issue and would like to emphasize that these are very useful features - thank you very much for implementing them.
In addition we may be able to help with testing - just let us know if you think that makes sense...
Fabian Schuttenberg
14:06 Feature #29715 (Closed): Allow me to not copy attachments when copying issues
I am really pleased with the current ability to copy issues, and in particular copy groups of issues where all the subtasks get duplicated as well. It lets me bring forward groups of regular tasks from month to month for example.
Howe...
Ewan Makepeace
12:03 Defect #26023 (New): Category filter only shows categories of current project
I think we can deliver this in 4.0.0. Go MAEDA
09:56 Defect #26023: Category filter only shows categories of current project
Thank you for reviewing, Felix.
I also did't notice the visibility caused by permission.
I confirmed that the new patch(attachment:26023_test_added.patch) works fine and passes the tests!
Takenori TAKAKI
12:01 Patch #29710 (Closed): Remove unused variable 'filter_options' from Query#add_filter
Go MAEDA
05:46 Patch #29710: Remove unused variable 'filter_options' from Query#add_filter
Committed. Thank you for detecting and reporting it. Go MAEDA
02:28 Patch #29710 (Closed): Remove unused variable 'filter_options' from Query#add_filter
The variable was changed in r86 along with the instance method Query#add_filter.
However, @filter_options@ is unused.
(In r86, most of the filter_options's processing was comment out.)
I would like to change it as follows.
Yuichi HARADA
11:49 Feature #29660: Add Referrer-Policy header to prevent browsers from sending private data to external sites
Holger Just wrote:
> The most secure variant would probably be @strict-origin-when-cross-origin@ which seems to be supported by the same current set of commonly used browsers which support @origin-when-cross-origin@. Compared to the sho...
Go MAEDA
11:24 Feature #29660: Add Referrer-Policy header to prevent browsers from sending private data to external sites
Hi,
If you look at HTTP Headers, could you have a look to #29405
Best regards
Ludovic Andrieux
10:14 Feature #29660: Add Referrer-Policy header to prevent browsers from sending private data to external sites
Holger Just wrote:
> If we also want to specifically support IE, we should use @origin@. However, this would impact most local log analyzer software people might use on their Redmine installations as user flows can not be followed anymo...
Gregor Schmidt
09:36 Feature #29660: Add Referrer-Policy header to prevent browsers from sending private data to external sites
Using Referrer-Policy HTTP header is a great idea. Ebrahim Mohammadi
11:06 Defect #29706: Unable to setup filter for query
Thank you very much for the response.
For more clarity, in our Redmine 3.4.6, after the field 'Status' is selected for the filter, there is nothing further that becomes available to select - no 'open', no 'is', no 'is not', no 'closed',...
mark f
09:12 Feature #29712 (Closed): Preview and wiki toolbar for full width custom fields
Currently, full-width custom fields don't have preview feature and wiki toolbar.
Since those look like a description field, I think it would be great and makes UI consistent to have preview and toolbar.
!{width: 707px; border: 1px ...
Go MAEDA
07:21 Feature #29449: Filter out issues from closed projects in My Page blocks
Thanks Yuichi for working on this. Yes, it should work, but it is not enough because users will have inconsistent results between the issues returned by the widgets and the issues returned in the Issues list when they click on the widget... Marius BĂLTEANU
07:06 Feature #29449: Filter out issues from closed projects in My Page blocks
If #29482 was not considered, I think that it will be solved by changing it as follows. Yuichi HARADA
05:05 Defect #28874 (Needs feedback): MailHandler does not log exceptions caught
Go MAEDA
04:31 Defect #28874: MailHandler does not log exceptions caught
In my environment, it works normally.
With Gmail IMAP enabled, we did the following steps.
1. Insert *@raise "An error occurred"@* in source:trunk/app/models/mail_handler.rb#L28.
2. Run the rake task.(rake redmine:email:receive_imap...
Yuichi HARADA
04:14 Defect #29708 (Closed): Wrong use of refute_includes in tests
Committed. Thanks. Go MAEDA
02:10 Defect #29708: Wrong use of refute_includes in tests
That makes sense to me. Mizuki ISHIKAWA

2018-10-01

22:54 Feature #26791: Send individual notification mails per mail recipient
Jean-Philippe Lang wrote:
> Thanks Marius, your patch applies cleanly but I get a few test failures: IP address is blank in security notifications.
Sorry Jean-Philippe, I'm not sure how to fix the failing test and I need more time to...
Marius BĂLTEANU
21:35 Feature #26791: Send individual notification mails per mail recipient
Thanks Marius, your patch applies cleanly but I get a few test failures: IP address is blank in security notifications. Jean-Philippe Lang
17:25 Feature #26791: Send individual notification mails per mail recipient
Holger, can you take a look to my updated patch or update your first patch to apply cleanly? Marius BĂLTEANU
21:49 Defect #29708 (Closed): Wrong use of refute_includes in tests
The "@refute_includes@ assertion":https://www.rubydoc.info/gems/minitest/5.11.3/Minitest/Assertions#refute_includes-instance_method expects the @collection@ first and the @object@ to test for after. The test in source:/trunk/test/functio... Felix Schäfer
21:39 Defect #26023: Category filter only shows categories of current project
Takaki-san thank you very much for your tests, I have been able to integrate them in my patch. I hope you will be mentioned as author of this patch too.
I have reworked two small syntax details in the patch. I have also noticed a visi...
Felix Schäfer
17:31 Feature #29660: Add Referrer-Policy header to prevent browsers from sending private data to external sites
The most secure variant would probably be @strict-origin-when-cross-origin@ which seems to be supported by the same current set of commonly used browsers which support @origin-when-cross-origin@. Compared to the shorter option, the stric... Holger Just
10:05 Feature #29660: Add Referrer-Policy header to prevent browsers from sending private data to external sites
This seems to be a sensible improvement. It does not impact the behavior for users on IE/Edge, but it improves privacy for users of Chrome, Firefox, Safari.
I also agree, that using an HTTP header is the better option.
However, I a...
Gregor Schmidt
16:59 Defect #29686 (Closed): Date format in issues pages
This interface is rendered by your webbrowser (where available) and thus usually follows the interface conventions of your operating system.
In the case of Firefox, the browser seems to use settings based on the locale of your operati...
Holger Just
16:39 Defect #29706 (Needs feedback): Unable to setup filter for query
When filtering issues, Redmine by default shows all open issues (i.e. all issues with a status which is not defined as closed) This should look like this:
!filter@2x.png!
To chose a specific status, yu can select *is* and define th...
Holger Just
13:26 Defect #29706 (Closed): Unable to setup filter for query
We have Redmine 3.4.6.
When trying to create a custom query, cannot setup a filter for a query.
For example, if I wanted to create a query that showed all open issues, you would choose a filter on the field 'Status' and then criteria w...
mark f
13:52 Patch #29696 (Closed): Japanese translation update (r17530)
Committed. Go MAEDA
12:02 Patch #29702 (Closed): Brazilian wiki help translation update
Committed the patch translated by Patrick Kaminski.
Thank you for your contribution.
Go MAEDA
05:42 Patch #29702 (Closed): Brazilian wiki help translation update
Copied from #29698. Go MAEDA
11:43 Feature #2770: Display of inline attached images in email notification
+1. Is there an update about this issue? Erich Balan
11:43 Patch #28509: hu.yml for Redmine 3.4
It is the only sane order so that we can use tools like _vimdiff -o hu.yml en.yml_ and see the related strings together so that we can guess the context and use a consistent style.
It's a huge work: complete (at the time) translation (a...
Greg T
11:09 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique
Setting target version to 4.1.0. Go MAEDA
11:00 Patch #29395: Pagination between repository entries and attachments of the same container
Felix Gliesche wrote:
> Here is an update to the patch, that should fix the before mentioned case.
Thank you for updating the patch. But I could not find differences between before and after applying 0004-Let-pagination-always-be-vis...
Go MAEDA
05:58 Patch #29703 (Closed): Brazilian translation (jstoolbar-pt-br.js) update
Go MAEDA
05:56 Patch #29703: Brazilian translation (jstoolbar-pt-br.js) update
Committed the patch translated by Patrick Kaminski.
Thank you for your contribution.
Go MAEDA
05:44 Patch #29703 (Closed): Brazilian translation (jstoolbar-pt-br.js) update
Copied from #29698. Go MAEDA
04:15 Defect #29701 (Closed): Custom queries are broken by updating with nil parameter values
Steps to reproduce:
1. Open the issues list and move some columns to "Selected Columns" list box in the filter options. In the screenshot below, "Start date" and "Due date" is the column. You will see those 2 columns in the issues lis...
Go MAEDA
00:30 Defect #28609 (Closed): Error 404 on configure plugin
Please contact the author of those plugins. Go MAEDA

2018-09-30

18:46 Patch #29698 (Closed): Brazilian translation update
Hello everyone!
I'm sending 4 patches with updates for the Brazilian Portuguese translation...
* pt-BR
* jstoolbar
* wiki markdown
* wiki textile
Patrick Kaminski
18:41 Feature #26237: Support wiki_page_title attribute in Versions REST API
Is it possible to get this in 4.0.0? It's a small fix, so I guess it's not a problem to change the target release. Kenan Dervisevic
18:32 Feature #24681 (Closed): Syntax highlighter: replace CodeRay with Rouge
I'm closing this because the unwanted change was reverted by r17537. Marius BĂLTEANU
15:33 Patch #29697 (Closed): Czech translation fixes
Committed. Thank you for improving Redmine. Go MAEDA
15:22 Patch #29697 (Closed): Czech translation fixes
Separated translation change from #28372. Go MAEDA
15:29 Patch #28372 (Closed): Czech translation update
Committed. Thank you for your contribution. Go MAEDA
15:27 Patch #28372: Czech translation update
Separated translation changes to #29697.
This issue handles a newly translated string.
Go MAEDA
14:34 Patch #28509: hu.yml for Redmine 3.4
Thank you for your contribution. But the file is hard to check because translation keys are reordered. Please don't reorder keys in the file and could you provide a diff file? Go MAEDA
14:16 Patch #29696 (Closed): Japanese translation update (r17530)
Translated the following strings.
* label_ldaps_verify_none
* label_ldaps_warning
* label_nothing_to_preview
Go MAEDA
11:58 Feature #8016: Drag-and-drop issue (ticket) ordering
+1 Nadav Kavalerchik
11:39 Defect #29695 (New): Duplicated assignee option when selecting a category with default assignee
1. Go to a project with a default category assignee
2. Go to new issue page
3. Select the category with the default assignee
4. Open the Assignee dropdown
5. Observe that the default category assignee is duplicated in the dropdown.
...
Marius BĂLTEANU
11:24 Feature #26791: Send individual notification mails per mail recipient
My last shot. Marius BĂLTEANU
11:14 Feature #26791: Send individual notification mails per mail recipient
Jean-Philippe Lang wrote:
> Thank you Marius, but still I get many conflicts when trying to apply your patch on current trunk.
Let me take a look, maybe I missed something.
Marius BĂLTEANU
11:13 Feature #26791: Send individual notification mails per mail recipient
Thank you Marius, but still I get many conflicts when trying to apply your patch on current trunk. Jean-Philippe Lang
11:13 Defect #29694 (New): Some buttons in wiki toolbar are hidden in responsive layout
#27758#note-8 by Marius BALTEANU:
> on responsive mode, when the screen resolution width in less than the total width of the js toolbar (tabs + buttons), some buttons become hidden. I'm not happy with the current solution, but is not a ...
Go MAEDA
11:01 Feature #27758 (Closed): Adds preview option to the wiki toolbar
Marius BALTEANU wrote:
> IMHO, we can deliver this as it is and we'll fix it in the next minor release when for sure we will have other small improvements to be done for this feature.
I agree with you. Since it is a small issue, it s...
Go MAEDA
09:19 Feature #27758: Adds preview option to the wiki toolbar
Go MAEDA wrote:
> Takeshi Nakamura wrote:
> ...
I know the issue, I've mentioned about this in note-8 ("- on responsive mode, when the screen resolution width in less than the total width of the js toolbar (tabs + buttons), some button...
Marius BĂLTEANU
06:11 Feature #27758 (Reopened): Adds preview option to the wiki toolbar
Takeshi Nakamura wrote:
> Toolbar buttons are not wrapped when the screen is narrow.
Marius, could you look into this?
Go MAEDA
06:06 Feature #27758: Adds preview option to the wiki toolbar
Toolbar buttons are not wrapped when the screen is narrow.
*Redmine 4.0*
!toolbar-4.0.png!
*Redmine 3.4*
!toolbar-3.4.png!
Takeshi Nakamura
06:01 Defect #29259: Attachment preview does not work for some source files such as JavaScript and Go
Since we have moved from CodeRay to Rouge, we cannot use the proposed @is_code@ method. Go MAEDA
05:57 Defect #20758 (Closed): Ampersand+keyword in code highlighting
The bug that "&" is changed to "x%x%" in the text passed to the syntax highlighter has been fixed in r17532. Please see source:trunk/lib/redmine/wiki_formatting/textile/formatter.rb@17532#L128
Please note that Redmin...
Go MAEDA
 

Also available in: Atom