Project

General

Profile

Activity

From 2019-02-15 to 2019-02-17

2019-02-17

23:26 Feature #3816 (Closed): Allow pasting screenshots from clipboard
Committed the patch. Now you can paste images from clipboard if you use modern browsers except for Edge and IE11.
I modified the patch to generate a filename like 'clipboard-yyyymmddHHMM-a1b2c.png' that is a bit shorter than Takenori ...
Go MAEDA
17:15 Feature #3816: Allow pasting screenshots from clipboard
Go MAEDA wrote:
> Marius, thank you for reviewing and improving the patch.
> ...
I don't have any preference for the filename, I chose to change it only because I found it simpler to have 1 line of code instead of 4 lines. You can reve...
Marius BĂLTEANU
16:15 Feature #3816: Allow pasting screenshots from clipboard
Marius, thank you for reviewing and improving the patch.
> - simplified the filename generation
The previous patch generates a filename like 'clipboard-201902181323-a1b2c3d.png'. I prefer to include a date like '20190217' in the fi...
Go MAEDA
15:00 Feature #3816: Allow pasting screenshots from clipboard
I've made some small changes to the patch, the most important is the check for @e.clipboardData || e.originalEvent.clipboardData@ in order to not throw errors in the console when the clipboardData doesn't exist (for example: IE11).
An...
Marius BĂLTEANU
23:11 Feature #13111: New setting to include the status changes in issue mail notifications subject
Gmail is one of the most used email clients and I think it should be very nice to support email threading. The rule is simple, the subject of the email must be the same.
Go Maeda, do you think that we should do this configurable (ex: ...
Marius BĂLTEANU
23:05 Defect #11593 (Closed): Error 500 on child issue with no start date
Marius BĂLTEANU
21:05 Feature #26791: Send individual notification mails per mail recipient
Holger Just wrote:
> h3. BCC recipients
> ...
I've attached a patch to #30820 to drop the bcc setting.
Marius BĂLTEANU
21:04 Defect #30787: Other recipients are not listed in To field even if Setting.bcc_recipients is false
Go Maeda, please let us know what it the purpose of this defect. Marius BĂLTEANU
21:03 Defect #30787: Other recipients are not listed in To field even if Setting.bcc_recipients is false
Holger Just wrote:
>
> ...
Thanks for pointing to your comment, I've attached a patch to (#30820).
Marius BĂLTEANU
21:00 Feature #30820 (Closed): Drop setting "Blind carbon copy recipients (bcc)"
From #26791:
> h3. BCC recipients
> ...
I agree, the setting doesn't make any sense now.
Marius BĂLTEANU
18:20 Defect #13888: Daylight savings causes inconsistency of Message-Id in emails
Go MAEDA wrote:
> We don't have to care about daylight savings if we always use UTC when generating a message-id.
> ...
yep, I agree
pasquale [:dedalus]
13:38 Defect #13888: Daylight savings causes inconsistency of Message-Id in emails
We don't have to care about daylight savings if we always use UTC when generating a message-id. Go MAEDA
15:31 Defect #29276: Autocomplete does not show anything
I've attached the patch to #30818. Marius BĂLTEANU
15:30 Patch #30818 (Closed): Issues autocomplete should respond with content type json
Currently, @issues/auto_complete@ respond with: Marius BĂLTEANU
14:57 Defect #17096: Issue emails cannot be threaded by some mailers due to inconsistent Message-ID and References field
Go MAEDA wrote:
> I think that adding consistent Message-Id and References filed will be easier if per user notification sending is implemented by #26791. We don't have to use random_hex in Mailer.token_for method. Instead, we can use E...
Go MAEDA
11:30 Feature #23980: Replace icon images with Tabler SVG icons
Basically I agree with Go and Jan. It's not an option to make decisions behind JP's back. As much as I share this opinion I can understand Max's intention. This issue is nearly three years old and no decisions are made. So has anybody a ... Bernhard Rohloff
07:49 Feature #1380: Deleting an issue only marks it as being deleted
+1
As a workaround, there is also a way to simply change the project_id of the issue.
(Project_id -> 0, -% Project_id%,% Project_trashcan%)
The following requirements can be satisfied.
1.Even if you specify the ticket number, i...
Yuuki NARA
06:15 Patch #16069: Allow configuration of API limit instead of hardcoding at 100
+1
I think that it should be changeable by the responsibility of the system administrator.
There are many configuration items in the world system that may cause troubles due to setting change contents.
Since there are cases where ...
Yuuki NARA
06:02 Defect #30785: Mail handler does not ignore emails sent from emission email address if Setting.mail_from includes display name
Go MAEDA wrote:
> Therefore, I think r17862 should be reverted before releasing Redmine 4.0.2 and this issue should be fixed like the following:
> ...
Attaching a new patch. This patch can be applied after reverting r17862.
Go MAEDA

2019-02-16

23:57 Defect #14792 (Closed): Don't add a display name and extra angle brackets in List-Id header field
Updated the test to catch this issue (r17873). Go MAEDA
15:45 Defect #14792: Don't add a display name and extra angle brackets in List-Id header field
Adding a test method is too much. We can test that display name and other stuff is not included by adding only one line. Go MAEDA
01:01 Defect #14792: Don't add a display name and extra angle brackets in List-Id header field
Fixed in r17870 along with #5913.
I will commit the following test later.
Go MAEDA
08:14 Feature #23980: Replace icon images with Tabler SVG icons
Go MAEDA wrote:
> I will not commit such a big change without Jean-Philippe's consent. I never forget that he is the owner of this software and we can use Redmine thanks to him and his many years of efforts.
Absolutely agree!
Jan from Planio www.plan.io
02:04 Feature #23980: Replace icon images with Tabler SVG icons
Max Johansson wrote:
> Marius, maybe it will be easier to update the patch and sneak-commit it with help of Go?
I will not commit such a big change without Jean-Philippe's consent. I never forget that he is the owner of this software...
Go MAEDA
08:02 Feature #17699: Parse author's name enclosed in parentheses in the From field when creating a user account from an email
Updated the patch again. @from_addr.comments@ also can be nil. Go MAEDA
07:38 Feature #17699: Parse author's name enclosed in parentheses in the From field when creating a user account from an email
Updated the patch. @email.header['from']@ can be nil or @Mail::UnstructuredField@ object (does not have @addrs@ method). Go MAEDA
04:45 Feature #17699: Parse author's name enclosed in parentheses in the From field when creating a user account from an email
I wrote a new patch. The code using @Mail::Address@ is shorter and maybe more reliable (I hope) than the code using our regular expressions.
Patches to commit:
* attachment:17699-fix-using-mail-address-object.diff
* attachment:email...
Go MAEDA
06:14 Feature #30813: Project background Color in Project view page
Can you set the color arbitrarily on the Project Settings Information tab or make it possible to set the color for each category?
But I think that it is better to be able to set it arbitrarily because there is also a demand for all pr...
Mitsuyoshi Kawabata
02:07 Feature #3816: Allow pasting screenshots from clipboard
Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Thank you for pointing out problems and suggesting solutions.
I changed the patch and attach it.
The changes are as follows.
* replaced $ (". wiki-edit") --> $ (". filedroplistner. wi...
Takenori TAKAKI
01:44 Feature #30229 (Closed): Optimization: all UI icons collapsed into a single sprite
Max Johansson wrote:
> I offer to close this issue so we focus on it's only related issue #23980 which seems like the best solution anyway :)
Closing.
As pointed out in #7792#note-6, CSS sprites are difficult to maintain.
Go MAEDA
01:35 Defect #30718 (Closed): Translation missing for filter by project status
Merged to 4.0-stable branch. Go MAEDA
00:45 Defect #30718 (Resolved): Translation missing for filter by project status
Committed. Thank you all for reporting, investigating, and fixing this issue. Go MAEDA
01:28 Defect #30785 (Reopened): Mail handler does not ignore emails sent from emission email address if Setting.mail_from includes display name
Go MAEDA wrote:
> The patch adds a new method @Setting.mail_from_addess@ to extract an email address from the value of Setting.mail_from. I think it is useful to fix #14792 and implement #5913.
#5913 and #14792 have been fixed withou...
Go MAEDA
00:53 Feature #5913 (Closed): Authors name in from address of email notifications
Committed. Go MAEDA

2019-02-15

19:44 Patch #9697: Projects list with progress
I think if it really needs to exist, it then has to be optional and maybe even the progress bar design to be thin and as minimalist as possible, so a person wouldn't feel overwhelmed with the information on the project list view, which a... Anonymous
19:34 Feature #30229: Optimization: all UI icons collapsed into a single sprite
I offer to close this issue so we focus on it's only related issue #23980 which seems like the best solution anyway :) Anonymous
18:50 Patch #4979: Human readable Time for the issue table
Ok, this is awesome! Thank you for your kind reply on this :)
Since I created this ticket 9 years ago, a _lot_ of stuff happened in my life, so the codebase of this project. You guessed it already: This patch is not relevant any more....
Aaron Fischer
16:55 Patch #4979: Human readable Time for the issue table
*queries_helper.rb* has completely changed ever since 9 years ago, so this patch is now obsolete and will require a completely different approach if ever to be remade again. I else fail to really understand what was the intention with th... Anonymous
18:28 Feature #23980: Replace icon images with Tabler SVG icons
Marius, maybe it will be easier to update the patch and sneak-commit it with help of Go? Then we could cross fingers and hope that Jean-Philippe might not notice it :D Anonymous
18:12 Patch #30730: [Revision view] Place link to add a related issue next to the heading
+1
I tested the patch against very recent trunk and LGTM. Please commit while it's not spoiled. XD
Anonymous
16:01 Defect #30718: Translation missing for filter by project status
Patches to commit:
1. attachment:0001-Fix-30718.patch
2. attachment:query_test.rb.patch
Marius BĂLTEANU
15:15 Defect #30718: Translation missing for filter by project status
works fine, thanks Pavel Rosický
16:00 Defect #2641 (Closed): other-formats paragraph location is inconsistent
Marius BĂLTEANU
14:27 Defect #2641: other-formats paragraph location is inconsistent
Maybe it's safe to close this issue now, because it's obsolete.
1. Seems like it's from the era when views used to be in .rhtml format
2. *<div style="clear: both;"></div>* line don't exist in *show.html.erb* already and
Anonymous
15:24 Patch #2281: Total-columns in the issue summary (issue_report)
It could be a penalty to performance if there are too many versions, too many categories and etc as it introduces additional for loops. This IMHO would be a lot cheaper to do on the front end instead, but it would require correct classif... Anonymous
14:05 Feature #30813 (New): Project background Color in Project view page
Hi Redminers :)
has any one from you an idea how can i define a color for each Project to show it in the projects background in the main projects view page ?
example in the attachments.
Thanks in Advanced :)
Saleh Alashkar
09:24 Feature #3816: Allow pasting screenshots from clipboard
Marius BALTEANU wrote:
> - "wiki-edit" class doesn't mean automatically that a "files" input is available.
You are right. For example, "textarea.wiki-edit" on /settings page don't accept attachments. Do you think that we can resolve ...
Go MAEDA
06:36 Feature #3816: Allow pasting screenshots from clipboard
Andreas Schnöppl wrote:
> Why not take the clipboard image paste plugin?
> ...
We can support this on the proposed patch.
> * Has crop functionality
Indeed, but I don't think that it is enough or it worth it to support this feature c...
Marius BĂLTEANU
07:34 Defect #30811 (Closed): "rake db:fixtures:load" does not work
Rails provides a rake task @db:fixtures:load@ to load fixtures to the database. Fixture data is useful to prepare Redmine for testing. But, in Redmine, the task fails due to @test/fixtures/configuration/*.yml@. Go MAEDA
 

Also available in: Atom