Activity
From 2019-03-05 to 2019-03-07
2019-03-07
-
22:50 Feature #30893: Show "Updated issues" on the profile page
- I'm not sure that retrieving the "Updated issues" using a custom query is the best option. I would investigate how to get those issues using @IssueQuery@ (in the same way how the issues are retrieved in My page) if we really want to add ...
-
09:34 Feature #30893: Show "Updated issues" on the profile page
- I attached a patch.
The "Updated issues" row shows number of open, closed and total. And each value is linked to issues list filtered by "Updated by" filter.
-
22:09 Patch #30994 (Closed): Refactor custom field css classes
- We should move the logic to generate the css classes for a custom field to a method in order to make the code cleaner and easy to maintain.
The attach patch must be applied on top of #30985.
-
22:02 Feature #30986: New toolbar button to insert wiki macros
- I like this idea. In the future, we can extend the button to include Redmine links to different objects (issues, source, etc).
-
08:15 Feature #30986 (New): New toolbar button to insert wiki macros
- Redmine has useful wiki macros such as "child_pages", "collapse", "include" and "thumbnail".
Despite the usefulness of those macros, not so many people know the feature because they are too hidden. Only people who read the detailed sy... -
21:37 Feature #26561: Enable frozen string literals
- Go MAEDA wrote:
> Thank you for updating the patch. I would like to enable frozen_string_literal in files under the ./test directory first
I can do that, but there're some problematic methods
User#find_by_login
https://github.com/r... -
04:04 Feature #26561: Enable frozen string literals
- Pavel Rosický wrote:
> https://github.com/redmine/redmine/pull/115
> ...
Thank you for updating the patch. I would like to enable frozen_string_literal in files under the ./test directory first for the following reasons:
* Changes ... -
15:29 Feature #30985: Add CSS class to user custom fields
- Attaching a patch.
-
05:23 Feature #30985 (Closed): Add CSS class to user custom fields
- User custom fields displayed in the profile page don't have a CSS class that expresses the internal id of the custom field.
Those fields should have a class as already done in issue and project custom fields.
*[The current HTML]* -
10:08 Feature #4347: Contributing to an issue should automatically add the user to the watchers list
- nice!
-
01:45 Feature #4347: Contributing to an issue should automatically add the user to the watchers list
- I propose the following features for auto watch.
* User is added as a watcher automatically, When adding a comment to an issue.
* Enable to select "Auto watch" ON / OFF on Account Settings (Default is ON).
* When adding a feature, the... -
09:42 Defect #30988 (Closed): Preformatted text overflows the preview area
- Like the image below, the pre tag overflows from the preview tab.
!{width: 70%; border: 1px solid #ccc}note.png! -
09:24 Defect #30987 (Closed): Unnecessary empty lines are displayed when syntax highlighting
- Unnecessary empty lines are displayed like the image.
!{width: 70%; border: 1px solid #ccc}test.png!
I found this problem with trunk.
r17891 may be involved in this problem. -
09:08 Patch #30983 (Closed): Traditional Chinese translation (to r17932)
- Committed the translation. Thank you.
-
04:11 Patch #30983 (Closed): Traditional Chinese translation (to r17932)
- * New tags added
** setting_mail_handler_preferred_body_part, setting_show_status_changes_in_mail_subject -
09:05 Defect #30367 (Resolved): "Last updated by" filter causes an SQL error with MariaDB
- Committed the patch. Thank you for reporting and fixing the issue.
-
08:20 Defect #30367: "Last updated by" filter causes an SQL error with MariaDB
- Pavel Rosický wrote:
> the fix is fairly simple, Marius please take a look
Thank you for sharing the patch.
I confirmed that the failed test succeeded by applying your patch.
I also confirmed that the last_updated_by filter works f... -
05:41 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
- The attached patch adds a feature to mention to the user.
* Use user link such as "user:jsmith" "@jsmith" "user#2".
* Notify when the user mentioned by the user link has the authority to view the element and has not rejected the notifi... -
03:40 Defect #30850: Unified diff link broken on specific file/revision diff view
- By changing to the following, the diff format is allowed.
-
00:29 Feature #30977 (Closed): Add CSS class to project custom fields
2019-03-06
-
23:31 Feature #30977 (Resolved): Add CSS class to project custom fields
- Committed.
-
15:14 Feature #30977: Add CSS class to project custom fields
- Here is a patch to implement this.
-
08:36 Feature #30977 (Closed): Add CSS class to project custom fields
- Project custom fields displayed on the Overview page does not have any CSS class. This makes it difficult for users to style those fields shown on the page.
I think those fields should have a proper CSS class that identify the custom ... -
20:29 Feature #26561: Enable frozen string literals
- https://github.com/redmine/redmine/pull/115
this is a pull request without frozen_string_literal comment - 69 vs 936 changes, it should be much easier to review
you can apply the comment afterwards using rubocop like this
*> rubocop... -
18:09 Feature #26561: Enable frozen string literals
- Since the patch is too big to review for me, I would like to take a step-by-step approach. It means that I will enable frozen_string_literal in each file one after another.
Today, I confirmed that we can enable frozen_string_literal f... -
14:22 Feature #26561: Enable frozen string literals
- since ruby 2.2 support was dropped this should be ready for 4.1
let me know if there's anything else I can do -
15:52 Feature #7360: Issue custom query: default query per instance, project and user
- +1!
I hope that this feature will be release soon too. It's very annoying. It should be possible to define a global default filter and then save a dedicated filter per project. -
15:51 Defect #14753: Remember issue filter for each project
- I hope that this feature will be release soon too. It's very annoying. It should be possible to define a global default filter and then save a dedicated filter per project.
-
15:36 Defect #30367: "Last updated by" filter causes an SQL error with MariaDB
- Setting the target version to 3.4.10.
-
14:23 Defect #30367: "Last updated by" filter causes an SQL error with MariaDB
- the fix is fairly simple, Marius please take a look
-
11:59 Patch #30971: principals_options_for_select does not select user when user id is numeric
- The only places where selected is an integer are :
* in bulk edit :
->/lxc/redmine4/home/smile/redmine-4.0.0/app/views/issues/bulk_edit.html.erb
74: principals_options_for_select(@assignables, @issue_params[:assign... -
04:29 Patch #30971: principals_options_for_select does not select user when user id is numeric
- Could you show the steps to reproduce the problem with the Web UI?
-
11:03 Feature #30981 (New): Allow "New Member" modal to keep track of selected users between searches
- When we add new members to a project through the "New Member" modal, there is a search box and, if there are lots of users, pagination.
- If we attempt to search for a user, check it, then search for another one, the initial selection... -
08:43 Feature #30978 (New): Issue rating plugin
- Hello,
I need a plugin that will allow any user to rate any issue, plus, to leave the feedback.
There is already the same functionality on each page
see *rate this plugin* here -> https://www.redmine.org/plugins/vote_on_issues
... -
07:36 Patch #10970: Sort issues in roadmap by IssueStatus.position
- Thanks for the patch, I fixed for Redmine v3.4.4
Hope this feature can be merged into redmine master. -
04:53 Feature #30829: Simpler link syntax "#note-123" to make a link to a note of the current issue
- LGTM. Setting the target version to 4.1.0.
-
03:39 Feature #30975 (Closed): New My page block: Updated issues
- "Updated" filter added in Redmine 3.4.0 (#17720) is useful to understand the issues you involved in the past.
I think it would be great if the My page has a new block "Updated issues" that lists issues the user updated recently.
2019-03-05
-
23:03 Defect #30974 (Closed): Code coverage report on the official site has not been updated
- https://www.redmine.org/builds/coverage/ has not been updated since 2018-11-20.
-
22:25 Defect #30964 (Closed): 500 appears when trying to filter by last updated by
- MariaDB is not yet supported by Redmine, please see #19395 and #30367.
-
03:29 Defect #30964 (Closed): 500 appears when trying to filter by last updated by
- *OS*
-
22:17 Defect #28506 (Reopened): Error Setup Redmine with Win10
-
22:16 Defect #28506 (Closed): Error Setup Redmine with Win10
-
16:04 Defect #28506: Error Setup Redmine with Win10
- Thank You!
-
15:55 Defect #28506: Error Setup Redmine with Win10
- Black Zajaz wrote:
> i have some problem with redmine - 4.0.2.
> ...
Currently, Redmine 4.0 does not support Microsoft SQL server due to problems of a third-party library. Please check #30285. -
14:08 Defect #28506: Error Setup Redmine with Win10
- Hello,
i have some problem with redmine - 4.0.2.
i want to migrate from mysql to mssql server.
best regards, -
17:37 Patch #30971 (New): principals_options_for_select does not select user when user id is numeric
- +To fix it+ : In application Helper L487
convert selected to string if it is an integer -
16:53 Patch #30970 (Closed): Small improvements in appearance of the code coverage index page
- Committed the patch.
-
16:22 Patch #30970 (Closed): Small improvements in appearance of the code coverage index page
- The attached patch slightly improves the code coverage report which is generated by "rake test:coverage".
# Highlight a row on hover
# Don't wrap text in "% covered", "Lines", "Relevant", and "Covered" columns
*[Before]*
!{width:... -
16:50 Feature #6417 (Closed): Allow collapse/expand in gantt chart
- Committed. Thanks.
-
03:50 Feature #6417: Allow collapse/expand in gantt chart
- Go MAEDA wrote:
> The patch breaks GanttHelperTest. Could you fix the failing tests?
Sorry, I fixed the failed tests.
I rebuilt a patch.
-
14:11 Feature #8363: Git: Pull requests
- +1
Redmine lack some feature repository management as a pull request, create/add/remove repository on settings (at now, it only import repositories, not create or delete). -
12:15 Feature #30963 (Closed): Update simplecov gem (~> 0.17.0)
- Committed.
-
10:46 Feature #30963: Update simplecov gem (~> 0.17.0)
- I found that the error I wrote in #30963#note-1 depends on the version of Ruby. You will see the error if you run @rake test:coverage@ in Ruby 2.5 or 2.6. The error is reproducible with not only the latest SimpleCov 0.16 but also 0.14.1 ...
-
07:16 Feature #30963: Update simplecov gem (~> 0.17.0)
- The error described in #30963#note-1 occurs while processing app/models/repository/git.rb line 3 ('ŋ') or lib/redmine/search.rb line 63 ('汉').
The following change will fixes the error. -
01:02 Feature #30963: Update simplecov gem (~> 0.17.0)
- I encountered the following error while running @bin/rake test:coverage@ with simplecov 0.16.1.
-
00:32 Feature #30963 (Closed): Update simplecov gem (~> 0.17.0)
- simplecov 0.16.1 has been released on 2018-03-16.
-
10:18 Defect #30967 (Closed): "rake test:coverage" fails in Ruby 2.5 and 2.6
- rake test:coverage fails in Ruby 2.5 or 2.6 with the error like the following. It occurs due to Unicode characters such as 'ŋ' in app/models/repository/git.rb line 3 and '汉' in lib/redmine/search.rb line 63.
-
03:21 Patch #4502: New date filter operators: tomorrow, next week, next month
- Go MAEDA wrote:
> QueryTest#test_operator_tomorrow fails depending on timezone.
> ...
Thank you for pointing that out.
The attached patch updates the #4502#note-13 test to fix the random failure.