Project

General

Profile

Activity

From 2019-06-02 to 2019-06-04

2019-06-04

16:52 Feature #31499: Show "Due in X days" in issue details page
Yuuki NARA wrote:
> As a simple solution, I propose to make it possible to set a reference number of days to start displaying the remaining number of days.
I don't want to add a new setting if possible because it increases complexity...
Go MAEDA
15:29 Feature #31499: Show "Due in X days" in issue details page

+1
I agree to show the remaining days on the ticket details screen,
but I am concerned about the following points.
First of all, I think that this function is to make it easy to be aware of the number of days until the ticket d...
Yuuki NARA
04:32 Feature #31499: Show "Due in X days" in issue details page
Adding as a tooltip in issues list and related issues is a nice improvement.
But I think the information should be shown by default for issue detail page. Since the information is really useful to manage tasks, I want to know it at a ...
Go MAEDA
15:54 Defect #31512 (New): valid ldap auth_source item _has_ to be id 1
After adding a new LDAP server to log on to, I couldn't delete the old LDAP server, so I removed the DB row in auth_sources. This didn't work, so I restored the old entry, which also didn't work. Then it struck me, the only difference wa... Han Boetes
15:06 Defect #31511: CSV export of time entries report does not honor project filter
Setting the target version to 4.0.4. Go MAEDA
10:42 Defect #31511: CSV export of time entries report does not honor project filter
Here is a patch for this issue (its tracker may be changed).
Tests done :
* Export from "/time_entries/report"
→ uses "/time_entries/report.csv"
* Export from "/project/foo/time_entries/report"
→ uses "/project/foo/time_entries/re...
Xavier Calland
10:35 Defect #31511: CSV export of time entries report does not honor project filter
Thank you for sharing the probrem.
I have confirmed that the following changes solve the problem.
Mizuki ISHIKAWA
09:53 Defect #31511 (Closed): CSV export of time entries report does not honor project filter
When exporting a report of time entries in a projet (from an URL like @/project/foo/time_entries/report@) the URL used (when the export options dialog is closed) is not the project specific URL (i.e. @/time_entries/report.csv@ and not @/... Xavier Calland
11:03 Feature #7774: Sub groups or Multi-level groups
Here is the original patch, not compatible with recent Redmine versions : Jérôme BATAILLE
08:41 Defect #31508 (Closed): Add missing frozen strings and copyrights
Committed the patch. Thanks. Go MAEDA
08:36 Revision 18225 (svn): Add missing frozen string literals and copyrights (#31508).
Go MAEDA
07:50 Feature #1739: Add ability to change issue author
+1
It's definitely the feature we are missing the most from redmine. So I second the move to add it as core functionality.
T H
05:54 Defect #31510 (Confirmed): Fix missing closing tags in workflows/permissions.html.erb
Enziin System wrote:
> In the view/workflows/permissions.html.erb
> ...
Thanks for finding this issue, it seems to be an old problem introduced by r15068.
> Please use an editor support check syntax (ex: Rubymine)
Please believe ...
Marius BĂLTEANU
05:02 Defect #31510 (Closed): Fix missing closing tags in workflows/permissions.html.erb
In the view/workflows/permissions.html.erb
Row 19:
<a href="#" data-expands="#role_id"><span class="toggle-multiselect icon-only icon-toggle-plus"></a>
Row 24:
<a href="#" data-expands="#tracker_id"><span class="toggle-multis...
Enziin System
05:43 Feature #31505: Mark edited journal notes as "Edited"
The patch works as expected. Very nice. :) Bernhard Rohloff
03:41 Defect #31501: reminder.rake should ignore blank parameters
Setting the target version to 4.1.0. Go MAEDA
01:28 Defect #31496 (Closed): Switch between toggle plus and minus icons for toggle multi select
Marius BALTEANU wrote:
> Please commit the attached fixes, the problem wasn't only the broken css rule.
Committed in r18224. Thanks.
Go MAEDA
01:27 Defect #31502 (Closed): Error syntax in application.css
Fixed in r18224. Thank you. Go MAEDA
01:26 Revision 18224 (svn): Some fixes for r18214 (#31496):
* incorrect icon-toggle-plus and icon-toggle-minus background rules
* broken CSS rule in .toggle-multiselect and removes some unnecessary rules
* some cases where clicking on toggle-multiselect element adds the icon class to "a" element ...
Go MAEDA

2019-06-03

22:57 Patch #31509 (Closed): Add Rubocop to enforce some styles
I propose to add Rubocop to enforce some styles for those who contribute with patches to Redmine or for those who review the proposed patches.
For the moment, I propose to start only with 2 cops:
# *Layout/TrailingWhitespace*:
To ...
Marius BĂLTEANU
22:46 Feature #31499: Show "Due in X days" in issue details page
Interesting feature.
I'm wondering if it's better to add this info as tooltip in order to keep the issue view as clean as possible and also to make the info available everywhere where due date is rendered (issues list, related issues).
Marius BĂLTEANU
16:02 Feature #31499: Show "Due in X days" in issue details page
Setting the target version to 4.1.0. Go MAEDA
02:22 Feature #31499 (Closed): Show "Due in X days" in issue details page
This patch adds "Due in X days" / "X days late" next to the due date. It is shown only when the issue is open.
It allows you to easily and clearly understand that the due date is approaching.
!{width: 762px; border: 1px solid #ccc;...
Go MAEDA
22:42 Defect #31508 (Closed): Add missing frozen strings and copyrights
There were some new files added in the last weeks that don't contain the frozen string literal and the copyright. The attach patch fixes this. Marius BĂLTEANU
22:41 Patch #31385: Formating toolbar : new color tools
Thanks Go to have proposed this for the next major release. Jérôme BATAILLE
22:08 Defect #31507 (Closed): Test fails if trailing whitespaces are removed
The test @test_partials_with_html_entities@ fails if the trailing whitespaces are removed. The attached patch can be used to reproduce the below problem: Marius BĂLTEANU
22:01 Patch #31506: Remove trailing whitespaces
All tests pass: https://gitlab.com/redmine-org/redmine/-/jobs/223806842 Marius BĂLTEANU
22:00 Patch #31506 (Closed): Remove trailing whitespaces
Marius BĂLTEANU
21:56 Feature #12388: Diffs for editions of issue/notes entries
Bernhard Rohloff wrote:
> +1 If somebody edits a comment it should at least be visible to others.
I've added a patch to #31505 which implements this feature.
Marius BĂLTEANU
21:55 Feature #31505 (Closed): Mark edited journal notes as "Edited"
The attached patch marks the edited notes as "Edited", showing on hover the author and time of the last edit.
!{width: 50%; border: 1px solid grey;}.edited.png!
This issue is related to #12388, but I chose to open a new issue because...
Marius BĂLTEANU
18:41 Defect #31496: Switch between toggle plus and minus icons for toggle multi select
My last patch fixes:
- incorrect @icon-toggle-plus@ and @icon-toggle-minus@ background rules
- broken CSS rule in @.toggle-multiselect@ and removes some unnecessary rules
- some cases where clicking on toggle-multiselect element adds ...
Marius BĂLTEANU
08:53 Defect #31496: Switch between toggle plus and minus icons for toggle multi select
Please commit the attached fixes, the problem wasn't only the broken css rule. Marius BĂLTEANU
08:33 Defect #31496 (Reopened): Switch between toggle plus and minus icons for toggle multi select
Go MAEDA
08:33 Defect #31496 (Resolved): Switch between toggle plus and minus icons for toggle multi select
An error in application.css was reported as #31502. Go MAEDA
17:45 Defect #31503 (Closed): Undefined local variable sender_email in MailHandler#receive_message_reply
When receiving a reply to a locked topic, mail handler crashes with the following error: Andriy Lesyuk
16:56 Patch #31498 (Closed): Add redmine_plugin_migration generator
Committed the patch. Thank you. Go MAEDA
08:53 Patch #31498: Add redmine_plugin_migration generator
Setting the target version to 4.1.0. Go MAEDA
07:10 Patch #31498: Add redmine_plugin_migration generator
Good catch.
I've updated the patch.
Kouhei Sutou
07:07 Patch #31498: Add redmine_plugin_migration generator
>I think that minimum implementation is a good starting point.
+1, nice work!
This is a minute thing but `plugin_pretty_name` declared in line 16 of redmine_plugin_migration_generator.rb is not used so far and probably can be safel...
vzvu 3k6k
00:00 Patch #31498 (Closed): Add redmine_plugin_migration generator
Redmine provides @redmine_plugin_model@ generator. It's similar to @model@ generator by Rails but for Redmine plugin. It's useful to add a new model to Redmine plugin.
But Redmine doesn't provide @redmine_plugin_migration@ generator. ...
Kouhei Sutou
16:56 Revision 18223 (svn): Add redmine_plugin_migration generator (#31498).
Patch by Kouhei Sutou. Go MAEDA
08:55 Defect #31502: Error syntax in application.css
Thanks for catching this problem, I've attached to #31496 a patch with multiple fixes.
Marius BĂLTEANU
05:56 Defect #31502: Error syntax in application.css
You can change to:
no-repeat: 0% 40%;
Enziin System
05:55 Defect #31502: Error syntax in application.css
Thank you for reporting.
Maybe we can simply remove "@no-repeat 0% 40%;@"?
Go MAEDA
05:45 Defect #31502 (Closed): Error syntax in application.css
In the file stylesheet: public/stylesheets/application.css
.toggle-multiselect { no-repeat 0% 40%; padding-left:16px; margin-left:0; margin-right:5px; cursor:pointer;}
It error at the "no-repeat 0% 40%;"
Missing ":"
Enziin System
07:30 Feature #31427 (Closed): Insert a link to the source to the attribution line when quoting a note or a message
Go MAEDA wrote:
> I think using the instance default language is better. Consider a team with members of multiple nationalities and they are communicating in English. In this case, the English version of text_user_wrote should be used. ...
Marius BĂLTEANU
05:44 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
Marius BALTEANU wrote:
> > > 3. This is not related to the current changes, but is there any reason for why we don't replace the @ll(Setting.default_language, :text_user_wrote, @message.author@ with @l(:text_user_wrote, @message.author)...
Go MAEDA
05:09 Defect #31501 (Closed): reminder.rake should ignore blank parameters
Currently, reminder.rake does not ignore blank parameters and it causes unexpected behavior.
Assume the following command line that invokes email reminder. I expect that @trackers=@ in the command line should be ignored and reminder b...
Go MAEDA
02:56 Feature #31500 (Closed): Ruby 2.7 support
Ruby 2.7.0 is going to be released on 2019-12-25.
https://bugs.ruby-lang.org/versions/35
Go MAEDA
02:27 Patch #31493 (Closed): Add a link to project_issues_report from project_issues_report_details
Committed the patch. Go MAEDA
02:27 Revision 18222 (svn): Add a link to project_issues_report from project_issues_report_details (#31493).
Patch by Go MAEDA. Go MAEDA
01:40 Feature #22481 (Closed): Show thumbnails for PDF attachments
Marius BALTEANU wrote:
> We should run @ test_thumbnail_for_pdf_should_be_png@ only when GS is available.
Thank you for cleaning up after my mistake. Committed the fix in r18221.
Go MAEDA
01:39 Revision 18221 (svn): Run test only when GhostScript is available (#22481).
Patch by Marius BALTEANU. Go MAEDA
01:23 Revision 18220 (svn): Remove trailing whitespaces from test/test_helper.rb
Go MAEDA
01:21 Revision 18219 (svn): Remove trailing whitespaces from test/functional/attachments_controller_test.rb
Go MAEDA

2019-06-02

19:16 Feature #22481 (Reopened): Show thumbnails for PDF attachments
We should run @ test_thumbnail_for_pdf_should_be_png@ only when GS is available.
One test fails without the patch: https://gitlab.com/redmine-org/redmine/-/jobs/223654807
All tests pass after applying the patch: https://gitlab.com/re...
Marius BĂLTEANU
18:47 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Thanks!
>
> ...
Ok, your decision. I see a little bit different, but it is not so important.
> > 3. This is not related to the current changes, but is there any reason for why we ...
Marius BĂLTEANU
18:01 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
Marius BALTEANU wrote:
> 1. @indice = @journal.issue.visible_journals_with_index.find{|j| j.id == @journal.id}.indice@ generates a lot of unnecessary queries:
> ...
Committed the proposed code in r18218. Thanks.

> 2. I think it's...
Go MAEDA
16:43 Feature #31427 (Reopened): Insert a link to the source to the attribution line when quoting a note or a message
Go MAEDA wrote:
> Committed the patch. Thank you for the nice improvement.
Indeed, it's a nice and useful improvement, but I would to review the implementation:
1. @indice = @journal.issue.visible_journals_with_index.find{|j| j.id...
Marius BĂLTEANU
15:33 Feature #31427 (Closed): Insert a link to the source to the attribution line when quoting a note or a message
Committed the patch. Thank you for the nice improvement. Go MAEDA
17:58 Revision 18218 (svn): Send the journal_indice as param in order to get rid of extra queries (#31427).
Patch by Marius BALTEANU. Go MAEDA
15:29 Revision 18217 (svn): Insert a link to the source to the attribution line when quoting a note or a message (#31427).
Patch by Mizuki ISHIKAWA. Go MAEDA
15:25 Revision 18216 (svn): Add text_user_wrote_in to locales (#31427).
Patch by Mizuki ISHIKAWA. Go MAEDA
14:37 Patch #31497 (Closed): Czech translation update
Committed the patch. Thanks. Go MAEDA
11:54 Patch #31497 (Closed): Czech translation update
Pavel Rosický
14:36 Revision 18215 (svn): Czech translation update (#31497).
Patch by Pavel Rosický. Go MAEDA
11:25 Patch #31493: Add a link to project_issues_report from project_issues_report_details
Setting the target version to 4.1.0. Go MAEDA
10:07 Patch #31493 (Closed): Add a link to project_issues_report from project_issues_report_details
This patch adds a link which points to project_issues_report page (@/projects/:id/issues/report@) on project_issues_report_details page (@/projects/:id/issues/report/:detail@).
The change makes it easier to go back and forth between t...
Go MAEDA
11:11 Feature #23980: Replace icon images with Tabler SVG icons
I've have updated my patch to include the latest changes made in #31433 and #31496.
Considering that most of the icons are now replaced with font awesome icons, I'm assigning this to version:"4.1.0" in order to take a feedback from Je...
Marius BĂLTEANU
10:48 Defect #31496 (Closed): Switch between toggle plus and minus icons for toggle multi select
Committed the patch. Thank you for fixing the behavior. Go MAEDA
10:39 Defect #31496 (Closed): Switch between toggle plus and minus icons for toggle multi select
This patch:
# fixes the existent behaviour where the same toggle plus icon is shown regardless multi select state
# adds the "icon icon-*" classes
*Before:*
!{width:50%; border: 1px solid grey;}.before.png!
*After:*
!{width:...
Marius BĂLTEANU
10:48 Revision 18214 (svn): Switch between toggle plus and minus icons for toggle multi select (#31496).
Patch by Marius BALTEANU. Go MAEDA
10:32 Defect #31495 (New): Tracker status cannot be empty in when processing commit messages
Hello everyone,
we just recently upgraded to Redmine 4.0.3 and face troubles updating our issues with commit messages. We are using the keyword "for" to mark commits that refer to a certain issue - but do not necessarily cause any cha...
Stefan Zugal
07:53 Patch #31465 (Closed): Add an icon linked to trackers detail report on the project overview page
Committed the patch. Go MAEDA
02:09 Patch #31465: Add an icon linked to trackers detail report on the project overview page
Setting the target version to 4.1.0. Go MAEDA
07:53 Revision 18213 (svn): Add an icon linked to trackers detail report on the project overview page (#31465).
Patch by Go MAEDA. Go MAEDA
07:20 Feature #14332 (Closed): [Repository] Make "view file" the default
The repository browser shows file contents by default since Redmine 3.4.0 (#25999). Go MAEDA
06:24 Feature #16309 (Closed): Add a concept of role-based permission to trackers
The feature was added in Redmine 3.3.0 (#285). Go MAEDA
05:54 Defect #22973 (Closed): Api rest assigned_to_id
Go MAEDA
05:50 Defect #22940 (Closed): Why I received mail that contain underscore instead of space in from redmine.
Go MAEDA
05:46 Defect #10755 (Closed): Why I got "Email has already been taken" message when creating new user?
Please reopen this issue if you still experience the problem. Go MAEDA
04:51 Feature #14639 (Closed): Emission email address Name
In the upcoming 4.1.0, the name of the user who triggered the notification is displayed in the From field of the email (#5913). Go MAEDA
04:42 Feature #5228 (Closed): Users are just numbers
Marius BALTEANU wrote:
> Link to user profile was committed in #4179. The following syntaxes are supported:
> ...
#4179 delivered in Redmine 3.4.0 meets the request.
Go MAEDA
03:02 Defect #30164: Missing images in a wiki page are not visualized
Firefox displays a broken image icon for a missing image but Chrome does not. So, it is not easy for Chrome users to detect that some images are missing.
!firefox-broken-image.png!
Go MAEDA
02:33 Defect #31487 (Closed): Issues filtering
I think the behavior you pointed out is the expected behavior. I often use "any" operator to filter issues with any assignee is set, or issues with any target version is set.
You don't have to use the assignee filter if you want to ge...
Go MAEDA
02:23 Defect #31471: Lost right shift for 'journal-link'
Probably the issue is specific to a particular theme. The default theme does not show the history number next to the icon.
!{width: 661px; border: 1px solid #ccc;}.history@2x.png!
Go MAEDA
02:05 Defect #31365: Issue subject may be broken if the subject field in the receiving email is split into multiple lines
Setting the target version to 4.0.4. Go MAEDA
 

Also available in: Atom