Redmine

2019-06-05

18:09 Feature #31521: Make REST API for users incremental with plugins

Same solution is already included for projects with "render_api_includes":/projects/redmine/repository/entry/trunk/ap... Alexander Meindl

17:55 Feature #31521 (New): Make REST API for users incremental with plugins

At the moment there is no way to add custom values to REST api output for users. This patch adds a helper function to... Alexander Meindl

15:55 Defect #31519 (Closed): Redmine 4.0.3 does not send all notification emails ?

Currently i have a problem with my Redmine docker based installation. I migrated from a turnkey linux appliance to a ... Hans Riekehof

13:45 Defect #31511 (Resolved): CSV export of time entries report does not honor project filter

Committed the fix. Thank you for reporting and fixing this issue. Go MAEDA

13:40 Defect #31511 (Confirmed): CSV export of time entries report does not honor project filter

Go MAEDA

13:01 Feature #30492: Replace RMagick with MiniMagick

Ronan Chagas wrote:
> Goh Matsumoto wrote:
> *EDIT*: By the way, this patch is working perfectly and, even installi... Richard Hafenscher

12:50 Feature #31518: Default due date for issues

+1
The request for the display form is different for each site and project,
Especially in large scale environment... Yuuki NARA

11:26 Feature #31518 (Closed): Default due date for issues

It would be nice if we can configure Redmine to set a default due date for issues (N days from today).
Due date is... Go MAEDA

12:34 Feature #31499: Show "Due in X days" in issue details page

Go MAEDA wrote:
> How about discussing adding the setting after this patch has been merged?
> Maybe the discussi... Yuuki NARA

02:50 Feature #31499: Show "Due in X days" in issue details page

Yuuki NARA wrote:
> I want to show only when the date is within a few days.
> If it has been displayed for a month,... Go MAEDA

11:20 Defect #31501 (Closed): reminder.rake should ignore blank parameters

Committed the fix. Go MAEDA

08:23 Feature #31444: Add "<< me >>" option to user format issue custom fields

confirmed.
I think there is no problem. akitani ryo

2019-06-04

16:52 Feature #31499: Show "Due in X days" in issue details page

Yuuki NARA wrote:
> As a simple solution, I propose to make it possible to set a reference number of days to start d... Go MAEDA

15:29 Feature #31499: Show "Due in X days" in issue details page

+1
I agree to show the remaining days on the ticket details screen,
but I am concerned about the following poi... Yuuki NARA

04:32 Feature #31499: Show "Due in X days" in issue details page

Adding as a tooltip in issues list and related issues is a nice improvement.
But I think the information should be... Go MAEDA

15:54 Defect #31512 (New): valid ldap auth_source item _has_ to be id 1

After adding a new LDAP server to log on to, I couldn't delete the old LDAP server, so I removed the DB row in auth_s... Han Boetes

15:06 Defect #31511: CSV export of time entries report does not honor project filter

Setting the target version to 4.0.4. Go MAEDA

10:42 Defect #31511: CSV export of time entries report does not honor project filter

Here is a patch for this issue (its tracker may be changed).
Tests done :
* Export from "/time_entries/report"
→... Xavier Calland

10:35 Defect #31511: CSV export of time entries report does not honor project filter

Thank you for sharing the probrem.
I have confirmed that the following changes solve the problem.... Mizuki ISHIKAWA

09:53 Defect #31511 (Closed): CSV export of time entries report does not honor project filter

When exporting a report of time entries in a projet (from an URL like @/project/foo/time_entries/report@) the URL use... Xavier Calland

11:03 Feature #7774: Sub groups or Multi-level groups

Here is the original patch, not compatible with recent Redmine versions : Jérôme BATAILLE

08:41 Defect #31508 (Closed): Add missing frozen strings and copyrights

Committed the patch. Thanks. Go MAEDA

07:50 Feature #1739: Add ability to change issue author

+1
It's definitely the feature we are missing the most from redmine. So I second the move to add it as core functio... T H

05:54 Defect #31510 (Confirmed): Fix missing closing tags in workflows/permissions.html.erb

Enziin System wrote:
> In the view/workflows/permissions.html.erb
>
> Row 19:
>
> <a href="#" data-expands="#r... Marius BĂLTEANU

05:02 Defect #31510 (Closed): Fix missing closing tags in workflows/permissions.html.erb

In the view/workflows/permissions.html.erb
Row 19:
<a href="#" data-expands="#role_id"><span class="toggle-mult... Enziin System

05:43 Feature #31505: Mark edited journal notes as "Edited"

The patch works as expected. Very nice. :) Bernhard Rohloff

03:41 Defect #31501: reminder.rake should ignore blank parameters

Setting the target version to 4.1.0. Go MAEDA

01:28 Defect #31496 (Closed): Switch between toggle plus and minus icons for toggle multi select

Marius BALTEANU wrote:
> Please commit the attached fixes, the problem wasn't only the broken css rule.
Committed... Go MAEDA

01:27 Defect #31502 (Closed): Error syntax in application.css

Fixed in r18224. Thank you. Go MAEDA

2019-06-03

22:57 Patch #31509 (Closed): Add Rubocop to enforce some styles

I propose to add Rubocop to enforce some styles for those who contribute with patches to Redmine or for those who rev... Marius BĂLTEANU

22:46 Feature #31499: Show "Due in X days" in issue details page

Interesting feature.
I'm wondering if it's better to add this info as tooltip in order to keep the issue view as c... Marius BĂLTEANU

16:02 Feature #31499: Show "Due in X days" in issue details page

Setting the target version to 4.1.0. Go MAEDA

02:22 Feature #31499 (Closed): Show "Due in X days" in issue details page

This patch adds "Due in X days" / "X days late" next to the due date. It is shown only when the issue is open.
It ... Go MAEDA

22:42 Defect #31508 (Closed): Add missing frozen strings and copyrights

There were some new files added in the last weeks that don't contain the frozen string literal and the copyright. The... Marius BĂLTEANU

22:41 Patch #31385: Formating toolbar : new color tools

Thanks Go to have proposed this for the next major release. Jérôme BATAILLE

22:08 Defect #31507 (Closed): Test fails if trailing whitespaces are removed

The test @test_partials_with_html_entities@ fails if the trailing whitespaces are removed. The attached patch can be ... Marius BĂLTEANU

22:01 Patch #31506: Remove trailing whitespaces

All tests pass: https://gitlab.com/redmine-org/redmine/-/jobs/223806842 Marius BĂLTEANU

22:00 Patch #31506 (Closed): Remove trailing whitespaces

Marius BĂLTEANU

21:56 Feature #12388: diffs for editions of issue/notes entries

Bernhard Rohloff wrote:
> +1 If somebody edits a comment it should at least be visible to others.
I've added a pa... Marius BĂLTEANU

21:55 Feature #31505 (Closed): Mark edited journal notes as "Edited"

The attached patch marks the edited notes as "Edited", showing on hover the author and time of the last edit.
!{widt... Marius BĂLTEANU

18:41 Defect #31496: Switch between toggle plus and minus icons for toggle multi select

My last patch fixes:
- incorrect @icon-toggle-plus@ and @icon-toggle-minus@ background rules
- broken CSS rule in @... Marius BĂLTEANU

08:53 Defect #31496: Switch between toggle plus and minus icons for toggle multi select

Please commit the attached fixes, the problem wasn't only the broken css rule. Marius BĂLTEANU

08:33 Defect #31496 (Reopened): Switch between toggle plus and minus icons for toggle multi select

Go MAEDA

08:33 Defect #31496 (Resolved): Switch between toggle plus and minus icons for toggle multi select

An error in application.css was reported as #31502. Go MAEDA

17:45 Defect #31503 (Closed): Undefined local variable sender_email in MailHandler#receive_message_reply

When receiving a reply to a locked topic, mail handler crashes with the following error:... Andriy Lesyuk

16:56 Patch #31498 (Closed): Add redmine_plugin_migration generator

Committed the patch. Thank you. Go MAEDA

08:53 Patch #31498: Add redmine_plugin_migration generator

Setting the target version to 4.1.0. Go MAEDA

07:10 Patch #31498: Add redmine_plugin_migration generator

Good catch.
I've updated the patch. Kouhei Sutou

07:07 Patch #31498: Add redmine_plugin_migration generator

>I think that minimum implementation is a good starting point.
+1, nice work!
This is a minute thing but `plugi... vzvu 3k6k

00:00 Patch #31498 (Closed): Add redmine_plugin_migration generator

Redmine provides @redmine_plugin_model@ generator. It's similar to @model@ generator by Rails but for Redmine plugin.... Kouhei Sutou

08:55 Defect #31502: Error syntax in application.css

Thanks for catching this problem, I've attached to #31496 a patch with multiple fixes.
Marius BĂLTEANU

05:56 Defect #31502: Error syntax in application.css

You can change to:
no-repeat: 0% 40%; Enziin System

05:55 Defect #31502: Error syntax in application.css

Thank you for reporting.
Maybe we can simply remove "@no-repeat 0% 40%;@"? ... Go MAEDA

05:45 Defect #31502 (Closed): Error syntax in application.css

In the file stylesheet: public/stylesheets/application.css
.toggle-multiselect { no-repeat 0% 40%; padding-left:16... Enziin System

07:30 Feature #31427 (Closed): Insert a link to the source to the attribution line when quoting a note or a message

Go MAEDA wrote:
> I think using the instance default language is better. Consider a team with members of multiple na... Marius BĂLTEANU

05:44 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message

Marius BALTEANU wrote:
> > > 3. This is not related to the current changes, but is there any reason for why we don't... Go MAEDA

05:09 Defect #31501 (Closed): reminder.rake should ignore blank parameters

Currently, reminder.rake does not ignore blank parameters and it causes unexpected behavior.
Assume the following ... Go MAEDA

02:56 Feature #31500 (Closed): Ruby 2.7 support

Ruby 2.7.0 is going to be released on 2019-12-25.
https://bugs.ruby-lang.org/versions/35 Go MAEDA

02:27 Patch #31493 (Closed): Add a link to project_issues_report from project_issues_report_details

Committed the patch. Go MAEDA

01:40 Feature #22481 (Closed): Show thumbnails for PDF attachments

Marius BALTEANU wrote:
> We should run @ test_thumbnail_for_pdf_should_be_png@ only when GS is available.
Thank y... Go MAEDA