Project

General

Profile

Activity

From 2020-02-19 to 2020-02-21

2020-02-21

23:02 Patch #24623: Implements CRUD permissions and restrictions to issue attachments
Well I downloaded fresh 4.1 and got few chunk errors, and many succeeds... Aleksandar Pavic
14:16 Patch #24623: Implements CRUD permissions and restrictions to issue attachments
Aleksandar Pavic wrote:
> So for Redmine 4, we should only run this one 0015-Implement... from above post?
> ...
Untested, but probably works. Redmine 4 changed some user permissions regarding issues, you can see it in the role adminis...
Frederico Camara
13:38 Patch #24623: Implements CRUD permissions and restrictions to issue attachments
So for Redmine 4, we should only run this one 0015-Implement... from above post?
How about Redmine 4.1 ?
Aleksandar Pavic
18:06 Feature #32424: CommonMark Markdown Text Formatting
Marius BALTEANU wrote:
> I'm my opinion, it is a good move to replace Redcarpet with CommonMarker, but I don't think that we can do it without helping users to migrate their existing content.
I believe that keeping the content and ju...
Martin Cizek
14:27 Feature #32424: CommonMark Markdown Text Formatting
Attaching an incremental patch to handle invalid URIs in HTML anchors. It prevents HTTP 500 for inputs like: Martin Cizek
14:43 Defect #32449: Diff view for .js files in repositories is broken
Setting the target version to 4.0.7. Go MAEDA
09:11 Defect #32449: Diff view for .js files in repositories is broken
After applying Mizuki ISHIKAWA's change and restarting Redmine, _View differences_ page works flawlessly with .js files. Guillermo ML
03:44 Defect #32449: Diff view for .js files in repositories is broken
When displaying the js file, base.html.erb was not used as the layout file.
Specifying an explicit layout file as shown below should solve the problem.
Mizuki ISHIKAWA
13:40 Feature #8168: Allow to disable feature attachment
+1
This is related to #24623
Aleksandar Pavic
13:16 Feature #24763: Force SSL when Setting.protocol is "https"
I can confirm this issues still prevails on Aleksandar Pavic
13:06 Feature #31859: Per role visibility settings for spent time custom fields
Hello #Go MAEDA is the plug-in useful for Redmine 3.4.13 too? I cannot find GIT repo for this patch. Thank you Mi Po
09:34 Feature #33037 (Closed): Support for Gitlab flavored Markdown
Its great to see that Redmine also supports markdown in the meantime. However in the current version 4.1 the Markdown Features are quite limited.
Its missing some basics things like scaling pictures, and some more advanced things like `...
Hans Riekehof
08:17 Feature #1575: Toolbar button to insert a table
Fixed a patch. Mizuki ISHIKAWA
07:37 Feature #1575: Toolbar button to insert a table
Hiroyuki ENDO wrote:
> I made a new icon image.
Thank you for making the icon.
The icon looks very nice!
Screenshot when attachment:image.png is applied:
!use-table-icon.png!
Updated the patch to use attachment:image.png as t...
Mizuki ISHIKAWA
07:19 Feature #1575: Toolbar button to insert a table
I made a new icon image. Hiroyuki ENDO
04:58 Patch #33036 (Closed): Add missing fixture to IssuesControllerTest
Committed as a part of #4511. Thank you. Go MAEDA
01:35 Patch #33036 (Closed): Add missing fixture to IssuesControllerTest
IssuesControllerTest has failed. Yuichi HARADA
04:00 Defect #33023: Warning occurs when displaying a few exceptional PDF thumbnail
I tried ImageMagick 7.0.9-24 Q16, but still got the error.
No error occurs when adding the "+profile icc", "-strip" or "-quiet" parameter.
Adding info:
Ghostscript v9.21 or earlier got no errors, however v9.22 or later got errors.
Anonymous
01:48 Defect #33023: Warning occurs when displaying a few exceptional PDF thumbnail
Thank you for providing the PDF file but I could not reproduce the issue. A thumbnail was generated without any error. Go MAEDA
02:30 Feature #32085: Allow newline as a separator in "Allowed extensions", "Disallowed extensions", "Exclude attachments by name" field in Administration
+1
I think that allowing a newline as a separator makes it easier to type and easier to read. I attached a patch.
Yuichi HARADA

2020-02-20

13:35 Defect #33029: API POST requests fail with 422 Can't verify CSRF token authenticity. on 3.4.13, 4.0.6 and 4.1.0
Enable REST web service is ticked.
I have resorted to disallowing protect_from_forgery by mounting and overwriting the additional_environment.rb containing that setting. This is acceptable but not optimal.
It's an internal system beh...
casper nielsen
13:27 Defect #33029 (Needs feedback): API POST requests fail with 422 Can't verify CSRF token authenticity. on 3.4.13, 4.0.6 and 4.1.0
It's likely that you have forgotten to activated the support for REST API in your local Redmine installation. Make sure to activate the API in *Administration* -> *Settings* -> *API*.
Does this solve your issue?
Holger Just
09:23 Defect #33029 (Closed): API POST requests fail with 422 Can't verify CSRF token authenticity. on 3.4.13, 4.0.6 and 4.1.0
I have been tasked with making our main application work with a newer version of redmine than it did before.
The old one was ancient. Our current one is 3.4.13 in a docker container.
I have tried the latest three versions localhost...
casper nielsen
13:34 Feature #33003 (Closed): Emails footer
You can add a reference to an image to the footer using the same syntax you can use from inside your issues, e.g.,
* @!https://www.redmine.org/attachments/7069/Redmine_logo.png!@ (if you are using Textile)
* or @![](https://www.redmi...
Holger Just
11:43 Feature #4347: Contributing to an issue should automatically add the user to the watchers list
+1 Matthias Reinhardt
09:02 Defect #32971: New line between list items break a list
Kevin Fischer wrote:
> How about adding a unit test to prevent future regressions of this conversion?
Thank you for pointing it out.
I have added the following test to attachment:32971-fixed-v3.patch .
Yuichi HARADA
04:10 Defect #32971: New line between list items break a list
Ji-Hyeon Gim wrote:
> New line between list items break a list when I try to write ordered/unordered list with textile.
> ...
* list1
* list2
* list3
# list4
# list5
# list6
</pre>
>
> ...
I noticed when looking ...
Yuichi HARADA
07:32 Defect #33027 (Confirmed): Fix missing closing div in _time_entries_fields_mapping.html.erb
Thanks for catching this, attached the patch with the fix. Marius BĂLTEANU
03:45 Defect #33027 (Closed): Fix missing closing div in _time_entries_fields_mapping.html.erb
In the file:
_/trunk/app/views/imports/_time_entries_fields_mapping.html.erb_
Element div is not closed.
Enziin System
07:28 Defect #33021: [v.4.0.5-stable] Internal Server Error 500 when accessing 'repository' tab
Anatol Pomozov wrote:
> It would be great to debug and fix this problem so Arch can switch to ruby2.7 and avoid pulling the old ruby version.
Only Redmine 4.2.0 will have official support for ruby2.7, the fixes won't be back ported t...
Marius BĂLTEANU
01:41 Defect #33021: [v.4.0.5-stable] Internal Server Error 500 when accessing 'repository' tab
It would be great to debug and fix this problem so Arch can switch to ruby2.7 and avoid pulling the old ruby version. Anatol Pomozov
01:43 Defect #33023: Warning occurs when displaying a few exceptional PDF thumbnail
Here is a sample PDF. Anonymous
01:12 Patch #684: Add journal count on issues list
Marius BALTEANU wrote:
> We should count only the journals with notes? or all journals?
I think it should be the number of all journals.
Activities such as adding attachments without note and changing the target version are also i...
Go MAEDA

2020-02-19

21:46 Patch #684: Add journal count on issues list
Florian ROBERT wrote:
> +1, I have user requests on this feature
We should count only the journals with notes? or all journals?
Marius BĂLTEANU
15:43 Patch #684: Add journal count on issues list
+1, I have user requests on this feature Florian ROBERT
16:45 Defect #32981 (Closed): Unable to distinguish disabled input fields
Go MAEDA
15:54 Feature #22913 (Closed): Auto-select fields mapping in Importing
Committed the patches.
Thank you all for working on this nice improvement.
Go MAEDA
06:10 Feature #22913: Auto-select fields mapping in Importing
The patch series works fine. Thank you.
I will commit them in a few days.
Go MAEDA
14:45 Patch #32530: Update RuboCop to 1.12
Updated to RuboCop 0.80 in r19522. Go MAEDA
14:28 Defect #2493: Subversion: Error message for some of view differences
+1 Jonas De Meulenaere
11:40 Defect #32971: New line between list items break a list
How about adding a unit test to prevent future regressions of this conversion? Kevin Fischer
07:17 Defect #32971: New line between list items break a list
I fixed the attachment:32971-fixed.patch because sometimes the @flush_left@ method did not end. Yuichi HARADA
05:18 Defect #32971: New line between list items break a list
Yuichi HARADA wrote:
> Yuichi HARADA wrote:
> ...
It did not work well with attachment:32971-fixed-v2.patch . The same problem occurred as in the previous situation.
Please delete attachment:32971-fixed-v2.patch .
Yuichi HARADA
03:47 Defect #32971: New line between list items break a list
Yuichi HARADA wrote:
> I think the behavior has probably changed by applying r17603 ( "Defect !#29756: \f or \v character in Textile markup may cause RegexpError exception":https://www.redmine.org/issues/29756 ).
> ...
Sorry, I found t...
Yuichi HARADA
11:39 Feature #33025: Optional email headers
What I got complained about is that it exposes active directory user (X-Redmine-Sender).
Aleksandar Pavic
11:38 Feature #33025 (New): Optional email headers
Now 8 years later, this feature #5643 is in some cases seen by vulnerability that exposes unnecessary information.
It would be preferable to have a checkbox to completely turn-off Redmine headers.
This should probably be a patch I ...
Aleksandar Pavic
11:18 Feature #1718: Table column sorting
There was a little problem with the patch (or was it just on my side?): It assumed that the JavaScript/CSS files were already there and thus could not be applied directly. I fixed that.
I tried the patch and function-wise it looked go...
Kevin Fischer
10:44 Feature #1718: Table column sorting
Although there is a limitation that numbers are treated as strings when sorting, the feature is useful. Go MAEDA
10:36 Defect #32449: Diff view for .js files in repositories is broken
Same with our Mercurial SCM.
h2. version 3.4.4.stable --> works fine
!{width: 70%}defect.32449-redmine_3.4.4.png!
h2. version 4.0.4.stable --> no styles and the menu disappears
!{width: 70%}defect.32449-redmine_4.0.4.png!
Guillermo ML
09:57 Defect #32449 (Confirmed): Diff view for .js files in repositories is broken
Go MAEDA
08:43 Feature #32629: Add edit button to Wiki sidebar
+1
Good idea. Small suggestion: If is not already considered: What do you think about that the Sidebar page contains those three default links straight away? If it was not created yet and you click the button or go directly to the pag...
Robert Schneider
08:39 Patch #28861: Add a date item to the context menu
Because there were many opinions that the Clear check box was difficult to understand, "Start date / Due date" can be changed only in context menu for one issue.(Cannot be changed during bulk edit)
I think that changing just one issue w...
Mizuki ISHIKAWA
08:35 Patch #28861: Add a date item to the context menu
Ponmuthu Muniyasamy wrote:
> Hi Everyone,
> ...
The [[Patch]] page has instructions on how to do it, but individual customization is not recommended as problems may occur after application.
Mizuki ISHIKAWA
08:28 Defect #33023: Warning occurs when displaying a few exceptional PDF thumbnail
Thank you for reporting the issue. Could you provide a sample PDF file that causes the error? Go MAEDA
08:19 Defect #33023 (New): Warning occurs when displaying a few exceptional PDF thumbnail
A PDF thumbnail is displayed, but the following message is output to STDERR.
The PDF file cannot be published, but it was created with a fax image (binary image).
Anonymous
07:08 Feature #4687: Add copy project permission
I have attached the patch.
Users with copy_project permission can copy from projects/show.
---
Even if you do not have view_issues permission of the copy source project, you can copy issues from the source project if you have copy...
Mizuki ISHIKAWA
06:31 Feature #1575: Toolbar button to insert a table
The attached patch adds a button to insert a table into the wiki toolbar.
The button create a table with rows / columns according to the selected range.
!{width: 70%; border: 1px solid #ccc}use-table-generator.gif!
Markdown:
Mizuki ISHIKAWA
06:14 Feature #33002: Include attachments in news post notifications
LGTM. Setting the target version to 4.2.0. Go MAEDA
 

Also available in: Atom