Activity
From 2019-05-19 to 2019-05-21
2019-05-21
-
23:56 Patch #31385: Formating toolbar : new color tools
- Fixed previous patch.
Managed more mixed color / background color tags.
@Go thanks to have renamed the issue subject -
01:33 Patch #31385: Formating toolbar : new color tools
- Here is a new patch managing some mixed cases of color / background color.
Detects if selected text already contains a css tag.
* If tag contains the css we want, replace the color.
* If not, add the css to the other tags. -
18:15 Patch #28510: Show issue assignee gravatar in roadmap and version page
- Thanks Takenori for the patch.
What do you think if we render the assignee in its own cell?
-
09:15 Patch #28510: Show issue assignee gravatar in roadmap and version page
- To specify the style of the list element,
How about making the following small changes to the Mariu's patch? -
17:11 Patch #31147: Add custom styles for all fields
- Marius BALTEANU wrote:
> One more fix for an issue introduced by r18177:
> ...
Confirmed.
!{width: 450px; border: 1px solid #ccc;}.note-27@2x.png! -
17:02 Patch #31147 (Reopened): Add custom styles for all fields
- One more fix for an issue introduced by r18177:
-
16:59 Defect #31337: Explicitly load redmine/info in order to avoid "uninitialized constant" error
- The following patch fixes the problem.
-
11:02 Patch #31409 (Closed): Japanese translation update (r18182)
- Committed the patch.
-
02:54 Patch #31409 (Closed): Japanese translation update (r18182)
- Translated strings added in r18182.
-
10:38 Patch #31412 (Closed): Traditional Chinese translation (to r18182)
- Committed the patch. Xiexie.
-
08:19 Patch #31412 (Closed): Traditional Chinese translation (to r18182)
- * New tags added
** field_recently_used_projects, label_optgroup_bookmarks, label_optgroup_others, label_optgroup_recents, button_project_bookmark, button_project_bookmark_delete -
10:31 Defect #31411 (Closed): Internal Error (r18182)
- Committed the fix. Thank you for checking the fix.
-
07:50 Defect #31411: Internal Error (r18182)
- Hello,
it's okay.
thanks for the info.
good to know that it had been fixed already.
-
07:42 Defect #31411: Internal Error (r18182)
- Probably #31355#note-11 fixes the problem. I am going to commit the fix later. Sorry for the inconvenience.
-
07:40 Defect #31411 (Closed): Internal Error (r18182)
- Hello,
I got this error after updating my site to r18182 -
10:30 Feature #31355 (Closed): Bookmarks and recently used projects for the project jump box
- Committed the fix in #31355#note-10.
-
02:43 Feature #31355: Bookmarks and recently used projects for the project jump box
- The following change fixes #31355#note-10.
-
02:29 Feature #31355 (Reopened): Bookmarks and recently used projects for the project jump box
- It does not work in production mode.
-
00:30 Feature #31355 (Closed): Bookmarks and recently used projects for the project jump box
- Committed the patches. Thank you for contributing the great improvement.
-
08:40 Defect #31413 (New): Copy Groups changes Project of Sub Tasks
- I really love the Copy feature to duplicate an issue and even more for a group of issues.
h2. Example
I have a group of monthly tasks - 5 emails, one SEO page and one data dump. Each month I copy the parent group, rename the child... -
05:56 Defect #31365: Issue subject may be broken if the subject field in the receiving email is split into multiple lines
- I hope to include the workaround in 4.0.4 or 4.1.0.
Fundamentally, mail gem should be fixed and monkey patching in Redmine is not an ideal solution.
However, I think the workaround is beneficial for users who are affected by this p... -
05:33 Defect #31387: Don't rescue Exception class
- Setting the target version to 4.1.0.
-
01:49 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
- are you about to open it for constributors? in such case all stable branches should be marked as protected.
for me it would be much easier. I'll instantly know about potential conflicts or if tests are green without even setting a loc...
2019-05-20
-
22:51 Feature #31395: Make the footer of the 'Powered by Redmine' line user changeable.
- Thank you for your response.
-
22:38 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
- I made two changes:
1. Moved the repository from my namespace to a new one created 'redmine-org'.
2. Changed the visibility to public.
If you consider it shouldn't be public, please let me know. I'm still using it to keep my work an... -
22:34 Feature #23980: Replace icon images with Tabler SVG icons
- Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Sorry, I didn't know that the project is private. I made it public now, you should have access. -
16:51 Feature #23980: Replace icon images with Tabler SVG icons
- Marius BALTEANU wrote:
> "Here":https://gitlab.com/redmine-org/redmine/merge_requests/3 is an updated version of my patch.
Since the page requires authentication, I could not get the patch. -
08:49 Feature #23980: Replace icon images with Tabler SVG icons
- "Here":https://gitlab.com/redmine-org/redmine/merge_requests/3 is an updated version of my patch. Because the size of the patch is too big, you need to download it from my gitlab instance (screenshot attached for those who are not famili...
-
19:52 Defect #31407 (New): relative_url_root does not correctly set the menu_items href
- If I set the relative_url_root in config/environment.rb using
Redmine::Utils::relative_url_root = "/redmine"
or
ActionController::Base.relative_url_root = "/redmine"
or with an ENV of RAILS_RELATIVE_URL_ROOT=/redmine
the script a... -
17:26 Feature #31225: Show the number of days left until the due date in reminders
- Yuichi HARADA wrote:
> Sorry, I fixed to the UTC Date at 0:00 using @travel_to Date.today.to_time(:utc)@ .
> ...
Unfortunately, tests still fail. -
07:23 Feature #31225: Show the number of days left until the due date in reminders
- Go MAEDA wrote:
> The tests fail depending on the timezone.
> ...
Sorry, I fixed to the UTC Date at 0:00 using @travel_to Date.today.to_time(:utc)@ .
This fix eliminates the dependency on time zones. -
01:36 Feature #31225 (Reopened): Show the number of days left until the due date in reminders
- The tests fail depending on the timezone.
I think the error occurs when the date of the current timezone is different from the date in UTC. For example, I observed the following error on *20 May* 2019 08:15:00 +0900 (*19 May* 2019 23:... -
17:11 Patch #28510: Show issue assignee gravatar in roadmap and version page
- Marius BALTEANU wrote:
> Here is the updated patch that can be applied after #31391 is committed.
The patch works fine but I prefer the layout of attachment:assignee_first.png is better the layout of the latest patch because the star... -
15:39 Feature #31196: Updates jQuery to 2.2.4 and adds jQuery Migrate library
- I've some work in progress on this topic.
-
14:46 Feature #31196: Updates jQuery to 2.2.4 and adds jQuery Migrate library
- Federico Vera wrote:
> The current version of jQuery used in Redmine (1.11.1) is a couple of years old, and plagued with known "security vulnerabilities":https://www.cvedetails.com/vulnerability-list.php?vendor_id=6538&product_id=0&vers... -
14:59 Defect #31387: Don't rescue Exception class
- exceptions have a hierarchy
-
14:26 Defect #31387: Don't rescue Exception class
- Pavel Rosický wrote:
> it should be -
14:09 Defect #31387: Don't rescue Exception class
- thanks, there's a typo in config/routes.rb
it should be -
13:46 Defect #31387: Don't rescue Exception class
- Here are patches to fix not to raise/rescue Exception. I hope someone to review these patches.
-
11:39 Feature #31404 (Resolved): Time visualization plugin
- This feature could help the project management to review the estimations.
This plugin makes the plannings faster and the presentations more understandable.
http://www.redmine.org/plugins/redtime
-
11:28 Feature #6666: Soft delete of issues
- +1
-
10:51 Patch #5899 (Closed): Display user's gravatar when editing profile
- Committed the patch.
-
10:44 Patch #31402 (Closed): Add support for customization by block to IssueCustomField.generate!
- Committed the patch. Thank you for your contribution.
-
09:09 Patch #31402: Add support for customization by block to IssueCustomField.generate!
- Setting the target version to 4.1.0.
-
08:29 Patch #31402 (Closed): Add support for customization by block to IssueCustomField.generate!
- @generate!@ methods in @test/object_helpers.rb@ supports customizing by block. But @IssueCustomField.generate!@ doesn't support it.
The attached patch adds it.
FYI: I created this diff by Git. Because I have the same problem as #24... -
10:37 Patch #31398 (Closed): Traditional Chinese translation (to r18175)
- Committed. Thank you for your contribution.
-
05:27 Patch #31398 (Closed): Traditional Chinese translation (to r18175)
- * New tags added
** label_import_time_entries, label_import_notifications, text_gs_available
-
10:34 Patch #31147 (Closed): Add custom styles for all fields
- Committed the patch in #31147#note-22. Thanks.
-
09:39 Patch #31147: Add custom styles for all fields
- Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Not really, I think it is enough to revert only the CSS change and committed it again as part of this ticket. -
09:35 Patch #31147: Add custom styles for all fields
- Marius BALTEANU wrote:
> Go Maeda, just to know, you have committed the change proposed above by Bernhard as part of the #31391.
Sorry, I didn't know the mistake. Do you think if I should revert r18175 and commit #31391 again?
-
09:30 Patch #31147: Add custom styles for all fields
- Go Maeda, just to know, you have committed the change proposed above by Bernhard as part of the #31391.
Please see http://www.redmine.org/projects/redmine/repository/revisions/18175/diff/trunk/public/stylesheets/application.css -
09:26 Feature #31355: Bookmarks and recently used projects for the project jump box
- I am sure that no one will dislike or oppose this feature. Let's deliver this feature in 4.1.0.
-
09:15 Feature #31355: Bookmarks and recently used projects for the project jump box
- The patch looks very good to me. I'm in favour of delivering this feature in version:"4.1.0".
-
07:40 Feature #31355: Bookmarks and recently used projects for the project jump box
- Bernhard Rohloff wrote:
> Oh, one thing I forgot is, the patch doesn't contain the two new icons referenced by the stylesheet changes.
> ...
The icons are included in the patch. You can get them by using @git apply@ instead of @patch@ ... -
06:25 Feature #31355: Bookmarks and recently used projects for the project jump box
- Oh, one thing I forgot is, the patch doesn't contain the two new icons referenced by the stylesheet changes.
-
06:03 Feature #31355: Bookmarks and recently used projects for the project jump box
- I've tried the patch and it makes project switching very fast and easy. A really great improvement for Redmine!
+1 -
09:13 Patch #31384: Remove custom lazy loading of i18n files
- Jean-Philippe, please take a look at the patch proposed by Pavel as a fix to a problem that was introduced by me when we updated the i8n gem to 1.6.0 (#29946).
For me, the change looks good, especially because we drop quite a lot of c... -
08:35 Feature #25746: Spent time - CUSTOM fields - permissions
- +1
-
05:34 Patch #31399 (Closed): make /my/account endpoint accessible through API
- This would allow a user to update their account info through an external app. Currently admin privileges are required to change i.e. a user's name through the /users API.
-
00:27 Patch #31391 (Closed): Small refactorization of avatar methods
- Committed the patch. Thanks.
2019-05-19
-
17:54 Feature #31395: Make the footer of the 'Powered by Redmine' line user changeable.
- Excuse me, but please change it because the subject was incorrect
From -
17:02 Feature #31395 (New): Make the footer of the 'Powered by Redmine' line user changeable.
- In the case of in-house operation, it may be instructed to display the management department / responsible person name display in the footer.
It can be dealt with by modifying the source code, but I think that it is desirable to be ab... -
16:53 Feature #31381: Find change status of issues at custom query
- +1
-
13:07 Feature #31381: Find change status of issues at custom query
- +1
-
15:30 Feature #29946 (Reopened): Update i18n gem (~> 1.6.0)
- #31384 has been reported for this change.
-
14:03 Patch #5899: Display user's gravatar when editing profile
- Go MAEDA wrote:
> Marius, could you attach the patch?
Sorry, I referred to the patch from #31391. Your patch from note-1 is good enough, we should remove only the size from it. -
13:19 Patch #5899: Display user's gravatar when editing profile
- Marius, could you attach the patch?
-
13:55 Defect #31388: ApiTest fails if config.time_zone is set
- Should we update the test code or always fix the time zone for API responses to UTC?
-
12:08 Feature #29824: Add user initials when Gravatar is disabled
- Go MAEDA wrote:
> I prefer option 2 for privacy reason. An admin should be able to decide whether to send characters extracted from user names to ui-avatars.com.
> ...
We won't use ui-avatars.com or any other external service, it will ... -
11:58 Feature #29824: Add user initials when Gravatar is disabled
- I prefer option 2 for privacy reason. An admin should be able to decide whether to send characters extracted from user names to ui-avatars.com.
As I wrote in #29824#note-5, the names of people in East Asian countries such as Japan, Ch... -
10:58 Feature #23778 (Closed): default sort email reminders by due date (and list due date in email)
- The upcoming Redmine 4.1.0 shows the number of days left until the due date ("due in X days" / "X days late"). Please see #31225 for details.
-
10:57 Patch #6357 (Closed): Show and sort by due_date in reminders
- The upcoming Redmine 4.1.0 shows the number of days left until the due date ("due in X days" / "X days late"). Please see #31225 for details.
-
10:53 Feature #31225 (Closed): Show the number of days left until the due date in reminders
- Committed the patch. Thanks.
-
08:21 Patch #31391: Small refactorization of avatar methods
- LGTM. Setting the target version to 4.1.0.