Project

General

Profile

Activity

From 2019-09-04 to 2019-09-06

2019-09-06

23:37 Feature #1580 (Closed): Field to store comments in Custom Fields
The description field for custom fields has been added in r12400 for Redmine 2.5.0. Go MAEDA
21:03 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
Anyhow I'd elaborate, but for whatever reason I can't post my reply because: "This request was denied because it was considered spam or your IP adress () is temporarily blocked." Not only there is a typo in that message, but also it bloc... Anonymous
17:27 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
Antonio McDeal wrote:
> I don't know?... Aren't colors considered as theming capabilities? I always thought it's the most fundamental thing actually.
Ok back to topic. What are the advantages of your colors of choice over the current c...
Bernhard Rohloff
16:00 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
I don't know?... Aren't colors considered as theming capabilities? I always thought it's the most fundamental thing actually.
And even if we set things like these apart "improving the theming capabilities" besides colors may be as subje...
Anonymous
12:51 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
Antonio McDeal wrote:
>...
> ...
If this is the case, wouldn't it make more sense to concentrate on improving the theming capabilities instead of changing its default colors?
Bernhard Rohloff
10:59 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
P.S. an interesting article about colors: https://www.helpscout.com/blog/psychology-of-color/ Anonymous
10:04 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
Bernhard Rohloff wrote:
> I think to get a decision on this topic we need more feedback from the community and should spark discussions in all our communication channels.
We tried this one before, nobody simply just cares... there is n...
Anonymous
09:44 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
@Bernhard, not sure what version of Chrome you got, but I got all identical colors on latest Firefox, Chrome and even IE11.
!colors.png!
Anonymous
09:18 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
To leave my 2cts on this topic. Colors are a very subjective choice. You don't meet the taste everybody. I think to get a decision on this topic we need more feedback from the community and should spark discussions in all our communicat... Bernhard Rohloff
17:10 Feature #27314: Remove the 'Administration' index page and jump right into settings
Antonio McDeal wrote:
> P.S. As you mentioned on Discord once, and I think it was your idea as well. If "ditching the sidebar and giving Redmine a proper menu toolbar instead" will happen, will this patch have to be kind of rethought ag...
Bernhard Rohloff
16:29 Feature #27314: Remove the 'Administration' index page and jump right into settings
@Bernhard +1 go for it! This adds on to the rule of "less clicks to get to desired destination". The index view would also be unnecessary then.
P.S. As you mentioned on Discord once, and I think it was your idea as well. If "ditching ...
Anonymous
14:46 Feature #27314: Remove the 'Administration' index page and jump right into settings
I've changed my proposal. Patch is available, too. Bernhard Rohloff
16:56 Patch #31441: Show elements titles using jQuery UI tooltips
I think tool-tips like these should also be used as gantt tool-tips which display brief information when rolling cursor over issue lines of the timeline, because currently those kind of tool-tips in gantt aren't designed to spawn on the ... Anonymous
16:07 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
@Marius I would also like to test it, and if it's not ready, we could atleast disassemble it and take a look. Anonymous
15:14 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
@Marius have you had time to make any progress on this issue in last time?
If yes, I would love to test it. :-)
Bernhard Rohloff
11:43 Feature #1739: Add ability to change issue author
+1 billy chou
10:25 Patch #25265: QueriesController can not handle subclass of IssueQuery
Hi Jean-Philippe,
your suggested change would be fix problems for some plugins, which I maintain. It would be nice to get this change in a upcoming release.
Alexander Meindl
06:56 Patch #32025 (Closed): mail_body method in test/test_helper.rb raises an exception if the message is not multipart
Yuichi HARADA
04:37 Feature #31989: Inline issue auto complete (#) in fields with text-formatting enabled
Go MAEDA wrote:
>It is ideal if we can deliver the feature together with #13919.
I agree with this opinion.
I also associate mention feature from @user format as Go MAEDA says.
Mizuki ISHIKAWA
04:24 Feature #31989: Inline issue auto complete (#) in fields with text-formatting enabled
I am hesitating to commit the patch because auto-complete feature for users was added. If the patch had not had the auto-complete for users, I had committed the patch without any hesitation.
As I wrote in #31989#note-14, I am afraid t...
Go MAEDA

2019-09-05

20:35 Patch #30448: Remove wrapper2 and wrapper3 wrapping containers
Actively maintained themes have to be anyway patched on per minor release basis, and not actively maintained themes shouldn't be our responsibility really. I bet those wrappers aren't even the most important things that may affect things... Anonymous
16:58 Feature #31921: Changes to properly support 4 byte characters (emoji) when database is MySQL
I updated Marius's patch:
* Removed "with ruby1.9". The version of Ruby is unnecessary because Redmine no longer supports Ruby 1.8 that require 'mysql' adapter instead of 'mysql2' adapter. Please see the example file in Redmine 2.6 fo...
Go MAEDA
13:54 Feature #31989: Inline issue auto complete (#) in fields with text-formatting enabled
I think it is better to add @requireLeadingSpace: true@ in order to prevent the auto-complete menu from being displayed while typing the second "#" in "#123#note-4" or "@" in "foo@example.com". Go MAEDA
13:21 Patch #32019 (Closed): Remove unnecessary scroll indicator from Gantt page
Committed the fix as a part of #27672. Thank you for reporting and fixing this issue. Go MAEDA
06:02 Patch #32019: Remove unnecessary scroll indicator from Gantt page
LGTM. This superfluous scrollbar was introduced by r18171 as part of #27672. Mischa The Evil
02:18 Patch #32019: Remove unnecessary scroll indicator from Gantt page
The vertical scrollbar in the gantt is useless even when there are many issues. I think it is no problem to remove it.
Setting the target version to 4.1.0.
Go MAEDA
12:31 Patch #32023 (Closed): Add missing fixtures to IssueStatusesControllerTest
Committed the patch. Thank you for fixing the issue. Go MAEDA
09:52 Patch #32023 (Closed): Add missing fixtures to IssueStatusesControllerTest
@IssueStatusesControllerTest#test_index_should_show_warning_when_no_workflow_is_defined@ has failed. Yuichi HARADA
12:26 Feature #32002: Add inherit_members to projects API response
Thank you. Alex Sinav
06:11 Feature #32002 (Closed): Add inherit_members to projects API response
Committed the patch. Thank you for your contribution.
Alex Sinav wrote:
> So is there plans to update REST API with this feature?
It will be available in upcoming Redmine 4.1.0, stay tuned. Thank you for reporting this.
Go MAEDA
03:24 Feature #32002: Add inherit_members to projects API response
LGTM. Setting the target version to 4.1.0. Go MAEDA
02:08 Feature #32002: Add inherit_members to projects API response
I fixed to return @inherit_members@ for @GET /projects/:id.(xml|json)@ and @GET /projects.(xml|json)@.
I attached a patch.
Yuichi HARADA
11:54 Defect #32024 (Closed): Broken gzip icon in the repository view
Committed the patch. Thank you for catching and fixing the issue. Go MAEDA
11:46 Defect #32024: Broken gzip icon in the repository view
In my environment, @Redmine::MimeType.css_class_of('foo.gz')@ returns "application-x-gzip" in 2.6-stable but "application-gzip" in 3.0-stable.
Probably it has been broken since Redmine 3.0.
Go MAEDA
09:52 Defect #32024 (Closed): Broken gzip icon in the repository view
Seiei Miyagi
10:05 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
Beauty knows no pain! :D It really reduces the amount white (specifically large non-text elements) against oppositely contrasted background in the header though. To be fair we will never know unless a new way on something is shown to use... Anonymous
04:31 Patch #32017: A much happier blue palette for the header (#header + #top-menu)
I prefer not to hide the search box and the project selector. I am afraid that it makes difficult for newcomers to find the features. Go MAEDA
10:02 Feature #2716: User option to automatically add assignee to watchers
kai b wrote:
> Hi, i have forked this plugin on Github and fixed Redmine 4 compatibility:
> ...
It doesn't work with version 4.0.4.stable
If you try make new issue, and assign user - it will crash.
In logs:
Anton Koptsev
09:23 Feature #31154 (Closed): Reject setting RFC non-compliant emission email addresses
Yuichi HARADA wrote:
> Go MAEDA wrote:
> ...
Committed the fix in r18434. Thanks.
Go MAEDA
07:43 Feature #31154: Reject setting RFC non-compliant emission email addresses
Go MAEDA wrote:
> The test sometimes fails:
> ...
I think @::I18n.locale@ was set to @'fr'@ in other tests. I think it will be solved with this patch.
Yuichi HARADA
09:01 Defect #32022 (Closed): IssueSubtaskingTest fails with high probability
Merged to 3.4-stable. Go MAEDA
08:45 Defect #32022 (Reopened): IssueSubtaskingTest fails with high probability
3.4-stable branch has the same problem. It also can be fixed by backporting r17761. Go MAEDA
07:58 Defect #32022 (Closed): IssueSubtaskingTest fails with high probability
Merged r17761 to 4.0-stable. Go MAEDA
07:17 Defect #32022: IssueSubtaskingTest fails with high probability
I backported r17761 to 4.0-stable and performed the same seed test.
I have confirmed that no fail occurred in IssueSubtaskingTest.
Yuichi HARADA
05:32 Defect #32022: IssueSubtaskingTest fails with high probability
The test assumes that @User.current@ is @AnonymousUser@, who cannot see other user's private issue. The error occurs when @User.current@ is a user whose role has permission to see see other user's private issue.
We can fix the error b...
Go MAEDA
04:43 Defect #32022: IssueSubtaskingTest fails with high probability
I am having been observed this issue since r18359. I think it can be fixed if r17761 is merged to 4.0-stable branch. Go MAEDA
04:38 Defect #32022 (Closed): IssueSubtaskingTest fails with high probability
Go MAEDA
07:01 Feature #28471: Query links for subtasks on issue page
here's how it looks now...
!{border: 1px solid #ccc;}subtask_query_links.png!
Bernhard Rohloff
06:41 Feature #28471: Query links for subtasks on issue page
This patch implements Ewan's proposal. It's quite convenient to filter subtasks this way. Good idea!
Bernhard Rohloff
02:19 Patch #30435 (Reopened): Replace float rules with flexbox for content and sidebar block
Go MAEDA
02:03 Defect #32012 (Closed): Broken JavaScript icon in the repository view
Go MAEDA
01:59 Defect #32012 (Resolved): Broken JavaScript icon in the repository view
Committed the patch. Thank you for your contribution. Go MAEDA
01:45 Defect #32012: Broken JavaScript icon in the repository view
Confirmed that the icon is not displayed due to r10195 and the attached patch fixes the issue.
!{width: 300px; border: 1px solid #ccc;}.before@2x.png!
!{width: 300px; border: 1px solid #ccc;}.after@2x.png!
Go MAEDA

2019-09-04

21:04 Patch #32021 (New): Give project description, homepage and custom fields an own box too
This patch wraps project information like description, homepage, custom fields in the box if they exist.
Couple of very minor problems with this patch, but aren't catastrophic to not consider proceeding:
1. If a custom field exists a...
Anonymous
19:44 Feature #8095: Allow overriding the default text formatting in each project
Currently, we use the following plugin:
https://www.redmine.org/plugins/per-project-formatting
but it would be nice to have this upstream. Or even per page formatting!
Peter Volkov
19:39 Patch #32016: Rounded corners on roadmap's progress bar
!roadmapbar.png! Anonymous
19:01 Patch #32016 (New): Rounded corners on roadmap's progress bar
Same motivation as for #32013 Anonymous
19:36 Patch #32015: Rounded corners of "my page" blocks
!roundedmypage.png! Anonymous
18:58 Patch #32015 (Closed): Rounded corners of "my page" blocks
Same motivation as in #32013 Anonymous
19:33 Patch #32013: Rounded corners of the main menu
!roundedmenu.png! Anonymous
18:53 Patch #32013 (Closed): Rounded corners of the main menu
Most UI elements of Redmine are now rounded, it feels like main menu should too. Anonymous
19:31 Patch #32014: Rounded corners on table.list elements
!{border: 1px solid; border-color: #ccc; width: 99%;}roundedlisttables.png!
!{border: 1px solid; border-color: #ccc; width: 99%;}roundedlisttables2.png!
Anonymous
18:56 Patch #32014 (Closed): Rounded corners on table.list elements
Same motivation as in #32013
The patch doesn't make calendar and gantt tables rounded though, due to more complex structure that they have, hence requiring different approach.
Anonymous
19:23 Patch #30435: Replace float rules with flexbox for content and sidebar block
To conclude the major point behind this issue, which never got resolved back then, here is a patch to try out as a reference to #30435#note-19 Anonymous
19:18 Patch #32019 (Closed): Remove unnecessary scroll indicator from Gantt page
!Capture.PNG! Anonymous
19:16 Patch #32018: Visually consolidate project selector and the popup box with the projects
This looks the best when #32017 is applied, else there will be border between bar and the box. Anonymous
19:14 Patch #32018 (New): Visually consolidate project selector and the popup box with the projects
!preview.png! Anonymous
19:11 Patch #32017 (Closed): A much happier blue palette for the header (#header + #top-menu)
This patch also makes search bar + project selector "camouflage" a bit until clicked.
!newheader.png!
!focusedsearchbar.png!
!focusedselector.png!
Anonymous
18:50 Defect #32012 (Closed): Broken JavaScript icon in the repository view
Related to #11621 Anonymous
12:21 Feature #32009 (New): Allow to directly edit Issues
Hi,
thanks for this amazing application, we introduced redmine in our company and it works great sofar. But people are complaining about the following:
Before editing or writing a comment they must press edit. So I am thinking abo...
Jannis Hübl
11:59 Feature #32002: Add inherit_members to projects API response
So is there plans to update REST API with this feature? Alex Sinav
02:34 Feature #32002: Add inherit_members to projects API response
Unfortunately, @GET /projects/:id.(xml|json)@ and @GET /projects.(xml|json)@ don't return @inherit_members@. I think the APIs should have been updated when the feature was added in Redmine 2.3.0 (#5605). Go MAEDA
10:01 Feature #32005 (New): Better Category Handling
One of my central projects had become hard to manage so I split out about 25% of the functionality into a new project. As I set about moving 100's (and soon 1000's) of tasks to the new project I realised a major drawback of my approach -... Ewan Makepeace
09:39 Defect #30467 (Closed): Footer is not placed at the bottom on pages with little content
Committed the patch. Thank you for your contribution. Go MAEDA
07:15 Defect #30467: Footer is not placed at the bottom on pages with little content
I had a chat with Go and it's OK for him, so LGTM! :-) Bernhard Rohloff
08:16 Feature #31321 (Closed): Option not to block closing a parent issue when its subtask is open
Duplicate of #28492. Toshi MARUYAMA
08:12 Feature #31322 (New): Provide a way to automatically close all open subtasks too when a parent issue is being closed
I don't think this issue is duplicate of #28492. Toshi MARUYAMA
04:00 Defect #32003 (Confirmed): Project copy always send email notifications ignoring "Send email notifications during the project copy" option
When copying a project in the projects list(Administration > Projects), you can disable sending an email by unchecking the "Send email notifications during the project copy" checkbox.
However, even if this checkbox is unchecking, email ...
Yuichi HARADA
03:35 Defect #31900: Problem with tickets issued by rdm-mailhandler on redmine 4.0.4
My coworker looked into this but we could not reproduce the problem. The email you sent to me was correctly parsed after replacing rdm-mailhandler.rb with the latest one. Go MAEDA
02:40 Patch #31556: Update Rouge to 3.12.0
Updated Rouge to 3.10.0 in r18424. Go MAEDA
02:19 Feature #31921: Changes to properly support 4 byte characters (emoji) when database is MySQL
I think the change against test/unit/issue_test.rb should not be merged because it may break tests on the official CI server if the encoding of the MySQL database on the CI server is not utf8mb4.
http://www.redmine.org/builds/
No one...
Go MAEDA
 

Also available in: Atom