Activity
From 2020-01-29 to 2020-01-31
2020-01-31
-
19:37 Feature #4462: Per Project Emission Address
- +1 this would help really as we provide each of our customers with dedicated email address where we capture tickets sent to it...these are converted into the issues in specific project (per customer).
When any update is done to the iss... -
15:22 Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed
- Fix indents.
-
15:06 Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed
- Mischa The Evil wrote:
> -
14:54 Defect #32921: Rails 6: add header=present to csv tests
- Pavel Rosický wrote:
> yeah, because the documentation is obsolete, it was changed here https://github.com/rails/rails/pull/37017
Thanks, it's clear now. Your patches look good to me and the failing tests because of this are passing ... -
11:27 Defect #32921: Rails 6: add header=present to csv tests
- yeah, because the documentation is obsolete, it was changed here https://github.com/rails/rails/pull/37017
-
09:38 Defect #32921: Rails 6: add header=present to csv tests
- Pavel, maybe you have a clue because I can't find or understand why @media_type@ returns "text/csv; header=present" and not only @text/csv@ as is explained "here":https://github.com/rails/rails/blob/master/guides/source/upgrading_ruby_on...
-
14:33 Feature #28492: Option not to block closing a parent issue when it has open subtask(s)
- Mischa The Evil wrote:
> I'd propose the following T9N for the string @setting_close_parent_issue_whose_subtasks_are_open@: "Allow closed parent issues with open subtasks" and a similar I18n string and setting name.
Changed. -
13:14 Defect #32859: Issue list: long text custom field missing in PDF export
- JFTR: applied the patch and works perfectly, Thanks!
-
11:34 Patch #31439 (Closed): I can not attach a file to a ticket
- Closing because this seems a plugin issue.
-
11:29 Defect #32930: Unable to uncheck "All projects" in saved issue filter query
- Yes, it's the same thing.
I couldn't find it. Thanks.
However I've proposed possible solution
(from User Experience perspective). -
11:02 Defect #32930: Unable to uncheck "All projects" in saved issue filter query
- Maybe is this the same issue as #28033?
-
08:51 Defect #32930: Unable to uncheck "All projects" in saved issue filter query
- One possible solution would be to show project select box, when All projects is unchecked.
-
08:39 Defect #32930 (Closed): Unable to uncheck "All projects" in saved issue filter query
- If you choose some issue filtering options, and save them for one project (by not clicking for all projects) it works.
But if you edit it, and check All projects, it also works and is visible in all projects.
However, if you unchec... -
11:28 Defect #28033: Unable to turn off "For all projects" flag of custom queries
- +1 please see #32930 I've proposed a possible solution.
-
10:42 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects
- Maybe if the shift key is maintained during the drag+drop, the original email is deleted, or something like that?
-
10:38 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects
- I've Redmine 4 customers who find the actual behaviour very convenient:
When they drag an e-mail from Outlook to Redmine, the e-mail disappear from Outlook, while is actually what they want, because the e-mail has been "processed" and s... -
09:30 Patch #32922 (New): Reload detached attachments
- Let's keep it open, maybe we can fix the issue.
-
09:29 Patch #32911: Rails 6: Fix deprecation warning "Class level methods will no longer inherit scoping"
- Tests pass here: https://gitlab.com/redmine-org/redmine/pipelines/113171478
-
09:07 Defect #29694: Some buttons in wiki toolbar are hidden in responsive layout
- I made two patterns of patches to make wiki-toolbar scrollable.
Attach the patches with the screenshot.
(1) scrollable-css.patch
Add scroll setting with css to wiki-toolbar.
!{width:400px}scrollable-css.gif!
(2) move-left-righ... -
08:21 Patch #32929 (Closed): Add missing fixtures to AttachmentsControllerTest
- Committed the patch. Thank you.
-
02:51 Patch #32929 (Closed): Add missing fixtures to AttachmentsControllerTest
- AttachmentsControllerTest has failed.
-
08:05 Feature #4511: Allow adding user groups as watchers for issues
- Yuichi HARADA wrote:
> Fixed functionality to allow adding groups to the watcher of issues.
> ...
Thank you for posting the patch for this long-awaited feature. I tried out the patch and it works fine.
!{width: 433px; border: 1px so... -
03:23 Feature #4511: Allow adding user groups as watchers for issues
- Fixed functionality to allow adding groups to the watcher of issues.
I attached a patch. -
05:17
Defect #32915: Internal Server Error occurted when exporting gantt chart to png on Windows
- To work on Windows, divided the MiniMagick "convert" block.
This patch can display up to about 200 issues.
However, the subjects() and lines() functions create "convert" commands internally, so these could't be divided.
2020-01-30
-
16:38 Feature #8241: Advanced notification: per user, per project configurable schedule, event filter and notification format
- +1
-
16:06 Patch #32927: CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific
- No, we should not ;) But I think this specific test is too precise. It will break as soon as the table is modified, even if the tested function has not changed.
But feel free to close my issue if you prefer to not update the current t... -
15:20 Patch #32927: CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific
- Plugins often break core tests. Should we relax tests every time a plugin the test suite?
-
14:27 Patch #32927 (Closed): CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific
- Hi
Just a tiny patch which makes a test less specific. This way, a plugin can add columns to the table without breaking core tests.
Thank you -
15:47 Patch #32918 (Closed): Czech translations
- Committed the patch. Thank you.
-
15:43 Patch #32928 (Closed): Czech translation for 4.1-stable
- Committed the patch. Thank you for your contribution.
-
15:37 Patch #32928 (Closed): Czech translation for 4.1-stable
- Originally posted by Pavel Rosický as #32918.
-
15:26 Patch #32917 (Closed): Bulgarian translation
- Committed the patch. Thank you for your contribution.
-
12:28 Patch #32922 (Resolved): Reload detached attachments
- sry, thanks for catching this, I was confused about the comment. Closing
-
08:13 Patch #32922: Reload detached attachments
- Thanks Pavel for posting the patches for Rails 6 update.
I've applied this patch on the current trunk and a test fails: -
00:57 Patch #32922 (Closed): Reload detached attachments
- use #reload instead, after upgrading to Rails 5
-
11:55 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note
- +1 for this
-
09:34 Defect #32477 (Resolved): Right-aligned TOC tag is displayed in exported PDF if the text formatting setting is Markdown
- Committed the patch.
-
09:19 Feature #16006: Include attachments in forum post notifications
- Yuichi HARADA wrote:
> Perhaps I think that Message's callback method @after_create_commit@ ( "Message#send_notification":https://www.redmine.org/projects/redmine/repository/entry/trunk/app/models/message.rb#L126 ) fired before saving t... -
08:47 Defect #5354: Updating custom fields does not trigger update to "updated_on" field in the customized object
- Setting the target version to 4.2.0.
-
08:16 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Thanks, patch from #note-5 is the correct one, you can commit it. -
06:27 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Marius BALTEANU wrote:
> Sorry, I've attached a broken patch, please revert it and will post later the correct one.
Done. -
04:45 Patch #32924 (Closed): tmp/pdf directory is no longer necessary
- We can remove the following code because @tmp/pdf@ directory that is used when generating pdf files is no longer used after r13358.
Curentry, the PDF library rbpdf uses tmp instead of tmp/pdf as a temporary directory. -
03:34
Defect #32916: Bar length is wrong when exporting gantt chart to PDF
- Improved bar length calculation accuracy for exporting to PDF (and png).
(modified patch code) -
02:53 Feature #32240: Add download buttons in Files columns of the issues list
- LGTM. Setting the target version to 4.2.0.
-
02:46 Feature #3088: Estimated hours field able to hide role based
- Go MAEDA wrote:
> Now the patch cannot be applied cleanly.
Fixed the patch to work on the current trunk(r19478). -
01:00 Defect #32923 (Closed): Rails 6: detach attachments when a conflict occurs
- fixes
2020-01-29
-
23:06 Defect #32921 (Closed): Rails 6: add header=present to csv tests
- fixes
-
22:38 Patch #32909: Replace pluck().first with pick()
- Looks good to me.
-
11:33 Patch #32918 (Closed): Czech translations
-
08:07 Patch #32917 (Closed): Bulgarian translation
- * field_toolbar_language_options
* label_user_mail_notify_about_high_priority_issues_html -
06:15
Defect #32916 (Closed): Bar length is wrong when exporting gantt chart to PDF
- When exporting a gantt chart to PDF, short (1 or 2 days) tasks are sometimes correct and sometimes incorrect, depending on the time period.
(The attached image is modified.)
!{width:500px}gc2pdf.png!
Calculation error of start and e... -
05:58 Defect #32737: Duplicate sort keys for issue query cause SQL error with SQL Server
- Go MAEDA wrote:
> Maybe also this patch will work.
Execute tests on SQL Server, 12 test failures (500: Internal Server Error. I think duplicate ORDER BY clauses are involved) and 16 execution errors (duplicate ORDER BY clause) occurr... -
05:44 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects
- Simon Hori wrote:
> Now it works perfectly fine with my MS Outlook!!
> ...
Thank you for the test result. Setting the target version to 4.0.7. -
05:37 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects
- Sorry, you are right. I changed a wrong line in `dragOutHandler` but it must be added to `dragOverHandler` as you wrote.
Now it works perfectly fine with my MS Outlook!!
No deletion occurred after a drag-drop. Thank you.
I hope th... -
04:07 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects
- Simon Hori wrote:
> Thanks for the patch! I believe I added the two lines properly to the js but unfortunately it is still deleting the item from my Outlook and this error is logged when mouse over to the drop area.
> ...
attachments.j... -
03:41 Defect #32656: Drag and drop objects from Outlook to Redmine deletes the objects
- Thanks for the patch! I believe I added the two lines properly to the js but unfortunately it is still deleting the item from my Outlook and this error is logged when mouse over to the drop area.
-
05:11
Defect #32915 (New): Internal Server Error occurted when exporting gantt chart to png on Windows
- Redmine 4.0.4 using RMagick was fine.
However, Redmine 4.1.0 using MiniMagick does not work.
prodution.log of Redmine 4.1.0 is this: -
02:07 Defect #32914 (Closed): Rails 6: remove #filename_for_content_disposition for MS browsers
- relates to #32913
this prevents double escaping, fixes -
01:33 Defect #32913 (Closed): Rails 6: add filename header
- fixes
-
00:50 Defect #32912: Rails 6: update no longer bypass optimistic locking
- I'm not sure about test_copy_should_not_copy_subtasks_twice_when_saving_twice which was introduced in https://github.com/redmine/redmine/commit/5003927f13f54850ca9eeac48e353df5e4e325a1
it should be probably refactored in order to refl... -
00:42 Defect #32912 (Closed): Rails 6: update no longer bypass optimistic locking
- fixes test failures