Project

General

Profile

Activity

From 2018-06-16 to 2018-06-18

2018-06-18

21:36 Feature #29048: Wiki page permission level
Did you consider using multiple projects and cross-project wiki links? Gregor Schmidt
18:42 Feature #29048: Wiki page permission level
User with lover level will see pages of high level and not vice versa filippo mandelli
18:36 Feature #29048 (New): Wiki page permission level
I would like to set different permission level in a wiki page.
i.e:
| *Level* | *Description*|
| 1 | developers |
| 2 | service |
| 3 | marketing |
| 4 | customer |
And I would like to set permission in the Roles setting.
filippo mandelli
19:54 Defect #28925: Custom field values for enumerations not saved
why enumerations use strong params instead of safe_attributes like all other models do? Pavel Rosický
17:38 Defect #28925: Custom field values for enumerations not saved
Maybe we can use @available_custom_fields@ to collect ids of custom fields. I think the following change can make the patch simpler and faster. Mizuki, do you think it is correct? Go MAEDA
08:18 Defect #28925: Custom field values for enumerations not saved
I changed the test a little. Mizuki ISHIKAWA
07:44 Defect #28925: Custom field values for enumerations not saved
I wrote a patch to fix this defect.
The key of custom_field_values allows only id of custom field of enumeration.
Mizuki ISHIKAWA
15:44 Patch #29045: Change Japanese translation for Tracker
+1
I am also a Japanese. I think that this change is reasonable.
ryou soda
15:28 Patch #29045: Change Japanese translation for Tracker
+1
Yes, I agree, too.
Documentations and manuals are to be changed, but it must progress the understandability of Japanese ordinary people.
Masakazu IZUI
15:17 Patch #29045: Change Japanese translation for Tracker
+1
I also ageree.
Akipii Oga
14:22 Patch #29045: Change Japanese translation for Tracker
+1
I agree with this fix.
In Japanese, "トラッカー" is not a general term, it does not understand intuitively what it means.
If it is "チケット種別" (means "issue type") its meaning is easy to infer.
Yuuki NARA
09:04 Patch #29045: Change Japanese translation for Tracker
Here are some screenshots:
!{width: 1024px; border: 1px solid #ccc;}.trackers-index@2x.png!
!{width: 445px; border: 1px solid #ccc;}.issues-index@2x.png!
!{width: 742px; border: 1px solid #ccc;}.issues-edit@2x.png!
Go MAEDA
08:01 Patch #29045: Change Japanese translation for Tracker
+1 Hirofumi Kadoya
06:51 Patch #29045 (Closed): Change Japanese translation for Tracker
The current Japanese translation for the word "tracker" is "トラッカー". It is not a true translation but just an imitation of English pronunciation of "tracker". So, most Japanese people cannot understand the word "トラッカー" without someone's e... Go MAEDA
15:37 Defect #27153: Custom query breaks calendar view with error 500
Created issue in issue_hot_buttons plugin https://github.com/panicinc/issue_hot_buttons/issues/15 Nikita Remizov
12:02 Defect #28125: PNG images on a wiki page don't appear in exported PDF
bundle update and restart webserver should be enough?
For me it is not working...
Pawel Szafer
11:50 Defect #28125 (Resolved): PNG images on a wiki page don't appear in exported PDF
Go MAEDA
11:10 Defect #28125: PNG images on a wiki page don't appear in exported PDF
tested right now after bundle update, it's ok for we with redmine 3.4.5 stable, it works ! Xavier Poncet
11:45 Revision 17405 (svn): Update rbpdf gem to 1.19.4 (#28125).
Contributed by Jun NAITOH. Go MAEDA
08:14 Feature #29042 (Closed): Add links to Users, Projects and Versions (at least) in timelog report
Committed. Thank you for improving Redmine. Go MAEDA
08:13 Revision 17404 (svn): Add links to Users, Projects and Versions in timelog report (#29042).
Patch by Marius BALTEANU. Go MAEDA
07:24 Feature #5358: Share Issues Categories for sub-projects
+1 Mizuki ISHIKAWA

2018-06-17

22:40 Defect #29043 (New): Dropdown Project Search list is sorted in weird order
Since #19299 was implemented (I'm assuming somewhat here), the sort order of projects in the dropdown list is sort-of-alfabetical. If used to be in the same order as the project list, in other words, alfabetical, but with sub-project so... Roland Giesler
21:56 Feature #24568 (Closed): Show locked users in 'Users' filter for 'Spent time' report
Go MAEDA wrote:
> The patch #24568#note-10 looks good.
> ...

Done (#29042).
In this case, I'm closing this one as fixed by r17371 in #15201.
Marius BĂLTEANU
09:10 Feature #24568: Show locked users in 'Users' filter for 'Spent time' report
The patch #24568#note-10 looks good.
But I think it would be better to create a new issue for the patch. The reasons are as follows:
* The feature requested in this issue has already been implemented by #15201.
* Your patch bring...
Go MAEDA
21:53 Feature #29042 (Closed): Add links to Users, Projects and Versions (at least) in timelog report
This issue is extracted from 24568#note-8.
*Before:*
!{width: 60%; border: 1px solid grey;}timelog_report_before.png!
*After:*
!{width: 60%; border: 1px solid grey;}timelog_report.png!
In this way, the locked users will have ...
Marius BĂLTEANU
21:39 Defect #27283: Failed to run "rake db:migrate" command against clean database on MySQL 5.7
Official Docker image: Marius BĂLTEANU
16:53 Defect #27283: Failed to run "rake db:migrate" command against clean database on MySQL 5.7
Jean-Philippe Lang wrote:
> Migration is working fine for me with mysql 5.7.22 and default config using current trunk.
> ...
I can reproduce the problem.
* Ubuntu 16.04.2 LTS
* MySQL 5.7.22-0ubuntu0.16.04.1
/etc/mysql/my.cnf:
Go MAEDA
15:40 Defect #27283: Failed to run "rake db:migrate" command against clean database on MySQL 5.7
Migration is working fine for me with mysql 5.7.22 and default config using current trunk.
Please provide your my.conf in order to reproduce.
Jean-Philippe Lang
21:15 Defect #26892: Link to user in wiki syntax only works when login is written in lower case
I agree with the workaround posted above by Go Maeda, it is enough to fix the failing test. It seems that on my local environment, the search is case insensitive and the test doesn't fail. Marius BĂLTEANU
16:28 Defect #26892: Link to user in wiki syntax only works when login is written in lower case
Jean-Philippe Lang wrote:
> Marius, I have applied #26443 and I'm getting a failure for the test included in this patch:
This is a workaround for the error.
Go MAEDA
07:56 Defect #26892: Link to user in wiki syntax only works when login is written in lower case
Marius, I have applied #26443 and I'm getting a failure for the test included in this patch: Jean-Philippe Lang
20:00 Feature #28952: Update User#last_login_on only once per minute
done #29041 Pavel Rosický
16:54 Feature #28952 (Closed): Update User#last_login_on only once per minute
Patch committed, thanks.
Pavel Rosický wrote:
> I'm wondering if something like this could be also applied for
> ...
Please fill a separate issue so we can keep track of that.
Jean-Philippe Lang
19:57 Feature #29041 (Closed): Update session token only once per minute
this is simmilar to #28952
if Rails.application.config.redmine_verify_sessions is enabled, basically each read request triggers an update to tokens table. This is bad for performance because it blocks the database.
My patch transform...
Pavel Rosický
18:29 Feature #2471: Add my activities to my page
Setting target version to 4.1.0. Go MAEDA
18:23 Patch #28940: Use Regexp#match? to reduce allocations of MatchData object
I combined all patches into a single file and I retested it on Ruby 2.3 and Ruby 2.4 Pavel Rosický
18:01 Feature #28947: Show the existing attachments on the wiki editing page
Tomomi Yuzuriha wrote:
> I wrote a patch to implement this feature.
Thank you for submitting the patch.
Would you explain why the patch disables 'Delete' button on wiki#edit page?
Go MAEDA
17:29 Defect #29038: Thumbnail macro causes attachment file not found and broken filename and link
in thumbnail macro (lib/redmine/wiki-formatting/macros.rb), Toru Takahashi
17:00 Defect #29038 (Closed): Thumbnail macro causes attachment file not found and broken filename and link
Wiki's thumbnail macro seemed to break attachment's filename attribute when the attachment has non-blank description.
* case 1
On a wiki page attached an image file with description, and wrote twice thumbnail macros of the image fil...
Toru Takahashi
16:51 Revision 17403 (svn): Update User#last_login_on only once per minute and user to reduce DB lock contention on users table (#28952).
Patch by Holger Just. Jean-Philippe Lang
15:00 Defect #28951 (Closed): Cannot clear category field on copying an Issue
Jean-Philippe Lang
08:37 Defect #28951: Cannot clear category field on copying an Issue
Jean-Philippe Lang wrote:
> But the OP is using a stable branch, can you confirm?
No, I cannot reproduce it on 3.4.6. Probably the reporter is using the master branch of https://github.com/redmine/redmine. It is not an svn working co...
Go MAEDA
08:26 Defect #28951: Cannot clear category field on copying an Issue
Go MAEDA wrote:
> Confirmed the problem. This is due to r17320. The trunk is affected but stable branches are not.
This problem should be fixed by r17395.
But the OP is using a stable branch, can you confirm?
Jean-Philippe Lang
07:23 Defect #28951 (Confirmed): Cannot clear category field on copying an Issue
Confirmed the problem. This is due to r17320. The trunk is affected but stable branches are not. Go MAEDA
12:13 Revision 17402 (svn): Use arrows for repository browser.
Jean-Philippe Lang
12:04 Revision 17401 (svn): Removes unused move down/up CSS classes.
Jean-Philippe Lang
12:02 Revision 17400 (svn): Changes arrow images.
Jean-Philippe Lang
11:12 Revision 17399 (svn): Slight change to wiki toolbar style.
Jean-Philippe Lang
11:03 Revision 17398 (svn): Don't repeat revision on each line.
Jean-Philippe Lang
10:29 Revision 17397 (svn): Highlight "Spent time" in main menu when creating a time entries query.
Jean-Philippe Lang
10:23 Revision 17396 (svn): Add Users tab to application settings.
Jean-Philippe Lang
08:22 Revision 17395 (svn): Cannot clear category field on copying an Issue (#28951).
Jean-Philippe Lang
08:00 Defect #27968 (Closed): Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address
Patch committed, thanks Marius. Jean-Philippe Lang
08:00 Revision 17394 (svn): Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address (#27968).
Patch by Marius BALTEANU. Jean-Philippe Lang
07:57 Defect #26507 (Closed): "attachment:filename" link syntax would not work if the file name contains "@"
Thanks Marius. Jean-Philippe Lang
07:57 Revision 17393 (svn): "attachment:filename" link syntax would not work if the file name contains "@" (#26507).
Patch by Marius BALTEANU. Jean-Philippe Lang
07:47 Defect #26443 (Closed): User link syntax (user:login) doesn't work for logins consisting of an email adress
Patch committed, thanks Marius.
Marius BALTEANU wrote:
> Just a technical note: An interesting approach is the "html-pipeline":https://github.com/jch/html-pipeline used by GitHub which easily allows you to apply different filters or ...
Jean-Philippe Lang
07:45 Revision 17392 (svn): User link syntax (user:login) doesn't work for logins consisting of an email adress (#26443).
Patch by Marius BALTEANU. Jean-Philippe Lang
03:07 Defect #28946 (Closed): If assignee is locked subtasks don't get copied
Committed. Thank you for the fix. Go MAEDA
03:07 Revision 17391 (svn): Merged r17390 from trunk to 3.4-stable (#28946).
Go MAEDA
03:03 Revision 17390 (svn): Clear subtask assignee during copy if is locked (#28946).
Patch by Marius BALTEANU. Go MAEDA

2018-06-16

16:53 Feature #15919 (Closed): Set default category assignee immediately upon category selection
I made a small change that improves the behaviour when changing/removing the category and solves the 2 issues reported by Marius. Jean-Philippe Lang
16:50 Revision 17389 (svn): Handle default assignee when changing category (#15919).
Jean-Philippe Lang
16:35 Feature #26577 (Closed): More neutral color download icon
Jean-Philippe Lang
16:35 Feature #26576 (Closed): Use tabs to switch between file changes and diff of a commit
Jean-Philippe Lang
16:34 Feature #26579 (Closed): Project settings : remove Wiki tab
Jean-Philippe Lang
16:34 Feature #27849 (Closed): Ruby 2.5 support
Jean-Philippe Lang
16:33 Feature #26575 (Closed): Add update info at the bottom of the wiki page
Patch committed, thanks. Jean-Philippe Lang
16:33 Revision 17388 (svn): Add links to the user name and date on wiki update info (#26575).
Patch by Marius BALTEANU. Jean-Philippe Lang
16:31 Feature #26638 (Closed): Move journal action links above the notes
Patch committed, thanks. Jean-Philippe Lang
16:31 Revision 17387 (svn): Missing left-margin for journal icons (#26638).
Patch by Marius BALTEANU. Jean-Philippe Lang
16:30 Feature #26488 (Closed): Project settings : Move issue tracking settings to their own tab
Jean-Philippe Lang
16:29 Patch #26522 (Closed): Repository routing bug when file path starts with (browse|entry|raw|changes|annotate|diff)/
Routes without repository_id are removed. Jean-Philippe Lang
16:27 Revision 17386 (svn): Removes repository routes without repository_id (#26522).
Jean-Philippe Lang
16:09 Patch #11898: Inheritable issue categories
I added a category inheritance function to Redmine 3.4.6 and released it to GitHub repository.
See http://www.redmine.org/issues/5358#note-98
Yuuki NARA
16:01 Feature #5358: Share Issues Categories for sub-projects
I added a category inheritance function to Redmine 3.4.6 and released it to GitHub repository.
It is working on my environment, but I have not done enough operation check yet.
I did not add test code.
If you need this function, pl...
Yuuki NARA
13:53 Defect #28125: PNG images on a wiki page don't appear in exported PDF
This problem fixed by rbpdf 1.19.4.
please bundle update.
Jun NAITOH
12:56 Patch #28169 (Closed): Enable and add underline button to the toolbar for Markdown formatting
Patch committed, thanks! Jean-Philippe Lang
12:56 Revision 17385 (svn): Enable and add underline button to the toolbar for Markdown formatting (#28169).
Patch by Marius BALTEANU. Jean-Philippe Lang
12:54 Defect #28264 (Closed): Global and public custom queries are shown as editable to non administrators in projects
Marius BALTEANU wrote:
> Jean-Philippe Lang, looking at the fix committed, I'm observing that the tests "test_editable_by_for_global_query" and "test_editable_by_for_global_query_with_project_set" are identical. Is this ok?
Fixed, th...
Jean-Philippe Lang
12:53 Revision 17384 (svn): Fixed that "test_editable_by_for_global_query" and "test_editable_by_for_global_query_with_project_set" are identical (#28264).
Jean-Philippe Lang
12:51 Defect #26610 (Closed): Migration file generated by redmine_plugin_model generator is not compatible with Rails 5.1
Thanks. Jean-Philippe Lang
12:50 Defect #22424 (Closed): Change Russian translation for default_issue_status_feedback
This is a default translation that can be changed online by admins. Jean-Philippe Lang
12:48 Defect #17517 (Closed): Attempting to Add a Related Issue Multiple Times Sequentially Causes 500
Works for me Jean-Philippe Lang
09:56 Defect #29036 (Closed): "Assigned to" filter on the issues page works only on second attempt
Redmine version 3.4.6.stable
Ruby version 2.5.1-p57 (2018-03-29) [x86_64-linux]
Rails version 4.2.8
Environment production
Database adapter PostgreSQL...
Vladislav Yashin
06:31 Defect #29007 (Closed): How to modify the width of the project table?
Please contact the author of the plugin. Go MAEDA
06:03 Defect #29028: Redmine generates notification emails that fail DMARC and will therefore often be rejected or quarantined
Jonathan Kamens wrote:
> I guess that means that whatever the problem is, I need to take it up with the folks who maintain bugs.ruby-lang.org?
I think so. They run the customized Redmine. The following line seems to set the author's ...
Go MAEDA
 

Also available in: Atom