Project

General

Profile

Activity

From 2017-11-27 to 2017-11-29

2017-11-29

23:26 Feature #27677 (Closed): New notfication settings value in role setting
Thanks for your suggestion. However, it's duplicating existing issue #8488 and a lot of its related issues (spec. #12584 #10173 #13828 #27028 #14318 #7412#note-13 and finally #23546). I'll close this issue as such. Mischa The Evil
19:41 Feature #27677 (Closed): New notfication settings value in role setting
it's possible to implement a fourth value for notifications type in role setting -> issue visibility -> "issue created by or assigned to the user or user is watcher" ?
In a project / issue in which the user is not the creator or assi...
Heiko Böhme
23:23 Patch #27663 (Resolved): Same relates relation can be created twice
Go MAEDA
20:58 Patch #27676: Information leak on roadmap and versions view
Also reported in #9411 and #15248 Jean-Philippe Lang
20:54 Patch #27676: Information leak on roadmap and versions view
I've committed the patch serie, thanks.
This issue was already reported long time ago and it was chosen not to change the behaviour (see #15258). With this change, different users might now see different progress values for the same v...
Jean-Philippe Lang
17:27 Patch #27676 (Closed): Information leak on roadmap and versions view
When limiting a role's permission to only access "Issues created by or assigned to the user", the roadmap (@/projects/:identifier/roadmap@) and version details (@versions/:id@) view leaks information about inaccessible issues and time es... Jan from Planio www.plan.io
16:45 Feature #24533: Change HTML title of tickets to #nr type
This patch adds new setting: Artem Baikuzin
14:32 Feature #8453 (Closed): Modify a relation
Closing as a duplicate of #8155. Go MAEDA
12:05 Feature #1739: Add ability to change issue author
+1 Jess Nielsen
12:03 Feature #8488: Create an 'Involve' mechanism to private issues
+1 Jess Nielsen
11:53 Defect #27673 (Closed): Watchers cannot see issue with restricted issue visibility
Duplicate of #9330 and others. Toshi MARUYAMA
11:05 Defect #27673 (Closed): Watchers cannot see issue with restricted issue visibility
People added as watchers cannot see the respective issue
when "Issues visibility" is set to "Issues created by or assigned to the user"
for the role they belong to.
This is very annoying, please up-prioritize it.
Jess Nielsen
10:30 Feature #1757: Immediately send a notify email when a user is added to issue's watcher list
+1 Heiko Böhme
10:26 Defect #11888: No e-mail notification for non-members who are watchers
+1 Heiko Böhme
09:17 Patch #27670 (Closed): Fix typo in configuration.yml.example
Committed in the trunk. Go MAEDA
09:12 Patch #27670: Fix typo in configuration.yml.example
I found another typo. Go MAEDA
00:38 Patch #27670 (Closed): Fix typo in configuration.yml.example
Pull request https://github.com/redmine/redmine/pull/61/files by Kosta Harlan. Go MAEDA
06:23 Feature #26409: Show assignee on gantt
Mischa The Evil wrote:
> * what's the actual significance of the assignee over other attributes (priority for example, which is in my opinion evenly important as assignee in gantt context)? From this follows that depending on the use, o...
Mizuki ISHIKAWA
05:34 Feature #27672 (Closed): Show selected columns in gantt chart
I would like to select and show the necessary columns like issues/index.
!{width: 70%; border:1px solid #ccc}gantt_plan.png!
Mizuki ISHIKAWA
04:51 Feature #24550 (Closed): Open GANTT for more than 24months
Closing as a duplicate of #14654. Go MAEDA
04:14 Defect #10742 (Closed): icons in rtl gantt
Fixed by #18390 (Redmine 3.0.0).
source:trunk/public/stylesheets/rtl.css@13623#L366
Go MAEDA
03:24 Patch #27671 (Closed): Use reverse_each instead of reverse.each for better performance
Array#reverse_each is faster than Array#reverse.each because reverse_each does not create an intermediate array.
Pull request https://github.com/redmine/redmine/pull/84 by Timur Tarasenko.
Go MAEDA

2017-11-28

17:10 Patch #27024: Links on custom field values don't have "external" class
Attaching an updated patch. Fixed test failure. Go MAEDA
06:13 Patch #27024: Links on custom field values don't have "external" class
LGTM :)
I tested Go MAEDA's patch on the Latest trunk@17038.
Takenori TAKAKI
14:58 Patch #27659: redmine_plugin_model_generator improvements(fixes and timestamps)
New feature:
Timestamps in the name of the generated migration file, right now redmine plugins generates the migrations in this form:
Javier Menéndez Rizo
14:53 Patch #27659: redmine_plugin_model_generator improvements(fixes and timestamps)
Problems:
* parent option: before the patch the parent option do nothing because in the model.rb template is not defined
*Before patch model.rb template only inherits from ActiveRecord::Base*
Javier Menéndez Rizo
05:02 Patch #27659: redmine_plugin_model_generator improvements(fixes and timestamps)
Javier Menéndez Rizo wrote:
> Problems fixed:
> ...
Please explain more details.
AFAIK Redmine plugin is based old Rails engines, but current Redmine does not implement full feature of Rails engines.
Toshi MARUYAMA
11:58 Defect #27356: Confusing statements concerning fixed versions on Security Advisories wiki page
Thank you so much for your research. In your proposed update, the third entry convers CVE-2013-0155 and CVE-2013-0156. While the second line covers mainly CVE-2013-0155 for 2.3.x. This follows the time line, but I think it would be more ... Gregor Schmidt
04:58 Defect #27356 (Needs feedback): Confusing statements concerning fixed versions on Security Advisories wiki page
Mischa The Evil
04:57 Defect #27356: Confusing statements concerning fixed versions on Security Advisories wiki page
h2. Final results
Here are the final results of my research. I've already modified/updated the earlier posted bits of info.
h3. Course of events:
The course of events in that January month of 2013 can best be represented within ...
Mischa The Evil
11:27 Patch #27663: Same relates relation can be created twice
LGTM. Setting target version to 3.3.6. Go MAEDA
11:03 Patch #27663: Same relates relation can be created twice
I confirmed the problem.
!{width: 718px; border: 1px solid #ccc;}.duplicated-related-issue@2x.png!
Go MAEDA
10:23 Patch #27663 (Closed): Same relates relation can be created twice
By switching from and to, it is possible to create the same relates relation twice. Within the Redmine UI, those relations look like duplicates.
For all other relationship types it's not allowed to create duplicates, so I assume that ...
Gregor Schmidt
11:23 Feature #2477: mail reminder for watchers
+1 Anything new? Torben Junker
05:40 Feature #26409: Show assignee on gantt
I don't want to ruin anyone's party, but I'd like to drop some thoughts (concerns) I have about this feature and the proposed, patched implementation:
* what's the actual significance of the assignee over other attributes (priority for ...
Mischa The Evil
04:36 Defect #19578: Issues reports table header overlaping
Leonel Iturralde wrote:
> If I change it to _table-layout:auto_ . I can see all the content.
Thank you for the workaround.
But changing table-layout property from @fixed@ to @auto@ causes other problem. Please see the screenshots ...
Go MAEDA
04:31 Defect #27658: Git merge-graph does not respect first parent
Redmine revision graph draws by revision order in DB. Toshi MARUYAMA
03:36 Patch #26671 (Closed): Use the new pagination style in gantt
Committed in the trunk.
Mizuki, thank you for reviewing the patch.
Go MAEDA
02:24 Defect #13521: Gantt bars with start date and end date on the same day don't become red by overdue
FWIW: Pavel Shalagin wrote about it first (and even provided a patch for it) in #6276#note-17 about 7 years ago:
> "Don't know if it can be considered as a problem, but the tasks with the same start_date and end_date seems not to be col...
Mischa The Evil

2017-11-27

22:11 Patch #27659 (Closed): redmine_plugin_model_generator improvements(fixes and timestamps)
Problems fixed:
* parent option not working
* migration option not working
Things added:
* Timestamp for migrations
It would be really nice to add this to the migration generator for plugins.
Javier Menéndez Rizo
20:55 Defect #27658 (New): Git merge-graph does not respect first parent
The git DAG Mainly that the DAG always seems to be oriented backward:
‎The revisions that "git log --graph" and gitk/qgit/etc. display as the left-hand side is on the right (what git calls the "first parent" is drawn as the `last parent...
Joshua Judson Rosen
16:27 Patch #27649 (Closed): Spanish/Panama translation update (jstoolbar-es-pa.js)
Committed in the trunk and merged to stable branches. Go MAEDA
16:12 Patch #27649 (Closed): Spanish/Panama translation update (jstoolbar-es-pa.js)
References: #27642, #27642#note-2: Go MAEDA
16:02 Patch #27642 (Closed): Spanish translation update (jstoolbar-es.js)
Committed to the trunk and merged to stable branches. Thank you for translating the word.
And I will also update jstoolbar-es-pa.js.
Go MAEDA
15:41 Patch #27642 (New): Spanish translation update (jstoolbar-es.js)
Go MAEDA
15:34 Patch #27642: Spanish translation update (jstoolbar-es.js)
Go MAEDA wrote:
> Javier Menéndez Rizo, thank you for translating the term.
> ...
Yes it's ok to use it
Javier Menéndez Rizo
14:21 Patch #27139 (Closed): Fix for project link background in calendar tooltips
Committed in the trunk and merged to stable branches.
Thank you for fixing this issue and thank Marius for reviewing the patch.
Go MAEDA
06:44 Patch #27139: Fix for project link background in calendar tooltips
Yes, I agree. Marius' approach is much cleaner. Thank you!
I've made another patch with the changes suggested by him.
Bernhard Rohloff
00:58 Patch #27139: Fix for project link background in calendar tooltips
I think that it is more safe to target directly the issue using @table.cal .starting a.issue@ instead of the :first-child. Marius BĂLTEANU
09:52 Feature #17660 (Closed): Gantt chart-increase column size of issue description
You will be able to resize subject column in upcoming Redmine 4.0.0 (#20481).
I think the new feature covers this issue.
Go MAEDA
09:19 Defect #13521 (Confirmed): Gantt bars with start date and end date on the same day don't become red by overdue
Confirmed.
!{width: 407px;}.gantt-defect13521@2x.png!
Go MAEDA
03:26 Feature #26409: Show assignee on gantt
I fixed the patch.
* Compatible the latest trunk.
* Add styles to gravatar like #26410
Mizuki ISHIKAWA
02:18 Defect #27356: Confusing statements concerning fixed versions on Security Advisories wiki page
When it wasn't clear yet: I'm researching this issue. Almost done btw. Some last commit-history checks for both Rails and Redmine and wrapping up are remaining. Though, the issues with the current table values begin to be more clearly vi... Mischa The Evil
01:59 Patch #26869 (Closed): Use number input field instead of text input for Gantt months field
Committed in the trunk. Thank you for improving Redmine. Go MAEDA
01:47 Defect #12510: Issues PDF export: Spent time/Float-values aren't rounded to 2 digits
Tested on current trunk (r17037) and the issue still occurs.
I've updated the patch from Holger Just to apply cleanly. I think that we can fix this issue in the next release.
*Before:*
!before.png!
*After:*
!after.png!
Marius BĂLTEANU
01:42 Patch #26671: Use the new pagination style in gantt
+1
I think this small patch is a good patch to improve screen uniformity.
Mizuki ISHIKAWA
01:38 Feature #10485 (Closed): Add new context menu in Gantt view for each issue
Marius BALTEANU wrote:
> I've added some basic assertions for this feature.
Committed. Thank you.
Go MAEDA
01:15 Feature #10485 (Reopened): Add new context menu in Gantt view for each issue
I've added some basic assertions for this feature. Marius BĂLTEANU
 

Also available in: Atom