Project

General

Profile

Activity

From 2019-02-17 to 2019-02-19

2019-02-19

23:34 Feature #3660: Configurable subject of notification email for issue_add/issue_edit
I've added a patch to #13111 that gives you the option to include or not the status changes in issue mail notifications subject. Marius BĂLTEANU
23:32 Defect #12720 (Closed): TLS configuration documentation for Rails 3
Rails 3 is no longer supported. Marius BĂLTEANU
23:28 Patch #13658: include "In-Reply-To" field to aid email threading for some clients
I've attached a patch to #13111 that fixes the threading issues on Gmail and Office 365. Marius BĂLTEANU
23:26 Defect #21398: Mysql: 500 server error when submitting 4 bytes utf8 (to be saved in the 'notes' field)
This does not work for me on Redmine 4.0.1, any ideas?
Error: NameError: uninitialized constant Utf8mb4
Sven Culley
23:18 Feature #13111: New setting to include the status changes in issue mail notifications subject
I can confirm that applying the patch on the current trunk fixes the thread issues on both major mail platforms:
1. Office 365
!{border: 1px solid grey; width: 70%;}.office365.png!
2. Gmail
!{border: 1px solid grey; width: 70%;}....
Marius BĂLTEANU
23:00 Feature #13111: New setting to include the status changes in issue mail notifications subject
Marius BALTEANU wrote:
> Go MAEDA wrote:
> ...
Attached the patch that adds a new setting to include the status changes in issue mail notifications subject.
The setting is useful to control the grouping of mails on some mail clients...
Marius BĂLTEANU
16:26 Feature #30843 (New): Restrict receiving emails
Hi there!
Today I have set up my system to receive e-mails via imap. During the setup I tried to restrict the users who are allowed to send mails to the system, but can't find any relevant parameters at http://www.redmine.org/projects...
Manuel Bernhardt
15:21 Patch #30739: Project Custom Fields configuration : split by tracker
Hi, can you review this simple patch ? I think this makes Project Custom Fields configuration quite more clear. Jérôme BATAILLE
15:06 Feature #30829: Simpler link syntax "#note-123" to make a link to a note of the current issue
+1 Anonymous
14:41 Feature #30829: Simpler link syntax "#note-123" to make a link to a note of the current issue
+1
Yuuki NARA
14:01 Feature #30829: Simpler link syntax "#note-123" to make a link to a note of the current issue
I think it's a nice usability improvement.
+1
Bernhard Rohloff
12:42 Defect #13888 (Closed): Daylight savings causes inconsistency of Message-Id in emails
Committed the fix.
The timestamp is UTC after r17890. Daylight savings will never affect message-id.
Go MAEDA
12:36 Revision 17890 (svn): Daylight savings causes inconsistency of Message-Id (#13888).
Patch by Go MAEDA. Go MAEDA
12:05 Defect #30811 (Closed): "rake db:fixtures:load" does not work
Committed the patch. Thank you for fixing it. Go MAEDA
11:20 Defect #30811: "rake db:fixtures:load" does not work
Marius BALTEANU wrote:
> Maybe ".example" is more appropriate than ".txt"?
Thanks, looks nicer.
Go MAEDA
08:09 Defect #30811: "rake db:fixtures:load" does not work
Maybe ".example" is more appropriate than ".txt"? Marius BĂLTEANU
06:17 Defect #30811: "rake db:fixtures:load" does not work
Go MAEDA wrote:
> Currently, all files used by tests are placed under @fixtures@ directory. Here are some examples:
> ...
Thank you for pointing out my problem with my patch.
I was not able to notice the current implicit rules...
Cer...
Takenori TAKAKI
01:20 Defect #30811: "rake db:fixtures:load" does not work
Currently, all files used by tests are placed under @fixtures@ directory. Here are some examples:
* test/fixtures/diffs
* test/fixtures/ldap
* test/fixtures/mail_handler
I think it is better not to move @text/fixtures/configurati...
Go MAEDA
12:03 Revision 17889 (svn): "rake db:fixtures:load" does not work (#30811).
Patch by Takenori TAKAKI. Go MAEDA
11:30 Feature #29946 (Closed): Update i18n gem (~> 1.6.0)
Committed the patch. Thank you for writing the patch. Go MAEDA
11:29 Revision 17888 (svn): Update i18n gem to 1.5.3 (#29946).
Patch by Marius BALTEANU. Go MAEDA
11:11 Feature #30356 (Closed): Drop Ruby 2.2 support
Committed. Redmine 4.1 supports Ruby 2.3 and later. Go MAEDA
11:11 Revision 17887 (svn): Drop Ruby 2.2 support (#30356).
Go MAEDA
10:39 Patch #30818 (Closed): Issues autocomplete should respond with content type json
Christian Wolf wrote:
> Is there a chance that the pachs is inserted into the 3.4 version?
Thank you for pointing it out. I have just merged r17881 to 3.4-stable branch. The fix will be delivered in 3.4.9.
Go MAEDA
10:25 Patch #30818 (Reopened): Issues autocomplete should respond with content type json
Go MAEDA
10:19 Patch #30818: Issues autocomplete should respond with content type json
Go MAEDA wrote:
> Committed the patch. Thanks.
Is there a chance that the pachs is inserted into the 3.4 version?
Christian Wolf
10:37 Revision 17886 (svn): Merged r17881 from trunk to 3.4-stable (#30818).
Go MAEDA
08:23 Feature #12796: Display user's groups on profile
Hello,
there is a workaround for this. If for example you want to get to know the members of the group A, create a test ticket and assign it to the group A, then you will receive a notification by mail and you will get all the users ...
M.Moorad HEETUN
06:02 Revision 17885 (svn): Merged r17884 from trunk to 4.0-stable (#30834).
Go MAEDA
05:56 Feature #30834 (Closed): Links to forum replies should highlight the linked reply
Committed the patch. Thank you for your contribution. Go MAEDA
05:33 Feature #30834: Links to forum replies should highlight the linked reply
+1
I confirmed that the patch will work for me.
Mizuki ISHIKAWA
03:22 Feature #30834: Links to forum replies should highlight the linked reply
Popoki Tom (@cat_in_136) wrote:
> As noticed in #28330#note-4, I believe this improvement should be applied to the version 4.x.x stream.
Indeed. I forgot to create an issue at that time. I think the fix should be delivered in 4.0.2.
Go MAEDA
02:30 Feature #30834 (Closed): Links to forum replies should highlight the linked reply
When I follow e.g. the link message#4, the forum page opens without any indication where the linked reply message is.
In Redmine 4.x, the linked issue notes (#22978) and wiki sections (#28330) is emphasized.
My patch have the link...
Popoki Tom (@cat_in_136)
05:54 Revision 17884 (svn): Links to forum replies should highlight the linked reply (#30834).
Patch by Popoki Tom. Go MAEDA
04:23 Feature #30838 (Closed): Option to parse HTML part of multipart (HTML) emails first
Currently, when mail_handler receives a multipart email that contains both text and HTML part, it tries to retrieve text parts first. HTML parts are processed only when the email does not have any text parts.
However, in 2019, unlike ...
Go MAEDA
03:15 Feature #30808: Multiple issue ids in "Subtasks" filter
I changed so that The Subtasks filter supports comma-separated multiple issue ids.
I attached a patch.
Yuichi HARADA
03:14 Feature #13844 (Closed): Option to enable HTML emails for issue creation.
Redmine 3.1.0 and later parse HTML emails more correctly. Instead of simply removing tags, it converts some HTML tags to Textile/Markdown. Please see #16962 for details. Go MAEDA
00:20 Patch #30828 (Closed): Refactor GitAdapter#default_branch not to unnecessarily iterate through all elements
Committed the patch. Thank you for your contribution. Go MAEDA
00:19 Revision 17883 (svn): Refactor GitAdapter#default_branch not to unnecessarily iterate through all elements (#30828).
Patch by Pavel Rosický. Go MAEDA

2019-02-18

20:37 Feature #30831 (Closed): Redmine on Synology Docker - Upgrade request
The image is not maintained by us, please contact Synology Package Center or the image maintainer.
Thanks!
Marius BĂLTEANU
18:10 Feature #30831 (Closed): Redmine on Synology Docker - Upgrade request
Dear,
Within the Synology Package Center, Redmine 3.3.6 is available.
However, some very usefull features which I'm searching for, are available in the newer versions (3.4).
Somehow, I prefer to stay within the packages - in order...
David Reyntjens
18:49 Patch #30827: git tags can't handle utf-8
looks like I can't attach .tar.gz as a patch... Pavel Rosický
18:45 Patch #30827: git tags can't handle utf-8
@Go MAEDA you can simulate the problem with attached tests.
I'm not sure about the input encoding, AFAIK it should be set by the shell's LC_ALL variable or is it always in UTF-8?
Pavel Rosický
15:03 Patch #30827: git tags can't handle utf-8
right, thanks. I'm looking into it! Pavel Rosický
13:48 Patch #30827: git tags can't handle utf-8
Maybe also branches should be fixed? Go MAEDA
10:05 Patch #30827 (Closed): git tags can't handle utf-8
1/ create a git tag that contains ascii incompatible character like "Aufräumen"
2/ open the repository page
Internal Server Error - incompatible character encodings: UTF-8 and ASCII-8BIT
https://github.com/redmine/redmine/blob/979b0...
Pavel Rosický
17:16 Feature #9139: Use favicon for redmine.org
+1
Favicon itself is made, do not you?
Mitsuyoshi Kawabata
17:08 Defect #30811: "rake db:fixtures:load" does not work
test/fixtures/configuration/*.yml is test data for Redmine::Configuration but it's not fixtures.
I think that this problem will be solved by changing the location of these files.
(eg. test/fixtures/configuration/*.yml -> test/configu...
Takenori TAKAKI
16:14 Patch #30818 (Closed): Issues autocomplete should respond with content type json
Go MAEDA
15:56 Patch #30818 (Resolved): Issues autocomplete should respond with content type json
Committed the patch. Thanks. Go MAEDA
16:14 Defect #29276 (Closed): Autocomplete does not show anything
Go MAEDA
16:13 Revision 17882 (svn): Merged r17881 from trunk to 4.0-stable (#30818).
Go MAEDA
15:56 Revision 17881 (svn): Issues autocomplete should response with content type json and not html (#30818).
Patch by Marius BALTEANU. Go MAEDA
15:51 Defect #13888: Daylight savings causes inconsistency of Message-Id in emails
Attaching a patch that includes a test. Go MAEDA
15:49 Feature #23980: Replace icon images with Tabler SVG icons
> So has anybody a better idea on how to get at least a yes, no, maybe from Redmine's kahuna?
I guess the only way I could come up with is to bump this ticket with a message mentioning *JPL* and *urgent* to be visible in the *activity l...
Anonymous
14:59 Defect #30099: Multiple blank lines in pre tags are not preserved in Textile
Setting the target version to 4.1.0. Go MAEDA
05:37 Defect #30099: Multiple blank lines in pre tags are not preserved in Textile
I think that it is possible to solve the problem by swapping the order of 'escape pre content' and 'clean up white space' in RedCloth#to_html.
I made a patch and attach it.
Takenori TAKAKI
14:52 Defect #30785 (Closed): Mail handler does not ignore emails sent from emission email address if Setting.mail_from includes display name
Reverted r17862 and applied the new patch in r17879. Go MAEDA
14:51 Revision 17880 (svn): Merged r17878 and r17879 from trunk to 4.0-stable (#30785).
Go MAEDA
14:21 Revision 17879 (svn): Mail handler does not ignore emails sent from emission email address if Setting.mail_from includes display name (#30785).
Patch by Go MAEDA. Go MAEDA
14:03 Revision 17878 (svn): Reverts r17862.
Go MAEDA
13:40 Feature #1011: Add voting to tickets
Antoine Beaupré wrote:
> unwatch this issue and apologize for this final, ultimate mike drop: +1 :)
LOL XD
Anonymous
12:58 Patch #30828: Refactor GitAdapter#default_branch not to unnecessarily iterate through all elements
Setting the target version to 4.1.0. Go MAEDA
10:38 Patch #30828 (Closed): Refactor GitAdapter#default_branch not to unnecessarily iterate through all elements
#select iterates through all records and creates a new array which isn't necessary Pavel Rosický
10:57 Feature #30829 (Closed): Simpler link syntax "#note-123" to make a link to a note of the current issue
Currently, you can link to issue notes using the syntax @#98765#note-123@. I propose a new syntax @#note-123@ to link to a note of the current issue.
Sometimes I feel that the markup used to link to a note of the current issue is too ...
Go MAEDA
10:48 Defect #27003: import subtask csv
Finally , I found that with redmine 3.4.4.stable , the default "import menu" can do that .
Ihe most important thing is that: the value of the "Parent task" is not only integer , it has to contain character # ,such as @#816@
sosogh sosogh
09:14 Defect #27003: import subtask csv
My redmine is : sosogh sosogh
09:42 Feature #306: Full Text Search of files
I'm confirming these patches on master.
We need at least the following changes:
We need to resolve conflict for @Gemfile@ in 0001-implements-fulltext-extraction-for-attachments.patch.
Kouhei Sutou
09:40 Patch #30821 (Closed): Stay in RMagick 2.16.0 and don't update to 3.0.0
Go MAEDA
09:15 Patch #30821 (Resolved): Stay in RMagick 2.16.0 and don't update to 3.0.0
Committed. Go MAEDA
08:36 Patch #30821: Stay in RMagick 2.16.0 and don't update to 3.0.0
Good news. Ivan Cenov
01:51 Patch #30821 (Closed): Stay in RMagick 2.16.0 and don't update to 3.0.0
RMagick 3.0.0 has been released on 2019-02-16 but the installation of Redmine fails due to the latest RMagick in some environments.
This is because RMagick 3.0.0 narrowed the supported ImageMagick version. Previous Rmagick 2.16.0 supp...
Go MAEDA
09:40 Revision 17877 (svn): Merged r17875 from trunk to 3.4-stable (#30821).
Go MAEDA
09:36 Revision 17876 (svn): Merged r17875 from trunk to 4.0-stable (#30821).
Go MAEDA
09:15 Revision 17875 (svn): Stay in RMagick 2.16.0 and don't update to 3.0.0 (#30821).
Patch by Go MAEDA. Go MAEDA
09:14 Feature #30826 (New): Order of related issues types
I'am expected that value of _order_ in _TYPES_ (issue_relations.rb) determines the order on display.
The order of displaying types of relations (_precedes_, _follows_) depend on order of adding relations.
Bolesław Kalinowski
08:20 Feature #13111: New setting to include the status changes in issue mail notifications subject
Marius BALTEANU wrote:
> For Gmail won’t work because the rule for threading uses only the subject, but I’m curios if it’ll fix the problem on Exchange/Office365.
I have just confirmed that patch #17096#note-19 has no effect on Gmail...
Go MAEDA
07:23 Feature #13111: New setting to include the status changes in issue mail notifications subject
Go MAEDA wrote:
> I prefer making the subject line configurable rather than simply removing the status. The information that the status has been changed is useful for me.
Thanks, I’ll prepare a patch.
> ...
For Gmail won’t work bec...
Marius BĂLTEANU
02:54 Feature #13111: New setting to include the status changes in issue mail notifications subject
Marius BALTEANU wrote:
> Go Maeda, do you think that we should do this configurable (ex: Show issue status in email notifications for issues) or we should just remove the status from the subject? IMO, I never found the status informatio...
Go MAEDA
03:36 Feature #30822 (New): Show Gravatar icons in email notifications
Currently, Gravatar icons are shown in Web UI when @Setting.gravatar_enabled?@ is @true@ but not shown at all in email notifications.
Icons are really useful to quickly understand the author, assignee, and the user who updated the iss...
Go MAEDA
02:34 Feature #30492: Replace RMagick with MiniMagick
RMagick 3.0.0 has released on 2019-02-16 but it does not support ImageMagick 7.0 yet. In addition, it narrowed the supported version. The minimum supported version of ImageMagick has raised from 6.4.9 to 6.8.9. Go MAEDA

2019-02-17

23:26 Feature #3816 (Closed): Allow pasting screenshots from clipboard
Committed the patch. Now you can paste images from clipboard if you use modern browsers except for Edge and IE11.
I modified the patch to generate a filename like 'clipboard-yyyymmddHHMM-a1b2c.png' that is a bit shorter than Takenori ...
Go MAEDA
17:15 Feature #3816: Allow pasting screenshots from clipboard
Go MAEDA wrote:
> Marius, thank you for reviewing and improving the patch.
> ...
I don't have any preference for the filename, I chose to change it only because I found it simpler to have 1 line of code instead of 4 lines. You can reve...
Marius BĂLTEANU
16:15 Feature #3816: Allow pasting screenshots from clipboard
Marius, thank you for reviewing and improving the patch.
> - simplified the filename generation
The previous patch generates a filename like 'clipboard-201902181323-a1b2c3d.png'. I prefer to include a date like '20190217' in the fi...
Go MAEDA
15:00 Feature #3816: Allow pasting screenshots from clipboard
I've made some small changes to the patch, the most important is the check for @e.clipboardData || e.originalEvent.clipboardData@ in order to not throw errors in the console when the clipboardData doesn't exist (for example: IE11).
An...
Marius BĂLTEANU
23:11 Feature #13111: New setting to include the status changes in issue mail notifications subject
Gmail is one of the most used email clients and I think it should be very nice to support email threading. The rule is simple, the subject of the email must be the same.
Go Maeda, do you think that we should do this configurable (ex: ...
Marius BĂLTEANU
23:05 Defect #11593 (Closed): Error 500 on child issue with no start date
Marius BĂLTEANU
22:55 Revision 17874 (svn): Allow pasting screenshots from clipboard (#3816).
Patch by Takenori TAKAKI and Marius BALTEANU. Go MAEDA
21:05 Feature #26791: Send individual notification mails per mail recipient
Holger Just wrote:
> h3. BCC recipients
> ...
I've attached a patch to #30820 to drop the bcc setting.
Marius BĂLTEANU
21:04 Defect #30787: Other recipients are not listed in To field even if Setting.bcc_recipients is false
Go Maeda, please let us know what it the purpose of this defect. Marius BĂLTEANU
21:03 Defect #30787: Other recipients are not listed in To field even if Setting.bcc_recipients is false
Holger Just wrote:
>
> ...
Thanks for pointing to your comment, I've attached a patch to (#30820).
Marius BĂLTEANU
21:00 Feature #30820 (Closed): Drop setting "Blind carbon copy recipients (bcc)"
From #26791:
> h3. BCC recipients
> ...
I agree, the setting doesn't make any sense now.
Marius BĂLTEANU
18:20 Defect #13888: Daylight savings causes inconsistency of Message-Id in emails
Go MAEDA wrote:
> We don't have to care about daylight savings if we always use UTC when generating a message-id.
> ...
yep, I agree
pasquale [:dedalus]
13:38 Defect #13888: Daylight savings causes inconsistency of Message-Id in emails
We don't have to care about daylight savings if we always use UTC when generating a message-id. Go MAEDA
15:31 Defect #29276: Autocomplete does not show anything
I've attached the patch to #30818. Marius BĂLTEANU
15:30 Patch #30818 (Closed): Issues autocomplete should respond with content type json
Currently, @issues/auto_complete@ respond with: Marius BĂLTEANU
14:57 Defect #17096: Issue emails cannot be threaded by some mailers due to inconsistent Message-ID and References field
Go MAEDA wrote:
> I think that adding consistent Message-Id and References filed will be easier if per user notification sending is implemented by #26791. We don't have to use random_hex in Mailer.token_for method. Instead, we can use E...
Go MAEDA
11:30 Feature #23980: Replace icon images with Tabler SVG icons
Basically I agree with Go and Jan. It's not an option to make decisions behind JP's back. As much as I share this opinion I can understand Max's intention. This issue is nearly three years old and no decisions are made. So has anybody a ... Bernhard Rohloff
07:49 Feature #1380: Deleting an issue only marks it as being deleted
+1
As a workaround, there is also a way to simply change the project_id of the issue.
(Project_id -> 0, -% Project_id%,% Project_trashcan%)
The following requirements can be satisfied.
1.Even if you specify the ticket number, i...
Yuuki NARA
06:15 Patch #16069: Allow configuration of API limit instead of hardcoding at 100
+1
I think that it should be changeable by the responsibility of the system administrator.
There are many configuration items in the world system that may cause troubles due to setting change contents.
Since there are cases where ...
Yuuki NARA
06:02 Defect #30785: Mail handler does not ignore emails sent from emission email address if Setting.mail_from includes display name
Go MAEDA wrote:
> Therefore, I think r17862 should be reverted before releasing Redmine 4.0.2 and this issue should be fixed like the following:
> ...
Attaching a new patch. This patch can be applied after reverting r17862.
Go MAEDA
 

Also available in: Atom