Project

General

Profile

Activity

From 2020-02-18 to 2020-02-20

2020-02-20

13:35 Defect #33029: API POST requests fail with 422 Can't verify CSRF token authenticity. on 3.4.13, 4.0.6 and 4.1.0
Enable REST web service is ticked.
I have resorted to disallowing protect_from_forgery by mounting and overwriting the additional_environment.rb containing that setting. This is acceptable but not optimal.
It's an internal system beh...
casper nielsen
13:27 Defect #33029 (Needs feedback): API POST requests fail with 422 Can't verify CSRF token authenticity. on 3.4.13, 4.0.6 and 4.1.0
It's likely that you have forgotten to activated the support for REST API in your local Redmine installation. Make sure to activate the API in *Administration* -> *Settings* -> *API*.
Does this solve your issue?
Holger Just
09:23 Defect #33029 (Closed): API POST requests fail with 422 Can't verify CSRF token authenticity. on 3.4.13, 4.0.6 and 4.1.0
I have been tasked with making our main application work with a newer version of redmine than it did before.
The old one was ancient. Our current one is 3.4.13 in a docker container.
I have tried the latest three versions localhost...
casper nielsen
13:34 Feature #33003 (Closed): Emails footer
You can add a reference to an image to the footer using the same syntax you can use from inside your issues, e.g.,
* @!https://www.redmine.org/attachments/7069/Redmine_logo.png!@ (if you are using Textile)
* or @![](https://www.redmi...
Holger Just
11:43 Feature #4347: Contributing to an issue should automatically add the user to the watchers list
+1 Matthias Reinhardt
09:02 Defect #32971: New line between list items break a list
Kevin Fischer wrote:
> How about adding a unit test to prevent future regressions of this conversion?
Thank you for pointing it out.
I have added the following test to attachment:32971-fixed-v3.patch .
Yuichi HARADA
04:10 Defect #32971: New line between list items break a list
Ji-Hyeon Gim wrote:
> New line between list items break a list when I try to write ordered/unordered list with textile.
> ...
* list1
* list2
* list3
# list4
# list5
# list6
</pre>
>
> ...
I noticed when looking ...
Yuichi HARADA
07:32 Defect #33027 (Confirmed): Fix missing closing div in _time_entries_fields_mapping.html.erb
Thanks for catching this, attached the patch with the fix. Marius BĂLTEANU
03:45 Defect #33027 (Closed): Fix missing closing div in _time_entries_fields_mapping.html.erb
In the file:
_/trunk/app/views/imports/_time_entries_fields_mapping.html.erb_
Element div is not closed.
Enziin System
07:28 Defect #33021: [v.4.0.5-stable] Internal Server Error 500 when accessing 'repository' tab
Anatol Pomozov wrote:
> It would be great to debug and fix this problem so Arch can switch to ruby2.7 and avoid pulling the old ruby version.
Only Redmine 4.2.0 will have official support for ruby2.7, the fixes won't be back ported t...
Marius BĂLTEANU
01:41 Defect #33021: [v.4.0.5-stable] Internal Server Error 500 when accessing 'repository' tab
It would be great to debug and fix this problem so Arch can switch to ruby2.7 and avoid pulling the old ruby version. Anatol Pomozov
01:43 Defect #33023: Warning occurs when displaying a few exceptional PDF thumbnail
Here is a sample PDF. Anonymous
01:12 Patch #684: Add journal count on issues list
Marius BALTEANU wrote:
> We should count only the journals with notes? or all journals?
I think it should be the number of all journals.
Activities such as adding attachments without note and changing the target version are also i...
Go MAEDA

2020-02-19

21:46 Patch #684: Add journal count on issues list
Florian ROBERT wrote:
> +1, I have user requests on this feature
We should count only the journals with notes? or all journals?
Marius BĂLTEANU
15:43 Patch #684: Add journal count on issues list
+1, I have user requests on this feature Florian ROBERT
16:45 Defect #32981 (Closed): Unable to distinguish disabled input fields
Go MAEDA
16:45 Revision 19525 (svn): Merged r19519 from trunk to 4.1-stable (#32981).
Go MAEDA
15:54 Feature #22913 (Closed): Auto-select fields mapping in Importing
Committed the patches.
Thank you all for working on this nice improvement.
Go MAEDA
06:10 Feature #22913: Auto-select fields mapping in Importing
The patch series works fine. Thank you.
I will commit them in a few days.
Go MAEDA
15:52 Revision 19524 (svn): Auto select fields mapping in import based on the internal field name (ex: estimared_hours, fixed_version, spent_on) or field label (Estimated hours, Version, Date) (#22913).
* mappings are case insensitive
* a field is auto mapped only if there is no mapping setting present for that field
* "Current user" default value for User field when the user has permission to log time for other users is override by the...
Go MAEDA
15:31 Revision 19523 (svn): Use 'user' as internal field instead of user_id because the column accepts also user login as value, not only the id (#22913).
Patch by Marius BALTEANU. Go MAEDA
14:45 Patch #32530: Update RuboCop to 1.12
Updated to RuboCop 0.80 in r19522. Go MAEDA
14:45 Revision 19522 (svn): Update RuboCop to 0.80 (#32530).
Go MAEDA
14:28 Defect #2493: Subversion: Error message for some of view differences
+1 Jonas De Meulenaere
11:40 Defect #32971: New line between list items break a list
How about adding a unit test to prevent future regressions of this conversion? Kevin Fischer
07:17 Defect #32971: New line between list items break a list
I fixed the attachment:32971-fixed.patch because sometimes the @flush_left@ method did not end. Yuichi HARADA
05:18 Defect #32971: New line between list items break a list
Yuichi HARADA wrote:
> Yuichi HARADA wrote:
> ...
It did not work well with attachment:32971-fixed-v2.patch . The same problem occurred as in the previous situation.
Please delete attachment:32971-fixed-v2.patch .
Yuichi HARADA
03:47 Defect #32971: New line between list items break a list
Yuichi HARADA wrote:
> I think the behavior has probably changed by applying r17603 ( "Defect !#29756: \f or \v character in Textile markup may cause RegexpError exception":https://www.redmine.org/issues/29756 ).
> ...
Sorry, I found t...
Yuichi HARADA
11:39 Feature #33025: Optional email headers
What I got complained about is that it exposes active directory user (X-Redmine-Sender).
Aleksandar Pavic
11:38 Feature #33025 (New): Optional email headers
Now 8 years later, this feature #5643 is in some cases seen by vulnerability that exposes unnecessary information.
It would be preferable to have a checkbox to completely turn-off Redmine headers.
This should probably be a patch I ...
Aleksandar Pavic
11:18 Feature #1718: Table column sorting
There was a little problem with the patch (or was it just on my side?): It assumed that the JavaScript/CSS files were already there and thus could not be applied directly. I fixed that.
I tried the patch and function-wise it looked go...
Kevin Fischer
10:44 Feature #1718: Table column sorting
Although there is a limitation that numbers are treated as strings when sorting, the feature is useful. Go MAEDA
10:36 Defect #32449: Diff view for .js files in repositories is broken
Same with our Mercurial SCM.
h2. version 3.4.4.stable --> works fine
!{width: 70%}defect.32449-redmine_3.4.4.png!
h2. version 4.0.4.stable --> no styles and the menu disappears
!{width: 70%}defect.32449-redmine_4.0.4.png!
Guillermo ML
09:57 Defect #32449 (Confirmed): Diff view for .js files in repositories is broken
Go MAEDA
08:43 Feature #32629: Add edit button to Wiki sidebar
+1
Good idea. Small suggestion: If is not already considered: What do you think about that the Sidebar page contains those three default links straight away? If it was not created yet and you click the button or go directly to the pag...
Robert Schneider
08:39 Patch #28861: Add a date item to the context menu
Because there were many opinions that the Clear check box was difficult to understand, "Start date / Due date" can be changed only in context menu for one issue.(Cannot be changed during bulk edit)
I think that changing just one issue w...
Mizuki ISHIKAWA
08:35 Patch #28861: Add a date item to the context menu
Ponmuthu Muniyasamy wrote:
> Hi Everyone,
> ...
The [[Patch]] page has instructions on how to do it, but individual customization is not recommended as problems may occur after application.
Mizuki ISHIKAWA
08:28 Defect #33023: Warning occurs when displaying a few exceptional PDF thumbnail
Thank you for reporting the issue. Could you provide a sample PDF file that causes the error? Go MAEDA
08:19 Defect #33023 (New): Warning occurs when displaying a few exceptional PDF thumbnail
A PDF thumbnail is displayed, but the following message is output to STDERR.
The PDF file cannot be published, but it was created with a fax image (binary image).
Anonymous
07:08 Feature #4687: Add copy project permission
I have attached the patch.
Users with copy_project permission can copy from projects/show.
---
Even if you do not have view_issues permission of the copy source project, you can copy issues from the source project if you have copy...
Mizuki ISHIKAWA
06:31 Feature #1575: Toolbar button to insert a table
The attached patch adds a button to insert a table into the wiki toolbar.
The button create a table with rows / columns according to the selected range.
!{width: 70%; border: 1px solid #ccc}use-table-generator.gif!
Markdown:
Mizuki ISHIKAWA
06:14 Feature #33002: Include attachments in news post notifications
LGTM. Setting the target version to 4.2.0. Go MAEDA

2020-02-18

22:58 Defect #33021: [v.4.0.5-stable] Internal Server Error 500 when accessing 'repository' tab
Manually Downgraded the following packages:
ruby (2.7.0-1 => 2.6.5-1)
rubygems (3.1.2-4 => 3.0.6-1)
ruby-bundler (2.1.4-1 => 2.0.2-1)
and re-ran @bundle install --without development test@ which fixed the problem. This was my mist...
Matthew Sexton
22:26 Defect #33021: [v.4.0.5-stable] Internal Server Error 500 when accessing 'repository' tab
redmine 4.0.5 doesn't support ruby 2.7 yet https://www.redmine.org/issues/31500
the error seems to be related to this change https://bugs.ruby-lang.org/issues/16150
https://github.com/redmine/redmine/blob/caa88a2ed308224edc66f411b1...
Pavel Rosický
20:45 Defect #33021 (Closed): [v.4.0.5-stable] Internal Server Error 500 when accessing 'repository' tab
Using Arch Linux kernel version 5.5.3-arch1-1, Redmine served using mod_passenger (v6.0.4-2) on Apache (2.4.41-1). Trying to access 'repository' tab gives error 500. Changesets can be viewed, and git integration otherwise works well. Iss... Matthew Sexton
18:02 Feature #22913: Auto-select fields mapping in Importing
Yuichi HARADA wrote:
> Marius BALTEANU wrote:
> ...
You're welcome.
> In particular, it was very good that the @test/functional/imports_controller_test.rb@ was written in detail and was easy to understand. However, I think it would ...
Marius BĂLTEANU
02:49 Feature #22913: Auto-select fields mapping in Importing
Marius BALTEANU wrote:
> Thanks Yuichi for updating the patch.
> ...
Thanks, Marius for improving the patches. I confirmed that it works properly.
In particular, it was very good that the @test/functional/imports_controller_test.rb@ ...
Yuichi HARADA
15:09 Feature #2770: Display of inline attached images in email notification
Nick Nick wrote:
> guys,what kind of plugin works on version 4.0.2?
I'm interested too.
Robert Röttger
09:51 Feature #29285: Add "Assign to me" shortcut to issue edit form
Setting the target version to 4.2.0. Go MAEDA
09:50 Feature #29285: Add "Assign to me" shortcut to issue edit form
I have updated the patch to be applicable to the current trunk r19511. Go MAEDA
08:43 Feature #7056: Download all attachments at once
I have changed the patch:
* Add a label to the bulk download button
* Move the button to below the attachments list (like "usability plugin":https://www.redmine.org/plugins/usability)
* Updated messages
* Raised the default value f...
Go MAEDA
08:04 Feature #33018 (New): Add an ability to attach and embed a file to "Image" button in the Wiki toolbar
Currently, we have "Image" button in the Wiki toolbar. I think the button would be more useful and user-friendly if the button has an ability to attach a file.
The following is my idea of the new behavior.
*1. You will see a file d...
Go MAEDA
07:25 Feature #33002: Include attachments in news post notifications
I included the attachments in the notifications when the news was added.
!{width:600px;border:1px solid #ccc;}news-notification-include-attachments.png!
Yuichi HARADA
06:18 Feature #29193 (Closed): Finish Restoring Guide
Description was added by Gerd Pokorra in July 2018. Bernhard Rohloff
06:11 Feature #33017 (Closed): Complete documentation of news REST API
The documentation of the news API shows only the GET part. The API has been completed in #13468 and the other parts should be added to the documentation, as well. Bernhard Rohloff
05:41 Defect #32971: New line between list items break a list
Thanks for your help Yuichi! :)
This patch works gracefully well!
Thank you again for patching it :)
Jihyeon Gim
05:26 Patch #32888: Use stylelint to avoid errors and enforce conventions in CSS files
It's a good idea. And I'm completely with you Marius that we need some coding standards on the stylesheets. Bernhard Rohloff
03:15 Patch #32888: Use stylelint to avoid errors and enforce conventions in CSS files
I think it is nice to have Stylelint. Setting the target version to 4.2.0. Go MAEDA
05:23 Feature #33016 (New): Adding Watchers to a News Item
At my work we feel it is a bit backwards to ask people to subscribe to a News item after it is published.
It would be more efficient if, instead, the writer of the News item could add people or a group to a News Item so they are autom...
Anestis Kozakis
03:59 Defect #32977: Remove references to deleted user from "user"-Format CustomFields
Setting the target version to 4.2.0. Go MAEDA
03:07 Patch #32927 (Closed): CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific
Committed the patch. Thank you. Go MAEDA
03:06 Revision 19521 (svn): Fix that CSS selector in test_index_should_show_warning_when_no_workflow_is_defined is too specific (#32927).
Patch by Vincent Robert. Go MAEDA
02:53 Feature #32998 (Closed): Change the default value for "Default Gravatar image" to "Identicons"
Committed the patch. Go MAEDA
02:53 Revision 19520 (svn): Change the default value for "Default Gravatar image" to "Identicons" (#32998).
Patch by Go MAEDA. Go MAEDA
02:51 Defect #32981 (Resolved): Unable to distinguish disabled input fields
Committed the patch. Thank you for reporting and fixing the issue. Go MAEDA
02:50 Revision 19519 (svn): Unable to distinguish disabled input fields (#32981).
Patch by Hirokazu Onozato. Go MAEDA
 

Also available in: Atom