Activity
From 2019-06-18 to 2019-06-20
2019-06-20
-
23:35 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- Here is the patch.
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/67280161
* Rubocop: https://gitlab.com/redmine-org/redmine/-/jobs/236746558
* Tests: https://gitlab.com/redmine-org/redmine/-/jobs/236746561
-
13:25 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- Marius BALTEANU wrote:
> Should these commits (r18216, r18217 and r18218) be reverted now that the target version was changed to version:"4.2.0"?
I don't think so. The issue reported in #31427#note-11 is small and an edge case. In a... -
12:16 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- Should these commits (r18216, r18217 and r18218) be reverted now that the target version was changed to version:"4.2.0"? Or, considering that the fix remained is not so big, I can attach tonight a new patch with my changes and the test...
-
01:49 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- Marius BALTEANU wrote:
> Mizuki, why we don't check the value of @indice@ inside the @render_journal_actions@ method?
> ...
The fix looks cleaner and looks better.
I think that it is good with this correction method. -
22:50 Patch #31598 (Closed): Move the links (All time entries, Import) from Spent time section of the spent time list sidebar under a dropdown
- !{width:50%;border: 1px solid grey!}move_links_from_sidebar.png!
Same as #30294, but for time spent. -
22:41 Patch #30294: Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown
- Bernhard Rohloff wrote:
> I've tested the latest trunk version (r18308) right now and the dropdown menu is missing. Presumably there went something wrong with the "settings" patch.
Indeed, the patch didn't apply as expected, I've att... -
20:02 Patch #30294 (Reopened): Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown
- I've tested the latest trunk version (r18308) right now and the dropdown menu is missing. Presumably there went something wrong with the "settings" patch.
-
18:38 Patch #30294 (Closed): Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown
- Committed, thanks.
-
18:59 Feature #27988: Option to configure which trackers can be set as subtasks for each tracker
- Jean-Philippe Lang wrote:
> Kamil . wrote:
> ...
I can try to add this checkbox, but I’m a little bit worried about the complexity because in order to not confuse the admin users, we need also to modify in the Workflow -> Fields permis... -
10:04 Feature #27988: Option to configure which trackers can be set as subtasks for each tracker
- Kamil . wrote:
> Adding my two cents (as my feature request was considered as duplicate of this one)
> ...
I think it really makes sense to support this behaviour along with this feature. -
18:58 Patch #30162 (Closed): Wiki page collapse block image is not displayed in exported PDF
- Committed, thanks!
-
18:46 Patch #26604 (Closed): Set a random name attribute on all forms to prevent overwritten values after soft reload with Firefox
- Committed, thanks.
-
18:44 Patch #30203 (Closed): Add links to administration pages in project settings
- Committed, thanks.
-
18:36 Feature #31444 (Closed): Add "<< me >>" option to user format issue custom fields
- Committed, thanks.
-
16:34 Feature #31444 (Reopened): Add "<< me >>" option to user format issue custom fields
- The test fails randomly.
-
11:05 Feature #31444 (Closed): Add "<< me >>" option to user format issue custom fields
- Committed, thanks.
-
18:24 Patch #29151 (Closed): Add honorific suffixes ("san") in Japanese translation
- Committed, thanks.
-
18:22 Patch #29263: Move issue attributes to their own section in issue page
- I don't see the benefit of adding this section for now. It just eats up a bit more vertical space.
-
17:44 Feature #31581: Issue burnup chart in the version detail
- Thanks for the comment, Marius.
I think that we can understand from the chart when & how many tickets were created and closed in the version. And when we have these information, we can make an outlook whether it is possible to complete ... -
16:50 Feature #25540: Unify fields of subtasks and related issues on issue page
- !{width:700px}25540.png!
I made a patch to display the same field on Subtasks and Related issue. -
16:35 Feature #26709: Use correct http status codes
- only http://www.redmine.org/attachments/19034/builders.rb.patch is relevant.
this is the redmine way how to access an api, the format is determined as an extension -
15:45 Feature #26709: Use correct http status codes
- Fixing status codes and changing the behaviour of the API regarding Accept header are different topics. I think these patches need some deeper review.
-
16:17 Patch #27659 (Closed): redmine_plugin_model_generator improvements(fixes and timestamps)
- Committed, thanks.
-
16:10 Patch #31399 (Closed): make /my/account endpoint accessible through API
- Documentation to be added here [[Rest_MyAccount]].
-
16:05 Feature #30820: Drop setting "Blind carbon copy recipients (bcc)"
- Removing a setting may cause some plugins to error.
Setting it to a major release. -
16:04 Patch #30448: Remove wrapper2 and wrapper3 wrapping containers
- We remove tags from the layout and some themes may rely on them.
Better set it to a major release. -
16:01 Feature #29489 (Closed): Issue macro for flexible linking to issues
- Committed, thanks!
-
15:59 Patch #27625 (Closed): Increase maximum size for role name
- Committed, thanks.
-
15:56 Patch #26714: pluck instead of map in issue_query
- Need some work to avoid duplicate code with @IssueQuery#versions@.
-
15:48 Patch #29441 (Closed): Remove code related to JRuby and unsupported Ruby versions
- Committed, thanks.
-
15:35 Patch #29589 (Closed): Set the first status as a default status in "New tracker" form
- Committed, thanks.
-
07:46 Patch #29589: Set the first status as a default status in "New tracker" form
- I often forget to select the default status and see a validation error. It always irritates me.
Setting the target version to 4.1.0.
!{width: 505px; border: 1px solid #ccc;}.new-tracker-form@2x.png! -
14:43 Patch #31384: Remove custom lazy loading of i18n files
- thanks for the feedback. You're right, i18n gem provides lazy loading for translations, but it loads all available translations at once.
the original redmine backend loaded only the current locale and this optimization was removed.
... -
10:42 Patch #31384 (Closed): Remove custom lazy loading of i18n files
- Patch committed.
-
10:40 Patch #31384: Remove custom lazy loading of i18n files
- Marius BALTEANU wrote:
> For me, the change looks good, especially because we drop quite a lot of custom code.
Sure but it also removes the feature that this custom code provides :-)
-
13:18 Defect #31466 (Closed): Error assigning a task to a user whose role does not allow it
- The author of an issue can always be set as an assignee. This is an intended behavior implemented in r4240.
Closing as a duplicate of #30771. -
13:04 Defect #31595 (Closed): Error allowing assigning a task to a user when his role does not allow it
- Hi,
We have found an error in the roles of the users.
I thought it only happened in version 3.3.1, but it also happens in actual version 4.0.4.
we have a user called for example "*user1*" with a "*reporter*" role but in this rol... -
11:49 Defect #31549: LF line terminators cause misparse of a multi-part email when rdm-mailhandler.rb is invoked from /etc/aliases
- Using the same regular expression as "Mail::Utilities.binary_unsafe_to_crlf":https://www.rubydoc.info/gems/mail/Mail%2FUtilities.binary_unsafe_to_crlf is faster.
-
08:43 Defect #31549: LF line terminators cause misparse of a multi-part email when rdm-mailhandler.rb is invoked from /etc/aliases
- Yuichi HARADA wrote:
> I rewrote the patch of rdm-mailhandler.rb. Please delete the previous patch. ( attachment:fixed-31549.patch )
I didn't need encoding, so I rewrote the patch. -
11:13 Feature #31573: Show each journal entry from issue history in a box
- I need to update these patches now that #3058 was committed .
-
10:59 Feature #30986: New toolbar button to insert wiki macros
- Nice feature but:
* we should find something else than the Redmine logo for this button
* as Bernhard said, it should comme along with additional information about the macro and the arguments that it expects. The macro name on its own ... -
10:57 Feature #30207 (Closed): Hide menu item in the cross-project menu if the module is not enabled in any project
- I also had a concern about these queries but as long as they are fast it should not be a problem.
-
10:51 Feature #29482: Query system for Projects page
- Marius BALTEANU wrote:
> I'm working on updating the patch series to apply cleanly on the current trunk.
Here are the updated patches, all tests pass.
-
09:41 Feature #29482: Query system for Projects page
- I'm working on updating the patch series to apply cleanly on the current trunk.
-
10:42 Feature #29946 (Closed): Update i18n gem (~> 1.6.0)
-
10:26 Feature #29034: Option to collapse/expand issue sections
- I think we actually save space when we can collapse some sections +by default+. Having to collpase sections manually to save space each time we display an issue doesn't sound so much usefull to me.
Can we have more feedback on this prop... -
10:17 Feature #28213 (Closed): Support external ID when importing issues
- Patch committed, thanks!
-
10:13 Feature #11530: Support hooks in mailer
- Kouhei Sutou wrote:
> It's already provided.
> ...
Sure, but how does the hook that is called know about this? -
09:50 Feature #11530: Support hooks in mailer
- It's already provided.
If we're rendering a HTML email, @XXX.html.erb@ is used.
If we're rendering a plain text email, @XXX.text.erb@ is used. -
09:44 Feature #11530: Support hooks in mailer
- We need to provide a way for the hook to know if we're rendering a html or plain text email.
-
10:02 Feature #26653 (Closed): REST API - Add full CRUD support for News
-
10:01 Feature #26033 (Closed): Respect "Objects per page" option when displaying forum replies
-
09:57 Feature #22090 (Closed): Make project settings more accessible
- Committed, thanks.
-
09:49 Patch #31594 (Closed): Japanese translation update (r18281)
- Translated the following strings which are added by #3058:
* field_history_default_tab
* label_issue_history_properties
* label_issue_history_notes
* label_last_tab_visited -
09:36 Feature #10378 (Closed): Don't show empty fields in email notifications
- Patch committed, thanks.
-
09:26 Feature #3058 (Closed): Show issue history using tabs
- Thanks Marius for updating the patches. They are now committed, thanks for your hard work on this!
-
08:20 Feature #3058: Show issue history using tabs
- Ko Nagase wrote:
> Hi,
> ...
No, you can't, it is Jean-Philippe decision on this feature.
In the meantime, I've updated the patch series to apply cleanly and I've added a new patch (attachment:0008-Remove-history-label-and-no-data.p... -
09:10 Defect #31593 (Closed): Email Receiving creates broken issues when incoming message is S/MIME signed
- Email Receiving creates broken issues when incoming message is S/MIME signed.
See attached screenshots, they show several parts of the ticket.
-
08:50 Feature #306: Full Text Search of files
- This is a nice feature but it should go along with a more appropriate search engine. It also add
Scanning megs or gigs of text files (eg log files attached to tickets) with a simple sql LIKE would quickly kill the search. -
08:46 Defect #31582 (Confirmed): Issue subject may be truncated if the subject field in the receiving email is split into multiple lines in singlebytes and multibytes mixed
-
08:42 Defect #31582: Issue subject may be truncated if the subject field in the receiving email is split into multiple lines in singlebytes and multibytes mixed
- This is caused by patch #31365.
I think this is a severe problem and r18245 must be reverted. -
08:38 Defect #31232 (Closed): Text may unexpectedly be enclosed in pre tags when an issue is created via HTML email
- Committed, thanks.
-
08:33 Feature #13803 (Closed): Implement grouping issues by date (start, due, creation, update, closing dates)
- Go MAEDA wrote:
> An issue regarding this feature has been reported as #30288.
It was fixed in r17745. -
08:33 Defect #31093 (Closed): Duplicate method definition: ProjectsControllerTest#test_jump_should_not_redirect_to_unknown_tab
- Fixed in r18267, thanks.
-
08:30 Defect #30288: Groups are incorrect when grouping by date without user timezone set
- Removing the target version. This fix is a part of #13803 which will be delivered in upcoming 4.1.0, so it is not necessary to publish in the changelog.
-
08:24 Defect #30288 (Closed): Groups are incorrect when grouping by date without user timezone set
- Patch committed, thanks!
-
08:29 Defect #30949 (Closed): Roadmap shows 100%, but one of its tasks is still set to 90%
- Patch and test committed, thanks to both of you.
-
08:13 Defect #29581 (Closed): Issues in paginated views may be lost because sorting criteria are not unique
- Patch committed, thanks.
-
08:08 Feature #28392: Improve wiki headings style
- Jean-Philippe Lang has removed border-bottom property for headings in r10102. I think it is better not to add a bottom border on ".wiki h1".
-
07:24 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
- Marius BALTEANU wrote:
> My main concern regarding the proposed solution is that there is no way for the user to control the notification emails, he'll be notified every time when someone will mention him.
I think it is the ideal be...
2019-06-19
-
22:01 Feature #31581: Issue burnup chart in the version detail
- It is an interesting feature, but I'm not sure how to read the chart. Go Maeda, Takenori TAKAKI, can you explain a little bit what we should understand from the chart?
-
18:02 Feature #31581: Issue burnup chart in the version detail
- !{border: 1px solid #ccc;}.screenshot-whole-page.png!
-
17:45 Defect #31519 (Closed): Redmine 4.0.3 does not send all notification emails ?
- Thank you for the feedback.
-
11:45 Defect #31519 (Resolved): Redmine 4.0.3 does not send all notification emails ?
- It was the mail server... My external it service company seems to be unexperienced with exchange configuration
-
17:43 Feature #31553 (Closed): Preview .webm as video instead of audio
- Committed the patch. Thank you all for working on this issue.
-
09:21 Feature #31553: Preview .webm as video instead of audio
- I've attached the patch to my dev environment and it works flawlessly with my test video made by a screen recorder. Very nice improvement!
-
09:02 Feature #31553: Preview .webm as video instead of audio
- Setting the target version to 4.1.0.
-
11:46 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
- In the meantime, I've added Rubocop checks to the "pipeline":https://gitlab.com/redmine-org/redmine/pipelines/66911287. Test results "here":https://gitlab.com/redmine-org/redmine/-/jobs/234560433.
Go Maeda, I'm planning to add Posteg... -
11:39 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
- Pavel Rosický wrote:
> are you about to open it for constributors? in such case all stable branches should be marked as protected.
> ...
I'm open only to accept new branches to be pushed in order to have the tests run in GitLab CI. Any... -
11:29 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- Mizuki, why we don't check the value of @indice@ inside the @render_journal_actions@ method?
Something like that (tested briefly): -
11:16 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message
- I attached a patch that added a test to #31427#note-11 's change.
-
10:33 Patch #31441 (Closed): Show elements titles using jQuery UI tooltips
- Thank you to everyone who involved in this patch.
-
10:22 Patch #31441: Show elements titles using jQuery UI tooltips
- Thank you! It looks good to me.
Since the title attribute is too general and XSS may occur, I think it would be nice to disable HTML support.
IMO If you need HTML support, it may be better to add explicit attributes. (e.g. like html-... -
10:01 Patch #31441: Show elements titles using jQuery UI tooltips
- I think for now it's enough to disable the HTML support (attached patch).
What do you think, Seiei Miyagi? -
09:43 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
- Marius BALTEANU wrote:
> Did you start work on this? or someone from your team? If not, I can do it considering that I was the one who implemented the restriction.
No one in my team has started work yet. I am appreciative that you wi... -
09:34 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
- Did you start work on this? or someone from your team? If not, I can do it considering that I was the one who implemented the restriction.
-
05:23 Feature #31589 (Closed): Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
- You cannot close an issue if it has open subtasks (#10989).
This rule is not obvious and difficult to know for users. In my company, "why I cannot close this issue?" is an FAQ. When they come across the behavior, they spend a long tim... -
07:57 Feature #31322 (Closed): Provide a way to automatically close all open subtasks too when a parent issue is being closed
- Closing as a duplicate of #28492.
-
02:49 Patch #31509 (Closed): Add Rubocop to enforce some styles
- Committed. Thank you for your contribution.
-
00:44 Patch #31509: Add Rubocop to enforce some styles
- Go MAEDA wrote:
> I have updated the patch:
> ...
Looks very good to me, thank you for improving my patch!
-
02:19 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique
- Seiei Miyagi wrote:
> > 'issues.id DESC'
> ...
Thank you for pointing it out.
I changed the way of writing table names.
2019-06-18
-
20:23 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
- In a company there should be no problem as mentioning a user would have the same effect as sending an email to the user. So I believe the main concern would be in public websites like this one.
It could be controlled by a new permissi... -
18:10 Defect #31587 (Closed): Time Entries REST API user_id parameter doesn't work
- I'm trying to use Time Entries REST API and it works as expected except user_id parameter.
When I tried to get time entries https://myredmine/time_entries.json?key=mykey&from=2019-06-01&to=2019-06-30&limit=5&user_id=5 I'm getting time... -
17:51 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique
- > 'issues.id DESC'
Is it OK to write table name of the Issue model directly?
In app/models/issue_query.rb, It seems code like following is more preferable. -
14:06 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique
- Thank you for your response! Your v2 patch looks good to me.
-
07:25 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique
- vzvu 3k6k wrote:
> > -
17:15 Patch #31509: Add Rubocop to enforce some styles
- I have updated the patch:
* Added rules that Marius pointed out in #31509#note-6. I have added rules to @.rubocop.yml@ instead of updating @.rubocop_todo.yml@ because @.rubocop_todo.yml@ is an auto-generated file and it will be overwr... -
11:25 Feature #11313: Automatic closing of resolved issues
- +1
redmine 3.4 here -
09:52 Patch #31441: Show elements titles using jQuery UI tooltips
- Seiei Miyagi wrote:
> I found the XSS in attached patch.
> ...
You're right, thanks for pointing this out, I'll fix it. -
09:34 Patch #31441: Show elements titles using jQuery UI tooltips
- I found the XSS in attached patch.
If I fill the project description like below, then open http://localhost:3000/admin/projects and hover the title of the project, the alert is showing. -
04:00 Patch #31441: Show elements titles using jQuery UI tooltips
- +1
-
09:16 Defect #31582 (Confirmed): Issue subject may be truncated if the subject field in the receiving email is split into multiple lines in singlebytes and multibytes mixed
- When you create issues via email, the subject of the created issue may be truncated if the subject field in the original email is split into multiple lines in singlebytes and multibytes mixed format like the following.
-
07:17 Feature #31581: Issue burnup chart in the version detail
- +1 A really useful feature
-
05:48 Feature #31581 (New): Issue burnup chart in the version detail
- I propose a feature to visualize the changes of registration / completion of issues in the version detail using 'Burnup chart'.
By visualizing with Burnup chart, we can intuitively grasp the change of issue registration / completion in ... -
03:58 Feature #31444: Add "<< me >>" option to user format issue custom fields
- akitani ryo wrote:
> confirmed.
> ...
Thank you for confirming!