Redmine

2019-06-20

23:35 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message

Here is the patch.
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/67280161
* Rubocop: https://g... Marius BĂLTEANU

13:25 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message

Marius BALTEANU wrote:
> Should these commits (r18216, r18217 and r18218) be reverted now that the target version w... Go MAEDA

12:16 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message

Should these commits (r18216, r18217 and r18218) be reverted now that the target version was changed to version:"4.2... Marius BĂLTEANU

01:49 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message

Marius BALTEANU wrote:
> Mizuki, why we don't check the value of @indice@ inside the @render_journal_actions@ metho... Mizuki ISHIKAWA

22:50 Patch #31598 (Closed): Move the links (All time entries, Import) from Spent time section of the spent time list sidebar under a dropdown

!{width:50%;border: 1px solid grey!}move_links_from_sidebar.png!
Same as #30294, but for time spent. Marius BĂLTEANU

22:41 Patch #30294: Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown

Bernhard Rohloff wrote:
> I've tested the latest trunk version (r18308) right now and the dropdown menu is missing. ... Marius BĂLTEANU

20:02 Patch #30294 (Reopened): Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown

I've tested the latest trunk version (r18308) right now and the dropdown menu is missing. Presumably there went somet... Bernhard Rohloff

18:38 Patch #30294 (Closed): Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown

Committed, thanks. Jean-Philippe Lang

18:59 Feature #27988: Option to configure which trackers can be set as subtasks for each tracker

Jean-Philippe Lang wrote:
> Kamil . wrote:
> > Adding my two cents (as my feature request was considered as duplica... Marius BĂLTEANU

10:04 Feature #27988: Option to configure which trackers can be set as subtasks for each tracker

Kamil . wrote:
> Adding my two cents (as my feature request was considered as duplicate of this one)
>
> There ar... Jean-Philippe Lang

18:58 Patch #30162 (Closed): Wiki page collapse block image is not displayed in exported PDF

Committed, thanks! Jean-Philippe Lang

18:46 Patch #26604 (Closed): Set a random name attribute on all forms to prevent overwritten values after soft reload with Firefox

Committed, thanks. Jean-Philippe Lang

18:44 Patch #30203 (Closed): Add links to administration pages in project settings

Committed, thanks. Jean-Philippe Lang

18:36 Feature #31444 (Closed): Add "<< me >>" option to user format issue custom fields

Committed, thanks. Jean-Philippe Lang

16:34 Feature #31444 (Reopened): Add "<< me >>" option to user format issue custom fields

The test fails randomly.... Go MAEDA

11:05 Feature #31444 (Closed): Add "<< me >>" option to user format issue custom fields

Committed, thanks. Jean-Philippe Lang

18:24 Patch #29151 (Closed): Add honorific suffixes ("san") in Japanese translation

Committed, thanks. Jean-Philippe Lang

18:22 Patch #29263: Move issue attributes to their own section in issue page

I don't see the benefit of adding this section for now. It just eats up a bit more vertical space. Jean-Philippe Lang

17:44 Feature #31581: Issue burnup chart in the version detail

Thanks for the comment, Marius.
I think that we can understand from the chart when & how many tickets were created a... Takenori TAKAKI

16:50 Feature #25540: Unify fields of subtasks and related issues on issue page

!{width:700px}25540.png!
I made a patch to display the same field on Subtasks and Related issue. Takenori TAKAKI

16:35 Feature #26709: Use correct http status codes

only http://www.redmine.org/attachments/19034/builders.rb.patch is relevant.
this is the redmine way how to access... Pavel Rosický

15:45 Feature #26709: Use correct http status codes

Fixing status codes and changing the behaviour of the API regarding Accept header are different topics. I think these... Jean-Philippe Lang

16:17 Patch #27659 (Closed): redmine_plugin_model_generator improvements(fixes and timestamps)

Committed, thanks. Jean-Philippe Lang

16:10 Patch #31399 (Closed): make /my/account endpoint accessible through API

Documentation to be added here [[Rest_MyAccount]]. Jean-Philippe Lang

16:05 Feature #30820: Drop setting "Blind carbon copy recipients (bcc)"

Removing a setting may cause some plugins to error.
Setting it to a major release. Jean-Philippe Lang

16:04 Patch #30448: Remove wrapper2 and wrapper3 wrapping containers

We remove tags from the layout and some themes may rely on them.
Better set it to a major release. Jean-Philippe Lang

16:01 Feature #29489 (Closed): Issue macro for flexible linking to issues

Committed, thanks! Jean-Philippe Lang

15:59 Patch #27625 (Closed): Increase maximum size for role name

Committed, thanks. Jean-Philippe Lang

15:56 Patch #26714: pluck instead of map in issue_query

Need some work to avoid duplicate code with @IssueQuery#versions@. Jean-Philippe Lang

15:48 Patch #29441 (Closed): Remove code related to JRuby and unsupported Ruby versions

Committed, thanks. Jean-Philippe Lang

15:35 Patch #29589 (Closed): Set the first status as a default status in "New tracker" form

Committed, thanks. Jean-Philippe Lang

07:46 Patch #29589: Set the first status as a default status in "New tracker" form

I often forget to select the default status and see a validation error. It always irritates me.
Setting the target... Go MAEDA

14:43 Patch #31384: Remove custom lazy loading of i18n files

thanks for the feedback. You're right, i18n gem provides lazy loading for translations, but it loads all available tr... Pavel Rosický

10:42 Patch #31384 (Closed): Remove custom lazy loading of i18n files

Patch committed. Jean-Philippe Lang

10:40 Patch #31384: Remove custom lazy loading of i18n files

Marius BALTEANU wrote:
> For me, the change looks good, especially because we drop quite a lot of custom code.
... Jean-Philippe Lang

13:18 Defect #31466 (Closed): Error assigning a task to a user whose role does not allow it

The author of an issue can always be set as an assignee. This is an intended behavior implemented in r4240.
Closin... Go MAEDA

13:04 Defect #31595 (Closed): Error allowing assigning a task to a user when his role does not allow it

Hi,
We have found an error in the roles of the users.
I thought it only happened in version 3.3.1, but it also ... Miguel Rodriguez Hernando

11:49 Defect #31549: LF line terminators cause misparse of a multi-part email when rdm-mailhandler.rb is invoked from /etc/aliases

Using the same regular expression as "Mail::Utilities.binary_unsafe_to_crlf":https://www.rubydoc.info/gems/mail/Mail%... Go MAEDA

08:43 Defect #31549: LF line terminators cause misparse of a multi-part email when rdm-mailhandler.rb is invoked from /etc/aliases

Yuichi HARADA wrote:
> I rewrote the patch of rdm-mailhandler.rb. Please delete the previous patch. ( attachment:fix... Yuichi HARADA

11:13 Feature #31573: Show each journal entry from issue history in a box

I need to update these patches now that #3058 was committed . Marius BĂLTEANU

10:59 Feature #30986: New toolbar button to insert wiki macros

Nice feature but:
* we should find something else than the Redmine logo for this button
* as Bernhard said, it shou... Jean-Philippe Lang

10:57 Feature #30207 (Closed): Hide menu item in the cross-project menu if the module is not enabled in any project

I also had a concern about these queries but as long as they are fast it should not be a problem. Jean-Philippe Lang

10:51 Feature #29482: Query system for Projects page

Marius BALTEANU wrote:
> I'm working on updating the patch series to apply cleanly on the current trunk.
Here are... Marius BĂLTEANU

09:41 Feature #29482: Query system for Projects page

I'm working on updating the patch series to apply cleanly on the current trunk. Marius BĂLTEANU

10:42 Feature #29946 (Closed): Update i18n gem (~> 1.6.0)

Jean-Philippe Lang

10:26 Feature #29034: Option to collapse/expand issue sections

I think we actually save space when we can collapse some sections +by default+. Having to collpase sections manually ... Jean-Philippe Lang

10:17 Feature #28213 (Closed): Support external ID when importing issues

Patch committed, thanks! Jean-Philippe Lang

10:13 Feature #11530: Support hooks in mailer

Kouhei Sutou wrote:
> It's already provided.
> If we're rendering a HTML email, @XXX.html.erb@ is used.
> If we're... Jean-Philippe Lang

09:50 Feature #11530: Support hooks in mailer

It's already provided.
If we're rendering a HTML email, @XXX.html.erb@ is used.
If we're rendering a plain text ema... Kouhei Sutou

09:44 Feature #11530: Support hooks in mailer

We need to provide a way for the hook to know if we're rendering a html or plain text email. Jean-Philippe Lang

10:02 Feature #26653 (Closed): REST API - Add full CRUD support for News

Jean-Philippe Lang

10:01 Feature #26033 (Closed): Respect "Objects per page" option when displaying forum replies

Jean-Philippe Lang

10:01 Feature #25035: Option to set current date as a default value of date format custom field

Mizuki ISHIKAWA wrote:
> I wrote a patch to realize this feature.
>
> Implementation for setting the default valu... Jean-Philippe Lang

09:57 Feature #22090 (Closed): Make project settings more accessible

Committed, thanks. Jean-Philippe Lang

09:49 Patch #31594 (Closed): Japanese translation update (r18281)

Translated the following strings which are added by #3058:
* field_history_default_tab
* label_issue_history_prop... Go MAEDA

09:36 Feature #10378 (Closed): Don't show empty fields in email notifications

Patch committed, thanks. Jean-Philippe Lang

09:26 Feature #3058 (Closed): Show issue history using tabs

Thanks Marius for updating the patches. They are now committed, thanks for your hard work on this! Jean-Philippe Lang

08:20 Feature #3058: Show issue history using tabs

Ko Nagase wrote:
> Hi,
> I hope that this functionality will be included on next Redmine 4.1.0 release.
> Is there... Marius BĂLTEANU

09:10 Defect #31593 (Closed): Email Receiving creates broken issues when incoming message is S/MIME signed

Email Receiving creates broken issues when incoming message is S/MIME signed.
See attached screenshots, they show se... Carsten Schuette

08:50 Feature #306: Full Text Search of files

This is a nice feature but it should go along with a more appropriate search engine. It also add
Scanning megs or g... Jean-Philippe Lang

08:46 Defect #31582 (Confirmed): Issue subject may be truncated if the subject field in the receiving email is split into multiple lines in singlebytes and multibytes mixed

Go MAEDA

08:42 Defect #31582: Issue subject may be truncated if the subject field in the receiving email is split into multiple lines in singlebytes and multibytes mixed

This is caused by patch #31365.
I think this is a severe problem and r18245 must be reverted. Go MAEDA

08:38 Defect #31232 (Closed): Text may unexpectedly be enclosed in pre tags when an issue is created via HTML email

Committed, thanks. Jean-Philippe Lang

08:33 Feature #13803 (Closed): Implement grouping issues by date (start, due, creation, update, closing dates)

Go MAEDA wrote:
> An issue regarding this feature has been reported as #30288.
It was fixed in r17745. Go MAEDA

08:33 Defect #31093 (Closed): Duplicate method definition: ProjectsControllerTest#test_jump_should_not_redirect_to_unknown_tab

Fixed in r18267, thanks. Jean-Philippe Lang

08:30 Defect #30288: Groups are incorrect when grouping by date without user timezone set

Removing the target version. This fix is a part of #13803 which will be delivered in upcoming 4.1.0, so it is not nec... Go MAEDA

08:24 Defect #30288 (Closed): Groups are incorrect when grouping by date without user timezone set

Patch committed, thanks! Jean-Philippe Lang

08:29 Defect #30949 (Closed): Roadmap shows 100%, but one of its tasks is still set to 90%

Patch and test committed, thanks to both of you. Jean-Philippe Lang

08:13 Defect #29581 (Closed): Issues in paginated views may be lost because sorting criteria are not unique

Patch committed, thanks. Jean-Philippe Lang

08:08 Feature #28392: Improve wiki headings style

Jean-Philippe Lang has removed border-bottom property for headings in r10102. I think it is better not to add a botto... Go MAEDA

07:24 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete

Marius BALTEANU wrote:
> My main concern regarding the proposed solution is that there is no way for the user to con... Go MAEDA

2019-06-19

22:01 Feature #31581: Issue burnup chart in the version detail

It is an interesting feature, but I'm not sure how to read the chart. Go Maeda, Takenori TAKAKI, can you explain a li... Marius BĂLTEANU

18:02 Feature #31581: Issue burnup chart in the version detail

!{border: 1px solid #ccc;}.screenshot-whole-page.png! Go MAEDA

17:45 Defect #31519 (Closed): Redmine 4.0.3 does not send all notification emails ?

Thank you for the feedback. Go MAEDA

11:45 Defect #31519 (Resolved): Redmine 4.0.3 does not send all notification emails ?

It was the mail server... My external it service company seems to be unexperienced with exchange configuration Hans Riekehof

17:43 Feature #31553 (Closed): Preview .webm as video instead of audio

Committed the patch. Thank you all for working on this issue. Go MAEDA

09:21 Feature #31553: Preview .webm as video instead of audio

I've attached the patch to my dev environment and it works flawlessly with my test video made by a screen recorder. V... Bernhard Rohloff

09:02 Feature #31553: Preview .webm as video instead of audio

Setting the target version to 4.1.0. Go MAEDA

11:46 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring

In the meantime, I've added Rubocop checks to the "pipeline":https://gitlab.com/redmine-org/redmine/pipelines/6691128... Marius BĂLTEANU

11:39 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring

Pavel Rosický wrote:
> are you about to open it for constributors? in such case all stable branches should be marked... Marius BĂLTEANU

11:29 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message

Mizuki, why we don't check the value of @indice@ inside the @render_journal_actions@ method?
Something like that ... Marius BĂLTEANU

11:16 Feature #31427: Insert a link to the source to the attribution line when quoting a note or a message

I attached a patch that added a test to #31427#note-11 's change. Mizuki ISHIKAWA

10:33 Patch #31441 (Closed): Show elements titles using jQuery UI tooltips

Thank you to everyone who involved in this patch. Go MAEDA

10:22 Patch #31441: Show elements titles using jQuery UI tooltips

Thank you! It looks good to me.
Since the title attribute is too general and XSS may occur, I think it would be ni... Seiei Miyagi

10:01 Patch #31441: Show elements titles using jQuery UI tooltips

I think for now it's enough to disable the HTML support (attached patch).
What do you think, Seiei Miyagi? Marius BĂLTEANU

09:43 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)

Marius BALTEANU wrote:
> Did you start work on this? or someone from your team? If not, I can do it considering that... Go MAEDA

09:34 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)

Did you start work on this? or someone from your team? If not, I can do it considering that I was the one who impleme... Marius BĂLTEANU

05:23 Feature #31589 (Closed): Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)

You cannot close an issue if it has open subtasks (#10989).
This rule is not obvious and difficult to know for use... Go MAEDA

07:57 Feature #31322 (Closed): Provide a way to automatically close all open subtasks too when a parent issue is being closed

Closing as a duplicate of #28492. Go MAEDA

02:49 Patch #31509 (Closed): Add Rubocop to enforce some styles

Committed. Thank you for your contribution. Go MAEDA

00:44 Patch #31509: Add Rubocop to enforce some styles

Go MAEDA wrote:
> I have updated the patch:
>
> * Added rules that Marius pointed out in #31509#note-6. I have ad... Marius BĂLTEANU

02:19 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique

Seiei Miyagi wrote:
> > 'issues.id DESC'
>
> Is it OK to write table name of the Issue model directly?
> In app/... Mizuki ISHIKAWA

2019-06-18

20:23 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete

In a company there should be no problem as mentioning a user would have the same effect as sending an email to the us... Anders Thomsen

18:10 Defect #31587 (Closed): Time Entries REST API user_id parameter doesn't work

I'm trying to use Time Entries REST API and it works as expected except user_id parameter.
When I tried to get tim... Serhiy Valchuk

17:51 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique

> 'issues.id DESC'
Is it OK to write table name of the Issue model directly?
In app/models/issue_query.rb, It see... Seiei Miyagi

14:06 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique

Thank you for your response! Your v2 patch looks good to me. vzvu 3k6k

07:25 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique

vzvu 3k6k wrote:
> > ... Mizuki ISHIKAWA

17:15 Patch #31509: Add Rubocop to enforce some styles

I have updated the patch:
* Added rules that Marius pointed out in #31509#note-6. I have added rules to @.rubocop.... Go MAEDA

11:25 Feature #11313: Automatic closing of resolved issues

+1
redmine 3.4 here Pierre PP

09:52 Patch #31441: Show elements titles using jQuery UI tooltips

Seiei Miyagi wrote:
> I found the XSS in attached patch.
> If I fill the project description like below, then open ... Marius BĂLTEANU

09:34 Patch #31441: Show elements titles using jQuery UI tooltips

I found the XSS in attached patch.
If I fill the project description like below, then open http://localhost:3000/adm... Seiei Miyagi

04:00 Patch #31441: Show elements titles using jQuery UI tooltips

+1 Mizuki ISHIKAWA

09:16 Defect #31582 (Confirmed): Issue subject may be truncated if the subject field in the receiving email is split into multiple lines in singlebytes and multibytes mixed

When you create issues via email, the subject of the created issue may be truncated if the subject field in the origi... Yuichi HARADA

07:17 Feature #31581: Issue burnup chart in the version detail

+1 A really useful feature Rolf Fischer

05:48 Feature #31581 (New): Issue burnup chart in the version detail

I propose a feature to visualize the changes of registration / completion of issues in the version detail using 'Burn... Takenori TAKAKI

03:58 Feature #31444: Add "<< me >>" option to user format issue custom fields

akitani ryo wrote:
> confirmed.
> I think there is no problem.
Thank you for confirming! Mizuki ISHIKAWA